Re: Review Request 69116: Added 'popen_tty()' to test util functions for the new CLI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69116/#review210304 --- PASS: Mesos patch 69116 was successfully built and tested. Reviews applied: `['69116']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2567/mesos-review-69116 - Mesos Reviewbot Windows On Oct. 22, 2018, 12:23 p.m., Armand Grillet wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69116/ > --- > > (Updated Oct. 22, 2018, 12:23 p.m.) > > > Review request for mesos and Kevin Klues. > > > Bugs: MESOS-9343 > https://issues.apache.org/jira/browse/MESOS-9343 > > > Repository: mesos > > > Description > --- > > This code was pulled directly from: > https://github.com/dcos/dcos-core-cli/blob/ > 7fd55421939a7782c237e2b8719c0fe2f543acd7/ > python/lib/dcoscli/dcoscli/test/common.py > > This function will be used by tests requiring a TTY. This will be the > case for tests concerning the 'task attach' subcommand. > > > Diffs > - > > src/python/cli_new/lib/cli/tests/base.py > 7fd39af665164eeef8bb1359de340ef923dc2272 > > > Diff: https://reviews.apache.org/r/69116/diff/3/ > > > Testing > --- > > ``` > (mesos-cli) ? cli_new (exec-attach) ? mesos-cli-tests > Running the Mesos CLI unit tests > > TestAgentPlugin > test_list (cli.tests.agent.TestAgentPlugin) ... ok > > TestInfrastructure > test_capture_output (cli.tests.tests.TestInfrastructure) ... ok > test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok > > TestTaskPlugin > test_exec (cli.tests.task.TestTaskPlugin) ... ok > test_exec_exit_status (cli.tests.task.TestTaskPlugin) ... ok > test_exec_interactive (cli.tests.task.TestTaskPlugin) ... ok > test_list (cli.tests.task.TestTaskPlugin) ... ok > > -- > Ran 7 tests in 17.238s > > OK > ``` > > > Thanks, > > Armand Grillet > >
Re: Review Request 69116: Added 'popen_tty()' to test util functions for the new CLI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69116/#review210299 --- Ship it! Ship It! - Kevin Klues On Okt. 22, 2018, 12:23 nachm., Armand Grillet wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69116/ > --- > > (Updated Okt. 22, 2018, 12:23 nachm.) > > > Review request for mesos and Kevin Klues. > > > Bugs: MESOS-9343 > https://issues.apache.org/jira/browse/MESOS-9343 > > > Repository: mesos > > > Description > --- > > This code was pulled directly from: > https://github.com/dcos/dcos-core-cli/blob/ > 7fd55421939a7782c237e2b8719c0fe2f543acd7/ > python/lib/dcoscli/dcoscli/test/common.py > > This function will be used by tests requiring a TTY. This will be the > case for tests concerning the 'task attach' subcommand. > > > Diffs > - > > src/python/cli_new/lib/cli/tests/base.py > 7fd39af665164eeef8bb1359de340ef923dc2272 > > > Diff: https://reviews.apache.org/r/69116/diff/3/ > > > Testing > --- > > ``` > (mesos-cli) ? cli_new (exec-attach) ? mesos-cli-tests > Running the Mesos CLI unit tests > > TestAgentPlugin > test_list (cli.tests.agent.TestAgentPlugin) ... ok > > TestInfrastructure > test_capture_output (cli.tests.tests.TestInfrastructure) ... ok > test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok > > TestTaskPlugin > test_exec (cli.tests.task.TestTaskPlugin) ... ok > test_exec_exit_status (cli.tests.task.TestTaskPlugin) ... ok > test_exec_interactive (cli.tests.task.TestTaskPlugin) ... ok > test_list (cli.tests.task.TestTaskPlugin) ... ok > > -- > Ran 7 tests in 17.238s > > OK > ``` > > > Thanks, > > Armand Grillet > >
Re: Review Request 69116: Added 'popen_tty' to test util functions for the new CLI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69116/#review210246 --- Patch looks great! Reviews applied: [69116] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Oct. 22, 2018, 12:23 p.m., Armand Grillet wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69116/ > --- > > (Updated Oct. 22, 2018, 12:23 p.m.) > > > Review request for mesos and Kevin Klues. > > > Bugs: MESOS-9343 > https://issues.apache.org/jira/browse/MESOS-9343 > > > Repository: mesos > > > Description > --- > > This code was pulled directly from: > https://github.com/dcos/dcos-core-cli/blob/ > 7fd55421939a7782c237e2b8719c0fe2f543acd7/ > python/lib/dcoscli/dcoscli/test/common.py > > This function will be used by tests requiring a TTY. This will be the > case for tests concerning the 'task attach' subcommand. > > > Diffs > - > > src/python/cli_new/lib/cli/tests/base.py > 7fd39af665164eeef8bb1359de340ef923dc2272 > > > Diff: https://reviews.apache.org/r/69116/diff/2/ > > > Testing > --- > > > Thanks, > > Armand Grillet > >
Re: Review Request 69116: Added 'popen_tty' to test util functions for the new CLI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69116/#review210245 --- PASS: Mesos patch 69116 was successfully built and tested. Reviews applied: `['69116']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2559/mesos-review-69116 - Mesos Reviewbot Windows On Oct. 22, 2018, 5:23 a.m., Armand Grillet wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69116/ > --- > > (Updated Oct. 22, 2018, 5:23 a.m.) > > > Review request for mesos and Kevin Klues. > > > Bugs: MESOS-9343 > https://issues.apache.org/jira/browse/MESOS-9343 > > > Repository: mesos > > > Description > --- > > This code was pulled directly from: > https://github.com/dcos/dcos-core-cli/blob/ > 7fd55421939a7782c237e2b8719c0fe2f543acd7/ > python/lib/dcoscli/dcoscli/test/common.py > > This function will be used by tests requiring a TTY. This will be the > case for tests concerning the 'task attach' subcommand. > > > Diffs > - > > src/python/cli_new/lib/cli/tests/base.py > 7fd39af665164eeef8bb1359de340ef923dc2272 > > > Diff: https://reviews.apache.org/r/69116/diff/2/ > > > Testing > --- > > > Thanks, > > Armand Grillet > >
Re: Review Request 69116: Added 'popen_tty' to test util functions for the new CLI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69116/#review209874 --- Bad patch! Reviews applied: [69116] Failed command: /usr/bin/python3 support/apply-reviews.py -n -r 69116 Error: 2018-10-22 16:36:31 URL:https://reviews.apache.org/r/69116/diff/raw/ [1588/1588] -> "69116.patch" [1] error: patch failed: src/python/cli_new/lib/cli/tests/base.py:486 error: src/python/cli_new/lib/cli/tests/base.py: patch does not apply Full log: https://builds.apache.org/job/Mesos-Reviewbot/23500/console - Mesos Reviewbot On Oct. 22, 2018, 12:23 p.m., Armand Grillet wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69116/ > --- > > (Updated Oct. 22, 2018, 12:23 p.m.) > > > Review request for mesos and Kevin Klues. > > > Bugs: MESOS-9343 > https://issues.apache.org/jira/browse/MESOS-9343 > > > Repository: mesos > > > Description > --- > > This code was pulled directly from: > https://github.com/dcos/dcos-core-cli/blob/ > 7fd55421939a7782c237e2b8719c0fe2f543acd7/ > python/lib/dcoscli/dcoscli/test/common.py > > This function will be used by tests requiring a TTY. This will be the > case for tests concerning the 'task attach' subcommand. > > > Diffs > - > > src/python/cli_new/lib/cli/tests/base.py > 3fb471c1f49e930d908322055bb9a188f88ee602 > > > Diff: https://reviews.apache.org/r/69116/diff/1/ > > > Testing > --- > > > Thanks, > > Armand Grillet > >
Re: Review Request 69116: Added 'popen_tty' to test util functions for the new CLI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69116/#review209855 --- FAIL: Failed to apply the current review. Failed command: `python.exe .\support\apply-reviews.py -n -r 69116` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2507/mesos-review-69116 Relevant logs: - [apply-review-69116.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2507/mesos-review-69116/logs/apply-review-69116.log): ``` error: patch failed: src/python/cli_new/lib/cli/tests/base.py:486 error: src/python/cli_new/lib/cli/tests/base.py: patch does not apply ``` - Mesos Reviewbot Windows On Oct. 22, 2018, 12:23 p.m., Armand Grillet wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69116/ > --- > > (Updated Oct. 22, 2018, 12:23 p.m.) > > > Review request for mesos and Kevin Klues. > > > Bugs: MESOS-9343 > https://issues.apache.org/jira/browse/MESOS-9343 > > > Repository: mesos > > > Description > --- > > This code was pulled directly from: > https://github.com/dcos/dcos-core-cli/blob/ > 7fd55421939a7782c237e2b8719c0fe2f543acd7/ > python/lib/dcoscli/dcoscli/test/common.py > > This function will be used by tests requiring a TTY. This will be the > case for tests concerning the 'task attach' subcommand. > > > Diffs > - > > src/python/cli_new/lib/cli/tests/base.py > 3fb471c1f49e930d908322055bb9a188f88ee602 > > > Diff: https://reviews.apache.org/r/69116/diff/1/ > > > Testing > --- > > > Thanks, > > Armand Grillet > >
