Re: Review Request 69719: Exposed subscriptions and disconnections RP manager metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69719/#review212099 --- Ship it! Ship It! - Chun-Hung Hsiao On Jan. 16, 2019, 11:49

Re: Review Request 69719: Exposed subscriptions and disconnections RP manager metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69719/#review212064 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 69719: Exposed subscriptions and disconnections RP manager metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69719/ --- (Updated Jan. 16, 2019, 12:49 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 69719: Exposed subscriptions and disconnections RP manager metrics.

> On Jan. 15, 2019, 12:55 a.m., Chun-Hung Hsiao wrote: > > src/resource_provider/manager.cpp > > Lines 823-832 (original), 827-836 (patched) > > > > > > How about moving this snippt to the end of this function, so

Re: Review Request 69719: Exposed subscriptions and disconnections RP manager metrics.

> On Jan. 14, 2019, 11:55 p.m., Chun-Hung Hsiao wrote: > > src/resource_provider/manager.cpp > > Lines 823-832 (original), 827-836 (patched) > > > > > > How about moving this snippt to the end of this function, so

Re: Review Request 69719: Exposed subscriptions and disconnections RP manager metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69719/#review212031 --- PASS: Mesos patch 69719 was successfully built and tested.

Re: Review Request 69719: Exposed subscriptions and disconnections RP manager metrics.

> On Jan. 14, 2019, 11:55 p.m., Chun-Hung Hsiao wrote: > > src/resource_provider/manager.cpp > > Lines 1004-1005 (patched) > > > > > > How about the following, to make it consistent with, e.g., > >

Re: Review Request 69719: Exposed subscriptions and disconnections RP manager metrics.

> On Jan. 15, 2019, 12:55 a.m., Chun-Hung Hsiao wrote: > > src/resource_provider/manager.cpp > > Lines 823-832 (original), 827-836 (patched) > > > > > > How about moving this snippt to the end of this function, so

Re: Review Request 69719: Exposed subscriptions and disconnections RP manager metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69719/ --- (Updated Jan. 15, 2019, 10:27 a.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 69719: Exposed subscriptions and disconnections RP manager metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69719/#review211971 --- src/resource_provider/manager.cpp Lines 823-832 (original),

Re: Review Request 69719: Exposed subscriptions and disconnections RP manager metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69719/#review211878 --- PASS: Mesos patch 69719 was successfully built and tested.