Re: Review Request 71355: Used boost `small_vector` in Resource Quantities and Limits.

2019-08-23 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71355/#review217413 --- Fix it, then Ship it! src/common/resource_quantities.cpp

Re: Review Request 71355: Used boost `small_vector` in Resource Quantities and Limits.

2019-08-23 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71355/ --- (Updated Aug. 23, 2019, 12:44 p.m.) Review request for mesos and Benjamin

Re: Review Request 71355: Used boost `small_vector` in Resource Quantities and Limits.

2019-08-23 Thread Meng Zhu
> On Aug. 23, 2019, 11:38 a.m., Benjamin Mahler wrote: > > include/mesos/resource_quantities.hpp > > Lines 168-169 (patched) > > > > > > How will we know to update this if we have more first class resources? > >

Re: Review Request 71355: Used boost `small_vector` in Resource Quantities and Limits.

2019-08-23 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71355/#review217406 --- include/mesos/resource_quantities.hpp Lines 168-169 (patched)

Re: Review Request 71355: Used boost `small_vector` in Resource Quantities and Limits.

2019-08-23 Thread Benjamin Mahler
> On Aug. 23, 2019, 6:24 p.m., Benjamin Mahler wrote: > > include/mesos/resource_quantities.hpp > > Lines 121-124 (original), 122-127 (patched) > > > > > > "small_vector is convertible to small_vector_base >

Re: Review Request 71355: Used boost `small_vector` in Resource Quantities and Limits.

2019-08-23 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71355/#review217404 --- include/mesos/resource_quantities.hpp Lines 121-124 (original),

Re: Review Request 71355: Used boost `small_vector` in Resource Quantities and Limits.

2019-08-22 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71355/ --- (Updated Aug. 22, 2019, 4:58 p.m.) Review request for mesos and Benjamin