Re: Review Request 72945: Ignored directoy entries when globing Nvidia GPU devices.

2020-10-12 Thread Qian Zhang 


> On Oct. 13, 2020, 3:20 a.m., Benjamin Mahler wrote:
> > src/slave/containerizer/mesos/isolators/gpu/isolator.cpp
> > Lines 446-450 (patched)
> > 
> >
> > The reader will wonder why this was introduced?
> > 
> > Perhaps a comment explaining that now there was an `nvidia-caps` folder 
> > introduced?
> > 
> > Personally, I would have expected one of the following approaches:
> > 
> > * Ignore all non-device files, or
> > * Ignore `nvidia-caps` specifically, since we probably want to know in 
> > the future if there's some other non device stuff getting added

Agreed, let's ignore `nvidia-caps` specifically.


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72945/#review222025
---


On Oct. 12, 2020, 9:50 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72945/
> ---
> 
> (Updated Oct. 12, 2020, 9:50 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Kevin Klues.
> 
> 
> Bugs: MESOS-10192
> https://issues.apache.org/jira/browse/MESOS-10192
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Ignored directoy entries when globing Nvidia GPU devices.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/gpu/isolator.cpp 
> a0be1026bdaf7d4bb33f41e4c7d45666bd61f005 
> 
> 
> Diff: https://reviews.apache.org/r/72945/diff/1/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 72945: Ignored directoy entries when globing Nvidia GPU devices.

2020-10-12 Thread Benjamin Mahler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72945/#review222025
---




src/slave/containerizer/mesos/isolators/gpu/isolator.cpp
Lines 446-450 (patched)


The reader will wonder why this was introduced?

Perhaps a comment explaining that now there was an `nvidia-caps` folder 
introduced?

Personally, I would have expected one of the following approaches:

* Ignore all non-device files, or
* Ignore `nvidia-caps` specifically, since we probably want to know in the 
future if there's some other non device stuff getting added


- Benjamin Mahler


On Oct. 12, 2020, 1:50 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72945/
> ---
> 
> (Updated Oct. 12, 2020, 1:50 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Kevin Klues.
> 
> 
> Bugs: MESOS-10192
> https://issues.apache.org/jira/browse/MESOS-10192
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Ignored directoy entries when globing Nvidia GPU devices.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/gpu/isolator.cpp 
> a0be1026bdaf7d4bb33f41e4c7d45666bd61f005 
> 
> 
> Diff: https://reviews.apache.org/r/72945/diff/1/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 72945: Ignored directoy entries when globing Nvidia GPU devices.

2020-10-10 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72945/#review222009
---



Patch looks great!

Reviews applied: [72945]

Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/jenkins/buildbot.sh

- Mesos Reviewbot


On Oct. 10, 2020, 1:39 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72945/
> ---
> 
> (Updated Oct. 10, 2020, 1:39 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-10192
> https://issues.apache.org/jira/browse/MESOS-10192
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Ignored directoy entries when globing Nvidia GPU devices.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/gpu/isolator.cpp 
> a0be1026bdaf7d4bb33f41e4c7d45666bd61f005 
> 
> 
> Diff: https://reviews.apache.org/r/72945/diff/1/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 72945: Ignored directoy entries when globing Nvidia GPU devices.

2020-10-10 Thread Qian Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72945/
---

(Updated Oct. 10, 2020, 9:39 p.m.)


Review request for mesos and Benjamin Mahler.


Bugs: MESOS-10192
https://issues.apache.org/jira/browse/MESOS-10192


Repository: mesos


Description
---

Ignored directoy entries when globing Nvidia GPU devices.


Diffs
-

  src/slave/containerizer/mesos/isolators/gpu/isolator.cpp 
a0be1026bdaf7d4bb33f41e4c7d45666bd61f005 


Diff: https://reviews.apache.org/r/72945/diff/1/


Testing
---

sudo make check


Thanks,

Qian Zhang