Re: Review Request 34136: Add ContainerImage protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34136/#review93481 --- include/mesos/mesos.proto (line 1213)

Re: Review Request 34136: Add ContainerImage protobuf.

> On July 14, 2015, 9:03 p.m., Jiang Yan Xu wrote: > > include/mesos/mesos.proto, lines 1211-1213 > > > > > > So I found the use of the field `id` inconsistent in the code. > > > > Sometimes `id` has the `s

Re: Review Request 34136: Add ContainerImage protobuf.

> On July 14, 2015, 2:03 p.m., Jiang Yan Xu wrote: > > include/mesos/mesos.proto, lines 1211-1213 > > > > > > So I found the use of the field `id` inconsistent in the code. > > > > Sometimes `id` has the `s

Re: Review Request 34136: Add ContainerImage protobuf.

> On July 14, 2015, 9:03 p.m., Jiang Yan Xu wrote: > > include/mesos/mesos.proto, lines 1211-1213 > > > > > > So I found the use of the field `id` inconsistent in the code. > > > > Sometimes `id` has the `s

Re: Review Request 34136: Add ContainerImage protobuf.

> On July 14, 2015, 9:03 p.m., Jiang Yan Xu wrote: > > include/mesos/mesos.proto, lines 1211-1213 > > > > > > So I found the use of the field `id` inconsistent in the code. > > > > Sometimes `id` has the `s

Re: Review Request 34136: Add ContainerImage protobuf.

> On June 26, 2015, 2:57 p.m., Jiang Yan Xu wrote: > > include/mesos/mesos.proto, lines 1212-1214 > > > > > > Is it the intention that Image type is **defined** outside MesosInfo > > because DockerInfo can later refe

Re: Review Request 34136: Add ContainerImage protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34136/#review91666 --- Sorry I didn't notice it in my original review but I traced the issu

Re: Review Request 34136: Add ContainerImage protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34136/ --- (Updated July 11, 2015, 9:47 p.m.) Review request for mesos, Chi Zhang, Paul Br

Re: Review Request 34136: Add ContainerImage protobuf.

> On June 26, 2015, 2:57 p.m., Jiang Yan Xu wrote: > > include/mesos/mesos.proto, lines 1212-1214 > > > > > > Is it the intention that Image type is **defined** outside MesosInfo > > because DockerInfo can later refe

Re: Review Request 34136: Add ContainerImage protobuf.

> On June 25, 2015, 3:32 p.m., Paul Brett wrote: > > include/mesos/mesos.proto, line 1221 > > > > > > Mesos info is optional, but if present can optionally contain an image? > > So what does a mesos present with a M

Re: Review Request 34136: Add ContainerImage protobuf.

> On July 1, 2015, 4:54 p.m., Lily Chen wrote: > > include/mesos/mesos.proto, line 1209 > > > > > > Same issue as when MesosInfo is not present. What happens when there is > > no Appc message present in Image? This

Re: Review Request 34136: Add ContainerImage protobuf.

> On June 25, 2015, 10:32 p.m., Paul Brett wrote: > > include/mesos/mesos.proto, line 1221 > > > > > > Mesos info is optional, but if present can optionally contain an image? > > So what does a mesos present with a

Re: Review Request 34136: Add ContainerImage protobuf.

> On June 25, 2015, 10:32 p.m., Paul Brett wrote: > > include/mesos/mesos.proto, line 1221 > > > > > > Mesos info is optional, but if present can optionally contain an image? > > So what does a mesos present with a

Re: Review Request 34136: Add ContainerImage protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34136/#review91002 --- Ship it! LGTM. include/mesos/mesos.proto (line 1220)

Re: Review Request 34136: Add ContainerImage protobuf.

> On June 26, 2015, 9:57 p.m., Jiang Yan Xu wrote: > > include/mesos/mesos.proto, lines 1212-1214 > > > > > > Is it the intention that Image type is **defined** outside MesosInfo > > because DockerInfo can later refe

Re: Review Request 34136: Add ContainerImage protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34136/#review90166 --- include/mesos/mesos.proto (line 1209)

Re: Review Request 34136: Add ContainerImage protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34136/#review89577 --- include/mesos/mesos.proto (lines 1212 - 1214)

Re: Review Request 34136: Add ContainerImage protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34136/#review89438 --- include/mesos/mesos.proto (line 1196)

Re: Review Request 34136: Add ContainerImage protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34136/#review89226 --- Ship it! Ship It! - Timothy Chen On June 22, 2015, 4:42 p.m., Ia

Re: Review Request 34136: Add ContainerImage protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34136/ --- (Updated June 22, 2015, 9:42 a.m.) Review request for mesos, Chi Zhang, Paul Br

Re: Review Request 34136: Add ContainerImage protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34136/#review83823 --- include/mesos/mesos.proto

Review Request 34136: Add ContainerImage protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34136/ --- Review request for mesos, Chi Zhang, Paul Brett, Timothy Chen, and Vinod Kone.