Re: Review Request 34299: Changed to use a push model for resource estimator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34299/#review84197 --- Ship it! src/tests/oversubscription_tests.cpp

Re: Review Request 34299: Changed to use a push model for resource estimator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34299/ --- (Updated May 18, 2015, 7:19 p.m.) Review request for mesos, Joris Van Remoorter

Re: Review Request 34299: Changed to use a push model for resource estimator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34299/#review84187 --- There are still places where it says "oversubscribed". I pointed to

Re: Review Request 34299: Changed to use a push model for resource estimator.

> On May 16, 2015, 12:13 a.m., Vinod Kone wrote: > > include/mesos/slave/resource_estimator.hpp, line 59 > > > > > > s/oversubscribed/oversubscribable/ ? > > > > or > > > > s/oversubscribed/oversubscri

Re: Review Request 34299: Changed to use a push model for resource estimator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34299/ --- (Updated May 18, 2015, 5:58 p.m.) Review request for mesos, Joris Van Remoorter

Re: Review Request 34299: Changed to use a push model for resource estimator.

> On May 16, 2015, 1:03 a.m., Niklas Nielsen wrote: > > src/slave/slave.cpp, line 4080 > > > > > > This is being executed in the context of the estimator thread? Is this > > safe? This will be executed in the slave'

Re: Review Request 34299: Changed to use a push model for resource estimator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34299/#review84011 --- src/slave/slave.cpp

Re: Review Request 34299: Changed to use a push model for resource estimator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34299/#review84009 --- Patch looks great! Reviews applied: [34299] All tests passed. - M

Re: Review Request 34299: Changed to use a push model for resource estimator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34299/#review84003 --- Looks good. My main comments are around naming. include/mesos/slav

Review Request 34299: Changed to use a push model for resource estimator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34299/ --- Review request for mesos, Joris Van Remoortere, Niklas Nielsen, and Vinod Kone.