Re: Review Request 36037: Adding /call endpoint to Master

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36037/#review95503 --- what's the status of this one? Should it be closed/discarded? - Mar

Re: Review Request 36037: Adding /call endpoint to Master

> On July 3, 2015, 12:29 a.m., Ben Mahler wrote: > > I chatted with Isabel on IRC and asked her to break apart this change into > > more bite-sized chunks, so that we can do smaller reviews and get things > > committed incrementally: > > > > (1) Dummy /call handler on the master. > > (2) Valid

Re: Review Request 36037: Adding /call endpoint to Master

> On July 3, 2015, 12:29 a.m., Ben Mahler wrote: > > I chatted with Isabel on IRC and asked her to break apart this change into > > more bite-sized chunks, so that we can do smaller reviews and get things > > committed incrementally: > > > > (1) Dummy /call handler on the master. > > (2) Valid

Re: Review Request 36037: Adding /call endpoint to Master

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36037/#review90408 --- src/master/http.cpp (lines 328 - 345)

Re: Review Request 36037: Adding /call endpoint to Master

> On July 3, 2015, 12:29 a.m., Ben Mahler wrote: > > I chatted with Isabel on IRC and asked her to break apart this change into > > more bite-sized chunks, so that we can do smaller reviews and get things > > committed incrementally: > > > > (1) Dummy /call handler on the master. > > (2) Valid

Re: Review Request 36037: Adding /call endpoint to Master

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36037/#review90302 --- I chatted with Isabel on IRC and asked her to break apart this chang

Re: Review Request 36037: Adding /call endpoint to Master

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36037/ --- (Updated July 2, 2015, 8:16 a.m.) Review request for mesos, Anand Mazumdar, Ben

Re: Review Request 36037: Adding /call endpoint to Master

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36037/ --- (Updated July 2, 2015, 7:35 a.m.) Review request for mesos, Anand Mazumdar, Ben

Re: Review Request 36037: Adding /call endpoint to Master

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36037/ --- (Updated July 2, 2015, 7:34 a.m.) Review request for mesos, Anand Mazumdar, Ben

Re: Review Request 36037: Adding /call endpoint to Master

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36037/#review90190 --- src/master/validation.cpp (line 80)

Re: Review Request 36037: Adding /call endpoint to Master

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36037/ --- (Updated July 2, 2015, 2:05 a.m.) Review request for mesos, Anand Mazumdar, Ben

Re: Review Request 36037: Adding /call endpoint to Master

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36037/#review90188 --- Ship it! src/master/http.cpp (line 322)

Re: Review Request 36037: Adding /call endpoint to Master

> On July 1, 2015, 7:11 p.m., Anand Mazumdar wrote: > > src/tests/call_tests.cpp, line 85 > > > > > > From the design doc : > > https://docs.google.com/document/d/1pnIY_HckimKNvpqhKRhbc9eSItWNFT-priXh_urR-T0/edit# > >

Re: Review Request 36037: Adding /call endpoint to Master

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36037/ --- (Updated July 1, 2015, 7:30 p.m.) Review request for mesos, Anand Mazumdar, Ben

Re: Review Request 36037: Adding /call endpoint to Master

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36037/ --- (Updated July 1, 2015, 7:23 p.m.) Review request for mesos, Anand Mazumdar, Ben

Re: Review Request 36037: Adding /call endpoint to Master

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36037/#review90102 --- Adding some minor test-based comments. src/tests/call_tests.cpp (l

Re: Review Request 36037: Adding /call endpoint to Master

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36037/ --- (Updated July 1, 2015, 6:52 p.m.) Review request for mesos, Anand Mazumdar, Ben

Re: Review Request 36037: Adding /call endpoint to Master

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36037/#review90019 --- I haven't looked at the patch itself, but looks like reviewbot is fa

Re: Review Request 36037: Adding /call endpoint to Master

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36037/#review90017 --- Bad patch! Reviews applied: [35934, 36073, 35934] Failed command:

Re: Review Request 36037: Adding /call endpoint to Master

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36037/ --- (Updated July 1, 2015, 1:52 a.m.) Review request for mesos, Anand Mazumdar, Ben

Re: Review Request 36037: Adding /call endpoint to Master

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36037/ --- (Updated July 1, 2015, 1:43 a.m.) Review request for mesos, Anand Mazumdar, Ben

Re: Review Request 36037: Adding /call endpoint to Master

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36037/#review89977 --- This looks good, Isabel! Just a few nits about error messages and my

Re: Review Request 36037: Adding /call endpoint to Master

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36037/ --- (Updated June 30, 2015, 9:07 a.m.) Review request for mesos, Anand Mazumdar, Be

Review Request 36037: Adding /call endpoint to Master

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36037/ --- Review request for mesos, Anand Mazumdar, Benjamin Hindman, Ben Mahler, Marco Ma