Re: Review Request 36115: perf: changed 'parse' interface to allow testing and added tests.

2015-07-02 Thread Chi Zhang
> On July 1, 2015, 11:41 p.m., Paul Brett wrote: > > src/tests/perf_tests.cpp, line 93 > > > > > > ASSERT_SOME_TRUE would need parse to be Try for it to compile. - Chi --

Re: Review Request 36115: perf: changed 'parse' interface to allow testing and added tests.

2015-07-02 Thread Chi Zhang
> On July 2, 2015, 12:29 a.m., Ian Downes wrote: > > src/tests/perf_tests.cpp, line 87 > > > > > > ```cpp > > foreach (const tuple& input, input1) {} > > ```? foreach doesn't work with tuple for me. I used the

Re: Review Request 36115: perf: changed 'parse' interface to allow testing and added tests.

2015-07-02 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36115/ --- (Updated July 2, 2015, 11:42 p.m.) Review request for mesos, Ian Downes, Paul B

Re: Review Request 36115: perf: changed 'parse' interface to allow testing and added tests.

2015-07-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36115/#review90182 --- Patch looks great! Reviews applied: [36112, 36113, 36114, 36115] A

Re: Review Request 36115: perf: changed 'parse' interface to allow testing and added tests.

2015-07-01 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36115/#review90177 --- src/tests/perf_tests.cpp (lines 76 - 84)

Re: Review Request 36115: perf: changed 'parse' interface to allow testing and added tests.

2015-07-01 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36115/#review90164 --- src/tests/perf_tests.cpp (line 87)

Review Request 36115: perf: changed 'parse' interface to allow testing and added tests.

2015-07-01 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36115/ --- Review request for mesos, Ian Downes, Paul Brett, and Cong Wang. Bugs: mesos-28