Re: Review Request 36197: Documented how to become a committer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36197/#review93558 --- Ship it! Ship It! - Adam B On July 28, 2015, 11:02 a.m., Bernd Mathiske wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36197/ --- (Updated July 28, 2015, 11:02 a.m.) Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, and Vinod Kone. Bugs: MESOS-1815 https://issues.apache.org/jira/browse/MESOS-1815 Repository: mesos Description --- Added new document committer-candidate-checklist.md and wrote a paragraph about the path to committership in committers.md. Diffs - docs/committer-candidate-checklist.md PRE-CREATION docs/committers.md ca8a6995c5272f3534ab63f95332565dfcaaf5b9 Diff: https://reviews.apache.org/r/36197/diff/ Testing --- The rendered files can be viewed here: https://gist.github.com/bernd-mesos/00de63ae13efec4331be Thanks, Bernd Mathiske
Re: Review Request 36197: Documented how to become a committer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36197/#review93265 --- I think the checklist could benefit from some organization, at least splitting it into the half that the candidate fills out and the half that the nominator fills out. Bonus points for a logical ordering/grouping within those. docs/committer-candidate-checklist.md (line 7) https://reviews.apache.org/r/36197/#comment147639 s/Project// s/as for instance/e.g./ docs/committer-candidate-checklist.md (line 9) https://reviews.apache.org/r/36197/#comment147638 I'm not convinced these `input type=text/` will actually show up on the website, or even github. Let's leave `Nomination date` out of the checklist, since that comes implicitly when the nominator makes the actual nomination, and is impossible to guess before then. docs/committer-candidate-checklist.md (line 15) https://reviews.apache.org/r/36197/#comment147640 Please add ReviewBoard username, since that's how we actually generate the Author field in the git commits. As far as I know, a github profile is unnecessary and irrelevant. docs/committer-candidate-checklist.md (lines 19 - 20) https://reviews.apache.org/r/36197/#comment147641 Please add links to explanations of the Apache Way, otherwise new contributors will be clueless. docs/committer-candidate-checklist.md (lines 22 - 26) https://reviews.apache.org/r/36197/#comment147642 These are rather vague. Are they meant to be filled in by the Nominator or the candidate? Either way, it'd be nice to give some hints/examples of how these would be demonstrated. docs/committer-candidate-checklist.md (lines 35 - 36) https://reviews.apache.org/r/36197/#comment147643 Another one that the candidate can't fill out themselves. Maybe it would be best to break this down into the candidate checklist part that the candidate fills out (all my ids/stats/queries, etc.) and the nomination form that the nominator fills out. docs/committer-candidate-checklist.md (lines 69 - 71) https://reviews.apache.org/r/36197/#comment147637 Let's generalize this so the candidate can choose how to provide evidence: ``` * Evidence of testing as a priority: A simple metric could be #tests written / #testable tickets. Or you could detail a particularly complex set of unit tests you had to write. Or explain how you have improved the project's testing infrastructure or best practices. ``` docs/committer-candidate-checklist.md (line 77) https://reviews.apache.org/r/36197/#comment147645 Doesn't this go along with the community participation section? docs/committers.md (line 7) https://reviews.apache.org/r/36197/#comment147634 s/developer/contributor/ My recommended wording: An Apache Mesos committer is a contributor with write access to the Mesos repositories and related Apache infrastructure. In the Mesos project, each committer is also a voting member of the PMC. Since this is more about the responsibilities/privileges of being a committer, the ICLA seems like an irrelevant administrative detail. docs/committers.md (line 11) https://reviews.apache.org/r/36197/#comment147635 s/elected/voted in/ since an election implies a choice of candidates. - Adam B On July 28, 2015, 1:11 a.m., Bernd Mathiske wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36197/ --- (Updated July 28, 2015, 1:11 a.m.) Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. Bugs: MESOS-1815 https://issues.apache.org/jira/browse/MESOS-1815 Repository: mesos Description --- Added new document committer-candidate-checklist.md and wrote a paragraph about the path to committership in committers.md. Diffs - docs/committer-candidate-checklist.md PRE-CREATION docs/committers.md ca8a6995c5272f3534ab63f95332565dfcaaf5b9 Diff: https://reviews.apache.org/r/36197/diff/ Testing --- The rendered files can be viewed here: https://gist.github.com/bernd-mesos/00de63ae13efec4331be Thanks, Bernd Mathiske
Re: Review Request 36197: Documented how to become a committer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36197/ --- (Updated July 28, 2015, 11:02 a.m.) Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, and Vinod Kone. Changes --- Addressed Adam's review. Bugs: MESOS-1815 https://issues.apache.org/jira/browse/MESOS-1815 Repository: mesos Description --- Added new document committer-candidate-checklist.md and wrote a paragraph about the path to committership in committers.md. Diffs (updated) - docs/committer-candidate-checklist.md PRE-CREATION docs/committers.md ca8a6995c5272f3534ab63f95332565dfcaaf5b9 Diff: https://reviews.apache.org/r/36197/diff/ Testing --- The rendered files can be viewed here: https://gist.github.com/bernd-mesos/00de63ae13efec4331be Thanks, Bernd Mathiske
Re: Review Request 36197: Documented how to become a committer.
On July 28, 2015, 3:17 a.m., Adam B wrote: docs/committer-candidate-checklist.md, line 9 https://reviews.apache.org/r/36197/diff/3/?file=1004883#file1004883line9 I'm not convinced these `input type=text/` will actually show up on the website, or even github. Let's leave `Nomination date` out of the checklist, since that comes implicitly when the nominator makes the actual nomination, and is impossible to guess before then. I tested the input boxes in a git gist. Indeed, no text box appears, but that's not a problem IMHO. The colon followed by white space makes it clear enough where text can be added. In other MD renderers the boxes do show up. On July 28, 2015, 3:17 a.m., Adam B wrote: docs/committer-candidate-checklist.md, lines 22-26 https://reviews.apache.org/r/36197/diff/3/?file=1004883#file1004883line22 These are rather vague. Are they meant to be filled in by the Nominator or the candidate? Either way, it'd be nice to give some hints/examples of how these would be demonstrated. This can be filled out by anybody. And not giving any guidance here is intended. This is part of the homework. On July 28, 2015, 3:17 a.m., Adam B wrote: docs/committer-candidate-checklist.md, lines 35-36 https://reviews.apache.org/r/36197/diff/3/?file=1004883#file1004883line35 Another one that the candidate can't fill out themselves. Maybe it would be best to break this down into the candidate checklist part that the candidate fills out (all my ids/stats/queries, etc.) and the nomination form that the nominator fills out. The candidate can fill out every part. This is not a signature, just listing who will vouch. - Bernd --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36197/#review93265 --- On July 28, 2015, 1:11 a.m., Bernd Mathiske wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36197/ --- (Updated July 28, 2015, 1:11 a.m.) Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. Bugs: MESOS-1815 https://issues.apache.org/jira/browse/MESOS-1815 Repository: mesos Description --- Added new document committer-candidate-checklist.md and wrote a paragraph about the path to committership in committers.md. Diffs - docs/committer-candidate-checklist.md PRE-CREATION docs/committers.md ca8a6995c5272f3534ab63f95332565dfcaaf5b9 Diff: https://reviews.apache.org/r/36197/diff/ Testing --- The rendered files can be viewed here: https://gist.github.com/bernd-mesos/00de63ae13efec4331be Thanks, Bernd Mathiske
Re: Review Request 36197: Documented how to become a committer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36197/#review93330 --- Patch looks great! Reviews applied: [36197] All tests passed. - Mesos ReviewBot On July 28, 2015, 6:02 p.m., Bernd Mathiske wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36197/ --- (Updated July 28, 2015, 6:02 p.m.) Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, and Vinod Kone. Bugs: MESOS-1815 https://issues.apache.org/jira/browse/MESOS-1815 Repository: mesos Description --- Added new document committer-candidate-checklist.md and wrote a paragraph about the path to committership in committers.md. Diffs - docs/committer-candidate-checklist.md PRE-CREATION docs/committers.md ca8a6995c5272f3534ab63f95332565dfcaaf5b9 Diff: https://reviews.apache.org/r/36197/diff/ Testing --- The rendered files can be viewed here: https://gist.github.com/bernd-mesos/00de63ae13efec4331be Thanks, Bernd Mathiske
Re: Review Request 36197: Documented how to become a committer.
On July 9, 2015, 3:32 p.m., Ben Mahler wrote: docs/committers.md, line 11 https://reviews.apache.org/r/36197/diff/2/?file=999881#file999881line11 No unanimous requirement :) https://community.apache.org/newcommitter.html @bmahler Would you support shipping this? - Bernd --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36197/#review91232 --- On July 10, 2015, 2:14 a.m., Bernd Mathiske wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36197/ --- (Updated July 10, 2015, 2:14 a.m.) Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. Bugs: MESOS-1825 https://issues.apache.org/jira/browse/MESOS-1825 Repository: mesos Description --- Added new document committer-candidate-checklist.md and wrote a paragraph about the path to committership in committers.md. Diffs - docs/committer-candidate-checklist.md PRE-CREATION docs/committers.md ca8a6995c5272f3534ab63f95332565dfcaaf5b9 Diff: https://reviews.apache.org/r/36197/diff/ Testing --- The rendered files can be viewed here: https://gist.github.com/bernd-mesos/00de63ae13efec4331be Thanks, Bernd Mathiske
Re: Review Request 36197: Documented how to become a committer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36197/ --- (Updated July 10, 2015, 2:14 a.m.) Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. Changes --- Removed unanimous from the sentence about PMC election. Bugs: MESOS-1825 https://issues.apache.org/jira/browse/MESOS-1825 Repository: mesos Description --- Added new document committer-candidate-checklist.md and wrote a paragraph about the path to committership in committers.md. Diffs (updated) - docs/committer-candidate-checklist.md PRE-CREATION docs/committers.md ca8a6995c5272f3534ab63f95332565dfcaaf5b9 Diff: https://reviews.apache.org/r/36197/diff/ Testing --- The rendered files can be viewed here: https://gist.github.com/bernd-mesos/00de63ae13efec4331be Thanks, Bernd Mathiske
Re: Review Request 36197: Documented how to become a committer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36197/#review91282 --- Patch looks great! Reviews applied: [36197] All tests passed. - Mesos ReviewBot On July 10, 2015, 9:14 a.m., Bernd Mathiske wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36197/ --- (Updated July 10, 2015, 9:14 a.m.) Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. Bugs: MESOS-1825 https://issues.apache.org/jira/browse/MESOS-1825 Repository: mesos Description --- Added new document committer-candidate-checklist.md and wrote a paragraph about the path to committership in committers.md. Diffs - docs/committer-candidate-checklist.md PRE-CREATION docs/committers.md ca8a6995c5272f3534ab63f95332565dfcaaf5b9 Diff: https://reviews.apache.org/r/36197/diff/ Testing --- The rendered files can be viewed here: https://gist.github.com/bernd-mesos/00de63ae13efec4331be Thanks, Bernd Mathiske
Re: Review Request 36197: Documented how to become a committer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36197/#review91232 --- docs/committers.md (line 11) https://reviews.apache.org/r/36197/#comment144509 No unanimous requirement :) https://community.apache.org/newcommitter.html - Ben Mahler On July 6, 2015, 1:43 p.m., Bernd Mathiske wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36197/ --- (Updated July 6, 2015, 1:43 p.m.) Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. Bugs: MESOS-1825 https://issues.apache.org/jira/browse/MESOS-1825 Repository: mesos Description --- Added new document committer-candidate-checklist.md and wrote a paragraph about the path to committership in committers.md. Diffs - docs/committer-candidate-checklist.md PRE-CREATION docs/committers.md ca8a6995c5272f3534ab63f95332565dfcaaf5b9 Diff: https://reviews.apache.org/r/36197/diff/ Testing --- The rendered files can be viewed here: https://gist.github.com/bernd-mesos/00de63ae13efec4331be Thanks, Bernd Mathiske
Re: Review Request 36197: Documented how to become a committer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36197/#review91225 --- Ship it! LGTM Bernd, let's commit this and ammend as necessary in the future. Thanks! - Benjamin Hindman On July 6, 2015, 1:43 p.m., Bernd Mathiske wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36197/ --- (Updated July 6, 2015, 1:43 p.m.) Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. Bugs: MESOS-1825 https://issues.apache.org/jira/browse/MESOS-1825 Repository: mesos Description --- Added new document committer-candidate-checklist.md and wrote a paragraph about the path to committership in committers.md. Diffs - docs/committer-candidate-checklist.md PRE-CREATION docs/committers.md ca8a6995c5272f3534ab63f95332565dfcaaf5b9 Diff: https://reviews.apache.org/r/36197/diff/ Testing --- The rendered files can be viewed here: https://gist.github.com/bernd-mesos/00de63ae13efec4331be Thanks, Bernd Mathiske
Review Request 36197: Documented how to become a committer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36197/ --- Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. Bugs: MESOS-1825 https://issues.apache.org/jira/browse/MESOS-1825 Repository: mesos Description --- Added new document committer-candidate-checklist.md and wrote a paragraph about the path to committership in committers.md. Diffs - docs/committer-candidate-checklist.md PRE-CREATION docs/committers.md ca8a6995c5272f3534ab63f95332565dfcaaf5b9 Diff: https://reviews.apache.org/r/36197/diff/ Testing --- The rendered files can be viewed here: https://gist.github.com/bernd-mesos/00de63ae13efec4331be Thanks, Bernd Mathiske
Re: Review Request 36197: Documented how to become a committer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36197/#review90473 --- docs/committers.md (line 7) https://reviews.apache.org/r/36197/#comment143559 They are also member of the PMC docs/committers.md (line 13) https://reviews.apache.org/r/36197/#comment143562 Sometimes you use Mesos PMC and sometimes Current Committers, there is a difference but currently the sets are identically (with the exception of you actually :-)). - Joerg Schad On July 6, 2015, 12:32 p.m., Bernd Mathiske wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36197/ --- (Updated July 6, 2015, 12:32 p.m.) Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. Bugs: MESOS-1825 https://issues.apache.org/jira/browse/MESOS-1825 Repository: mesos Description --- Added new document committer-candidate-checklist.md and wrote a paragraph about the path to committership in committers.md. Diffs - docs/committer-candidate-checklist.md PRE-CREATION docs/committers.md ca8a6995c5272f3534ab63f95332565dfcaaf5b9 Diff: https://reviews.apache.org/r/36197/diff/ Testing --- The rendered files can be viewed here: https://gist.github.com/bernd-mesos/00de63ae13efec4331be Thanks, Bernd Mathiske
Re: Review Request 36197: Documented how to become a committer.
On July 6, 2015, 5:39 a.m., Joerg Schad wrote: docs/committers.md, line 13 https://reviews.apache.org/r/36197/diff/1/?file=999718#file999718line13 Sometimes you use Mesos PMC and sometimes Current Committers, there is a difference but currently the sets are identically (with the exception of you actually :-)). I tried to use exactly the term (PMC member vs. committer) that is pertinent to the context in question. That they coincide does not mean that they are functionally equivalent. On July 6, 2015, 5:39 a.m., Joerg Schad wrote: docs/committers.md, line 7 https://reviews.apache.org/r/36197/diff/1/?file=999718#file999718line7 They are also member of the PMC I will ad a sentence saying that in the Mesos project committers eventually also join the PMC. - Bernd --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36197/#review90473 --- On July 6, 2015, 5:32 a.m., Bernd Mathiske wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36197/ --- (Updated July 6, 2015, 5:32 a.m.) Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. Bugs: MESOS-1825 https://issues.apache.org/jira/browse/MESOS-1825 Repository: mesos Description --- Added new document committer-candidate-checklist.md and wrote a paragraph about the path to committership in committers.md. Diffs - docs/committer-candidate-checklist.md PRE-CREATION docs/committers.md ca8a6995c5272f3534ab63f95332565dfcaaf5b9 Diff: https://reviews.apache.org/r/36197/diff/ Testing --- The rendered files can be viewed here: https://gist.github.com/bernd-mesos/00de63ae13efec4331be Thanks, Bernd Mathiske
Re: Review Request 36197: Documented how to become a committer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36197/ --- (Updated July 6, 2015, 6:43 a.m.) Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. Changes --- Addressed Joerg's review: Added sentence saying that in the Mesos project it is customary to also appoint every committer to the PMC. Bugs: MESOS-1825 https://issues.apache.org/jira/browse/MESOS-1825 Repository: mesos Description --- Added new document committer-candidate-checklist.md and wrote a paragraph about the path to committership in committers.md. Diffs (updated) - docs/committer-candidate-checklist.md PRE-CREATION docs/committers.md ca8a6995c5272f3534ab63f95332565dfcaaf5b9 Diff: https://reviews.apache.org/r/36197/diff/ Testing --- The rendered files can be viewed here: https://gist.github.com/bernd-mesos/00de63ae13efec4331be Thanks, Bernd Mathiske
