Re: Review Request 37853: Overlay filesystem provisioning backend

2016-07-09 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37853/#review141506 --- Closing this review due to inactivity. Please see our [guidelines

Re: Review Request 37853: Overlay filesystem provisioning backend

2015-12-01 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37853/#review108544 --- src/Makefile.am (line 776)

Re: Review Request 37853: Overlay filesystem provisioning backend

2015-12-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37853/#review108504 --- Patch looks great! Reviews applied: [37853] Passed command: expor

Re: Review Request 37853: Overlay filesystem provisioning backend

2015-11-30 Thread Mei Wan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37853/ --- (Updated Dec. 1, 2015, 5:26 a.m.) Review request for mesos and Timothy Chen.

Re: Review Request 37853: Overlay filesystem provisioning backend

2015-11-30 Thread Mei Wan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37853/ --- (Updated Nov. 30, 2015, 10:01 p.m.) Review request for mesos, Ben Mahler, Chi Z

Re: Review Request 37853: Overlay filesystem provisioning backend

2015-11-30 Thread Mei Wan
> On Nov. 23, 2015, 9:50 p.m., Timothy Chen wrote: > > src/slave/containerizer/mesos/provisioner/backends/overlay.hpp, line 36 > > > > > > What's N.B.? > > To me this is not really a desirable condition for users

Re: Review Request 37853: Overlay filesystem provisioning backend

2015-11-30 Thread Mei Wan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37853/ --- (Updated Nov. 30, 2015, 1:46 p.m.) Review request for mesos, Ben Mahler, Chi Zh

Re: Review Request 37853: Overlay filesystem provisioning backend

2015-11-23 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37853/#review107653 --- src/slave/containerizer/mesos/provisioner/backends/overlay.hpp (li

Re: Review Request 37853: Overlay filesystem provisioning backend

2015-10-27 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37853/#review104253 --- Patch looks great! Reviews applied: [37853] All tests passed. -

Re: Review Request 37853: Overlay filesystem provisioning backend

2015-10-27 Thread Mei Wan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37853/ --- (Updated Oct. 28, 2015, 3:58 a.m.) Review request for mesos, Ben Mahler, Chi Zh

Re: Review Request 37853: Overlay filesystem provisioning backend

2015-10-27 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37853/#review104245 --- Bad patch! Reviews applied: [37853] Failed command: ./support/app

Re: Review Request 37853: Overlay filesystem provisioning backend

2015-10-27 Thread Mei Wan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37853/ --- (Updated Oct. 28, 2015, 3:39 a.m.) Review request for mesos, Ben Mahler, Chi Zh

Re: Review Request 37853: Overlay filesystem provisioning backend

2015-10-27 Thread Mei Wan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37853/ --- (Updated Oct. 28, 2015, 3:35 a.m.) Review request for mesos, Ben Mahler, Chi Zh

Re: Review Request 37853: Overlay filesystem provisioning backend

2015-10-11 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37853/#review102199 --- Patch looks great! Reviews applied: [37853] All tests passed. -

Re: Review Request 37853: Overlay filesystem provisioning backend

2015-10-11 Thread Mei Wan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37853/ --- (Updated Oct. 11, 2015, 11:02 p.m.) Review request for mesos, Ben Mahler, Chi Z

Re: Review Request 37853: Overlay filesystem provisioning backend

2015-10-11 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37853/#review102196 --- Bad patch! Reviews applied: [37853] Failed command: ./support/app

Re: Review Request 37853: Overlay filesystem provisioning backend

2015-10-11 Thread Mei Wan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37853/ --- (Updated Oct. 11, 2015, 10:48 p.m.) Review request for mesos, Ben Mahler, Chi Z

Re: Review Request 37853: Overlay filesystem provisioning backend

2015-10-11 Thread Mei Wan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37853/ --- (Updated Oct. 11, 2015, 10:38 p.m.) Review request for mesos, Ben Mahler, Chi Z

Re: Review Request 37853: Overlay filesystem provisioning backend

2015-10-10 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37853/#review102163 --- src/Makefile.am (line 722)

Re: Review Request 37853: Overlay filesystem provisioning backend

2015-10-06 Thread Mei Wan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37853/ --- (Updated Oct. 6, 2015, 12:38 p.m.) Review request for mesos, Ben Mahler, Chi Zh

Re: Review Request 37853: Overlay filesystem provisioning backend

2015-10-06 Thread Mei Wan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37853/ --- (Updated Oct. 6, 2015, 12:36 p.m.) Review request for mesos, Ben Mahler, Chi Zh

Re: Review Request 37853: Overlay filesystem provisioning backend

2015-10-06 Thread Mei Wan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37853/ --- (Updated Oct. 6, 2015, 12:35 p.m.) Review request for mesos, Ben Mahler, Chi Zh

Re: Review Request 37853: Overlay filesystem provisioning backend

2015-10-05 Thread Mei Wan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37853/ --- (Updated Oct. 6, 2015, 6:36 a.m.) Review request for mesos, Ben Mahler, Chi Zha

Re: Review Request 37853: Overlay filesystem provisioning backend

2015-09-28 Thread Jie Yu
> On Aug. 27, 2015, 10:42 p.m., Jie Yu wrote: > > src/slave/containerizer/provisioners/backends/overlay.cpp, line 58 > > > > > > You also want to check if overlay fs is supported or not. Not every > > linux kernel su

Re: Review Request 37853: Overlay filesystem provisioning backend

2015-09-01 Thread Mei Wan
> On Aug. 27, 2015, 10:42 p.m., Jie Yu wrote: > > src/slave/containerizer/provisioners/backends/overlay.cpp, lines 101-103 > > > > > > Hum, I'd like to understand why overlay backend cannot support 1 layer. > > Any

Re: Review Request 37853: Overlay filesystem provisioning backend

2015-08-27 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37853/#review96763 --- This looks great! Thanks Mei! I think the main thing left here is th

Re: Review Request 37853: Overlay filesystem provisioning backend

2015-08-27 Thread Mei Wan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37853/ --- (Updated Aug. 27, 2015, 9:11 p.m.) Review request for mesos, Ben Mahler, Chi Zh

Re: Review Request 37853: Overlay filesystem provisioning backend

2015-08-27 Thread Jie Yu
The patch looks great! Thanks Mei! Looks like you've already rebased your patch to the current master, am I right? - Jie On Thu, Aug 27, 2015 at 1:50 PM, Mei Wan wrote: > > --- > This is an automatically generated e-mail. To reply, visit:

Review Request 37853: Overlay filesystem provisioning backend

2015-08-27 Thread Mei Wan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37853/ --- Review request for mesos. Repository: mesos Description --- Implemented