Re: Review Request 38003: MESOS-3351 (duplicated slave id in master after master failover)

2015-09-17 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38003/#review99394 --- Patch looks great! Reviews applied: [38003] All tests passed. -

Re: Review Request 38003: MESOS-3351 (duplicated slave id in master after master failover)

2015-09-17 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38003/ --- (Updated Sept. 17, 2015, 3:07 p.m.) Review request for mesos, Ben Mahler, Jie

Re: Review Request 38003: MESOS-3351 (duplicated slave id in master after master failover)

2015-09-17 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38003/#review99442 --- Ship it! feel free to resolve the open issues.

Re: Review Request 38003: MESOS-3351 (duplicated slave id in master after master failover)

2015-09-17 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38003/ --- (Updated Sept. 18, 2015, 12:13 a.m.) Review request for mesos, Ben Mahler, Jie

Re: Review Request 38003: MESOS-3351 (duplicated slave id in master after master failover)

2015-09-17 Thread Klaus Ma
> On Sept. 17, 2015, 9:13 p.m., Vinod Kone wrote: > > src/tests/master_tests.cpp, line 3733 > > > > > > why the change in formatting? we allow 80 char comments now? do you mean the following comments?

Re: Review Request 38003: MESOS-3351 (duplicated slave id in master after master failover)

2015-09-16 Thread Klaus Ma
> On Sept. 15, 2015, 10:32 p.m., Vinod Kone wrote: > > src/tests/master_tests.cpp, line 3637 > > > > > > Does this test reliably fail (i.e., every time) without the code change > > in master.cpp? Nop; the repro

Re: Review Request 38003: MESOS-3351 (duplicated slave id in master after master failover)

2015-09-15 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38003/#review99112 --- src/tests/master_tests.cpp (line 3596)

Re: Review Request 38003: MESOS-3351

2015-09-04 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38003/#review97785 --- src/master/master.cpp (lines 306 - 312)

Re: Review Request 38003: MESOS-3351

2015-09-04 Thread Vinod Kone
> On Sept. 4, 2015, 7:35 p.m., Vinod Kone wrote: > > Also, please make the summary and description more meaningful than just the ticket ID. - Vinod --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 38003: MESOS-3351 (duplicated slave id in master after master failover)

2015-09-04 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38003/ --- (Updated Sept. 5, 2015, 2:46 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 38003: MESOS-3351 (duplicated slave id in master after master failover)

2015-09-04 Thread Klaus Ma
> On Sept. 4, 2015, 7:35 p.m., Vinod Kone wrote: > > > > Vinod Kone wrote: > Also, please make the summary and description more meaningful than just > the ticket ID. Yes, both summary & description are updated for this fix > On Sept. 4, 2015, 7:35 p.m., Vinod Kone wrote: > >

Re: Review Request 38003: MESOS-3351

2015-09-01 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38003/ --- (Updated Sept. 1, 2015, 2:44 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 38003: MESOS-3351

2015-09-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38003/#review97281 --- Patch looks great! Reviews applied: [38003] All tests passed. -