Re: Review Request 39888: Windows: Added compatibility code for `grp.h` and `pwd.h`.

2015-12-17 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39888/#review110829
---

Ship it!



3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/grp.hpp (line 
36)


this can go on the previous line as per existing pattern in the code base.



3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/grp.hpp (line 
49)


let's mark the closing of the extern



3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/pwd.hpp (line 
37)


ditto



3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/pwd.hpp (line 
50)


let's mark the closing of the extern


- Joris Van Remoortere


On Dec. 15, 2015, 11:36 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39888/
> ---
> 
> (Updated Dec. 15, 2015, 11:36 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van 
> Remoortere, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This code will be particularly useful when we expand Windows support for
> `files/files.hpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> d1ef6f0df82e83d8e0d38f7b8986403702519a7d 
>   3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/grp.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/pwd.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
> 43c85f50958dd9a7ee2ad7c32565585560486c69 
> 
> Diff: https://reviews.apache.org/r/39888/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 39888: Windows: Added compatibility code for `grp.h` and `pwd.h`.

2015-12-15 Thread Alex Clemmer 


> On Dec. 15, 2015, 6:57 p.m., Alex Naparu wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/grp.hpp, 
> > line 37
> > 
> >
> > Returning NULL without setting errno is probably not a good idea. We 
> > might want to standardize on '0' for group/user IDs on Windows.

Per our conversation, you proposed we set `ENOSYS` to indicate that the 
function is not implemented, and I thought that's great, so that's what we did. 
I also added a comment about that.


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39888/#review110536
---


On Dec. 15, 2015, 11:36 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39888/
> ---
> 
> (Updated Dec. 15, 2015, 11:36 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van 
> Remoortere, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This code will be particularly useful when we expand Windows support for
> `files/files.hpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> d1ef6f0df82e83d8e0d38f7b8986403702519a7d 
>   3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/grp.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/pwd.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
> 43c85f50958dd9a7ee2ad7c32565585560486c69 
> 
> Diff: https://reviews.apache.org/r/39888/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 39888: Windows: Added compatibility code for `grp.h` and `pwd.h`.

2015-12-15 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39888/
---

(Updated Dec. 15, 2015, 11:36 p.m.)


Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van 
Remoortere, and Joseph Wu.


Repository: mesos


Description
---

This code will be particularly useful when we expand Windows support for
`files/files.hpp`.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
d1ef6f0df82e83d8e0d38f7b8986403702519a7d 
  3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/grp.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/pwd.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
43c85f50958dd9a7ee2ad7c32565585560486c69 

Diff: https://reviews.apache.org/r/39888/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 39888: Windows: Added compatibility code for `grp.h` and `pwd.h`.

2015-12-15 Thread Alex Naparu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39888/#review110538
---

Ship it!


Ship It!

- Alex Naparu


On Nov. 16, 2015, 9:15 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39888/
> ---
> 
> (Updated Nov. 16, 2015, 9:15 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van 
> Remoortere, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This code will be particularly useful when we expand Windows support for
> `files/files.hpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> a8c35c086ecae21701f6a720f25231c1b0d4e329 
>   3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/grp.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/pwd.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
> 1a7037d64afeedc340258c92067e95d1d3caa027 
> 
> Diff: https://reviews.apache.org/r/39888/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 39888: Windows: Added compatibility code for `grp.h` and `pwd.h`.

2015-12-15 Thread Alex Naparu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39888/#review110536
---



3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/grp.hpp (line 
37)


Returning NULL without setting errno is probably not a good idea. We might 
want to standardize on '0' for group/user IDs on Windows.


- Alex Naparu


On Nov. 16, 2015, 9:15 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39888/
> ---
> 
> (Updated Nov. 16, 2015, 9:15 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van 
> Remoortere, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This code will be particularly useful when we expand Windows support for
> `files/files.hpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> a8c35c086ecae21701f6a720f25231c1b0d4e329 
>   3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/grp.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/pwd.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
> 1a7037d64afeedc340258c92067e95d1d3caa027 
> 
> Diff: https://reviews.apache.org/r/39888/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 39888: Windows: Added compatibility code for `grp.h` and `pwd.h`.

2015-11-17 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39888/#review106929
---

Ship it!


LGTM.


3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/grp.hpp (line 
37)


Can you add a comment saying that, according to the POSIX spec, returning 
NULL means that the relevant entry was not found?  (And maybe add that on 
Windows, these things don't exist, so NULL will always be correct.)

Ditto for `getpwuid`.


- Joseph Wu


On Nov. 16, 2015, 1:15 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39888/
> ---
> 
> (Updated Nov. 16, 2015, 1:15 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van 
> Remoortere, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This code will be particularly useful when we expand Windows support for
> `files/files.hpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> a8c35c086ecae21701f6a720f25231c1b0d4e329 
>   3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/grp.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/pwd.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
> 1a7037d64afeedc340258c92067e95d1d3caa027 
> 
> Diff: https://reviews.apache.org/r/39888/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 39888: Windows: Added compatibility code for `grp.h` and `pwd.h`.

2015-11-16 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39888/
---

(Updated Nov. 16, 2015, 9:15 a.m.)


Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van 
Remoortere, and Joseph Wu.


Repository: mesos


Description
---

This code will be particularly useful when we expand Windows support for
`files/files.hpp`.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
a8c35c086ecae21701f6a720f25231c1b0d4e329 
  3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/grp.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/pwd.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
1a7037d64afeedc340258c92067e95d1d3caa027 

Diff: https://reviews.apache.org/r/39888/diff/


Testing
---


Thanks,

Alex Clemmer

Review Request 39888: Windows: Added compatibility code for `grp.h` and `pwd.h`.

2015-11-02 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39888/
---

Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van 
Remoortere, and Joseph Wu.


Repository: mesos


Description
---

This code will be particularly useful when we expand Windows support for
`files/files.hpp`.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
67b142bbc2d80f40a1e893cc5813d58dd2aa8381 
  3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/grp.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/pwd.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
1a7037d64afeedc340258c92067e95d1d3caa027 

Diff: https://reviews.apache.org/r/39888/diff/


Testing
---


Thanks,

Alex Clemmer