Re: Review Request 42685: Added roles validation to master.

2016-07-09 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42685/#review141534 --- Closing this review due to inactivity. Please see our [guidelines

Re: Review Request 42685: Added roles validation to master.

2016-01-27 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42685/#review116564 --- Patch looks great! Reviews applied: [42415, 42685] Passed comman

Re: Review Request 42685: Added roles validation to master.

2016-01-26 Thread Qian Zhang
> On Jan. 26, 2016, 9:32 a.m., Benjamin Bannier wrote: > > src/master/master.cpp, lines 1980-1983 > > > > > > This should probably be replaced with `strings::join("'", > > frameworkInfo.roles())` which could be use

Re: Review Request 42685: Added roles validation to master.

2016-01-26 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42685/ --- (Updated Jan. 27, 2016, 1:26 p.m.) Review request for mesos, Benjamin Bannier a

Re: Review Request 42685: Added roles validation to master.

2016-01-25 Thread Benjamin Bannier
> On Jan. 26, 2016, 2:32 a.m., Benjamin Bannier wrote: > > src/master/master.cpp, lines 1980-1983 > > > > > > This should probably be replaced with `strings::join("'", > > frameworkInfo.roles())` which could be use

Re: Review Request 42685: Added roles validation to master.

2016-01-25 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42685/#review116243 --- src/master/master.cpp (lines 1980 - 1983)

Re: Review Request 42685: Added roles validation to master.

2016-01-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42685/#review115986 --- Patch looks great! Reviews applied: [42415, 42685] Passed comman

Review Request 42685: Added roles validation to master.

2016-01-23 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42685/ --- Review request for mesos, Benjamin Bannier and Vinod Kone. Bugs: MESOS-4364