Re: Review Request 43240: Removed implicit, value changing conversion.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43240/#review118035 --- Fix it, then Ship it! src/log/tool/benchmark.cpp (line 209)

Re: Review Request 43240: Removed implicit, value changing conversion.

> On Feb. 5, 2016, 6:31 p.m., Jie Yu wrote: > > src/log/tool/benchmark.cpp, line 209 > > > > > > can you use 0xff here? Yes, I can and should. - Benjamin

Re: Review Request 43240: Removed implicit, value changing conversion.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43240/ --- (Updated Feb. 5, 2016, 6:41 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 43240: Removed implicit, value changing conversion.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43240/#review118067 --- Patch looks great! Reviews applied: [43240] Passed command:

Re: Review Request 43240: Removed implicit, value changing conversion.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43240/#review117984 --- Patch looks great! Reviews applied: [43240] Passed command:

Review Request 43240: Removed implicit, value changing conversion.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43240/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---