Re: Review Request 43613: Refactor cluster test helpers into self-contained objects.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43613/#review123785 --- Committed with the following formatting fixes.

Re: Review Request 43613: Refactor cluster test helpers into self-contained objects.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43613/#review123727 --- Ship it! I think there are a few parts that are a bit clunky,

Re: Review Request 43613: Refactor cluster test helpers into self-contained objects.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43613/ --- (Updated March 14, 2016, 2:31 p.m.) Review request for mesos, Benjamin

Re: Review Request 43613: Refactor cluster test helpers into self-contained objects.

> On March 9, 2016, 10:46 a.m., Michael Park wrote: > > src/tests/cluster.hpp, line 88 > > > > > > Why do we need to return `Try` as opposed to > > `Try`? > > Joseph Wu wrote: > We return an

Re: Review Request 43613: Refactor cluster test helpers into self-contained objects.

> On March 9, 2016, 6:46 p.m., Michael Park wrote: > > src/tests/cluster.hpp, line 88 > > > > > > Why do we need to return `Try` as opposed to > > `Try`? > > Joseph Wu wrote: > We return an

Re: Review Request 43613: Refactor cluster test helpers into self-contained objects.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43613/ --- (Updated March 9, 2016, 12:10 p.m.) Review request for mesos, Benjamin

Re: Review Request 43613: Refactor cluster test helpers into self-contained objects.

> On March 9, 2016, 10:46 a.m., Michael Park wrote: > > src/tests/cluster.hpp, line 88 > > > > > > Why do we need to return `Try` as opposed to > > `Try`? We return an `Owned` so that the tests can

Re: Review Request 43613: Refactor cluster test helpers into self-contained objects.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43613/#review122760 --- Pass over the header file for questions + review of the API.

Re: Review Request 43613: Refactor cluster test helpers into self-contained objects.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43613/#review122066 --- Ship it! Note to reviewers: the resulting code can still be

Re: Review Request 43613: Refactor cluster test helpers into self-contained objects.

> On March 3, 2016, 5:22 a.m., Bernd Mathiske wrote: > > src/tests/cluster.hpp, line 213 > > > > > > I don't think we need this constructor. We are using an instance of > > this merely as an aggregate temporary

Re: Review Request 43613: Refactor cluster test helpers into self-contained objects.

> On March 3, 2016, 5:22 a.m., Bernd Mathiske wrote: > > src/tests/cluster.hpp, line 213 > > > > > > I don't think we need this constructor. We are using an instance of > > this merely as an aggregate temporary

Re: Review Request 43613: Refactor cluster test helpers into self-contained objects.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43613/#review121835 --- src/tests/cluster.hpp (line 168)

Re: Review Request 43613: Refactor cluster test helpers into self-contained objects.

> On March 1, 2016, 5:56 a.m., Bernd Mathiske wrote: > > src/tests/cluster.cpp, line 97 > > > > > > The local assertions here do not stop the test outside the factory > > method from progressing. This hazard creates

Re: Review Request 43613: Refactor cluster test helpers into self-contained objects.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43613/#review121637 --- src/tests/cluster.cpp (line 134)

Re: Review Request 43613: Refactor cluster test helpers into self-contained objects.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43613/#review121433 --- src/tests/cluster.cpp (line 91)

Re: Review Request 43613: Refactor cluster test helpers into self-contained objects.

> On Feb. 26, 2016, 4:19 a.m., Bernd Mathiske wrote: > > src/tests/cluster.hpp, line 260 > > > > > > All this is nice to know, but ho does it connect to the variable > > "isShutdown" and why is it named this way?

Re: Review Request 43613: Refactor cluster test helpers into self-contained objects.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43613/ --- (Updated Feb. 26, 2016, 11:50 a.m.) Review request for mesos, Benjamin

Re: Review Request 43613: Refactor cluster test helpers into self-contained objects.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43613/#review120685 --- src/tests/cluster.hpp (line 111)

Re: Review Request 43613: Refactor cluster test helpers into self-contained objects.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43613/ --- (Updated Feb. 19, 2016, 4:50 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 43613: Refactor cluster test helpers into self-contained objects.

> On Feb. 19, 2016, 3:46 p.m., Alexander Rojas wrote: > > src/tests/cluster.hpp, line 163 > > > > > > Not yours (is the only unchanged line here) but if all other pointer > > objects are of type `process::Owned`

Re: Review Request 43613: Refactor cluster test helpers into self-contained objects.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43613/#review119989 --- src/tests/cluster.hpp (line 82)

Re: Review Request 43613: Refactor cluster test helpers into self-contained objects.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43613/ --- (Updated Feb. 19, 2016, 11:25 a.m.) Review request for mesos, Benjamin

Re: Review Request 43613: Refactor cluster test helpers into self-contained objects.

> On Feb. 19, 2016, 3:16 a.m., Bernd Mathiske wrote: > > src/tests/cluster.hpp, line 205 > > > > > > Slightly unclear which is which. Attempt to clarify: > > > > ... Once this method has been called, its

Re: Review Request 43613: Refactor cluster test helpers into self-contained objects.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43613/#review119858 --- First pass. Sorry, did not get through it in one seating.

Re: Review Request 43613: Refactor cluster test helpers into self-contained objects.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43613/ --- (Updated Feb. 17, 2016, 12:27 p.m.) Review request for mesos, Benjamin

Re: Review Request 43613: Refactor cluster test helpers into self-contained objects.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43613/ --- (Updated Feb. 17, 2016, 10:25 a.m.) Review request for mesos, Benjamin

Re: Review Request 43613: Refactor cluster test helpers into self-contained objects.

> On Feb. 17, 2016, 8:32 a.m., Bernd Mathiske wrote: > > src/tests/cluster.hpp, line 91 > > > > > > What do you mean by "some" of its state? In both of these objects, we don't do everything possible to cleanup.

Re: Review Request 43613: Refactor cluster test helpers into self-contained objects.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43613/#review119464 --- src/tests/cluster.hpp (line 77)

Review Request 43613: Refactor cluster test helpers into self-contained objects.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43613/ --- Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Artem