Re: Review Request 44690: Added 'delegate' info to the Help process.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44690/#review123085
---


Ship it!




Ship It!

- Ben Mahler


On March 11, 2016, 3:11 a.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44690/
> ---
> 
> (Updated March 11, 2016, 3:11 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Neil Conway.
> 
> 
> Bugs: MESOS-4787
> https://issues.apache.org/jira/browse/MESOS-4787
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Just as the ProcessManager needs the delegate name to know which
> process to service root HTTP requests from, the Help process needs to
> know the delegate name so it can generate the proper USAGE strings.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/help.hpp 
> 93306adfd64cc08933232e0db78d9efacb966018 
>   3rdparty/libprocess/src/help.cpp bac980ddec98b34bdfd786b03d0691fefb93f45a 
>   3rdparty/libprocess/src/process.cpp 
> 01bc19bc6f4d78923bb3796b7dd0a9ab2b3108d1 
> 
> Diff: https://reviews.apache.org/r/44690/diff/
> 
> 
> Testing
> ---
> 
> I spun up a master and an agent and looked at their /help endpoint to verify 
> that the updated USAGE strings include information about accessing the 
> enpoint without the process name.
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 44690: Added 'delegate' info to the Help process.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44690/
---

(Updated March 11, 2016, 3:11 a.m.)


Review request for mesos, Ben Mahler and Neil Conway.


Changes
---

Accidentally introduced unwanted change in last revision.  Updated to remove it.


Bugs: MESOS-4787
https://issues.apache.org/jira/browse/MESOS-4787


Repository: mesos


Description
---

Just as the ProcessManager needs the delegate name to know which
process to service root HTTP requests from, the Help process needs to
know the delegate name so it can generate the proper USAGE strings.


Diffs (updated)
-

  3rdparty/libprocess/include/process/help.hpp 
93306adfd64cc08933232e0db78d9efacb966018 
  3rdparty/libprocess/src/help.cpp bac980ddec98b34bdfd786b03d0691fefb93f45a 
  3rdparty/libprocess/src/process.cpp 01bc19bc6f4d78923bb3796b7dd0a9ab2b3108d1 

Diff: https://reviews.apache.org/r/44690/diff/


Testing
---

I spun up a master and an agent and looked at their /help endpoint to verify 
that the updated USAGE strings include information about accessing the enpoint 
without the process name.


Thanks,

Kevin Klues

Re: Review Request 44690: Added 'delegate' info to the Help process.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44690/
---

(Updated March 11, 2016, 3:05 a.m.)


Review request for mesos, Ben Mahler and Neil Conway.


Changes
---

Addressed comments from bmahler.


Bugs: MESOS-4787
https://issues.apache.org/jira/browse/MESOS-4787


Repository: mesos


Description
---

Just as the ProcessManager needs the delegate name to know which
process to service root HTTP requests from, the Help process needs to
know the delegate name so it can generate the proper USAGE strings.


Diffs (updated)
-

  3rdparty/libprocess/include/process/help.hpp 
93306adfd64cc08933232e0db78d9efacb966018 
  3rdparty/libprocess/src/help.cpp bac980ddec98b34bdfd786b03d0691fefb93f45a 
  3rdparty/libprocess/src/process.cpp 01bc19bc6f4d78923bb3796b7dd0a9ab2b3108d1 

Diff: https://reviews.apache.org/r/44690/diff/


Testing
---

I spun up a master and an agent and looked at their /help endpoint to verify 
that the updated USAGE strings include information about accessing the enpoint 
without the process name.


Thanks,

Kevin Klues

Re: Review Request 44690: Added 'delegate' info to the Help process.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44690/#review123076
---




3rdparty/libprocess/src/help.cpp (lines 97 - 100)


Can you add a comment here about why the delegate logic is here? Also, not 
yours, but the getUsagePath helper is pretty confusing, would be ideal to dig 
into that further as I'm a bit confused about when slashes need to be stripped 
from the end. Looks like help is broken for /version, for example. :(



3rdparty/libprocess/src/help.cpp (line 98)


2 spaces here



3rdparty/libprocess/src/help.cpp (line 100)


extra space here?


- Ben Mahler


On March 11, 2016, 1:38 a.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44690/
> ---
> 
> (Updated March 11, 2016, 1:38 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Neil Conway.
> 
> 
> Bugs: MESOS-4787
> https://issues.apache.org/jira/browse/MESOS-4787
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Just as the ProcessManager needs the delegate name to know which
> process to service root HTTP requests from, the Help process needs to
> know the delegate name so it can generate the proper USAGE strings.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/help.hpp 
> 93306adfd64cc08933232e0db78d9efacb966018 
>   3rdparty/libprocess/src/help.cpp bac980ddec98b34bdfd786b03d0691fefb93f45a 
>   3rdparty/libprocess/src/process.cpp 
> 01bc19bc6f4d78923bb3796b7dd0a9ab2b3108d1 
> 
> Diff: https://reviews.apache.org/r/44690/diff/
> 
> 
> Testing
> ---
> 
> I spun up a master and an agent and looked at their /help endpoint to verify 
> that the updated USAGE strings include information about accessing the 
> enpoint without the process name.
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Review Request 44690: Added 'delegate' info to the Help process.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44690/
---

Review request for mesos, Ben Mahler and Neil Conway.


Bugs: MESOS-4787
https://issues.apache.org/jira/browse/MESOS-4787


Repository: mesos


Description
---

Just as the ProcessManager needs the delegate name to know which
process to service root HTTP requests from, the Help process needs to
know the delegate name so it can generate the proper USAGE strings.


Diffs
-

  3rdparty/libprocess/include/process/help.hpp 
93306adfd64cc08933232e0db78d9efacb966018 
  3rdparty/libprocess/src/help.cpp bac980ddec98b34bdfd786b03d0691fefb93f45a 
  3rdparty/libprocess/src/process.cpp 01bc19bc6f4d78923bb3796b7dd0a9ab2b3108d1 

Diff: https://reviews.apache.org/r/44690/diff/


Testing
---

I spun up a master and an agent and looked at their /help endpoint to verify 
that the updated USAGE strings include information about accessing the enpoint 
without the process name.


Thanks,

Kevin Klues