Re: Review Request 45270: Added spec protobut for external mount.

> On 四月 15, 2016, 12:27 a.m., Jie Yu wrote: > > Second thoughts on this. We should not use a single protobuf file for > > checkpointing. Otherwise, we'll have to write the entire file to the > > filesystem anytime we do a mount or umount. Let's just create some > > directory structure under

Re: Review Request 45270: Added spec protobut for external mount.

> On 四月 14, 2016, 10:27 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/spec.proto, line 19 > > > > > > Why this namespace? This is technically not 'spec', but the _state_ > > scheme

Re: Review Request 45270: Added spec protobut for external mount.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45270/#review129043 --- Second thoughts on this. We should not use a single protobuf file

Re: Review Request 45270: Added spec protobut for external mount.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45270/#review129011 --- src/CMakeLists.txt (lines 52 - 54)

Re: Review Request 45270: Added spec protobut for external mount.

> On April 14, 2016, 8:17 p.m., Greg Mann wrote: > > Could you fix the typo in the commit message: "protobut" should be "protobuf". Also, could you remove the duplicate Summary that's in the Description field, and add a more verbose description of the patch in the Description field? - Greg

Re: Review Request 45270: Added spec protobut for external mount.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45270/#review128971 --- src/slave/containerizer/mesos/isolators/docker/volume/spec.proto

Re: Review Request 45270: Added spec protobut for external mount.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45270/#review128922 --- src/slave/containerizer/mesos/isolators/docker/volume/spec.proto

Re: Review Request 45270: Added spec protobut for external mount.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45270/ --- (Updated 四月 14, 2016, 4:41 a.m.) Review request for mesos, David vonThenen,

Re: Review Request 45270: Added spec protobut for external mount.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45270/ --- (Updated 四月 13, 2016, 10:40 p.m.) Review request for mesos, David vonThenen,

Re: Review Request 45270: Added spec protobut for external mount.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45270/ --- (Updated 四月 13, 2016, 7:16 a.m.) Review request for mesos, David vonThenen,

Re: Review Request 45270: Added spec protobut for external mount.

> On 四月 4, 2016, 11:16 p.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/isolators/docker/dvd/spec.hpp, line 28 > > > > > > Should we add a inline parse method here? Seems not as the dvd isolator do not

Re: Review Request 45270: Added spec protobut for external mount.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45270/#review127132 --- src/slave/containerizer/mesos/isolators/docker/dvd/spec.proto

Re: Review Request 45270: Added spec protobut for external mount.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45270/#review126968 --- src/slave/containerizer/mesos/isolators/docker/dvd/spec.hpp

Re: Review Request 45270: Added spec protobut for external mount.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45270/ --- (Updated 四月 2, 2016, 5:52 a.m.) Review request for mesos, Gilbert Song and Jie

Re: Review Request 45270: Added spec protobut for external mount.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45270/ --- (Updated 三月 30, 2016, 3:17 p.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 45270: Added spec protobut for external mount.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45270/ --- (Updated 三月 28, 2016, 2:44 a.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 45270: Added spec protobut for external mount.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45270/#review125266 --- Patch looks great! Reviews applied: [45214, 45217, 45265, 45270]

Review Request 45270: Added spec protobut for external mount.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45270/ --- Review request for mesos and Jie Yu. Bugs: MESOS-5013