Re: Review Request 45863: Updated error messages in weights handler.

2016-04-11 Thread Alexander Rukletsov
> On April 7, 2016, 11:07 a.m., Joerg Schad wrote: > > src/master/weights_handler.cpp, line 90 > > > > > > Not yours: Above the request.body is included in the output. Feels > > inconsistent here... > > Alexander

Re: Review Request 45863: Updated error messages in weights handler.

2016-04-11 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45863/ --- (Updated April 11, 2016, 2:48 p.m.) Review request for mesos, Yongqiao Wang

Re: Review Request 45863: Updated error messages in weights handler.

2016-04-11 Thread Alexander Rukletsov
> On April 7, 2016, 11:07 a.m., Joerg Schad wrote: > > src/master/weights_handler.cpp, line 90 > > > > > > Not yours: Above the request.body is included in the output. Feels > > inconsistent here... > > Alexander

Re: Review Request 45863: Updated error messages in weights handler.

2016-04-11 Thread Joerg Schad
> On April 7, 2016, 11:07 a.m., Joerg Schad wrote: > > src/master/weights_handler.cpp, line 90 > > > > > > Not yours: Above the request.body is included in the output. Feels > > inconsistent here... > > Alexander

Re: Review Request 45863: Updated error messages in weights handler.

2016-04-11 Thread Alexander Rukletsov
> On April 7, 2016, 11:07 a.m., Joerg Schad wrote: > > src/master/weights_handler.cpp, line 90 > > > > > > Not yours: Above the request.body is included in the output. Feels > > inconsistent here... Above are

Re: Review Request 45863: Updated error messages in weights handler.

2016-04-10 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45863/#review128057 --- Fix it, then Ship it! src/master/weights_handler.cpp (line

Re: Review Request 45863: Updated error messages in weights handler.

2016-04-08 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45863/#review127755 --- @ReviewBot retry - Alexander Rukletsov On April 7, 2016, 10:50

Re: Review Request 45863: Updated error messages in weights handler.

2016-04-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45863/#review127581 --- Bad patch! Reviews applied: [45863] Failed command:

Re: Review Request 45863: Updated error messages in weights handler.

2016-04-07 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45863/#review127580 --- Fix it, then Ship it! src/master/weights_handler.cpp (line

Review Request 45863: Updated error messages in weights handler.

2016-04-07 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45863/ --- Review request for mesos, Yongqiao Wang and Joerg Schad. Repository: mesos