Re: Review Request 46139: Add positive tests for /weights endpoint.

2016-04-25 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46139/#review130390 --- Ship it! Ship It! - Adam B On April 19, 2016, 6:42 a.m., Yon

Re: Review Request 46139: Add positive tests for /weights endpoint.

2016-04-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46139/#review129578 --- Patch looks great! Reviews applied: [46139] Passed command: expo

Re: Review Request 46139: Add positive tests for /weights endpoint.

2016-04-19 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46139/ --- (Updated April 19, 2016, 1:42 p.m.) Review request for mesos and Adam B. Chan

Re: Review Request 46139: Add positive tests for /weights endpoint.

2016-04-19 Thread Yongqiao Wang
> On April 14, 2016, 11:09 a.m., Adam B wrote: > > src/tests/dynamic_weights_tests.cpp, lines 168-179 > > > > > > Why are role2 and role1 in reverse order? Is this always the case? Why > > wouldn't it be forward-alp

Re: Review Request 46139: Add positive tests for /weights endpoint.

2016-04-14 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46139/#review128873 --- This'll do quite nicely once we address these issues. src/tests/

Review Request 46139: Add positive tests for /weights endpoint.

2016-04-12 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46139/ --- Review request for mesos and Adam B. Bugs: MESOS-4316 https://issues.apache