Re: Review Request 46158: Completed implementation of the cgroups unified isolator.

> On June 12, 2016, 2:51 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, lines 351-363 > > > > > > Why do we prepare hierarchy here? I think preparing hierarchy for a > > spe

Re: Review Request 46158: Completed implementation of the cgroups unified isolator.

> On June 12, 2016, 10:51 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, lines 351-363 > > > > > > Why do we prepare hierarchy here? I think preparing hierarchy for a > > sp

Re: Review Request 46158: Completed implementation of the cgroups unified isolator.

> On June 12, 2016, 2:51 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, lines 351-363 > > > > > > Why do we prepare hierarchy here? I think preparing hierarchy for a > > spe

Re: Review Request 46158: Completed implementation of the cgroups unified isolator.

> On June 12, 2016, 10:51 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, lines 351-363 > > > > > > Why do we prepare hierarchy here? I think preparing hierarchy for a > > sp

Re: Review Request 46158: Completed implementation of the cgroups unified isolator.

> On June 12, 2016, 2:51 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, lines 351-363 > > > > > > Why do we prepare hierarchy here? I think preparing hierarchy for a > > spe

Re: Review Request 46158: Completed implementation of the cgroups unified isolator.

> On June 12, 2016, 10:51 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, lines 351-363 > > > > > > Why do we prepare hierarchy here? I think preparing hierarchy for a > > sp

Re: Review Request 46158: Completed implementation of the cgroups unified isolator.

> On June 11, 2016, 2:31 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, line 141 > > > > > > I would suggest to rename this method to `prepareHierarchy()`, the > > word `ge

Re: Review Request 46158: Completed implementation of the cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46158/ --- (Updated June 19, 2016, 3:55 p.m.) Review request for mesos, Gilbert Song, Guan

Re: Review Request 46158: Completed implementation of the cgroups unified isolator.

> On June 15, 2016, 1:12 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, line 74 > > > > > > Can you please clarfiy why we want to have `user` as a field of `Info` > > class?

Re: Review Request 46158: Completed implementation of the cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46158/ --- (Updated June 19, 2016, 3:34 p.m.) Review request for mesos, Gilbert Song, Guan

Re: Review Request 46158: Completed implementation of the cgroups unified isolator.

> On June 12, 2016, 2:51 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, lines 351-363 > > > > > > Why do we prepare hierarchy here? I think preparing hierarchy for a > > spe

Re: Review Request 46158: Completed implementation of the cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46158/ --- (Updated June 19, 2016, 2:55 p.m.) Review request for mesos, Gilbert Song, Guan

Re: Review Request 46158: Completed implementation of the cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46158/ --- (Updated June 19, 2016, 10:21 a.m.) Review request for mesos, Gilbert Song, Gua

Re: Review Request 46158: Completed implementation of the cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46158/#review137677 --- src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line

Re: Review Request 46158: Completed implementation of the cgroups unified isolator.

> On June 11, 2016, 10:31 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, line 131 > > > > > > I think there is a special case that we need to handle: In the OS using > > sys

Re: Review Request 46158: Completed implementation of the cgroups unified isolator.

> On June 2, 2016, 10:58 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, lines 105-106 > > > > > > Since this is a multiple lines code, I think you need to add a newline > >

Re: Review Request 46158: Completed implementation of the cgroups unified isolator.

> On June 11, 2016, 2:31 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, line 131 > > > > > > I think there is a special case that we need to handle: In the OS using > > syst

Re: Review Request 46158: Completed implementation of the cgroups unified isolator.

> On June 2, 2016, 2:58 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, line 97 > > > > > > Why make it a static variable? I think > > `CgroupsIsolatorProcess::create()` will

Re: Review Request 46158: Completed implementation of the cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46158/#review137145 --- src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line

Re: Review Request 46158: Completed implementation of the cgroups unified isolator.

> On June 6, 2016, 10:15 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, lines 79-80 > > > > > > So we create subsystem for each container, suppose > > `"--isolation=cgroups/m

Re: Review Request 46158: Completed implementation of the cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46158/#review136998 --- src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line

Re: Review Request 46158: Completed implementation of the cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46158/#review136985 --- src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line

Re: Review Request 46158: Completed implementation of the cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46158/#review136250 --- src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line

Re: Review Request 46158: Completed implementation of the cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46158/#review135928 --- src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line

Re: Review Request 46158: Completed implementation of the cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46158/ --- (Updated April 16, 2016, 10:14 a.m.) Review request for mesos, Gilbert Song, Gu

Review Request 46158: Completed implementation of the cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46158/ --- Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, and Kev