Re: Review Request 47576: Agent: Add Windows support to the containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47576/#review135595 --- Ship it! Ship It! - Joris Van Remoortere On May 30, 2016, 4:

Re: Review Request 47576: Agent: Add Windows support to the containerizer.

> On May 31, 2016, 5:08 a.m., Joris Van Remoortere wrote: > > src/slave/containerizer/mesos/containerizer.cpp, lines 1233-1239 > > > > > > Do these get stored correctly since `launchFlags.pipe_xxx` is an int? > >

Re: Review Request 47576: Agent: Add Windows support to the containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47576/#review135590 --- src/slave/containerizer/mesos/containerizer.cpp (line 1184)

Re: Review Request 47576: Agent: Add Windows support to the containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47576/ --- (Updated May 30, 2016, 4:55 p.m.) Review request for mesos, Daniel Pravat, Arte

Re: Review Request 47576: Agent: Add Windows support to the containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47576/ --- (Updated May 29, 2016, 5:31 a.m.) Review request for mesos, Daniel Pravat, Arte

Re: Review Request 47576: Agent: Add Windows support to the containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47576/ --- (Updated May 29, 2016, 3:35 a.m.) Review request for mesos, Daniel Pravat, Arte

Re: Review Request 47576: Agent: Add Windows support to the containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47576/ --- (Updated May 29, 2016, 2:30 a.m.) Review request for mesos, Daniel Pravat, Arte

Re: Review Request 47576: Agent: Add Windows support to the containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47576/ --- (Updated May 29, 2016, 2:12 a.m.) Review request for mesos, Daniel Pravat, Arte

Re: Review Request 47576: Agent: Add Windows support to the containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47576/ --- (Updated May 28, 2016, 10:28 p.m.) Review request for mesos, Daniel Pravat, Art

Re: Review Request 47576: Agent: Add Windows support to the containerizer.

> On May 24, 2016, 11:37 p.m., Joris Van Remoortere wrote: > > src/slave/containerizer/mesos/launcher.hpp, lines 118-119 > > > > > > Is this the only difference? > > It would be great if we could clearly identify

Re: Review Request 47576: Agent: Add Windows support to the containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47576/ --- (Updated May 28, 2016, 3:17 a.m.) Review request for mesos, Daniel Pravat, Arte

Re: Review Request 47576: Agent: Add Windows support to the containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47576/ --- (Updated May 28, 2016, 2:17 a.m.) Review request for mesos, Daniel Pravat, Arte

Re: Review Request 47576: Agent: Add Windows support to the containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47576/ --- (Updated May 27, 2016, 5:37 a.m.) Review request for mesos, Daniel Pravat, Arte

Re: Review Request 47576: Agent: Add Windows support to the containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47576/ --- (Updated May 26, 2016, 3:02 p.m.) Review request for mesos, Daniel Pravat, Arte

Re: Review Request 47576: Agent: Add Windows support to the containerizer.

> On May 24, 2016, 11:37 p.m., Joris Van Remoortere wrote: > > src/slave/containerizer/mesos/containerizer.cpp, lines 286-288 > > > > > > Quick comment saying that the network isolator is currently not > > supported

Re: Review Request 47576: Agent: Add Windows support to the containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47576/#review134662 --- src/slave/containerizer/docker.cpp (line 251)

Re: Review Request 47576: Agent: Add Windows support to the containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47576/#review133866 --- Bad patch! Reviews applied: [47576, 47536, 47472, 47471, 47470, 4

Review Request 47576: Agent: Add Windows support to the containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47576/ --- Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere