Re: Review Request 65437: Added documentation for fault domains.

2018-02-02 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65437/#review196746
---



FAIL: Failed to apply the current review.

Failed command: `python.exe .\support\apply-reviews.py -n -r 65437`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65437

Relevant logs:

- 
[apply-review-65437-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65437/logs/apply-review-65437-stdout.log):

```
error: patch failed: docs/configuration/master-and-agent.md:95
error: docs/configuration/master-and-agent.md: patch does not apply
error: docs/fault-domains.md: already exists in index
error: patch failed: docs/home.md:26
error: docs/home.md: patch does not apply
```

- Mesos Reviewbot Windows


On Feb. 2, 2018, 7:30 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65437/
> ---
> 
> (Updated Feb. 2, 2018, 7:30 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-8291
> https://issues.apache.org/jira/browse/MESOS-8291
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fault domains are a new feature in 1.5 which did not yet have
> a corresponding description in the documentation.
> 
> 
> Diffs
> -
> 
>   docs/configuration/master-and-agent.md 
> f247498ead43a16bbef5afb49d453073dd9ab6ef 
>   docs/fault-domains.md PRE-CREATION 
>   docs/home.md f5b65cc7895b10181e1b8483e3ee9da596d00fd6 
> 
> 
> Diff: https://reviews.apache.org/r/65437/diff/3/
> 
> 
> Testing
> ---
> 
> No.
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 65437: Added documentation for fault domains.

2018-02-02 Thread Vinod Kone 


> On Feb. 2, 2018, 10:11 p.m., Vinod Kone wrote:
> >

Fixed the issues before committing.


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65437/#review196740
---


On Feb. 2, 2018, 7:30 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65437/
> ---
> 
> (Updated Feb. 2, 2018, 7:30 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-8483
> https://issues.apache.org/jira/browse/MESOS-8483
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fault domains are a new feature in 1.5 which did not yet have
> a corresponding description in the documentation.
> 
> 
> Diffs
> -
> 
>   docs/configuration/master-and-agent.md 
> f247498ead43a16bbef5afb49d453073dd9ab6ef 
>   docs/fault-domains.md PRE-CREATION 
>   docs/home.md f5b65cc7895b10181e1b8483e3ee9da596d00fd6 
> 
> 
> Diff: https://reviews.apache.org/r/65437/diff/3/
> 
> 
> Testing
> ---
> 
> No.
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 65437: Added documentation for fault domains.

2018-02-02 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65437/#review196740
---


Fix it, then Ship it!





docs/fault-domains.md
Line 74 (original), 79 (patched)


s/London/San Francisco/ ?



docs/fault-domains.md
Line 84 (original), 89 (patched)


s/companies/company's/


- Vinod Kone


On Feb. 2, 2018, 7:30 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65437/
> ---
> 
> (Updated Feb. 2, 2018, 7:30 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-8483
> https://issues.apache.org/jira/browse/MESOS-8483
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fault domains are a new feature in 1.5 which did not yet have
> a corresponding description in the documentation.
> 
> 
> Diffs
> -
> 
>   docs/configuration/master-and-agent.md 
> f247498ead43a16bbef5afb49d453073dd9ab6ef 
>   docs/fault-domains.md PRE-CREATION 
>   docs/home.md f5b65cc7895b10181e1b8483e3ee9da596d00fd6 
> 
> 
> Diff: https://reviews.apache.org/r/65437/diff/3/
> 
> 
> Testing
> ---
> 
> No.
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 65437: Added documentation for fault domains.

2018-02-02 Thread Vinod Kone 


> On Feb. 1, 2018, 10:18 p.m., Vinod Kone wrote:
> > docs/fault-domains.md
> > Lines 63 (patched)
> > 
> >
> > s/The default/By default, the/
> 
> Benno Evers wrote:
> Are you sure about this? It would imply to me as a reader that this 
> behaviour can be changed.

I see. Yea, I'm not very sure then, what you have is probably less confusing.


> On Feb. 1, 2018, 10:18 p.m., Vinod Kone wrote:
> > docs/fault-domains.md
> > Lines 80 (patched)
> > 
> >
> > Non-region-aware frameworks will only receive offers from the primary 
> > region (region containing masters). They won't get offers from other 
> > regions.
> 
> Benno Evers wrote:
> Does this actually imply that users should upgrade all their frameworks 
> to be partition-aware before configuring masters and agents with fault 
> domains? In this example, it would be quite devastating if two out of three 
> datacenters suddenly went completely unused.

s/primary/local/ in my first comment.

Do you mean REGION aware and not PARTION aware? So, yes, frameworks need to 
register with REGION_AWARE capability if they want remote region offers. The 
rationale was that most frameworks want their workloads in the local region and 
not magically go to remote regions with potentially higher latencies without an 
explicit opt-in. Note that region-aware frameworks should ideally expose the 
remote launching capability to their users too (e.g., via a configuration 
option in the app definition) before they start registering with REGION_AWARE 
capability.


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65437/#review196653
---


On Feb. 2, 2018, 7:30 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65437/
> ---
> 
> (Updated Feb. 2, 2018, 7:30 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-8483
> https://issues.apache.org/jira/browse/MESOS-8483
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fault domains are a new feature in 1.5 which did not yet have
> a corresponding description in the documentation.
> 
> 
> Diffs
> -
> 
>   docs/configuration/master-and-agent.md 
> f247498ead43a16bbef5afb49d453073dd9ab6ef 
>   docs/fault-domains.md PRE-CREATION 
>   docs/home.md f5b65cc7895b10181e1b8483e3ee9da596d00fd6 
> 
> 
> Diff: https://reviews.apache.org/r/65437/diff/3/
> 
> 
> Testing
> ---
> 
> No.
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 65437: Added documentation for fault domains.

2018-02-02 Thread Benno Evers 


> On Feb. 1, 2018, 10:18 p.m., Vinod Kone wrote:
> > docs/fault-domains.md
> > Lines 63 (patched)
> > 
> >
> > s/The default/By default, the/

Are you sure about this? It would imply to me as a reader that this behaviour 
can be changed.


> On Feb. 1, 2018, 10:18 p.m., Vinod Kone wrote:
> > docs/fault-domains.md
> > Lines 80 (patched)
> > 
> >
> > Non-region-aware frameworks will only receive offers from the primary 
> > region (region containing masters). They won't get offers from other 
> > regions.

Does this actually imply that users should upgrade all their frameworks to be 
partition-aware before configuring masters and agents with fault domains? In 
this example, it would be quite devastating if two out of three datacenters 
suddenly went completely unused.


- Benno


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65437/#review196653
---


On Feb. 2, 2018, 7:30 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65437/
> ---
> 
> (Updated Feb. 2, 2018, 7:30 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-8483
> https://issues.apache.org/jira/browse/MESOS-8483
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fault domains are a new feature in 1.5 which did not yet have
> a corresponding description in the documentation.
> 
> 
> Diffs
> -
> 
>   docs/configuration/master-and-agent.md 
> f247498ead43a16bbef5afb49d453073dd9ab6ef 
>   docs/fault-domains.md PRE-CREATION 
>   docs/home.md f5b65cc7895b10181e1b8483e3ee9da596d00fd6 
> 
> 
> Diff: https://reviews.apache.org/r/65437/diff/3/
> 
> 
> Testing
> ---
> 
> No.
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 65437: Added documentation for fault domains.

2018-02-02 Thread Benno Evers 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65437/
---

(Updated Feb. 2, 2018, 7:30 p.m.)


Review request for mesos and Vinod Kone.


Bugs: MESOS-8483
https://issues.apache.org/jira/browse/MESOS-8483


Repository: mesos


Description
---

Fault domains are a new feature in 1.5 which did not yet have
a corresponding description in the documentation.


Diffs (updated)
-

  docs/configuration/master-and-agent.md 
f247498ead43a16bbef5afb49d453073dd9ab6ef 
  docs/fault-domains.md PRE-CREATION 
  docs/home.md f5b65cc7895b10181e1b8483e3ee9da596d00fd6 


Diff: https://reviews.apache.org/r/65437/diff/3/

Changes: https://reviews.apache.org/r/65437/diff/2-3/


Testing
---

No.


Thanks,

Benno Evers

Re: Review Request 65437: Added documentation for fault domains.

2018-02-01 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65437/#review196653
---




docs/configuration/master-and-agent.md
Lines 99 (patched)


Can you also call this out in the home page of documentation 
"http://mesos.apache.org/documentation/latest/;, perhaps in the 
"Administration" section?



docs/fault-domains.md
Lines 15-16 (patched)


How about

"A fault domain is a 2 level hierarchy of regions and zones."



docs/fault-domains.md
Lines 51 (patched)


s/slave/agent/



docs/fault-domains.md
Lines 56 (patched)


s/master,/master/



docs/fault-domains.md
Lines 61 (patched)


This should be:

* All masters must belong to the same "region" to avoid cross-region quorum 
writes. It is recommended to put them in different zones within that region for 
high availability.



docs/fault-domains.md
Lines 63 (patched)


s/The default/By default, the/



docs/fault-domains.md
Lines 71 (patched)


s/connected in a/connected through a/



docs/fault-domains.md
Lines 74-78 (patched)


In this example, "europe", "na" and "asia" would be regions. 

Also, I would not use cross continental regions as an example because we 
haven't tested the latency limits. Lets use "california", "atlanta" and "new 
york" as regions.

Zones would be racks within the data center.

One of these regions should contain all the masters, preferrably spread 
across zones. Putting them across racks gives them enough isolation for faults 
without sacrificing latency for quorum writes.



docs/fault-domains.md
Lines 80 (patched)


Non-region-aware frameworks will only receive offers from the primary 
region (region containing masters). They won't get offers from other regions.



docs/fault-domains.md
Lines 88 (patched)


s/to read the `domain`/to register with `REGION_AWARE` capability/



docs/fault-domains.md
Lines 90-99 (patched)


This example is a bit too complicated. I would say lets use an example of 
one on-prem data center which is extended by a cloud provider hosted remote 
region.


- Vinod Kone


On Jan. 31, 2018, 5:50 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65437/
> ---
> 
> (Updated Jan. 31, 2018, 5:50 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-8483
> https://issues.apache.org/jira/browse/MESOS-8483
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fault domains are a new feature in 1.5 which did not yet have
> a corresponding description in the documentation.
> 
> 
> Diffs
> -
> 
>   docs/configuration/master-and-agent.md 
> f247498ead43a16bbef5afb49d453073dd9ab6ef 
>   docs/fault-domains.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/65437/diff/2/
> 
> 
> Testing
> ---
> 
> No.
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 65437: Added documentation for fault domains.

2018-01-31 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65437/#review196576
---



PASS: Mesos patch 65437 was successfully built and tested.

Reviews applied: `['65437']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65437

- Mesos Reviewbot Windows


On Jan. 31, 2018, 5:50 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65437/
> ---
> 
> (Updated Jan. 31, 2018, 5:50 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-8483
> https://issues.apache.org/jira/browse/MESOS-8483
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fault domains are a new feature in 1.5 which did not yet have
> a corresponding description in the documentation.
> 
> 
> Diffs
> -
> 
>   docs/configuration/master-and-agent.md 
> f247498ead43a16bbef5afb49d453073dd9ab6ef 
>   docs/fault-domains.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/65437/diff/2/
> 
> 
> Testing
> ---
> 
> No.
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 65437: Added documentation for fault domains.

2018-01-31 Thread Benno Evers 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65437/#review196571
---




docs/fault-domains.md
Lines 74 (patched)


This example actually differs from the description in the first section, 
but it seems to me that placing all masters in the same data center somewhat 
defeats the goal of achieving high availability, and  that most people would 
prefer running jobs in a remote data center rather than having the "main" 
datacenter overloaded. But maybe someone with more insight into the design of 
fault domains can comment on this?


- Benno Evers


On Jan. 31, 2018, 5:50 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65437/
> ---
> 
> (Updated Jan. 31, 2018, 5:50 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-8483
> https://issues.apache.org/jira/browse/MESOS-8483
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fault domains are a new feature in 1.5 which did not yet have
> a corresponding description in the documentation.
> 
> 
> Diffs
> -
> 
>   docs/configuration/master-and-agent.md 
> f247498ead43a16bbef5afb49d453073dd9ab6ef 
>   docs/fault-domains.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/65437/diff/2/
> 
> 
> Testing
> ---
> 
> No.
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Review Request 65437: Added documentation for fault domains.

2018-01-31 Thread Benno Evers 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65437/
---

Review request for mesos and Vinod Kone.


Bugs: MESOS-8483
https://issues.apache.org/jira/browse/MESOS-8483


Repository: mesos


Description
---

Fault domains are a new feature in 1.5 which did not yet have
a corresponding description in the documentation.


Diffs
-

  3rdparty/CMakeLists.txt da605707b89bbe9b3db9e60bc0b0a26dac46e56e 
  3rdparty/boost-1.53.0.tar.gz PRE-CREATION 
  3rdparty/boost-1.65.0.tar.gz 25973f3ec5d3ecb09d82774780726ee7dfd50518 
  3rdparty/cmake/Versions.cmake 94b0d8048412e00e2480f45e7ce4e6494da4bd5d 
  3rdparty/libprocess/Makefile.am 3071b7ce2b82a4ce0ea62e4d2b3518a6f5114803 
  3rdparty/libprocess/configure.ac 69ec9b9683199f580405e38ec16a581a01f919c4 
  3rdparty/libprocess/include/process/process.hpp 
8661706cb058efb26f5bfbcc84972f9930d3670f 
  3rdparty/libprocess/include/process/queue.hpp 
c364b7dc831050bc1b23f669dc1ccc1f1255a9c8 
  3rdparty/libprocess/src/libevent_ssl_socket.cpp 
521b0cfbccd3599524b1407ef70880f4538941df 
  3rdparty/libprocess/src/process.cpp ba9bc291bb6741e32b3a066fe90771311d21852a 
  3rdparty/libprocess/src/tests/benchmarks.cpp 
48b5f5cf38d8fb4d77025f9723031075ca8ab677 
  3rdparty/libprocess/src/tests/http_tests.cpp 
a60f6b132aff00da42e733f5c5f387dff2428ed2 
  3rdparty/libprocess/src/tests/queue_tests.cpp 
cc6b3d82ce5eb5ca16e2b9378dd5b1f28ac62fe8 
  3rdparty/stout/Makefile.am ef22a02a8a11326c6af19eb11d79eb82ff7861da 
  3rdparty/stout/configure.ac 5a8c023de63e6b96b128cdfb472859a6f3e6ede5 
  3rdparty/stout/include/stout/duration.hpp 
42c43cda21c75fc3bef962af67c4a09df68a95af 
  3rdparty/stout/include/stout/json.hpp 
7484f4aab0025a1b6e5d51484f92b0aef96fe433 
  3rdparty/stout/include/stout/numify.hpp 
ecf4fcf9f87d372bac6737d8c3a7ac9885bc581d 
  3rdparty/stout/include/stout/posix/os.hpp 
dfee0faa084932bf60c93c7aae63665225cd4ab1 
  3rdparty/stout/include/stout/protobuf.hpp 
7e7659814a5d95c41c4dfabb5669fd061dff4716 
  3rdparty/stout/include/stout/windows/os.hpp 
ec935209fc1532ebe087ac20933c99eed393506d 
  3rdparty/stout/tests/json_tests.cpp af00e425961daab6989339165045da3aad0513ba 
  3rdparty/stout/tests/os/env_tests.cpp 
b5b124dc6316e661af6dd90335ade5283c26d9f2 
  3rdparty/versions.am 3e008d5a7bdc029de23950463c295b968b3280c8 
  CHANGELOG 7bf7124bb5de5bd2db58f64382f5ac57c5687460 
  configure.ac 30fbadc32d1d96f719d45fa8067f975283c25507 
  docs/cmake-examples.md 74abfcc4ab97cf9ee91d99293b6731c1247a65e8 
  docs/configuration/master-and-agent.md 
f247498ead43a16bbef5afb49d453073dd9ab6ef 
  docs/fault-domains.md PRE-CREATION 
  docs/modules.md d3e3017fc98929baa4cb5bc29531a368dda0db8c 
  m4/libnl3.m4 e64ba492554d38f98b4d7cf8bd4bd1443e4d0a10 
  src/Makefile.am 155338673e1c23a2cfeab39bdf3ebe14568bfebc 
  src/executor/executor.cpp 945936883afba0b52c95242cd410c335424b5768 
  src/logging/logging.cpp 8e03ac66ea27ce1cc3a3fb5f2489ca201e1f8e92 
  src/slave/containerizer/docker.cpp f1d7d3e6afa119a6a24b054dcaa5ee68dbea965d 
  src/slave/containerizer/mesos/io/switchboard.cpp 
aeb0b3e4cf75b19efd9b3922cc4707d3c5cb 
  src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
697f998713f8bbb306f5186dcad7e5e92c2dd415 
  src/slave/containerizer/mesos/paths.hpp 
b9f0f454ada3ee4e6648916a2c582bcfeebe1732 
  src/slave/containerizer/mesos/paths.cpp 
186048f159d6ce20d9c5dc65c00012eb5911520b 
  src/tests/api_tests.cpp b639a4bafbf69d3ea53aa0573e9f0489c3a1a57f 
  src/tests/check_tests.cpp d48febfca220a9633b9884963bcf5a205db7f5e5 
  src/tests/containerizer/cni_isolator_tests.cpp 
b8eb80fb671646cd7551f1ee6cfad6f4a81ebc8f 
  src/tests/containerizer/mesos_containerizer_tests.cpp 
4fce8af7c89fd3b9166e1784203f99853624faef 
  src/tests/containerizer/nested_mesos_containerizer_tests.cpp 
796bc401d4f922e7a6bd9e5391003cddd4331c95 
  src/tests/default_executor_tests.cpp cc97e0d1fea7f4d0bc544d850593d8d91921b552 
  src/tests/disk_quota_tests.cpp 31cf4c44b1494afd3501046abffd303c7a1307f8 
  src/tests/fault_tolerance_tests.cpp 64a865339cc0dad1bc43aea40c6491d0ece6e48a 
  src/tests/hierarchical_allocator_tests.cpp 
42dc6ac5e281bb0cdb938106fd3f12324e9e6330 
  src/tests/master_slave_reconciliation_tests.cpp 
0541aa56a414fbec872e7e3ec6ad50206766054a 
  src/tests/master_tests.cpp 7112bb4efcc312dc4f68bdc44fb685c7624002b1 
  src/tests/master_validation_tests.cpp 
1260357e42f58934b55cc9a1544b4953844c6966 
  src/tests/oversubscription_tests.cpp 41c1178ec4514ef6a1fb369734d4f9d73710d883 
  src/tests/reconciliation_tests.cpp ad6c99306a82ef3da54a9d6d3c9d6f11ba145d6c 
  src/tests/slave_recovery_tests.cpp 6dcbedb94a2c7b3d65770fc89920c0cad1298d1f 
  src/tests/slave_tests.cpp 20b874481d3818574731fc30ba9df1fc2bcbe900 
  src/tests/sorter_tests.cpp da4e0f64a565af1d9458ff256ae0eafddd0a6b68 
  src/tests/storage_local_resource_provider_tests.cpp 
e0b089ac96de4762f2c5ddae9716a38d9837d1bf