Re: Review Request 66538: Added unit test slave recovery for default executor tests.

2018-04-12 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66538/#review200987 --- Fix it, then Ship it! src/tests/default_executor_tests.cpp Lin

Re: Review Request 66538: Added unit test slave recovery for default executor tests.

2018-04-11 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66538/ --- (Updated April 11, 2018, 1:40 p.m.) Review request for mesos, Jie Yu, Kevin Klu

Re: Review Request 66538: Added unit test slave recovery for default executor tests.

2018-04-11 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66538/ --- (Updated April 11, 2018, 12:01 p.m.) Review request for mesos, Jie Yu, Kevin Kl

Re: Review Request 66538: Added unit test slave recovery for default executor tests.

2018-04-11 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66538/ --- (Updated April 11, 2018, 11:53 a.m.) Review request for mesos, Jie Yu, Kevin Kl

Re: Review Request 66538: Added unit test slave recovery for default executor tests.

2018-04-11 Thread Gilbert Song
> On April 11, 2018, 7:14 a.m., Qian Zhang wrote: > > src/tests/default_executor_tests.cpp > > Lines 1427-1430 (patched) > > > > > > Why do we need to launch the executor using reserved resources? This > > seems no

Re: Review Request 66538: Added unit test slave recovery for default executor tests.

2018-04-11 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66538/#review200891 --- src/tests/default_executor_tests.cpp Lines 1427-1430 (patched)

Review Request 66538: Added unit test slave recovery for default executor tests.

2018-04-10 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66538/ --- Review request for mesos, Jie Yu, Kevin Klues, Qian Zhang, and Vinod Kone. Bugs