[GitHub] spark issue #15314: [SPARK-17747][ML] WeightCol support non-double datatypes

2016-10-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15314 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66598/ Test FAILed. ---

[GitHub] spark issue #15314: [SPARK-17747][ML] WeightCol support non-double datatypes

2016-10-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15314 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-10-09 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r82517028 --- Diff: python/pyspark/sql/catalog.py --- @@ -181,6 +181,22 @@ def dropTempView(self, viewName): """

[GitHub] spark issue #14861: [SPARK-17287] [PYSPARK] Add recursive kwarg to Python Sp...

2016-10-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14861 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66593/ Test PASSed. ---

[GitHub] spark issue #14861: [SPARK-17287] [PYSPARK] Add recursive kwarg to Python Sp...

2016-10-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14861 **[Test build #66593 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66593/consoleFull)** for PR 14861 at commit

[GitHub] spark issue #14861: [SPARK-17287] [PYSPARK] Add recursive kwarg to Python Sp...

2016-10-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14861 Build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #15159: [SPARK-17605][SPARK_SUBMIT] Add option spark.usePython a...

2016-10-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15159 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66594/ Test PASSed. ---

[GitHub] spark issue #15159: [SPARK-17605][SPARK_SUBMIT] Add option spark.usePython a...

2016-10-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15159 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15159: [SPARK-17605][SPARK_SUBMIT] Add option spark.usePython a...

2016-10-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15159 **[Test build #66594 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66594/consoleFull)** for PR 15159 at commit

[GitHub] spark issue #9766: [SPARK-11775][PYSPARK][SQL] Allow PySpark to register Jav...

2016-10-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/9766 **[Test build #66599 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66599/consoleFull)** for PR 9766 at commit

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-10-09 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r82517333 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala --- @@ -125,6 +124,9 @@ class QueryExecution(val sparkSession:

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-10-09 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r82517346 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala --- @@ -380,6 +380,7 @@ class SparkSqlAstBuilder(conf: SQLConf)

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-10-09 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r82517434 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala --- @@ -37,39 +37,14 @@ import

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-10-09 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r82517462 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala --- @@ -94,6 +69,47 @@ private[sql] class SharedState(val sparkContext:

[GitHub] spark issue #15403: [SPARK-17832][SQL] TableIdentifier.quotedString creates ...

2016-10-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15403 **[Test build #66596 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66596/consoleFull)** for PR 15403 at commit

[GitHub] spark issue #15403: [SPARK-17832][SQL] TableIdentifier.quotedString creates ...

2016-10-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15403 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66596/ Test PASSed. ---

[GitHub] spark issue #15403: [SPARK-17832][SQL] TableIdentifier.quotedString creates ...

2016-10-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15403 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-10-09 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r82517570 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/GlobalTempViewSuite.scala --- @@ -0,0 +1,168 @@ +/* + * Licensed to the Apache

[GitHub] spark issue #15319: [SPARK-17733][SQL] InferFiltersFromConstraints rule neve...

2016-10-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15319 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15319: [SPARK-17733][SQL] InferFiltersFromConstraints rule neve...

2016-10-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15319 **[Test build #66597 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66597/consoleFull)** for PR 15319 at commit

[GitHub] spark issue #15319: [SPARK-17733][SQL] InferFiltersFromConstraints rule neve...

2016-10-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15319 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66597/ Test FAILed. ---

[GitHub] spark issue #15388: [SPARK-17821][SQL] Support And and Or in Expression Cano...

2016-10-09 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/15388 @gatorsmile Because `bUpper > 100 || aUpper <= 10 && aUpper > bUpper` is actually `bUpper > 100 || (aUpper <= 10 && aUpper > bUpper)` due to operator precedence. --- If your project is set up for

[GitHub] spark issue #14847: [SPARK-17254][SQL] Filter can stop when the condition is...

2016-10-09 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/14847 Is it possible to speed up the whole-stage-on case? We can create a new physical operator `FilterOnSortedData` to isolate this special logic. --- If your project is set up for it, you can reply

[GitHub] spark issue #14847: [SPARK-17254][SQL] Filter can stop when the condition is...

2016-10-09 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/14847 @cloud-fan If this direction is okay for you, I can investigate it further. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #15388: [SPARK-17821][SQL] Support And and Or in Expression Cano...

2016-10-09 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/15388 LGTM, +1 on the suggestion of @gatorsmile to improve test coverage. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark issue #15314: [SPARK-17747][ML] WeightCol support non-double datatypes

2016-10-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15314 **[Test build #66600 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66600/consoleFull)** for PR 15314 at commit

[GitHub] spark issue #15219: [SPARK-14098][SQL] Generate Java code to build CachedCol...

2016-10-09 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/15219 I'm not familiar with this part, cc @davies --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #14847: [SPARK-17254][SQL] Filter can stop when the condition is...

2016-10-09 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/14847 If the filter condition is deterministic, I think this is a good optimization, especially for bucketed(with SORT BY) table, cc @yhuai @gatorsmile --- If your project is set up for it, you can

[GitHub] spark issue #14365: [SPARK-16628][SQL] Translate file-based relation schema ...

2016-10-09 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/14365 I noticed that `spark.sql.hive.convertMetastoreOrc` is false by default, so this bug is not so critical. And we may stop inferring file schema when reading ORC tables, for performance

[GitHub] spark pull request #10307: [SPARK-12334][SQL][PYSPARK] Support read from mul...

2016-10-09 Thread zjffdu
Github user zjffdu closed the pull request at: https://github.com/apache/spark/pull/10307 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #10307: [SPARK-12334][SQL][PYSPARK] Support read from mul...

2016-10-09 Thread zjffdu
GitHub user zjffdu reopened a pull request: https://github.com/apache/spark/pull/10307 [SPARK-12334][SQL][PYSPARK] Support read from multiple input paths for orc file in DataFrameReader.orc Beside the issue in spark api, also fix 2 minor issues in pyspark * support

[GitHub] spark issue #15319: [SPARK-17733][SQL] InferFiltersFromConstraints rule neve...

2016-10-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15319 **[Test build #66597 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66597/consoleFull)** for PR 15319 at commit

[GitHub] spark issue #15314: [SPARK-17747][ML] WeightCol support non-double datatypes

2016-10-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15314 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15314: [SPARK-17747][ML] WeightCol support non-double datatypes

2016-10-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15314 **[Test build #66595 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66595/consoleFull)** for PR 15314 at commit

[GitHub] spark issue #15314: [SPARK-17747][ML] WeightCol support non-double datatypes

2016-10-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15314 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66595/ Test FAILed. ---

[GitHub] spark issue #15388: [SPARK-17821][SQL] Support And and Or in Expression Cano...

2016-10-09 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/15388 ping @hvanhovell @rxin Can you take a look again? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark issue #15389: [SPARK-17817][PySpark] PySpark RDD Repartitioning Result...

2016-10-09 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15389 @holdenk Thanks you for cc'ing me. It looks okay to me as targeted but I feel we need a sign-off. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark issue #15178: [SPARK-17556][SQL] Executor side broadcast for broadcast...

2016-10-09 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/15178 ping @rxin @JoshRosen Can you review this? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #15389: [SPARK-17817][PySpark] PySpark RDD Repartitioning Result...

2016-10-09 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/15389 @holdenk @dusenberrymw @HyukjinKwon Thanks for review! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark issue #15218: [SPARK-17637][Scheduler]Packed scheduling for Spark task...

2016-10-09 Thread zhzhan
Github user zhzhan commented on the issue: https://github.com/apache/spark/pull/15218 @mridulm You are right. This patch is mainly for the job that has multiple stages, which is very common in production pipeline. As you mentioned, if there is shuffle involved,

[GitHub] spark issue #15314: [SPARK-17747][ML] WeightCol support non-double datatypes

2016-10-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15314 **[Test build #66598 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66598/consoleFull)** for PR 15314 at commit

[GitHub] spark issue #15388: [SPARK-17821][SQL] Support And and Or in Expression Cano...

2016-10-09 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15388 Why the following case can pass? ```Scala setTest(1, bUpper > 100 || aUpper <= 10 && aUpper > bUpper, bUpper > 100 || (aUpper <= 10 &&

[GitHub] spark issue #15388: [SPARK-17821][SQL] Support And and Or in Expression Cano...

2016-10-09 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15388 BTW, we need to add more mixed cases in the test cases when supporting `And` and `Or` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark issue #15314: [SPARK-17747][ML] WeightCol support non-double datatypes

2016-10-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15314 **[Test build #66598 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66598/consoleFull)** for PR 15314 at commit

[GitHub] spark issue #15403: [SPARK-17832][SQL] TableIdentifier.quotedString creates ...

2016-10-09 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/15403 @hvanhovell nvm about the `catalog.getTable` issue, it turns out to be my mistake. Sorry about that... --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark issue #15403: [SPARK-17832][SQL] TableIdentifier.quotedString creates ...

2016-10-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15403 **[Test build #66596 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66596/consoleFull)** for PR 15403 at commit

[GitHub] spark pull request #15319: [SPARK-17733][SQL] InferFiltersFromConstraints ru...

2016-10-09 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/15319#discussion_r82515583 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/QueryPlan.scala --- @@ -74,14 +74,26 @@ abstract class QueryPlan[PlanType <:

[GitHub] spark issue #15406: [Spark-17745][ml][PySpark] update NB python api

2016-10-09 Thread sethah
Github user sethah commented on the issue: https://github.com/apache/spark/pull/15406 Would you mind changing the title to reflect the actual change? Something to indicate that you are adding weight column param to Python? Thanks! --- If your project is set up for it, you can reply

[GitHub] spark issue #15408: [SPARK-17839][CORE] UnsafeSorterSpillReader should use N...

2016-10-09 Thread sitalkedia
Github user sitalkedia commented on the issue: https://github.com/apache/spark/pull/15408 cc - @rxin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark pull request #15371: [SPARK-17816] [Core] Fix ConcurrentModificationEx...

2016-10-09 Thread seyfe
Github user seyfe commented on a diff in the pull request: https://github.com/apache/spark/pull/15371#discussion_r82528765 --- Diff: core/src/main/scala/org/apache/spark/util/AccumulatorV2.scala --- @@ -444,7 +444,7 @@ class CollectionAccumulator[T] extends AccumulatorV2[T,

[GitHub] spark issue #15408: [SPARK-17839][CORE] UnsafeSorterSpillReader should use N...

2016-10-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15408 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15408: [SPARK-17839][CORE] UnsafeSorterSpillReader should use N...

2016-10-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15408 **[Test build #66612 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66612/consoleFull)** for PR 15408 at commit

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-10-09 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r82536096 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala --- @@ -94,6 +69,47 @@ private[sql] class SharedState(val sparkContext:

[GitHub] spark issue #15388: [SPARK-17821][SQL] Support And and Or in Expression Cano...

2016-10-09 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/15388 @cloud-fan / @gatorsmile I left some comments on improving clarity. It's pretty important to the maintenance of the project. --- If your project is set up for it, you can reply to this

[GitHub] spark issue #9287: SPARK-11326: Split networking in standalone mode

2016-10-09 Thread jacek-lewandowski
Github user jacek-lewandowski commented on the issue: https://github.com/apache/spark/pull/9287 Closing, although I don't really understand the reason why it wasn't accepted. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark issue #15292: [SPARK-17719][SPARK-17776][SQL] Unify and tie up options...

2016-10-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15292 **[Test build #66606 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66606/consoleFull)** for PR 15292 at commit

[GitHub] spark issue #14745: [SPARK-16896][SQL] Handle duplicated field names in head...

2016-10-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14745 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66605/ Test FAILed. ---

[GitHub] spark issue #14745: [SPARK-16896][SQL] Handle duplicated field names in head...

2016-10-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14745 **[Test build #66605 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66605/consoleFull)** for PR 14745 at commit

[GitHub] spark issue #15324: [SPARK-16872][ML] Gaussian Naive Bayes Classifier

2016-10-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15324 **[Test build #66604 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66604/consoleFull)** for PR 15324 at commit

[GitHub] spark pull request #15292: [SPARK-17719][SPARK-17776][SQL] Unify and tie up ...

2016-10-09 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/15292#discussion_r82524289 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala --- @@ -229,13 +229,9 @@ class DataFrameReader private[sql](sparkSession:

[GitHub] spark issue #14745: [SPARK-16896][SQL] Handle duplicated field names in head...

2016-10-09 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/14745 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #12691: [Spark-14761][SQL][WIP] Reject invalid join methods when...

2016-10-09 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/12691 @bkpathak you can just close this and reopen. Although you can fix this with git surgery and a force-push, sometimes it's not worth it if you can just branch, patch the commit(s) you want to keep,

[GitHub] spark issue #9287: SPARK-11326: Split networking in standalone mode

2016-10-09 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/9287 I ~guess~ the reason it wasn't accepted and reviewed due to the lack of man power of committers or the lack of appealing or because it simply just got stale. At least, I said +1 for this reason.

[GitHub] spark issue #14547: [SPARK-16718][MLlib] gbm-style treeboost

2016-10-09 Thread vlad17
Github user vlad17 commented on the issue: https://github.com/apache/spark/pull/14547 @setah do you have any opinion on "loss-based" vs. "auto" or @jkbradley do you feel strongly about this? I think the trade-off is between being explicit vs. possibly confusing the user. I prefer

[GitHub] spark pull request #15406: [Spark-17745][ml][PySpark] update NB python api

2016-10-09 Thread WeichenXu123
GitHub user WeichenXu123 opened a pull request: https://github.com/apache/spark/pull/15406 [Spark-17745][ml][PySpark] update NB python api ## What changes were proposed in this pull request? update python api for NaiveBayes. ## How was this patch tested?

[GitHub] spark issue #15292: [SPARK-17719][SPARK-17776][SQL] Unify and tie up options...

2016-10-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15292 **[Test build #66606 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66606/consoleFull)** for PR 15292 at commit

[GitHub] spark issue #15292: [SPARK-17719][SPARK-17776][SQL] Unify and tie up options...

2016-10-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15292 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15388: [SPARK-17821][SQL] Support And and Or in Expression Cano...

2016-10-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15388 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66601/ Test PASSed. ---

[GitHub] spark issue #15388: [SPARK-17821][SQL] Support And and Or in Expression Cano...

2016-10-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15388 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15388: [SPARK-17821][SQL] Support And and Or in Expression Cano...

2016-10-09 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15388 LGTM Forgot the precedence of `AND` is higher than `OR`. BTW, also checked SQL. It follows the same precedence order. That is, `AND` is higher than `OR`. ``` From

[GitHub] spark issue #15292: [SPARK-17719][SPARK-17776][SQL] Unify and tie up options...

2016-10-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15292 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66606/ Test PASSed. ---

[GitHub] spark issue #15388: [SPARK-17821][SQL] Support And and Or in Expression Cano...

2016-10-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15388 **[Test build #66601 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66601/consoleFull)** for PR 15388 at commit

[GitHub] spark issue #14897: [SPARK-17338][SQL] add global temp view

2016-10-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14897 **[Test build #66603 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66603/consoleFull)** for PR 14897 at commit

[GitHub] spark issue #14897: [SPARK-17338][SQL] add global temp view

2016-10-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14897 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14897: [SPARK-17338][SQL] add global temp view

2016-10-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14897 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14897: [SPARK-17338][SQL] add global temp view

2016-10-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14897 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66603/ Test PASSed. ---

[GitHub] spark pull request #9287: SPARK-11326: Split networking in standalone mode

2016-10-09 Thread jacek-lewandowski
Github user jacek-lewandowski closed the pull request at: https://github.com/apache/spark/pull/9287 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #15324: [SPARK-16872][ML] Gaussian Naive Bayes Classifier

2016-10-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15324 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66604/ Test FAILed. ---

[GitHub] spark issue #15324: [SPARK-16872][ML] Gaussian Naive Bayes Classifier

2016-10-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15324 **[Test build #66604 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66604/consoleFull)** for PR 15324 at commit

[GitHub] spark issue #15324: [SPARK-16872][ML] Gaussian Naive Bayes Classifier

2016-10-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15324 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #14745: [SPARK-16896][SQL] Handle duplicated field names ...

2016-10-09 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/14745#discussion_r82524139 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVFileFormat.scala --- @@ -57,22 +58,16 @@ class CSVFileFormat

[GitHub] spark issue #15406: [Spark-17745][ml][PySpark] update NB python api

2016-10-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15406 **[Test build #66607 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66607/consoleFull)** for PR 15406 at commit

[GitHub] spark issue #15406: [Spark-17745][ml][PySpark] update NB python api

2016-10-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15406 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66607/ Test PASSed. ---

[GitHub] spark issue #15406: [Spark-17745][ml][PySpark] update NB python api

2016-10-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15406 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15406: [Spark-17745][ml][PySpark] update NB python api

2016-10-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15406 **[Test build #66607 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66607/consoleFull)** for PR 15406 at commit

[GitHub] spark issue #14745: [SPARK-16896][SQL] Handle duplicated field names in head...

2016-10-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14745 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14745: [SPARK-16896][SQL] Handle duplicated field names in head...

2016-10-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14745 **[Test build #66608 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66608/consoleFull)** for PR 14745 at commit

[GitHub] spark issue #14215: [SPARK-16544][SQL][WIP] Support for conversion from comp...

2016-10-09 Thread wgtmac
Github user wgtmac commented on the issue: https://github.com/apache/spark/pull/14215 @HyukjinKwon no problem. Take your time. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #15382: [SPARK-17810] [SQL] Default spark.sql.warehouse.d...

2016-10-09 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/15382#discussion_r82520916 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -757,7 +758,10 @@ private[sql] class SQLConf extends Serializable with

[GitHub] spark pull request #15371: [SPARK-17816] [Core] Fix ConcurrentModificationEx...

2016-10-09 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/15371#discussion_r82521001 --- Diff: project/MimaExcludes.scala --- @@ -55,7 +55,11 @@ object MimaExcludes {

[GitHub] spark issue #14897: [SPARK-17338][SQL] add global temp view

2016-10-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14897 **[Test build #66602 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66602/consoleFull)** for PR 14897 at commit

[GitHub] spark issue #14897: [SPARK-17338][SQL] add global temp view

2016-10-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14897 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66602/ Test PASSed. ---

[GitHub] spark pull request #15371: [SPARK-17816] [Core] Fix ConcurrentModificationEx...

2016-10-09 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/15371#discussion_r82521015 --- Diff: core/src/main/scala/org/apache/spark/util/AccumulatorV2.scala --- @@ -444,7 +444,7 @@ class CollectionAccumulator[T] extends AccumulatorV2[T,

[GitHub] spark pull request #15405: [SPARK-15917][CORE] Added support for number of e...

2016-10-09 Thread JonathanTaws
GitHub user JonathanTaws opened a pull request: https://github.com/apache/spark/pull/15405 [SPARK-15917][CORE] Added support for number of executors in Standalone [WIP] ## What changes were proposed in this pull request? Currently in standalone mode it is not possible to

[GitHub] spark issue #15405: [SPARK-15917][CORE] Added support for number of executor...

2016-10-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15405 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #14215: [SPARK-16544][SQL][WIP] Support for conversion from comp...

2016-10-09 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/14215 @wgtmac Sorry, I will try to make this complete this within this week. I was busy for some reasons. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark issue #14745: [SPARK-16896][SQL] Handle duplicated field names in head...

2016-10-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14745 **[Test build #66605 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66605/consoleFull)** for PR 14745 at commit

[GitHub] spark pull request #15407: [SPARK-17841][STREAMING][KAFKA] drain commitQueue

2016-10-09 Thread koeninger
GitHub user koeninger opened a pull request: https://github.com/apache/spark/pull/15407 [SPARK-17841][STREAMING][KAFKA] drain commitQueue ## What changes were proposed in this pull request? Actually drain commit queue rather than just iterating it ## How was

[GitHub] spark issue #15334: [SPARK-10367][SQL][WIP] Support Parquet logical type INT...

2016-10-09 Thread dilipbiswal
Github user dilipbiswal commented on the issue: https://github.com/apache/spark/pull/15334 @gatorsmile Thanks .. I had absolutely no idea about this PR :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark issue #15371: [SPARK-17816] [Core] Fix ConcurrentModificationException...

2016-10-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15371 **[Test build #66611 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66611/consoleFull)** for PR 15371 at commit

  1   2   3   >