[GitHub] spark issue #16929: [SPARK-19595][SQL] Support json array in from_json

2017-02-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16929 **[Test build #73491 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73491/testReport)** for PR 16929 at commit

[GitHub] spark issue #16976: [SPARK-19610][SQL] Support parsing multiline CSV files

2017-02-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16976 **[Test build #73493 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73493/testReport)** for PR 16976 at commit

[GitHub] spark issue #17074: [SPARK-18646][REPL] Set parent classloader as null for E...

2017-02-26 Thread taroplus
Github user taroplus commented on the issue: https://github.com/apache/spark/pull/17074 @holdenk @zsxwing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark issue #16697: [SPARK-19358][CORE] LiveListenerBus shall log the event ...

2017-02-26 Thread CodingCat
Github user CodingCat commented on the issue: https://github.com/apache/spark/pull/16697 @mridulm thanks, I have changed the code --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #16987: [SPARK-19633][SS] FileSource read from FileSink

2017-02-26 Thread lw-lin
Github user lw-lin commented on a diff in the pull request: https://github.com/apache/spark/pull/16987#discussion_r103104003 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala --- @@ -243,13 +243,20 @@ case class DataSource(

[GitHub] spark pull request #16987: [SPARK-19633][SS] FileSource read from FileSink

2017-02-26 Thread lw-lin
Github user lw-lin commented on a diff in the pull request: https://github.com/apache/spark/pull/16987#discussion_r103104024 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/FileStreamSourceSuite.scala --- @@ -662,6 +663,101 @@ class FileStreamSourceSuite extends

[GitHub] spark issue #17071: [SPARK-15615][SQL][BUILD][FOLLOW-UP] Replace deprecated ...

2017-02-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17071 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17071: [SPARK-15615][SQL][BUILD][FOLLOW-UP] Replace deprecated ...

2017-02-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17071 **[Test build #73490 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73490/testReport)** for PR 17071 at commit

[GitHub] spark issue #17070: [SPARK-19721][SS] Good error message for version mismatc...

2017-02-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17070 **[Test build #73487 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73487/testReport)** for PR 17070 at commit

[GitHub] spark issue #16987: [SPARK-19633][SS] FileSource read from FileSink

2017-02-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16987 **[Test build #73492 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73492/testReport)** for PR 16987 at commit

[GitHub] spark issue #17067: [SPARK-19602][SQL][TESTS] Add tests for qualified column...

2017-02-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17067 **[Test build #73494 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73494/testReport)** for PR 17067 at commit

[GitHub] spark pull request #16987: [SPARK-19633][SS] FileSource read from FileSink

2017-02-26 Thread lw-lin
Github user lw-lin commented on a diff in the pull request: https://github.com/apache/spark/pull/16987#discussion_r103104036 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/FileStreamSourceSuite.scala --- @@ -662,6 +663,101 @@ class FileStreamSourceSuite extends

[GitHub] spark issue #17071: [SPARK-15615][SQL][BUILD][FOLLOW-UP] Replace deprecated ...

2017-02-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17071 **[Test build #73489 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73489/testReport)** for PR 17071 at commit

[GitHub] spark issue #17071: [SPARK-15615][SQL][BUILD][FOLLOW-UP] Replace deprecated ...

2017-02-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17071 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17072: [MINOR][BUILD] Fix lint-java breaks in Java

2017-02-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17072 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17072: [MINOR][BUILD] Fix lint-java breaks in Java

2017-02-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17072 **[Test build #73485 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73485/testReport)** for PR 17072 at commit

[GitHub] spark issue #17072: [MINOR][BUILD] Fix lint-java breaks in Java

2017-02-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17072 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73486/ Test PASSed. ---

[GitHub] spark issue #16976: [SPARK-19610][SQL] Support parsing multiline CSV files

2017-02-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16976 **[Test build #73493 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73493/testReport)** for PR 16976 at commit

[GitHub] spark issue #16976: [SPARK-19610][SQL] Support parsing multiline CSV files

2017-02-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16976 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73493/ Test PASSed. ---

[GitHub] spark issue #16976: [SPARK-19610][SQL] Support parsing multiline CSV files

2017-02-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16976 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16697: [SPARK-19358][CORE] LiveListenerBus shall log the event ...

2017-02-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16697 **[Test build #73495 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73495/testReport)** for PR 16697 at commit

[GitHub] spark issue #17071: [SPARK-15615][SQL][BUILD][FOLLOW-UP] Replace deprecated ...

2017-02-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17071 **[Test build #73490 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73490/testReport)** for PR 17071 at commit

[GitHub] spark issue #17071: [SPARK-15615][SQL][BUILD][FOLLOW-UP] Replace deprecated ...

2017-02-26 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/17071 I left single usage in `JavaSaveLoadSuite`. I believe this should be fine for testing the deprecated ones. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark issue #16929: [SPARK-19595][SQL] Support json array in from_json

2017-02-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16929 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73491/ Test PASSed. ---

[GitHub] spark issue #17072: [MINOR][BUILD] Fix lint-java breaks in Java

2017-02-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17072 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17072: [MINOR][BUILD] Fix lint-java breaks in Java

2017-02-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17072 **[Test build #73486 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73486/testReport)** for PR 17072 at commit

[GitHub] spark issue #16986: [SPARK-18891][SQL] Support for Map collection types

2017-02-26 Thread michalsenkyr
Github user michalsenkyr commented on the issue: https://github.com/apache/spark/pull/16986 Added support for Java Maps with support for pre-allocation (capacity argument on constructor) and sensible defaults for interfaces/abstract classes. Also includes implicit encoders.

[GitHub] spark issue #17074: [SPARK-18646][REPL] Set parent classloader as null for E...

2017-02-26 Thread holdenk
Github user holdenk commented on the issue: https://github.com/apache/spark/pull/17074 Thanks for working on this. It's been awhile since I looked at the classloader bits so I'd need to refresh my memory a bit, but regardless this PR probably needs better tests - specifically

[GitHub] spark issue #17071: [SPARK-15615][SQL][BUILD][FOLLOW-UP] Replace deprecated ...

2017-02-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17071 **[Test build #73488 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73488/testReport)** for PR 17071 at commit

[GitHub] spark issue #17071: [SPARK-15615][SQL][BUILD][FOLLOW-UP] Replace deprecated ...

2017-02-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17071 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73488/ Test PASSed. ---

[GitHub] spark issue #17071: [SPARK-15615][SQL][BUILD][FOLLOW-UP] Replace deprecated ...

2017-02-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17071 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16929: [SPARK-19595][SQL] Support json array in from_json

2017-02-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16929 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16929: [SPARK-19595][SQL] Support json array in from_json

2017-02-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16929 **[Test build #73491 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73491/testReport)** for PR 16929 at commit

[GitHub] spark issue #16987: [SPARK-19633][SS] FileSource read from FileSink

2017-02-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16987 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73492/ Test PASSed. ---

[GitHub] spark issue #16987: [SPARK-19633][SS] FileSource read from FileSink

2017-02-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16987 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17067: [SPARK-19602][SQL][TESTS] Add tests for qualified column...

2017-02-26 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17067 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #17070: [SPARK-19721][SS] Good error message for version mismatc...

2017-02-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17070 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73487/ Test PASSed. ---

[GitHub] spark issue #17070: [SPARK-19721][SS] Good error message for version mismatc...

2017-02-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17070 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17071: [SPARK-15615][SQL][BUILD][FOLLOW-UP] Replace deprecated ...

2017-02-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17071 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73490/ Test FAILed. ---

[GitHub] spark issue #16987: [SPARK-19633][SS] FileSource read from FileSink

2017-02-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16987 **[Test build #73492 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73492/testReport)** for PR 16987 at commit

[GitHub] spark issue #17071: [SPARK-15615][SQL][BUILD][FOLLOW-UP] Replace deprecated ...

2017-02-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17071 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73489/ Test PASSed. ---

[GitHub] spark issue #17072: [MINOR][BUILD] Fix lint-java breaks in Java

2017-02-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17072 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73485/ Test PASSed. ---

[GitHub] spark issue #17074: [SPARK-18646][REPL] Set parent classloader as null for E...

2017-02-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17074 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #17074: [SPARK-18646][REPL] Set parent classloader as nul...

2017-02-26 Thread taroplus
GitHub user taroplus opened a pull request: https://github.com/apache/spark/pull/17074 [SPARK-18646][REPL] Set parent classloader as null for ExecutorClassLoader ## What changes were proposed in this pull request? By default, a class loader will have java's system class

[GitHub] spark issue #17072: [MINOR][BUILD] Fix lint-java breaks in Java

2017-02-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17072 **[Test build #73485 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73485/testReport)** for PR 17072 at commit

[GitHub] spark issue #17071: [SPARK-15615][SQL][BUILD][FOLLOW-UP] Replace deprecated ...

2017-02-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17071 **[Test build #73483 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73483/testReport)** for PR 17071 at commit

[GitHub] spark issue #17072: [MINOR][BUILD] Fix lint-java breaks in Java

2017-02-26 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/17072 Thank you, yes just last night I put together some changes to fix this too, because I added some problems when I changed to Java 8 syntax. Maybe you can apply

[GitHub] spark pull request #17072: [MINOR][BUILD] Fix lint-java breaks in Java

2017-02-26 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/17072#discussion_r103099295 --- Diff: core/src/main/java/org/apache/spark/SparkFirehoseListener.java --- @@ -34,12 +34,12 @@ public void onEvent(SparkListenerEvent event) { }

[GitHub] spark issue #17072: [MINOR][BUILD] Fix lint-java breaks in Java

2017-02-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17072 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73482/ Test PASSed. ---

[GitHub] spark issue #17072: [MINOR][BUILD] Fix lint-java breaks in Java

2017-02-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17072 **[Test build #73482 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73482/testReport)** for PR 17072 at commit

[GitHub] spark issue #17072: [MINOR][BUILD] Fix lint-java breaks in Java

2017-02-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17072 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17071: [SPARK-15615][SQL][BUILD][FOLLOW-UP] Replace deprecated ...

2017-02-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17071 **[Test build #73489 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73489/testReport)** for PR 17071 at commit

[GitHub] spark issue #17070: [WIP][SS] Good error message for version mismatch in log...

2017-02-26 Thread lw-lin
Github user lw-lin commented on the issue: https://github.com/apache/spark/pull/17070 @srowen thank you for the comments! I was trying to tackle SPARK-19721, sorry the summary just said "WIP" without a JIRA number; adding JIRA number back. --- If your project is set up for it, you

[GitHub] spark issue #17071: [SPARK-15615][SQL][BUILD][FOLLOW-UP] Replace deprecated ...

2017-02-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17071 **[Test build #73488 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73488/testReport)** for PR 17071 at commit

[GitHub] spark issue #17067: [SPARK-19602][SQL][TESTS] Add tests for qualified column...

2017-02-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17067 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17067: [SPARK-19602][SQL][TESTS] Add tests for qualified column...

2017-02-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17067 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73479/ Test FAILed. ---

[GitHub] spark issue #17072: [WIP][MINOR][BUILD] Fix lint-java breaks in Java

2017-02-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17072 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73481/ Test FAILed. ---

[GitHub] spark issue #17072: [WIP][MINOR][BUILD] Fix lint-java breaks in Java

2017-02-26 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/17072 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #17072: [WIP][MINOR][BUILD] Fix lint-java breaks in Java

2017-02-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17072 **[Test build #73482 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73482/testReport)** for PR 17072 at commit

[GitHub] spark issue #17072: [WIP][MINOR][BUILD] Fix lint-java breaks in Java

2017-02-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17072 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17073: [SPARK-5984]Add notes and fix puzzling notes

2017-02-26 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/17073 OK, but you're un-documenting an invariant that is still supposed to be true. Your new invariant is the same as the first too. --- If your project is set up for it, you can reply to this email and

[GitHub] spark pull request #17070: [WIP][SS] Good error message for version mismatch...

2017-02-26 Thread lw-lin
Github user lw-lin commented on a diff in the pull request: https://github.com/apache/spark/pull/17070#discussion_r103102422 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/HDFSMetadataLog.scala --- @@ -268,6 +274,37 @@ class HDFSMetadataLog[T <: AnyRef

[GitHub] spark pull request #17070: [WIP][SS] Good error message for version mismatch...

2017-02-26 Thread lw-lin
Github user lw-lin commented on a diff in the pull request: https://github.com/apache/spark/pull/17070#discussion_r103102416 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/HDFSMetadataLog.scala --- @@ -18,6 +18,7 @@ package

[GitHub] spark pull request #17070: [WIP][SS] Good error message for version mismatch...

2017-02-26 Thread lw-lin
Github user lw-lin commented on a diff in the pull request: https://github.com/apache/spark/pull/17070#discussion_r103102420 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/HDFSMetadataLog.scala --- @@ -268,6 +274,37 @@ class HDFSMetadataLog[T <: AnyRef

[GitHub] spark pull request #17070: [WIP][SS] Good error message for version mismatch...

2017-02-26 Thread lw-lin
Github user lw-lin commented on a diff in the pull request: https://github.com/apache/spark/pull/17070#discussion_r103102394 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSource.scala --- @@ -100,7 +100,8 @@ private[kafka010] class

[GitHub] spark pull request #17070: [WIP][SS] Good error message for version mismatch...

2017-02-26 Thread lw-lin
Github user lw-lin commented on a diff in the pull request: https://github.com/apache/spark/pull/17070#discussion_r103102389 --- Diff: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSourceSuite.scala --- @@ -226,7 +226,15 @@ class KafkaSourceSuite

[GitHub] spark issue #17072: [MINOR][BUILD] Fix lint-java breaks in Java

2017-02-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17072 **[Test build #73486 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73486/testReport)** for PR 17072 at commit

[GitHub] spark pull request #17070: [WIP][SS] Good error message for version mismatch...

2017-02-26 Thread lw-lin
Github user lw-lin commented on a diff in the pull request: https://github.com/apache/spark/pull/17070#discussion_r103102481 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/HDFSMetadataLog.scala --- @@ -195,6 +196,11 @@ class HDFSMetadataLog[T <: AnyRef

[GitHub] spark issue #17070: [WIP][SS] Good error message for version mismatch in log...

2017-02-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17070 **[Test build #73487 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73487/testReport)** for PR 17070 at commit

[GitHub] spark pull request #17072: [MINOR][BUILD] Fix lint-java breaks in Java

2017-02-26 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/17072#discussion_r103099508 --- Diff: core/src/main/java/org/apache/spark/SparkFirehoseListener.java --- @@ -34,12 +34,12 @@ public void onEvent(SparkListenerEvent event) { }

[GitHub] spark issue #17073: [SPARK-5984]Add notes and fix puzzling notes

2017-02-26 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/17073 This has no explanation. This is also copied from the Android OSS project, so I don't think I'd change the comments without reason. It'd be easier to update later if needed --- If your project is

[GitHub] spark issue #17073: [SPARK-5984]Add notes and fix puzzling notes

2017-02-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17073 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #17073: [SPARK-5984]Add notes and fix puzzling notes

2017-02-26 Thread xiaoyesoso
Github user xiaoyesoso commented on the issue: https://github.com/apache/spark/pull/17073 @srowen The explanations are for TimSort from Android OSS。The code has bug ([see

[GitHub] spark issue #17071: [SPARK-15615][SQL][BUILD][FOLLOW-UP] Replace deprecated ...

2017-02-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17071 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73484/ Test PASSed. ---

[GitHub] spark issue #17071: [SPARK-15615][SQL][BUILD][FOLLOW-UP] Replace deprecated ...

2017-02-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17071 **[Test build #73484 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73484/testReport)** for PR 17071 at commit

[GitHub] spark issue #17071: [SPARK-15615][SQL][BUILD][FOLLOW-UP] Replace deprecated ...

2017-02-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17071 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17071: [SPARK-15615][SQL][BUILD][FOLLOW-UP] Replace deprecated ...

2017-02-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17071 **[Test build #73484 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73484/testReport)** for PR 17071 at commit

[GitHub] spark issue #17071: [SPARK-15615][SQL][BUILD][FOLLOW-UP] Replace deprecated ...

2017-02-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17071 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73483/ Test PASSed. ---

[GitHub] spark pull request #17070: [WIP][SS] Good error message for version mismatch...

2017-02-26 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/17070#discussion_r103098803 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/HDFSMetadataLog.scala --- @@ -18,6 +18,7 @@ package

[GitHub] spark pull request #17070: [WIP][SS] Good error message for version mismatch...

2017-02-26 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/17070#discussion_r103098815 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/HDFSMetadataLog.scala --- @@ -268,6 +274,37 @@ class HDFSMetadataLog[T <: AnyRef

[GitHub] spark issue #17070: [WIP][SS] Good error message for version mismatch in log...

2017-02-26 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/17070 This is changing a lot of stuff to barely improve an error, and the PR has problems. I don't think this is worthwhile --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request #17070: [WIP][SS] Good error message for version mismatch...

2017-02-26 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/17070#discussion_r103098735 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSource.scala --- @@ -100,7 +100,8 @@ private[kafka010] class

[GitHub] spark pull request #17070: [WIP][SS] Good error message for version mismatch...

2017-02-26 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/17070#discussion_r103098721 --- Diff: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSourceSuite.scala --- @@ -226,7 +226,15 @@ class KafkaSourceSuite

[GitHub] spark pull request #17070: [WIP][SS] Good error message for version mismatch...

2017-02-26 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/17070#discussion_r103098789 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/HDFSMetadataLog.scala --- @@ -195,6 +196,11 @@ class HDFSMetadataLog[T <: AnyRef

[GitHub] spark pull request #17070: [WIP][SS] Good error message for version mismatch...

2017-02-26 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/17070#discussion_r103098816 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/HDFSMetadataLog.scala --- @@ -268,6 +274,37 @@ class HDFSMetadataLog[T <: AnyRef

[GitHub] spark pull request #17072: [MINOR][BUILD] Fix lint-java breaks in Java

2017-02-26 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/17072#discussion_r103099256 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java --- @@ -153,7 +153,7 @@ public void writeTo(ByteBuffer buffer) {

[GitHub] spark pull request #17073: [SPARK-5984]Add notes and fix puzzling notes

2017-02-26 Thread xiaoyesoso
GitHub user xiaoyesoso opened a pull request: https://github.com/apache/spark/pull/17073 [SPARK-5984]Add notes and fix puzzling notes ## What changes were proposed in this pull request? Notes ## How was this patch tested? (Please explain how this patch was

[GitHub] spark issue #17071: [SPARK-15615][SQL][BUILD][FOLLOW-UP] Replace deprecated ...

2017-02-26 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/17071 Oh, no. I think I updated all instances. Let me maybe leave one case in `JsonSuite`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark issue #17071: [SPARK-15615][SQL][BUILD][FOLLOW-UP] Replace deprecated ...

2017-02-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17071 **[Test build #73483 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73483/testReport)** for PR 17071 at commit

[GitHub] spark issue #17071: [SPARK-15615][SQL][BUILD][FOLLOW-UP] Replace deprecated ...

2017-02-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17071 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17059: [SPARK-19733][ML]Removed unnecessary castings and refact...

2017-02-26 Thread datumbox
Github user datumbox commented on the issue: https://github.com/apache/spark/pull/17059 I decided to provide a few more bencharks in order to alleviate some of the concerns raised by @srowen. To reproduce the results add the following snippet in the ALSSuite class:

[GitHub] spark issue #17067: [SPARK-19602][SQL][TESTS] Add tests for qualified column...

2017-02-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17067 **[Test build #73494 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73494/testReport)** for PR 17067 at commit

[GitHub] spark issue #16991: [SPARK-19594][Structured Streaming] StreamingQueryListen...

2017-02-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16991 **[Test build #73496 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73496/testReport)** for PR 16991 at commit

[GitHub] spark issue #16991: [SPARK-19594][Structured Streaming] StreamingQueryListen...

2017-02-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16991 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73496/ Test PASSed. ---

[GitHub] spark issue #16991: [SPARK-19594][Structured Streaming] StreamingQueryListen...

2017-02-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16991 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16991: [SPARK-19594][Structured Streaming] StreamingQueryListen...

2017-02-26 Thread zsxwing
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/16991 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] spark issue #16782: [SPARK-19348][PYTHON][WIP] PySpark keyword_only decorato...

2017-02-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16782 **[Test build #3586 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3586/testReport)** for PR 16782 at commit

[GitHub] spark issue #16944: [SPARK-19611][SQL] Introduce configurable table schema i...

2017-02-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16944 **[Test build #73497 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73497/testReport)** for PR 16944 at commit

[GitHub] spark issue #16944: [SPARK-19611][SQL] Introduce configurable table schema i...

2017-02-26 Thread budde
Github user budde commented on the issue: https://github.com/apache/spark/pull/16944 Thanks for the thorough feedback. In the latest update I refactored ```convertToLogicalRelation()``` to update the schema of the ```catalogTable``` field of the value it returns whenever a

[GitHub] spark issue #17060: [SQL] Duplicate test exception in SQLQueryTestSuite due ...

2017-02-26 Thread dilipbiswal
Github user dilipbiswal commented on the issue: https://github.com/apache/spark/pull/17060 Thank you @srowen @gatorsmile --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

  1   2   >