[GitHub] spark issue #19196: [SPARK-21977] SinglePartition optimizations break certai...

2017-09-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19196 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81657/ Test FAILed. ---

[GitHub] spark issue #19196: [SPARK-21977] SinglePartition optimizations break certai...

2017-09-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19196 **[Test build #81657 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81657/testReport)** for PR 19196 at commit

[GitHub] spark issue #19196: [SPARK-21977] SinglePartition optimizations break certai...

2017-09-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19196 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19186: [SPARK-21972][ML] Add param handlePersistence

2017-09-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19186 **[Test build #81651 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81651/testReport)** for PR 19186 at commit

[GitHub] spark pull request #19136: [SPARK-15689][SQL] data source v2

2017-09-12 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19136#discussion_r138258962 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/upward/StatisticsSupport.java --- @@ -0,0 +1,26 @@ +/* + * Licensed to

[GitHub] spark pull request #19136: [SPARK-15689][SQL] data source v2

2017-09-12 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19136#discussion_r138255263 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/downward/CatalystFilterPushDownSupport.java --- @@ -0,0 +1,36 @@ +/* +

[GitHub] spark pull request #19136: [SPARK-15689][SQL] data source v2

2017-09-12 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19136#discussion_r138254904 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/ReadTask.java --- @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #19199: [SPARK-21610][SQL][FOLLOWUP] Corrupt records are ...

2017-09-12 Thread jmchung
GitHub user jmchung opened a pull request: https://github.com/apache/spark/pull/19199 [SPARK-21610][SQL][FOLLOWUP] Corrupt records are not handled properly when creating a dataframe from a file ## What changes were proposed in this pull request? When the `requiredSchema`

[GitHub] spark pull request #19199: [SPARK-21610][SQL][FOLLOWUP] Corrupt records are ...

2017-09-12 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19199#discussion_r138271989 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVFileFormat.scala --- @@ -109,6 +109,20 @@ class CSVFileFormat extends

[GitHub] spark pull request #19136: [SPARK-15689][SQL] data source v2

2017-09-12 Thread j-baker
Github user j-baker commented on a diff in the pull request: https://github.com/apache/spark/pull/19136#discussion_r138281654 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Strategy.scala --- @@ -0,0 +1,95 @@ +/* + * Licensed

[GitHub] spark pull request #19136: [SPARK-15689][SQL] data source v2

2017-09-12 Thread j-baker
Github user j-baker commented on a diff in the pull request: https://github.com/apache/spark/pull/19136#discussion_r138282764 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/downward/CatalystFilterPushDownSupport.java --- @@ -0,0 +1,36 @@ +/* + *

[GitHub] spark pull request #19136: [SPARK-15689][SQL] data source v2

2017-09-12 Thread j-baker
Github user j-baker commented on a diff in the pull request: https://github.com/apache/spark/pull/19136#discussion_r138287456 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/upward/Statistics.java --- @@ -0,0 +1,28 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #19201: [SPARK-21979][SQL]Improve QueryPlanConstraints fr...

2017-09-12 Thread gengliangwang
GitHub user gengliangwang opened a pull request: https://github.com/apache/spark/pull/19201 [SPARK-21979][SQL]Improve QueryPlanConstraints framework ## What changes were proposed in this pull request? Improve QueryPlanConstraints framework, make it robust and simple. In

[GitHub] spark issue #19200: Get default Locale

2017-09-12 Thread Gschiavon
Github user Gschiavon commented on the issue: https://github.com/apache/spark/pull/19200 As far as I saw there are other test cases that set default locale to US. This case is not passing when your jvm default locale value differs from "US". ---

[GitHub] spark pull request #19136: [SPARK-15689][SQL] data source v2

2017-09-12 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19136#discussion_r138255810 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/downward/FilterPushDownSupport.java --- @@ -0,0 +1,32 @@ +/* + *

[GitHub] spark pull request #19136: [SPARK-15689][SQL] data source v2

2017-09-12 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19136#discussion_r138255388 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/downward/ColumnPruningSupport.java --- @@ -0,0 +1,36 @@ +/* + *

[GitHub] spark pull request #19136: [SPARK-15689][SQL] data source v2

2017-09-12 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19136#discussion_r138255191 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/downward/CatalystFilterPushDownSupport.java --- @@ -0,0 +1,36 @@ +/* +

[GitHub] spark pull request #19136: [SPARK-15689][SQL] data source v2

2017-09-12 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19136#discussion_r138253590 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/DataSourceV2Reader.java --- @@ -0,0 +1,58 @@ +/* + * Licensed to the

[GitHub] spark pull request #19136: [SPARK-15689][SQL] data source v2

2017-09-12 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19136#discussion_r138252631 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/DataReader.java --- @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #19136: [SPARK-15689][SQL] data source v2

2017-09-12 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19136#discussion_r138254795 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/ReadTask.java --- @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #19136: [SPARK-15689][SQL] data source v2

2017-09-12 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19136#discussion_r138255522 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/downward/ColumnPruningSupport.java --- @@ -0,0 +1,36 @@ +/* + *

[GitHub] spark pull request #19136: [SPARK-15689][SQL] data source v2

2017-09-12 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19136#discussion_r138254894 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/ReadTask.java --- @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #19136: [SPARK-15689][SQL] data source v2

2017-09-12 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19136#discussion_r138254289 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/DataSourceV2Reader.java --- @@ -0,0 +1,58 @@ +/* + * Licensed to the

[GitHub] spark pull request #19136: [SPARK-15689][SQL] data source v2

2017-09-12 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19136#discussion_r138253471 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/DataSourceV2Reader.java --- @@ -0,0 +1,58 @@ +/* + * Licensed to the

[GitHub] spark pull request #19136: [SPARK-15689][SQL] data source v2

2017-09-12 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19136#discussion_r138254192 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/DataSourceV2Reader.java --- @@ -0,0 +1,58 @@ +/* + * Licensed to the

[GitHub] spark pull request #19136: [SPARK-15689][SQL] data source v2

2017-09-12 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19136#discussion_r138254426 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/DataSourceV2Reader.java --- @@ -0,0 +1,58 @@ +/* + * Licensed to the

[GitHub] spark issue #19118: [SPARK-21882][CORE] OutputMetrics doesn't count written ...

2017-09-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19118 **[Test build #81662 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81662/testReport)** for PR 19118 at commit

[GitHub] spark issue #19118: [SPARK-21882][CORE] OutputMetrics doesn't count written ...

2017-09-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19118 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19199: [SPARK-21610][SQL][FOLLOWUP] Corrupt records are not han...

2017-09-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19199 **[Test build #81661 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81661/testReport)** for PR 19199 at commit

[GitHub] spark issue #19118: [SPARK-21882][CORE] OutputMetrics doesn't count written ...

2017-09-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19118 **[Test build #81662 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81662/testReport)** for PR 19118 at commit

[GitHub] spark issue #19198: [MINOR][DOC] Add missing call of `update()` in examples ...

2017-09-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19198 **[Test build #81659 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81659/testReport)** for PR 19198 at commit

[GitHub] spark issue #16422: [SPARK-17642] [SQL] support DESC EXTENDED/FORMATTED tabl...

2017-09-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16422 **[Test build #81655 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81655/testReport)** for PR 16422 at commit

[GitHub] spark issue #19068: [SPARK-21428][SQL][FOLLOWUP]CliSessionState should point...

2017-09-12 Thread yaooqinn
Github user yaooqinn commented on the issue: https://github.com/apache/spark/pull/19068 cc @cloud-fan @jiangxb1987 @gatorsmile pr title and descriptions updated --- - To unsubscribe, e-mail:

[GitHub] spark pull request #19199: [SPARK-21610][SQL][FOLLOWUP] Corrupt records are ...

2017-09-12 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19199#discussion_r138272395 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVFileFormat.scala --- @@ -109,6 +109,20 @@ class CSVFileFormat extends

[GitHub] spark issue #19197: [SPARK-18608][ML] Fix double caching

2017-09-12 Thread zhengruifeng
Github user zhengruifeng commented on the issue: https://github.com/apache/spark/pull/19197 ping @jkbradley @WeichenXu123 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #18538: [SPARK-14516][ML] Adding ClusteringEvaluator with the im...

2017-09-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18538 **[Test build #81666 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81666/testReport)** for PR 18538 at commit

[GitHub] spark issue #19190: [SPARK-21976][DOC] Fix wrong documentation for Mean Abso...

2017-09-12 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/19190 Merged to master/2.2/2.1 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19199: [SPARK-21610][SQL][FOLLOWUP] Corrupt records are not han...

2017-09-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19199 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81661/ Test PASSed. ---

[GitHub] spark issue #19199: [SPARK-21610][SQL][FOLLOWUP] Corrupt records are not han...

2017-09-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19199 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19202: [SPARK-21980][SQL]References in grouping functions shoul...

2017-09-12 Thread DonnyZone
Github user DonnyZone commented on the issue: https://github.com/apache/spark/pull/19202 ping @cloud-fan @gatorsmile --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #19185: [Spark-21854] Added LogisticRegressionTrainingSummary fo...

2017-09-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19185 **[Test build #81660 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81660/testReport)** for PR 19185 at commit

[GitHub] spark issue #19198: [MINOR][DOC] Add missing call of `update()` in examples ...

2017-09-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19198 **[Test build #81659 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81659/testReport)** for PR 19198 at commit

[GitHub] spark pull request #19141: [SPARK-21384] [YARN] Spark + YARN fails with Loca...

2017-09-12 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/19141#discussion_r138262309 --- Diff: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala --- @@ -565,7 +565,6 @@ private[spark] class Client(

[GitHub] spark issue #19185: [Spark-21854] Added LogisticRegressionTrainingSummary fo...

2017-09-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19185 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81660/ Test FAILed. ---

[GitHub] spark issue #19198: [MINOR][DOC] Add missing call of `update()` in examples ...

2017-09-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19198 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81659/ Test FAILed. ---

[GitHub] spark issue #19118: [SPARK-21882][CORE] OutputMetrics doesn't count written ...

2017-09-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19118 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81662/ Test FAILed. ---

[GitHub] spark issue #19130: [SPARK-21917][CORE][YARN] Supporting adding http(s) reso...

2017-09-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19130 **[Test build #81658 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81658/testReport)** for PR 19130 at commit

[GitHub] spark issue #19185: [Spark-21854] Added LogisticRegressionTrainingSummary fo...

2017-09-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19185 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19198: [MINOR][DOC] Add missing call of `update()` in examples ...

2017-09-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19198 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19130: [SPARK-21917][CORE][YARN] Supporting adding http(s) reso...

2017-09-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19130 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #16422: [SPARK-17642] [SQL] support DESC EXTENDED/FORMATTED tabl...

2017-09-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16422 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #16422: [SPARK-17642] [SQL] support DESC EXTENDED/FORMATTED tabl...

2017-09-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16422 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81655/ Test FAILed. ---

[GitHub] spark issue #19185: [Spark-21854] Added LogisticRegressionTrainingSummary fo...

2017-09-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19185 **[Test build #81660 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81660/testReport)** for PR 19185 at commit

[GitHub] spark issue #19130: [SPARK-21917][CORE][YARN] Supporting adding http(s) reso...

2017-09-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19130 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81658/ Test FAILed. ---

[GitHub] spark pull request #19199: [SPARK-21610][SQL][FOLLOWUP] Corrupt records are ...

2017-09-12 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19199#discussion_r138268612 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVFileFormat.scala --- @@ -109,6 +109,20 @@ class CSVFileFormat extends

[GitHub] spark issue #19130: [SPARK-21917][CORE][YARN] Supporting adding http(s) reso...

2017-09-12 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19130 Jenkins, retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #19191: [SPARK-21958][ML] Word2VecModel save: transform data in ...

2017-09-12 Thread MLnick
Github user MLnick commented on the issue: https://github.com/apache/spark/pull/19191 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #19136: [SPARK-15689][SQL] data source v2

2017-09-12 Thread j-baker
Github user j-baker commented on a diff in the pull request: https://github.com/apache/spark/pull/19136#discussion_r138286323 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Strategy.scala --- @@ -0,0 +1,95 @@ +/* + * Licensed

[GitHub] spark pull request #19136: [SPARK-15689][SQL] data source v2

2017-09-12 Thread j-baker
Github user j-baker commented on a diff in the pull request: https://github.com/apache/spark/pull/19136#discussion_r138289364 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/ReadTask.java --- @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software

[GitHub] spark issue #18538: [SPARK-14516][ML] Adding ClusteringEvaluator with the im...

2017-09-12 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/18538 @yanboliang I addressed them. Thank you very much for your time, help and your great reviews. --- - To unsubscribe, e-mail:

[GitHub] spark issue #19191: [SPARK-21958][ML] Word2VecModel save: transform data in ...

2017-09-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19191 **[Test build #81667 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81667/testReport)** for PR 19191 at commit

[GitHub] spark issue #19191: [SPARK-21958][ML] Word2VecModel save: transform data in ...

2017-09-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19191 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19182: [SPARK-21970][Core] Fix Redundant Throws Declarations in...

2017-09-12 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/19182 Ah OK one more subtle thing @original-brownbear -- the code you see in org/apache/hive packages is, I believe, copied from Hive. Therefore it's probably best to leave it as-is because it makes it

[GitHub] spark pull request #19118: [SPARK-21882][CORE] OutputMetrics doesn't count w...

2017-09-12 Thread awarrior
Github user awarrior commented on a diff in the pull request: https://github.com/apache/spark/pull/19118#discussion_r138263099 --- Diff: core/src/main/scala/org/apache/spark/internal/io/SparkHadoopWriter.scala --- @@ -112,11 +112,12 @@ object SparkHadoopWriter extends Logging {

[GitHub] spark issue #19199: [SPARK-21610][SQL][FOLLOWUP] Corrupt records are not han...

2017-09-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19199 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #19199: [SPARK-21610][SQL][FOLLOWUP] Corrupt records are ...

2017-09-12 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19199#discussion_r138272202 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVFileFormat.scala --- @@ -109,6 +109,20 @@ class CSVFileFormat extends

[GitHub] spark issue #19199: [SPARK-21610][SQL][FOLLOWUP] Corrupt records are not han...

2017-09-12 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/19199 Two minor comments. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19191: [SPARK-21958][ML] Word2VecModel save: transform data in ...

2017-09-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19191 **[Test build #81667 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81667/testReport)** for PR 19191 at commit

[GitHub] spark issue #19200: Get default Locale

2017-09-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19200 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #19136: [SPARK-15689][SQL] data source v2

2017-09-12 Thread j-baker
Github user j-baker commented on a diff in the pull request: https://github.com/apache/spark/pull/19136#discussion_r138291926 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/upward/Statistics.java --- @@ -0,0 +1,28 @@ +/* + * Licensed to the Apache

[GitHub] spark issue #19191: [SPARK-21958][ML] Word2VecModel save: transform data in ...

2017-09-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19191 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81667/ Test PASSed. ---

[GitHub] spark issue #19185: [Spark-21854] Added LogisticRegressionTrainingSummary fo...

2017-09-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19185 **[Test build #81669 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81669/testReport)** for PR 19185 at commit

[GitHub] spark issue #19186: [SPARK-21972][ML] Add param handlePersistence

2017-09-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19186 **[Test build #81650 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81650/testReport)** for PR 19186 at commit

[GitHub] spark issue #19130: [SPARK-21917][CORE][YARN] Supporting adding http(s) reso...

2017-09-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19130 **[Test build #81658 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81658/testReport)** for PR 19130 at commit

[GitHub] spark pull request #19198: [MINOR][DOC] Add missing call of `update()` in ex...

2017-09-12 Thread zhengruifeng
GitHub user zhengruifeng opened a pull request: https://github.com/apache/spark/pull/19198 [MINOR][DOC] Add missing call of `update()` in examples of PeriodicGraphCheckpointer & PeriodicRDDCheckpointer ## What changes were proposed in this pull request? forgot to call

[GitHub] spark issue #19186: [SPARK-21972][ML] Add param handlePersistence

2017-09-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19186 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81651/ Test PASSed. ---

[GitHub] spark issue #19186: [SPARK-21972][ML] Add param handlePersistence

2017-09-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19186 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19199: [SPARK-21610][SQL][FOLLOWUP] Corrupt records are not han...

2017-09-12 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19199 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19199: [SPARK-21610][SQL][FOLLOWUP] Corrupt records are not han...

2017-09-12 Thread jmchung
Github user jmchung commented on the issue: https://github.com/apache/spark/pull/19199 cc @gatorsmile, @HyukjinKwon and @viirya. Could you guys help to review this? Thanks. --- - To unsubscribe, e-mail:

[GitHub] spark pull request #18659: [SPARK-21190][PYSPARK][WIP] Simple Python Vectori...

2017-09-12 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18659#discussion_r138273859 --- Diff: python/pyspark/sql/functions.py --- @@ -2112,7 +2113,7 @@ def wrapper(*args): @since(1.3) -def udf(f=None,

[GitHub] spark issue #18659: [SPARK-21190][PYSPARK][WIP] Simple Python Vectorized UDF...

2017-09-12 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18659 I prefer this PR over #19147 because it's much smaller, but we do need some tests. @ueshin can you contribute your test cases to this PR? thanks! ---

[GitHub] spark issue #18538: [SPARK-14516][ML] Adding ClusteringEvaluator with the im...

2017-09-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18538 **[Test build #81666 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81666/testReport)** for PR 18538 at commit

[GitHub] spark pull request #19136: [SPARK-15689][SQL] data source v2

2017-09-12 Thread j-baker
Github user j-baker commented on a diff in the pull request: https://github.com/apache/spark/pull/19136#discussion_r138289921 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/DataSourceV2Options.java --- @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #19136: [SPARK-15689][SQL] data source v2

2017-09-12 Thread j-baker
Github user j-baker commented on a diff in the pull request: https://github.com/apache/spark/pull/19136#discussion_r138289995 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/DataSourceV2Options.java --- @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache

[GitHub] spark issue #19199: [SPARK-21610][SQL][FOLLOWUP] Corrupt records are not han...

2017-09-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19199 **[Test build #81661 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81661/testReport)** for PR 19199 at commit

[GitHub] spark issue #19185: [Spark-21854] Added LogisticRegressionTrainingSummary fo...

2017-09-12 Thread yanboliang
Github user yanboliang commented on the issue: https://github.com/apache/spark/pull/19185 Jenkins, test this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #19130: [SPARK-21917][CORE][YARN] Supporting adding http(s) reso...

2017-09-12 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19130 @tgravescs , thanks for your comments, can you review again, if it is what you expected. --- - To unsubscribe, e-mail:

[GitHub] spark issue #9168: [SPARK-11182] HDFS Delegation Token will be expired when ...

2017-09-12 Thread jackiehff
Github user jackiehff commented on the issue: https://github.com/apache/spark/pull/9168 @marsishandsome, the patch file in jira HDFS-9276 has been introduced into hadoop-2.6.0-cdh5.7.3 which is our hadoop cluster version, but I still got token can't be found in cache error when I

[GitHub] spark issue #19118: [SPARK-21882][CORE] OutputMetrics doesn't count written ...

2017-09-12 Thread awarrior
Github user awarrior commented on the issue: https://github.com/apache/spark/pull/19118 @jiangxb1987 well, I passed that part above but met other initialization chances before runJob. They are in the write function of SparkHadoopWriter. > // Assert the output

[GitHub] spark issue #19198: [MINOR][DOC] Add missing call of `update()` in examples ...

2017-09-12 Thread zhengruifeng
Github user zhengruifeng commented on the issue: https://github.com/apache/spark/pull/19198 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #18659: [SPARK-21190][PYSPARK][WIP] Simple Python Vectori...

2017-09-12 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18659#discussion_r138272979 --- Diff: python/pyspark/serializers.py --- @@ -81,6 +81,12 @@ class SpecialLengths(object): NULL = -5 +class

[GitHub] spark pull request #18659: [SPARK-21190][PYSPARK][WIP] Simple Python Vectori...

2017-09-12 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18659#discussion_r138273168 --- Diff: python/pyspark/sql/functions.py --- @@ -2112,7 +2113,7 @@ def wrapper(*args): @since(1.3) -def udf(f=None,

[GitHub] spark issue #19200: Get default Locale

2017-09-12 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/19200 No, because the project is purposely not locale sensitive at this level. --- - To unsubscribe, e-mail:

[GitHub] spark pull request #19199: [SPARK-21610][SQL][FOLLOWUP] Corrupt records are ...

2017-09-12 Thread jmchung
Github user jmchung commented on a diff in the pull request: https://github.com/apache/spark/pull/19199#discussion_r138287636 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVFileFormat.scala --- @@ -109,6 +109,20 @@ class CSVFileFormat extends

[GitHub] spark issue #18902: [SPARK-21690][ML] one-pass imputer

2017-09-12 Thread zhengruifeng
Github user zhengruifeng commented on the issue: https://github.com/apache/spark/pull/18902 Any more comments on this PR? It have been about one month since the last modification. --- - To unsubscribe, e-mail:

[GitHub] spark pull request #19136: [SPARK-15689][SQL] data source v2

2017-09-12 Thread j-baker
Github user j-baker commented on a diff in the pull request: https://github.com/apache/spark/pull/19136#discussion_r138291376 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/upward/Statistics.java --- @@ -0,0 +1,28 @@ +/* + * Licensed to the Apache

[GitHub] spark issue #18538: [SPARK-14516][ML] Adding ClusteringEvaluator with the im...

2017-09-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18538 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #18538: [SPARK-14516][ML] Adding ClusteringEvaluator with the im...

2017-09-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18538 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81666/ Test PASSed. ---

[GitHub] spark pull request #19190: [SPARK-21976][DOC] Fix wrong documentation for Me...

2017-09-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19190 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19202: [SPARK-21980][SQL]References in grouping functions shoul...

2017-09-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19202 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

  1   2   3   4   5   >