[GitHub] spark pull request #19777: [SPARK-22549][SQL] Fix 64KB JVM bytecode limit pr...

2017-11-20 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19777#discussion_r151951926 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -125,19 +125,43 @@ case class

[GitHub] spark pull request #19777: [SPARK-22549][SQL] Fix 64KB JVM bytecode limit pr...

2017-11-20 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/19777#discussion_r151953946 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -125,19 +125,43 @@ case class

[GitHub] spark pull request #19781: [SPARK-22445][SQL][FOLLOW-UP] Respect children's ...

2017-11-20 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/19781#discussion_r151953815 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SortExec.scala --- @@ -124,9 +124,11 @@ case class SortExec( // Name of sorter

[GitHub] spark pull request #19778: [SPARK-22550][SQL] Fix 64KB JVM bytecode limit pr...

2017-11-20 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19778#discussion_r151955134 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -224,22 +224,55 @@ case class

[GitHub] spark pull request #19787: [SPARK-22541][SQL] Explicitly claim that Python u...

2017-11-20 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19787#discussion_r151927818 --- Diff: python/pyspark/sql/functions.py --- @@ -2205,6 +2205,10 @@ def udf(f=None, returnType=StringType()): rows that do not satisfy the

[GitHub] spark issue #10572: SPARK-12619 Combine small files in a hadoop directory in...

2017-11-20 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/10572 @jinxing64 Yup but I think I intended to say most cases within Spark datasources are covered by it. Empty files could be skipped by `spark.hadoopRDD.ignoreEmptySplits` and probably most other

[GitHub] spark issue #19786: [SPARK-22559][CORE]history server: handle exception on o...

2017-11-20 Thread gengliangwang
Github user gengliangwang commented on the issue: https://github.com/apache/spark/pull/19786 retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19773: [SPARK-22546][SQL] Supporting for changing column dataTy...

2017-11-20 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19773 **[Test build #84022 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84022/testReport)** for PR 19773 at commit

[GitHub] spark issue #19776: [SPARK-22548][SQL] Incorrect nested AND expression pushe...

2017-11-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19776 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84018/ Test FAILed. ---

[GitHub] spark issue #19607: [WIP][SPARK-22395][SQL][PYTHON] Fix the behavior of time...

2017-11-20 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19607 **[Test build #84013 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84013/testReport)** for PR 19607 at commit

[GitHub] spark issue #19607: [WIP][SPARK-22395][SQL][PYTHON] Fix the behavior of time...

2017-11-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19607 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84013/ Test FAILed. ---

[GitHub] spark issue #19786: [SPARK-22559][CORE]history server: handle exception on o...

2017-11-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19786 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19786: [SPARK-22559][CORE]history server: handle exception on o...

2017-11-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19786 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84015/ Test FAILed. ---

[GitHub] spark issue #19607: [WIP][SPARK-22395][SQL][PYTHON] Fix the behavior of time...

2017-11-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19607 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19776: [SPARK-22548][SQL] Incorrect nested AND expression pushe...

2017-11-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19776 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19776: [SPARK-22548][SQL] Incorrect nested AND expression pushe...

2017-11-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19776 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84017/ Test FAILed. ---

[GitHub] spark issue #19776: [SPARK-22548][SQL] Incorrect nested AND expression pushe...

2017-11-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19776 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19776: [SPARK-22548][SQL] Incorrect nested AND expression pushe...

2017-11-20 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19776 **[Test build #84019 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84019/testReport)** for PR 19776 at commit

[GitHub] spark pull request #19776: [SPARK-22548][SQL] Incorrect nested AND expressio...

2017-11-20 Thread jliwork
Github user jliwork commented on a diff in the pull request: https://github.com/apache/spark/pull/19776#discussion_r151922970 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala --- @@ -497,7 +497,11 @@ object DataSourceStrategy {

[GitHub] spark pull request #19781: [SPARK-22445][SQL][FOLLOW-UP] Respect children's ...

2017-11-20 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19781#discussion_r151924692 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SortExec.scala --- @@ -124,9 +124,11 @@ case class SortExec( // Name of sorter

[GitHub] spark pull request #19787: [SPARK-22541][SQL] Explicitly claim that Python u...

2017-11-20 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19787#discussion_r151928352 --- Diff: python/pyspark/sql/functions.py --- @@ -2205,6 +2205,10 @@ def udf(f=None, returnType=StringType()): rows that do not satisfy the

[GitHub] spark issue #19776: [SPARK-22548][SQL] Incorrect nested AND expression pushe...

2017-11-20 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19776 **[Test build #84017 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84017/testReport)** for PR 19776 at commit

[GitHub] spark pull request #19763: [SPARK-22537][core] Aggregation of map output sta...

2017-11-20 Thread gczsjdy
Github user gczsjdy commented on a diff in the pull request: https://github.com/apache/spark/pull/19763#discussion_r151921740 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -485,4 +485,13 @@ package object config { "array in the

[GitHub] spark issue #19786: [SPARK-22559][CORE]history server: handle exception on o...

2017-11-20 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19786 **[Test build #84015 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84015/testReport)** for PR 19786 at commit

[GitHub] spark issue #19776: [SPARK-22548][SQL] Incorrect nested AND expression pushe...

2017-11-20 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19776 **[Test build #84018 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84018/testReport)** for PR 19776 at commit

[GitHub] spark issue #19607: [WIP][SPARK-22395][SQL][PYTHON] Fix the behavior of time...

2017-11-20 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/19607 Jenkins, retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19607: [WIP][SPARK-22395][SQL][PYTHON] Fix the behavior of time...

2017-11-20 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19607 **[Test build #84020 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84020/testReport)** for PR 19607 at commit

[GitHub] spark issue #19786: [SPARK-22559][CORE]history server: handle exception on o...

2017-11-20 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19786 **[Test build #84021 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84021/testReport)** for PR 19786 at commit

[GitHub] spark pull request #19781: [SPARK-22445][SQL][FOLLOW-UP] Respect children's ...

2017-11-20 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19781#discussion_r151966937 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala --- @@ -83,11 +83,12 @@ case class

[GitHub] spark pull request #19781: [SPARK-22445][SQL][FOLLOW-UP] Respect children's ...

2017-11-20 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19781#discussion_r151967403 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala --- @@ -83,11 +83,12 @@ case class

[GitHub] spark pull request #19761: [SPARK-22479][SQL][BRANCH-2.2] Exclude credential...

2017-11-20 Thread onursatici
Github user onursatici closed the pull request at: https://github.com/apache/spark/pull/19761 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19607: [WIP][SPARK-22395][SQL][PYTHON] Fix the behavior of time...

2017-11-20 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19607 **[Test build #84020 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84020/testReport)** for PR 19607 at commit

[GitHub] spark issue #17436: [SPARK-20101][SQL] Use OffHeapColumnVector when "spark.m...

2017-11-20 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/17436 thanks, merging to master! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19607: [WIP][SPARK-22395][SQL][PYTHON] Fix the behavior of time...

2017-11-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19607 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84020/ Test PASSed. ---

[GitHub] spark issue #19607: [WIP][SPARK-22395][SQL][PYTHON] Fix the behavior of time...

2017-11-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19607 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #17436: [SPARK-20101][SQL] Use OffHeapColumnVector when "...

2017-11-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17436 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19760: [SPARK-22533][core] Handle deprecated names in ConfigEnt...

2017-11-20 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19760 thanks, merging to master! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #19760: [SPARK-22533][core] Handle deprecated names in Co...

2017-11-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19760 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19781: [SPARK-22445][SQL][FOLLOW-UP] Respect children's needCop...

2017-11-20 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19781 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19781: [SPARK-22445][SQL][FOLLOW-UP] Respect children's needCop...

2017-11-20 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19781 LGTM pending jenkins --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19781: [SPARK-22445][SQL][FOLLOW-UP] Respect children's needCop...

2017-11-20 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19781 BTW can we add a regression test? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #19781: [SPARK-22445][SQL][FOLLOW-UP] Respect children's needCop...

2017-11-20 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/19781 I tried though, I couldn't easily make the failed (and simple) test cases. But, I feel we should do. plz give me hours to try again. ---

[GitHub] spark pull request #19786: [SPARK-22559][CORE]history server: handle excepti...

2017-11-20 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19786#discussion_r152037332 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala --- @@ -132,15 +132,20 @@ private[history] class

[GitHub] spark issue #19789: [SPARK-22562][Streaming] CachedKafkaConsumer unsafe evic...

2017-11-20 Thread daroo
Github user daroo commented on the issue: https://github.com/apache/spark/pull/19789 Hey @koeninger , could you please have a look at my PR? Thanx a lot, Darek --- - To unsubscribe, e-mail:

[GitHub] spark issue #19778: [SPARK-22550][SQL] Fix 64KB JVM bytecode limit problem w...

2017-11-20 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19778 **[Test build #84032 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84032/testReport)** for PR 19778 at commit

[GitHub] spark pull request #19779: [SPARK-17920][SPARK-19580][SPARK-19878][SQL] Supp...

2017-11-20 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/19779#discussion_r152065236 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala --- @@ -841,6 +841,76 @@ class VersionsSuite extends

[GitHub] spark issue #19390: [SPARK-18935][MESOS] Fix dynamic reservations on mesos

2017-11-20 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19390 **[Test build #84029 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84029/testReport)** for PR 19390 at commit

[GitHub] spark issue #18982: [SPARK-21685][PYTHON][ML] PySpark Params isSet state sho...

2017-11-20 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18982 **[Test build #84035 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84035/testReport)** for PR 18982 at commit

[GitHub] spark pull request #19651: [SPARK-20682][SPARK-15474][SPARK-21791] Add new O...

2017-11-20 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19651#discussion_r152046143 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcDeserializer.scala --- @@ -0,0 +1,216 @@ +/* + * Licensed to

[GitHub] spark issue #19781: [SPARK-22445][SQL][FOLLOW-UP] Respect children's needCop...

2017-11-20 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19781 **[Test build #84028 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84028/testReport)** for PR 19781 at commit

[GitHub] spark issue #19388: [SPARK-22162] Executors and the driver should use consis...

2017-11-20 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/19388 Jenkins, retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19781: [SPARK-22445][SQL][FOLLOW-UP] Respect children's needCop...

2017-11-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19781 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19779: [SPARK-17920][SPARK-19580][SPARK-19878][SQL] Support wri...

2017-11-20 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/19779 Hi, @vinodkc . Thank you for taking a look at these issue. Since this PR contains multiple issues, could you add the followings in the PR description for reviewer and commit log? -

[GitHub] spark issue #19781: [SPARK-22445][SQL][FOLLOW-UP] Respect children's needCop...

2017-11-20 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19781 **[Test build #84026 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84026/testReport)** for PR 19781 at commit

[GitHub] spark issue #19781: [SPARK-22445][SQL][FOLLOW-UP] Respect children's needCop...

2017-11-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19781 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84025/ Test PASSed. ---

[GitHub] spark pull request #19779: [SPARK-17920][SPARK-19580][SPARK-19878][SQL] Supp...

2017-11-20 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/19779#discussion_r152064200 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala --- @@ -841,6 +841,76 @@ class VersionsSuite extends

[GitHub] spark pull request #19763: [SPARK-22537][core] Aggregation of map output sta...

2017-11-20 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19763#discussion_r152035574 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -485,4 +485,13 @@ package object config { "array in the

[GitHub] spark pull request #19786: [SPARK-22559][CORE]history server: handle excepti...

2017-11-20 Thread gengliangwang
Github user gengliangwang commented on a diff in the pull request: https://github.com/apache/spark/pull/19786#discussion_r152040491 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala --- @@ -132,15 +132,20 @@ private[history] class

[GitHub] spark pull request #19789: [SPARK-22562][Streaming] CachedKafkaConsumer unsa...

2017-11-20 Thread daroo
GitHub user daroo opened a pull request: https://github.com/apache/spark/pull/19789 [SPARK-22562][Streaming] CachedKafkaConsumer unsafe eviction from cache ## What changes were proposed in this pull request? Fixes a problem when one thread wants to add a new consumer into fully

[GitHub] spark issue #19789: [SPARK-22562][Streaming] CachedKafkaConsumer unsafe evic...

2017-11-20 Thread koeninger
Github user koeninger commented on the issue: https://github.com/apache/spark/pull/19789 My main comment is that if you have a situation where there's actually contention on the size of the cache, chances are things are going to be screwed up anyway due to consumers being recreated

[GitHub] spark pull request #19779: [SPARK-17920][SPARK-19580][SPARK-19878][SQL] Supp...

2017-11-20 Thread vinodkc
Github user vinodkc commented on a diff in the pull request: https://github.com/apache/spark/pull/19779#discussion_r152067290 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala --- @@ -841,6 +841,76 @@ class VersionsSuite extends SparkFunSuite

[GitHub] spark issue #19390: [SPARK-18935][MESOS] Fix dynamic reservations on mesos

2017-11-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19390 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84029/ Test PASSed. ---

[GitHub] spark issue #19390: [SPARK-18935][MESOS] Fix dynamic reservations on mesos

2017-11-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19390 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19350: [SPARK-22126][ML] Fix model-specific optimization suppor...

2017-11-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19350 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19350: [SPARK-22126][ML] Fix model-specific optimization suppor...

2017-11-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19350 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84023/ Test PASSed. ---

[GitHub] spark issue #19777: [SPARK-22549][SQL] Fix 64KB JVM bytecode limit problem w...

2017-11-20 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19777 **[Test build #84030 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84030/testReport)** for PR 19777 at commit

[GitHub] spark pull request #19769: [SPARK-12297][SQL] Adjust timezone for int96 data...

2017-11-20 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/19769#discussion_r152058935 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedColumnReader.java --- @@ -298,7 +304,10 @@ private void

[GitHub] spark issue #19737: [SPARK-22508][SQL] Fix 64KB JVM bytecode limit problem w...

2017-11-20 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19737 **[Test build #84031 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84031/testReport)** for PR 19737 at commit

[GitHub] spark pull request #19789: [SPARK-22562][Streaming] CachedKafkaConsumer unsa...

2017-11-20 Thread daroo
Github user daroo commented on a diff in the pull request: https://github.com/apache/spark/pull/19789#discussion_r152060617 --- Diff: external/kafka-0-10/src/main/scala/org/apache/spark/streaming/kafka010/CachedKafkaConsumer.scala --- @@ -155,11 +178,11 @@ object

[GitHub] spark issue #19781: [SPARK-22445][SQL][FOLLOW-UP] Respect children's needCop...

2017-11-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19781 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84027/ Test PASSed. ---

[GitHub] spark issue #19781: [SPARK-22445][SQL][FOLLOW-UP] Respect children's needCop...

2017-11-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19781 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19779: [SPARK-17920][SPARK-19580][SPARK-19878][SQL] Support wri...

2017-11-20 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/19779 Ping @cloud-fan and @gatorsmile . --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #19786: [SPARK-22559][CORE]history server: handle excepti...

2017-11-20 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19786#discussion_r152039449 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala --- @@ -132,15 +132,20 @@ private[history] class

[GitHub] spark issue #19781: [SPARK-22445][SQL][FOLLOW-UP] Respect children's needCop...

2017-11-20 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19781 **[Test build #84025 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84025/testReport)** for PR 19781 at commit

[GitHub] spark issue #19789: [SPARK-22562][Streaming] CachedKafkaConsumer unsafe evic...

2017-11-20 Thread daroo
Github user daroo commented on the issue: https://github.com/apache/spark/pull/19789 I see you point, but it's kind of difficult to size it properly when you use SubscribePattern (i.e. dynamic number of topics/partitions) consumer strategy ---

[GitHub] spark issue #19781: [SPARK-22445][SQL][FOLLOW-UP] Respect children's needCop...

2017-11-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19781 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19781: [SPARK-22445][SQL][FOLLOW-UP] Respect children's needCop...

2017-11-20 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19781 **[Test build #84027 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84027/testReport)** for PR 19781 at commit

[GitHub] spark issue #19781: [SPARK-22445][SQL][FOLLOW-UP] Respect children's needCop...

2017-11-20 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19781 **[Test build #84024 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84024/testReport)** for PR 19781 at commit

[GitHub] spark issue #19388: [SPARK-22162] Executors and the driver should use consis...

2017-11-20 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19388 **[Test build #84033 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84033/testReport)** for PR 19388 at commit

[GitHub] spark issue #19781: [SPARK-22445][SQL][FOLLOW-UP] Respect children's needCop...

2017-11-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19781 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84024/ Test PASSed. ---

[GitHub] spark pull request #19370: [SPARK-22495] Fix setup of SPARK_HOME variable on...

2017-11-20 Thread jsnowacki
Github user jsnowacki commented on a diff in the pull request: https://github.com/apache/spark/pull/19370#discussion_r152076566 --- Diff: bin/find-spark-home.cmd --- @@ -0,0 +1,49 @@ +@echo off + +rem +rem Licensed to the Apache Software Foundation (ASF) under one

[GitHub] spark issue #19651: [SPARK-20682][SPARK-15474][SPARK-21791] Add new ORCFileF...

2017-11-20 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19651 ping @dongjoon-hyun --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #19786: [SPARK-22559][CORE]history server: handle excepti...

2017-11-20 Thread gengliangwang
Github user gengliangwang commented on a diff in the pull request: https://github.com/apache/spark/pull/19786#discussion_r152038882 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala --- @@ -132,15 +132,20 @@ private[history] class

[GitHub] spark pull request #19769: [SPARK-12297][SQL] Adjust timezone for int96 data...

2017-11-20 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/19769#discussion_r152049670 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedColumnReader.java --- @@ -298,7 +304,10 @@ private void

[GitHub] spark issue #19468: [SPARK-18278] [Scheduler] Spark on Kubernetes - Basic Sc...

2017-11-20 Thread foxish
Github user foxish commented on the issue: https://github.com/apache/spark/pull/19468 @mridulm @vanzin @mateiz @rxin This is waiting for another LGTM I think (aside from the one by @jiangxb1987). If all parties have no major changes to suggest, may I propose we merge this before

[GitHub] spark issue #19781: [SPARK-22445][SQL][FOLLOW-UP] Respect children's needCop...

2017-11-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19781 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19781: [SPARK-22445][SQL][FOLLOW-UP] Respect children's needCop...

2017-11-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19781 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84028/ Test PASSed. ---

[GitHub] spark issue #19781: [SPARK-22445][SQL][FOLLOW-UP] Respect children's needCop...

2017-11-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19781 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84026/ Test PASSed. ---

[GitHub] spark issue #19781: [SPARK-22445][SQL][FOLLOW-UP] Respect children's needCop...

2017-11-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19781 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #19779: [SPARK-17920][SPARK-19580][SPARK-19878][SQL] Supp...

2017-11-20 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/19779#discussion_r152064637 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala --- @@ -841,6 +841,76 @@ class VersionsSuite extends

[GitHub] spark pull request #19779: [SPARK-17920][SPARK-19580][SPARK-19878][SQL] Supp...

2017-11-20 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/19779#discussion_r152064670 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala --- @@ -841,6 +841,76 @@ class VersionsSuite extends

[GitHub] spark issue #19777: [SPARK-22549][SQL] Fix 64KB JVM bytecode limit problem w...

2017-11-20 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19777 **[Test build #84034 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84034/testReport)** for PR 19777 at commit

[GitHub] spark pull request #19777: [SPARK-22549][SQL] Fix 64KB JVM bytecode limit pr...

2017-11-20 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19777#discussion_r152045624 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -163,13 +184,36 @@ case class

[GitHub] spark pull request #19769: [SPARK-12297][SQL] Adjust timezone for int96 data...

2017-11-20 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/19769#discussion_r152053946 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormat.scala --- @@ -355,17 +362,33 @@ class

[GitHub] spark pull request #19769: [SPARK-12297][SQL] Adjust timezone for int96 data...

2017-11-20 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/19769#discussion_r152055985 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetInteroperabilitySuite.scala --- @@ -87,4 +95,109 @@ class

[GitHub] spark pull request #19779: [SPARK-17920][SPARK-19580][SPARK-19878][SQL] Supp...

2017-11-20 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/19779#discussion_r152062291 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala --- @@ -841,6 +841,76 @@ class VersionsSuite extends

[GitHub] spark issue #19350: [SPARK-22126][ML] Fix model-specific optimization suppor...

2017-11-20 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19350 **[Test build #84023 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84023/testReport)** for PR 19350 at commit

[GitHub] spark pull request #19370: [SPARK-22495] Fix setup of SPARK_HOME variable on...

2017-11-20 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/19370#discussion_r152117193 --- Diff: bin/find-spark-home.cmd --- @@ -0,0 +1,56 @@ +@echo off + +rem +rem Licensed to the Apache Software Foundation (ASF) under one

[GitHub] spark issue #18982: [SPARK-21685][PYTHON][ML] PySpark Params isSet state sho...

2017-11-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18982 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84035/ Test PASSed. ---

[GitHub] spark issue #19770: [SPARK-21571][WEB UI] Spark history server leaves incomp...

2017-11-20 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19770 **[Test build #84040 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84040/testReport)** for PR 19770 at commit

  1   2   3   4   >