Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19803#discussion_r152881786
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/BoundAttribute.scala
---
@@ -60,20 +60,23 @@ case class
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19807#discussion_r152889444
--- Diff: bin/find-spark-home.cmd ---
@@ -0,0 +1,60 @@
+@echo off
+
+rem
+rem Licensed to the Apache Software Foundation (ASF) under one
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19808#discussion_r152891405
--- Diff: bin/spark-sql.cmd ---
@@ -0,0 +1,25 @@
+@echo off
+
+rem
+rem Licensed to the Apache Software Foundation (ASF) under one or
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19808#discussion_r152891440
--- Diff: bin/find-spark-home.cmd ---
@@ -32,7 +32,7 @@ if not "x%PYSPARK_PYTHON%"=="x" (
)
rem If there is python installed, trying to
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/19802
Can you please explain more, and how to reproduce this issue? Spark's RPC
is not designed for version compatible.
---
-
To
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19763#discussion_r152911829
--- Diff:
core/src/main/scala/org/apache/spark/internal/config/package.scala ---
@@ -485,4 +485,13 @@ package object config {
"array in the
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19803#discussion_r152881282
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/BoundAttribute.scala
---
@@ -60,20 +60,23 @@ case class
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19800
**[Test build #84144 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84144/testReport)**
for PR 19800 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19808
**[Test build #84147 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84147/testReport)**
for PR 19808 at commit
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19763#discussion_r152896399
--- Diff:
core/src/main/scala/org/apache/spark/internal/config/package.scala ---
@@ -485,4 +485,13 @@ package object config {
"array in the
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19788
**[Test build #84148 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84148/testReport)**
for PR 19788 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19803#discussion_r152883588
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala
---
@@ -355,19 +355,12 @@ case class FileSourceScanExec(
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19803
**[Test build #84146 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84146/testReport)**
for PR 19803 at commit
Github user gczsjdy commented on a diff in the pull request:
https://github.com/apache/spark/pull/19763#discussion_r152888380
--- Diff: core/src/main/scala/org/apache/spark/MapOutputTracker.scala ---
@@ -472,15 +475,66 @@ private[spark] class MapOutputTrackerMaster(
Github user gczsjdy commented on a diff in the pull request:
https://github.com/apache/spark/pull/19763#discussion_r152888257
--- Diff: core/src/main/scala/org/apache/spark/MapOutputTracker.scala ---
@@ -472,15 +475,66 @@ private[spark] class MapOutputTrackerMaster(
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19808
cc @cloud-fan, @felixcheung, @jsnowacki and @srowen who I could think are
probably interested in this.
---
-
To
GitHub user HyukjinKwon opened a pull request:
https://github.com/apache/spark/pull/19808
[SPARK-22597][SQL] Add spark-sql cmd script for Windows users
## What changes were proposed in this pull request?
This PR proposes to add cmd scripts so that Windows users can also run
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/19775
Do we have to put this in Spark, is it a necessary part of k8s? I think if
we pull in that PR(https://github.com/apache/spark/pull/11994), then this can
be stayed out of Spark as a package. Even
GitHub user CodingCat opened a pull request:
https://github.com/apache/spark/pull/19810
Partition level pruning 2
## What changes were proposed in this pull request?
In the current implementation of Spark, InMemoryTableExec read all data in
a cached table, filter
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19810
**[Test build #84152 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84152/testReport)**
for PR 19810 at commit
Github user gczsjdy commented on a diff in the pull request:
https://github.com/apache/spark/pull/19763#discussion_r152911325
--- Diff:
core/src/main/scala/org/apache/spark/internal/config/package.scala ---
@@ -485,4 +485,13 @@ package object config {
"array in the
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19809
**[Test build #84150 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84150/testReport)**
for PR 19809 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19809
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19809
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84150/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19803
**[Test build #84145 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84145/testReport)**
for PR 19803 at commit
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19806#discussion_r152886393
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala
---
@@ -829,7 +829,7 @@ class CastSuite extends
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19809
**[Test build #84150 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84150/testReport)**
for PR 19809 at commit
Github user vinodkc commented on the issue:
https://github.com/apache/spark/pull/19809
ping @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user gczsjdy commented on a diff in the pull request:
https://github.com/apache/spark/pull/19763#discussion_r152906960
--- Diff: core/src/main/scala/org/apache/spark/MapOutputTracker.scala ---
@@ -472,15 +475,66 @@ private[spark] class MapOutputTrackerMaster(
Github user gczsjdy commented on a diff in the pull request:
https://github.com/apache/spark/pull/19763#discussion_r152907079
--- Diff:
core/src/main/scala/org/apache/spark/internal/config/package.scala ---
@@ -485,4 +485,13 @@ package object config {
"array in the
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/19518
@mgaido91 Thank you for your questions.
1. I am using `javac` as shown. I am sorry that I cannot understand what
you are pointing out. In this benchmark, what are differences between `javac`
and
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/19788#discussion_r152891792
--- Diff: core/src/main/scala/org/apache/spark/MapOutputTracker.scala ---
@@ -812,10 +812,13 @@ private[spark] object MapOutputTracker extends
Logging {
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/19788#discussion_r152891172
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/IndexShuffleBlockResolver.scala ---
@@ -196,12 +196,14 @@ private[spark] class
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/19788#discussion_r152891438
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/IndexShuffleBlockResolver.scala ---
@@ -196,12 +196,14 @@ private[spark] class
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/19788#discussion_r152891920
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/IndexShuffleBlockResolver.scala ---
@@ -196,12 +196,14 @@ private[spark] class
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19789#discussion_r152895550
--- Diff:
external/kafka-0-10/src/main/scala/org/apache/spark/streaming/kafka010/KafkaRDD.scala
---
@@ -211,8 +211,8 @@ private[spark] class
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/19518
I like the latest @kiszk hybrid idea in terms of performance and
readability. Also, this is a corner case, so I don't want affect most regular
small queries.
---
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/19518
I created and ran another synthetic benchmark program for comparing flat
global variables, inner global variables, and array. In summary, the
followings are performance results (**small number is
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19763#discussion_r152896879
--- Diff: core/src/main/scala/org/apache/spark/MapOutputTracker.scala ---
@@ -472,15 +475,66 @@ private[spark] class MapOutputTrackerMaster(
GitHub user vinodkc opened a pull request:
https://github.com/apache/spark/pull/19809
[SPARK-17920][SQL] [FOLLOWUP] Backport PR 19779 to branch-2.2
## What changes were proposed in this pull request?
A followup of
> https://github.com/apache/spark/pull/19795
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19763#discussion_r152907606
--- Diff:
core/src/main/scala/org/apache/spark/internal/config/package.scala ---
@@ -485,4 +485,13 @@ package object config {
"array in the
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/19518
@kiszk I meant that `janinoc` creates a slightly different constant pool
from `javac`. I am not sure about performances, but the number of constant pool
entries is definitely different. For
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19803#discussion_r152883562
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala
---
@@ -56,9 +56,7 @@ case class ProjectExec(projectList:
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/19518
Based on performance results and usage of constant pool entry, I would like
to use hybrid approach with flat global variable and array.
For example, first 500 variables are stored into flat
Github user tengpeng commented on a diff in the pull request:
https://github.com/apache/spark/pull/17819#discussion_r152891005
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Bucketizer.scala
---
@@ -108,26 +164,53 @@ final class Bucketizer @Since("1.4.0")
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19803
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19803
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84146/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19803
**[Test build #84146 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84146/testReport)**
for PR 19803 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19808
**[Test build #84149 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84149/testReport)**
for PR 19808 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19810
**[Test build #84151 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84151/testReport)**
for PR 19810 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19800
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84144/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19800
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19803
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84145/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19803
**[Test build #84145 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84145/testReport)**
for PR 19803 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19803
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19803#discussion_r152899229
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -108,20 +108,22 @@ trait CodegenSupport extends
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19788
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19788
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84148/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19788
**[Test build #84148 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84148/testReport)**
for PR 19788 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19808
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19763#discussion_r152908363
--- Diff:
core/src/main/scala/org/apache/spark/internal/config/package.scala ---
@@ -485,4 +485,13 @@ package object config {
"array in the
Github user gczsjdy commented on a diff in the pull request:
https://github.com/apache/spark/pull/19763#discussion_r152912084
--- Diff:
core/src/main/scala/org/apache/spark/internal/config/package.scala ---
@@ -485,4 +485,13 @@ package object config {
"array in the
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19763#discussion_r152911936
--- Diff:
core/src/main/scala/org/apache/spark/internal/config/package.scala ---
@@ -485,4 +485,13 @@ package object config {
"array in the
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19808
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84147/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19808
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19808
**[Test build #84147 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84147/testReport)**
for PR 19808 at commit
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/19773#discussion_r152753785
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -318,16 +318,26 @@ case class AlterTableChangeColumnCommand(
Github user Gschiavon commented on the issue:
https://github.com/apache/spark/pull/19793
ping @ArtRand
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19082
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19082
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84126/
Test PASSed.
---
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19797#discussion_r152766978
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -851,9 +855,11 @@ case class Cast(child: Expression,
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19756
then can't we correctly implement `equals` for the coordinator?
---
-
To unsubscribe, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19498
gentle ping @zsxwing, @rxin, @tdas and @holdenk
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
GitHub user cloud-fan opened a pull request:
https://github.com/apache/spark/pull/19799
[SPARK-17920][followup] simplify the schema file creation in test
## What changes were proposed in this pull request?
a followup of https://github.com/apache/spark/pull/19779 , to
GitHub user viirya opened a pull request:
https://github.com/apache/spark/pull/19800
[SPARK-22591][SQL] GenerateOrdering shouldn't change
CodegenContext.INPUT_ROW
## What changes were proposed in this pull request?
When I played with codegen in developing another PR, I
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19082
**[Test build #84126 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84126/testReport)**
for PR 19082 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19799
cc @vinodkc @gatorsmile
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19518
You are comparing array vs member variables, can we compare array vs inner
class member variable? And too many classes will have overhead on the
classloader, we should test some extreme cases
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19799#discussion_r152781264
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala ---
@@ -862,17 +859,17 @@ class VersionsSuite extends
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19621
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84125/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19621
**[Test build #84125 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84125/testReport)**
for PR 19621 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19621
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19799
**[Test build #84127 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84127/testReport)**
for PR 19799 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19799
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SimonBin commented on the issue:
https://github.com/apache/spark/pull/18692
@aokolnychyi thank you for the clarification, I see now
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/19621
@viirya @MLnick Code updated. Thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19621
**[Test build #84125 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84125/testReport)**
for PR 19621 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19082
**[Test build #84126 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84126/testReport)**
for PR 19082 at commit
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19758#discussion_r152749515
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/tree/impl/TreeSplitUtilsSuite.scala ---
@@ -0,0 +1,280 @@
+/*
+ * Licensed to the Apache
Github user Aklakan commented on the issue:
https://github.com/apache/spark/pull/18692
Hi @aokolnychyi, a on note on @SimonBin 's comment (I am his colleague):
> The initial solution handled your case but then there was a decision to
restrict the proposed rule to cross joins
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/19714
cc @gatorsmile @hvanhovell
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user caneGuy commented on the issue:
https://github.com/apache/spark/pull/19764
Firstly , thanks too much @hvanhovell .
And sorry for replying so late since i have some other things to handle
during these time.
For the question, i think the ordering will not be broken.I
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19799#discussion_r152786374
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala ---
@@ -862,17 +859,17 @@ class VersionsSuite extends
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19799#discussion_r152788814
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala ---
@@ -862,17 +859,17 @@ class VersionsSuite extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19799#discussion_r152792399
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala ---
@@ -862,17 +859,17 @@ class VersionsSuite extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19800#discussion_r152798521
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
---
@@ -72,6 +72,7 @@ object
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19800#discussion_r152798443
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/OrderingSuite.scala
---
@@ -156,4 +156,13 @@ class OrderingSuite extends
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19800#discussion_r152798856
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
---
@@ -72,6 +72,7 @@ object
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19788
**[Test build #84132 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84132/testReport)**
for PR 19788 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19792
D'oh, you mean performance regression test. Manual tests should be fine.
When you share some codes you ran, maybe we can double check.
---
1 - 100 of 237 matches
Mail list logo
