[GitHub] spark pull request #20933: [SPARK-23817][SQL]Migrate ORC file format read pa...

2018-04-06 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20933#discussion_r179674548 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala --- @@ -187,6 +189,14 @@ class DataFrameReader private[sql](sparkSession: Sp

[GitHub] spark issue #20871: [SPARK-23762][SQL] UTF8StringBuffer uses MemoryBlock

2018-04-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20871 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20991: [SPARK-10399][SPARK-23879][HotFix] Fix Java lint errors

2018-04-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20991 **[Test build #88965 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88965/testReport)** for PR 20991 at commit [`25904bb`](https://github.com/apache/spark/commit/2

[GitHub] spark issue #20991: [SPARK-10399][SPARK-23879][HotFix] Fix Java lint errors

2018-04-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20991 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88965/ Test FAILed. ---

[GitHub] spark issue #20874: [SPARK-23763][SQL] OffHeapColumnVector uses MemoryBlock

2018-04-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20874 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88966/ Test FAILed. ---

[GitHub] spark issue #20991: [SPARK-10399][SPARK-23879][HotFix] Fix Java lint errors

2018-04-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20991 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20871: [SPARK-23762][SQL] UTF8StringBuffer uses MemoryBlock

2018-04-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20871 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88967/ Test FAILed. ---

[GitHub] spark issue #20874: [SPARK-23763][SQL] OffHeapColumnVector uses MemoryBlock

2018-04-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20874 **[Test build #88966 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88966/testReport)** for PR 20874 at commit [`0112d03`](https://github.com/apache/spark/commit/0

[GitHub] spark issue #20874: [SPARK-23763][SQL] OffHeapColumnVector uses MemoryBlock

2018-04-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20874 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20871: [SPARK-23762][SQL] UTF8StringBuffer uses MemoryBlock

2018-04-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20871 **[Test build #88967 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88967/testReport)** for PR 20871 at commit [`ba81497`](https://github.com/apache/spark/commit/b

[GitHub] spark issue #13599: [SPARK-13587] [PYSPARK] Support virtualenv in pyspark

2018-04-06 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/13599 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: review

[GitHub] spark issue #13599: [SPARK-13587] [PYSPARK] Support virtualenv in pyspark

2018-04-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13599 **[Test build #88968 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88968/testReport)** for PR 13599 at commit [`86484d6`](https://github.com/apache/spark/commit/86

[GitHub] spark pull request #20890: [WIP][SPARK-23779][SQL] TaskMemoryManager and Uns...

2018-04-06 Thread kiszk
Github user kiszk closed the pull request at: https://github.com/apache/spark/pull/20890 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20933: [SPARK-23817][SQL]Migrate ORC file format read pa...

2018-04-06 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20933#discussion_r179676507 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala --- @@ -368,8 +368,7 @@ case class FileSourceScanExec(

[GitHub] spark issue #13599: [SPARK-13587] [PYSPARK] Support virtualenv in pyspark

2018-04-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13599 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #13599: [SPARK-13587] [PYSPARK] Support virtualenv in pyspark

2018-04-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13599 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2025/ Tes

[GitHub] spark pull request #20992: [SPARK-23779][SQL] TaskMemoryManager and UnsafeSo...

2018-04-06 Thread kiszk
GitHub user kiszk opened a pull request: https://github.com/apache/spark/pull/20992 [SPARK-23779][SQL] TaskMemoryManager and UnsafeSorter related classes use MemoryBlock ## What changes were proposed in this pull request? This PR tries to use `MemoryBlock` in `TaskMemoryMan

[GitHub] spark issue #20874: [SPARK-23763][SQL] OffHeapColumnVector uses MemoryBlock

2018-04-06 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/20874 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...

[GitHub] spark issue #13599: [SPARK-13587] [PYSPARK] Support virtualenv in pyspark

2018-04-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13599 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #13599: [SPARK-13587] [PYSPARK] Support virtualenv in pyspark

2018-04-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13599 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88968/ Test FAILed. ---

[GitHub] spark issue #13599: [SPARK-13587] [PYSPARK] Support virtualenv in pyspark

2018-04-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13599 **[Test build #88968 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88968/testReport)** for PR 13599 at commit [`86484d6`](https://github.com/apache/spark/commit/8

[GitHub] spark issue #20992: [SPARK-23779][SQL] TaskMemoryManager and UnsafeSorter re...

2018-04-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20992 **[Test build #88969 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88969/testReport)** for PR 20992 at commit [`64c5d23`](https://github.com/apache/spark/commit/64

[GitHub] spark issue #20350: [SPARK-23179][SQL] Support option to throw exception if ...

2018-04-06 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/20350 any more comments @cloud-fan @gatorsmile @hvanhovell? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For ad

[GitHub] spark issue #20874: [SPARK-23763][SQL] OffHeapColumnVector uses MemoryBlock

2018-04-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20874 **[Test build #88971 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88971/testReport)** for PR 20874 at commit [`0112d03`](https://github.com/apache/spark/commit/01

[GitHub] spark issue #20962: [SPARK-23847][PYTHON][SQL]Add asc_nulls_first, asc_nulls...

2018-04-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20962 **[Test build #88970 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88970/testReport)** for PR 20962 at commit [`6efc544`](https://github.com/apache/spark/commit/6e

[GitHub] spark issue #20701: [SPARK-23528][ML] Add numIter to ClusteringSummary

2018-04-06 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/20701 any more comments @holdenk @sethah ? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #20992: [SPARK-23779][SQL] TaskMemoryManager and UnsafeSorter re...

2018-04-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20992 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2026/ Tes

[GitHub] spark issue #20629: [SPARK-23451][ML] Deprecate KMeans.computeCost

2018-04-06 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/20629 kindly ping @MLnick @jkbradley @hhbyyh --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional command

[GitHub] spark issue #20992: [SPARK-23779][SQL] TaskMemoryManager and UnsafeSorter re...

2018-04-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20992 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20962: [SPARK-23847][PYTHON][SQL]Add asc_nulls_first, asc_nulls...

2018-04-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20962 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20962: [SPARK-23847][PYTHON][SQL]Add asc_nulls_first, asc_nulls...

2018-04-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20962 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2027/ Tes

[GitHub] spark issue #20874: [SPARK-23763][SQL] OffHeapColumnVector uses MemoryBlock

2018-04-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20874 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20874: [SPARK-23763][SQL] OffHeapColumnVector uses MemoryBlock

2018-04-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20874 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2028/ Tes

[GitHub] spark issue #20871: [SPARK-23762][SQL] UTF8StringBuffer uses MemoryBlock

2018-04-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20871 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2029/ Tes

[GitHub] spark issue #20871: [SPARK-23762][SQL] UTF8StringBuffer uses MemoryBlock

2018-04-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20871 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20871: [SPARK-23762][SQL] UTF8StringBuffer uses MemoryBlock

2018-04-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20871 **[Test build #88972 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88972/testReport)** for PR 20871 at commit [`1d75cf3`](https://github.com/apache/spark/commit/1d

[GitHub] spark pull request #20993: [SPARK-23881][CORE][TEST] Fix flaky test JobCance...

2018-04-06 Thread jiangxb1987
GitHub user jiangxb1987 opened a pull request: https://github.com/apache/spark/pull/20993 [SPARK-23881][CORE][TEST] Fix flaky test JobCancellationSuite."interruptible iterator of shuffle reader" ## What changes were proposed in this pull request? The test case JobCancellati

[GitHub] spark issue #20993: [SPARK-23881][CORE][TEST] Fix flaky test JobCancellation...

2018-04-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20993 **[Test build #88973 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88973/testReport)** for PR 20993 at commit [`965a80f`](https://github.com/apache/spark/commit/96

[GitHub] spark issue #20993: [SPARK-23881][CORE][TEST] Fix flaky test JobCancellation...

2018-04-06 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/20993 cc @cloud-fan @advancedxy @dongjoon-hyun PTAL --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additio

[GitHub] spark pull request #20931: [SPARK-23815][Core]Spark writer dynamic partition...

2018-04-06 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20931#discussion_r179681849 --- Diff: core/src/main/scala/org/apache/spark/internal/io/HadoopMapReduceCommitProtocol.scala --- @@ -186,7 +186,9 @@ class HadoopMapReduceCommitProtoco

[GitHub] spark issue #20991: [SPARK-10399][SPARK-23879][HotFix] Fix Java lint errors

2018-04-06 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20991 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-

[GitHub] spark issue #20993: [SPARK-23881][CORE][TEST] Fix flaky test JobCancellation...

2018-04-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20993 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2030/ Tes

[GitHub] spark issue #20993: [SPARK-23881][CORE][TEST] Fix flaky test JobCancellation...

2018-04-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20993 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20991: [SPARK-10399][SPARK-23879][HotFix] Fix Java lint errors

2018-04-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20991 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2031/ Tes

[GitHub] spark issue #20991: [SPARK-10399][SPARK-23879][HotFix] Fix Java lint errors

2018-04-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20991 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20991: [SPARK-10399][SPARK-23879][HotFix] Fix Java lint errors

2018-04-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20991 **[Test build #88974 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88974/testReport)** for PR 20991 at commit [`25904bb`](https://github.com/apache/spark/commit/25

[GitHub] spark issue #20976: [SPARK-23835][SQL] Add not-null check to Tuples' argumen...

2018-04-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20976 **[Test build #88975 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88975/testReport)** for PR 20976 at commit [`03c9313`](https://github.com/apache/spark/commit/03

[GitHub] spark pull request #20994: [SPARK-21898][ML][FOLLOWUP] Fix Scala 2.12 build.

2018-04-06 Thread ueshin
GitHub user ueshin opened a pull request: https://github.com/apache/spark/pull/20994 [SPARK-21898][ML][FOLLOWUP] Fix Scala 2.12 build. ## What changes were proposed in this pull request? This is a follow-up pr of #19108 which broke Scala 2.12 build. ``` [error]

[GitHub] spark issue #20994: [SPARK-21898][ML][FOLLOWUP] Fix Scala 2.12 build.

2018-04-06 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/20994 cc @WeichenXu123 @MrBago @jkbradley --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-

[GitHub] spark pull request #15666: [SPARK-11421] [Core][Python][R] Added ability for...

2018-04-06 Thread mariusvniekerk
Github user mariusvniekerk closed the pull request at: https://github.com/apache/spark/pull/15666 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache

[GitHub] spark issue #15666: [SPARK-11421] [Core][Python][R] Added ability for addJar...

2018-04-06 Thread mariusvniekerk
Github user mariusvniekerk commented on the issue: https://github.com/apache/spark/pull/15666 This was superceded by #19643 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #20994: [SPARK-21898][ML][FOLLOWUP] Fix Scala 2.12 build.

2018-04-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20994 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20994: [SPARK-21898][ML][FOLLOWUP] Fix Scala 2.12 build.

2018-04-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20994 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2032/ Tes

[GitHub] spark issue #20994: [SPARK-21898][ML][FOLLOWUP] Fix Scala 2.12 build.

2018-04-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20994 **[Test build #88976 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88976/testReport)** for PR 20994 at commit [`6957f38`](https://github.com/apache/spark/commit/69

[GitHub] spark issue #20976: [SPARK-23835][SQL] Add not-null check to Tuples' argumen...

2018-04-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20976 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2033/ Tes

[GitHub] spark issue #20976: [SPARK-23835][SQL] Add not-null check to Tuples' argumen...

2018-04-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20976 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20991: [SPARK-10399][SPARK-23879][HotFix] Fix Java lint errors

2018-04-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20991 **[Test build #88977 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88977/testReport)** for PR 20991 at commit [`3315036`](https://github.com/apache/spark/commit/33

[GitHub] spark pull request #20906: [SPARK-23561][SS] Pull continuous processing out ...

2018-04-06 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20906#discussion_r179685434 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/writer/streaming/StreamWriter.java --- @@ -29,14 +31,15 @@ * increasing numeric ID

[GitHub] spark issue #20991: [SPARK-10399][SPARK-23879][HotFix] Fix Java lint errors

2018-04-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20991 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2034/ Tes

[GitHub] spark issue #20991: [SPARK-10399][SPARK-23879][HotFix] Fix Java lint errors

2018-04-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20991 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark pull request #20871: [SPARK-23762][SQL] UTF8StringBuffer uses MemoryBl...

2018-04-06 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20871#discussion_r179687170 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/codegen/UTF8StringBufferSuite.scala --- @@ -0,0 +1,42 @@ +/* + * Lic

[GitHub] spark pull request #20995: UTF8StringSuite.writeToOutputStreamUnderflow() is...

2018-04-06 Thread kiszk
GitHub user kiszk opened a pull request: https://github.com/apache/spark/pull/20995 UTF8StringSuite.writeToOutputStreamUnderflow() is not expected to be supported ## What changes were proposed in this pull request? This PR excludes an existing UT [`writeToOutputStreamUnder

[GitHub] spark issue #20995: [SPARK-23882][Core] UTF8StringSuite.writeToOutputStreamU...

2018-04-06 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/20995 cc @NathanHowell, @cloud-fan, @viirya --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #20995: [SPARK-23882][Core] UTF8StringSuite.writeToOutputStreamU...

2018-04-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20995 **[Test build #88978 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88978/testReport)** for PR 20995 at commit [`b47b861`](https://github.com/apache/spark/commit/b4

[GitHub] spark issue #19881: [SPARK-22683][CORE] Add a fullExecutorAllocationDivisor ...

2018-04-06 Thread jcuquemelle
Github user jcuquemelle commented on the issue: https://github.com/apache/spark/pull/19881 more aggressive must be forbidden, because the setting of 1.0 gives enough executors so that if the executor provisioning was perfect (e.g. all executors were available at the same time) and the

[GitHub] spark issue #20995: [SPARK-23882][Core] UTF8StringSuite.writeToOutputStreamU...

2018-04-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20995 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2035/ Tes

[GitHub] spark issue #20995: [SPARK-23882][Core] UTF8StringSuite.writeToOutputStreamU...

2018-04-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20995 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20995: [SPARK-23882][Core] UTF8StringSuite.writeToOutputStreamU...

2018-04-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20995 **[Test build #88978 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88978/testReport)** for PR 20995 at commit [`b47b861`](https://github.com/apache/spark/commit/b

[GitHub] spark issue #20995: [SPARK-23882][Core] UTF8StringSuite.writeToOutputStreamU...

2018-04-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20995 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88978/ Test FAILed. ---

[GitHub] spark issue #20995: [SPARK-23882][Core] UTF8StringSuite.writeToOutputStreamU...

2018-04-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20995 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20995: [SPARK-23882][Core] UTF8StringSuite.writeToOutputStreamU...

2018-04-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20995 **[Test build #88979 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88979/testReport)** for PR 20995 at commit [`04e9d5f`](https://github.com/apache/spark/commit/04

[GitHub] spark issue #20995: [SPARK-23882][Core] UTF8StringSuite.writeToOutputStreamU...

2018-04-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20995 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20995: [SPARK-23882][Core] UTF8StringSuite.writeToOutputStreamU...

2018-04-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20995 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2036/ Tes

[GitHub] spark issue #20994: [SPARK-21898][ML][FOLLOWUP] Fix Scala 2.12 build.

2018-04-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20994 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20994: [SPARK-21898][ML][FOLLOWUP] Fix Scala 2.12 build.

2018-04-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20994 **[Test build #88976 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88976/testReport)** for PR 20994 at commit [`6957f38`](https://github.com/apache/spark/commit/6

[GitHub] spark issue #20994: [SPARK-21898][ML][FOLLOWUP] Fix Scala 2.12 build.

2018-04-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20994 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88976/ Test PASSed. ---

[GitHub] spark issue #20994: [SPARK-21898][ML][FOLLOWUP] Fix Scala 2.12 build.

2018-04-06 Thread WeichenXu123
Github user WeichenXu123 commented on the issue: https://github.com/apache/spark/pull/20994 LGTM. Thanks! cc @jkbradley --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-m

[GitHub] spark issue #20980: [SPARK-23589][SQL] ExternalMapToCatalyst should support ...

2018-04-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20980 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2037/ Tes

[GitHub] spark issue #20980: [SPARK-23589][SQL] ExternalMapToCatalyst should support ...

2018-04-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20980 **[Test build #88980 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88980/testReport)** for PR 20980 at commit [`8783b2b`](https://github.com/apache/spark/commit/87

[GitHub] spark issue #20980: [SPARK-23589][SQL] ExternalMapToCatalyst should support ...

2018-04-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20980 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20923: [SPARK-23807][BUILD][WIP] Add Hadoop 3 profile with rele...

2018-04-06 Thread steveloughran
Github user steveloughran commented on the issue: https://github.com/apache/spark/pull/20923 Test failures are all in ` org.apache.spark.sql.sources.BucketedWriteWithoutHiveSupportSuite`. I don't see how these pom changes could have affected that --- ---

[GitHub] spark pull request #20979: [SPARK-23588][SQL] CatalystToExternalMap should s...

2018-04-06 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20979#discussion_r179705283 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -988,8 +988,20 @@ case class CatalystToExternal

[GitHub] spark pull request #20965: [SPARK-21870][SQL] Split aggregation code into sm...

2018-04-06 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20965#discussion_r179707996 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala --- @@ -254,6 +256,80 @@ case class HashAggregateExec(

[GitHub] spark pull request #20965: [SPARK-21870][SQL] Split aggregation code into sm...

2018-04-06 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20965#discussion_r179708034 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala --- @@ -254,6 +256,80 @@ case class HashAggregateExec(

[GitHub] spark issue #20978: [SPARK-23861][SQL][Doc] Clarify default window frame wit...

2018-04-06 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20978 retest please please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: revi

[GitHub] spark issue #20978: [SPARK-23861][SQL][Doc] Clarify default window frame wit...

2018-04-06 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20978 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: review

[GitHub] spark issue #20978: [SPARK-23861][SQL][Doc] Clarify default window frame wit...

2018-04-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20978 **[Test build #88981 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88981/testReport)** for PR 20978 at commit [`8fb7527`](https://github.com/apache/spark/commit/8f

[GitHub] spark issue #20978: [SPARK-23861][SQL][Doc] Clarify default window frame wit...

2018-04-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20978 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2038/ Tes

[GitHub] spark issue #20978: [SPARK-23861][SQL][Doc] Clarify default window frame wit...

2018-04-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20978 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark pull request #20906: [SPARK-23561][SS] Pull continuous processing out ...

2018-04-06 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20906#discussion_r179713596 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/writer/streaming/StreamWriter.java --- @@ -29,14 +31,15 @@ * increasing numeric ID

[GitHub] spark pull request #20871: [SPARK-23762][SQL] UTF8StringBuffer uses MemoryBl...

2018-04-06 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/20871#discussion_r179717061 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/codegen/UTF8StringBufferSuite.scala --- @@ -0,0 +1,42 @@ +/* + * Lice

[GitHub] spark issue #20871: [SPARK-23762][SQL] UTF8StringBuffer uses MemoryBlock

2018-04-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20871 **[Test build #88972 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88972/testReport)** for PR 20871 at commit [`1d75cf3`](https://github.com/apache/spark/commit/1

[GitHub] spark issue #20871: [SPARK-23762][SQL] UTF8StringBuffer uses MemoryBlock

2018-04-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20871 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20871: [SPARK-23762][SQL] UTF8StringBuffer uses MemoryBlock

2018-04-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20871 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88972/ Test FAILed. ---

[GitHub] spark issue #20996: [SPARK-23884][CORE] hasLaunchedTask should be true when ...

2018-04-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20996 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20996: [SPARK-23884][CORE] hasLaunchedTask should be tru...

2018-04-06 Thread Ngone51
GitHub user Ngone51 opened a pull request: https://github.com/apache/spark/pull/20996 [SPARK-23884][CORE] hasLaunchedTask should be true when launchedAnyTask be true ## What changes were proposed in this pull request? `hasLaunchedTask` should be `true` when `launchedAnyTask

[GitHub] spark issue #20996: [SPARK-23884][CORE] hasLaunchedTask should be true when ...

2018-04-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20996 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20993: [SPARK-23881][CORE][TEST] Fix flaky test JobCance...

2018-04-06 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20993#discussion_r179722604 --- Diff: core/src/test/scala/org/apache/spark/JobCancellationSuite.scala --- @@ -349,36 +350,38 @@ class JobCancellationSuite extends SparkFunSuite with

[GitHub] spark issue #20995: [SPARK-23882][Core] UTF8StringSuite.writeToOutputStreamU...

2018-04-06 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/20995 @kiszk let's just remove the test. It should have never been added in the first place. --- - To unsubscribe, e-mail: reviews-

[GitHub] spark issue #20993: [SPARK-23881][CORE][TEST] Fix flaky test JobCancellation...

2018-04-06 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20993 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apa

  1   2   3   4   >