Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23088
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99645/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23213
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23213
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99646/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23088
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23088
**[Test build #99645 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99645/testReport)**
for PR 23088 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23213
**[Test build #99646 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99646/testReport)**
for PR 23213 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/23200
Thank you @srowen and @BryanCutler
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23212
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/23196#discussion_r238495344
--- Diff: docs/sql-migration-guide-upgrade.md ---
@@ -33,6 +33,8 @@ displayTitle: Spark SQL Upgrading Guide
- Spark applications which are
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/23212
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22468#discussion_r238515227
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Projection.scala
---
@@ -166,29 +166,40 @@ object UnsafeProjection
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22911
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22911
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99630/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22911
**[Test build #99630 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99630/testReport)**
for PR 22911 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23174
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99629/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23174
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23169
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99631/
Test FAILed.
---
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22957#discussion_r238524763
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/EnsureRequirements.scala
---
@@ -145,9 +145,14 @@ case class
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23194
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23194
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22899
To be honest, we might still need to revisit it since it is still very
confusing to the developer which one they should use, top-down? or bottom-up?
The current use case for top-down is majorly
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22899
LGTM
Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23169
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99648/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23169
**[Test build #99648 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99648/testReport)**
for PR 23169 at commit
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22857#discussion_r238489445
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
---
@@ -31,14 +31,14 @@ import org.apache.spark.scheduler.{SparkListener,
Github user shahidki31 commented on a diff in the pull request:
https://github.com/apache/spark/pull/23088#discussion_r238492653
--- Diff:
core/src/test/scala/org/apache/spark/status/AppStatusStoreSuite.scala ---
@@ -77,6 +77,34 @@ class AppStatusStoreSuite extends SparkFunSuite {
Github user shahidki31 commented on a diff in the pull request:
https://github.com/apache/spark/pull/23088#discussion_r238492582
--- Diff: core/src/main/scala/org/apache/spark/status/AppStatusStore.scala
---
@@ -148,11 +148,20 @@ private[spark] class AppStatusStore(
//
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23212
**[Test build #99640 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99640/testReport)**
for PR 23212 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/23080
It's fixed in upcoming Spark. Spark 2.4 does not support it.
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23092
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99625/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23092
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22468#discussion_r238520267
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/UnsafeRowConverterSuite.scala
---
@@ -535,4 +535,100 @@ class
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23211
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23088
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23088
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99635/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23088
**[Test build #99635 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99635/testReport)**
for PR 23088 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23211
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99636/
Test PASSed.
---
Github user HeartSaVioR commented on the issue:
https://github.com/apache/spark/pull/23169
retest this, please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22468#discussion_r238534101
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/UnsafeRowConverterSuite.scala
---
@@ -535,4 +535,98 @@ class
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22899
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22899
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99642/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23194
**[Test build #99644 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99644/testReport)**
for PR 23194 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23207
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23214
**[Test build #99651 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99651/testReport)**
for PR 23214 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23207
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99643/
Test PASSed.
---
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22512#discussion_r238489997
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ---
@@ -148,12 +156,25 @@ class SQLQueryTestSuite extends QueryTest with
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23088
**[Test build #99635 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99635/testReport)**
for PR 23088 at commit
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20433
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22468#discussion_r238490121
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/InternalRow.scala ---
@@ -157,4 +157,22 @@ object InternalRow {
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23174
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99634/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23174
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user HeartSaVioR commented on the issue:
https://github.com/apache/spark/pull/22952
@zsxwing @gaborgsomogyi
What we were trying to do is enforcing archive path so that moved files
will not make overlap with source path. There may be same file name with
different directory
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23174
**[Test build #99634 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99634/testReport)**
for PR 23174 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23088
**[Test build #99645 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99645/testReport)**
for PR 23088 at commit
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/23194
LGTM except for minor comments
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/23194#discussion_r238526892
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -377,41 +377,41 @@ abstract class DDLSuite extends QueryTest
Github user shahidki31 commented on the issue:
https://github.com/apache/spark/pull/23088
Retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22468#discussion_r238533700
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/UnsafeRowConverterSuite.scala
---
@@ -535,4 +535,98 @@ class
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23212
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23169
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23092
**[Test build #99625 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99625/testReport)**
for PR 23092 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23169
**[Test build #99631 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99631/testReport)**
for PR 23169 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23174
**[Test build #99629 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99629/testReport)**
for PR 23174 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23169
Build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20433
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99638/
Test PASSed.
---
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23108#discussion_r238524452
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcSourceSuite.scala
---
@@ -186,6 +186,54 @@ abstract class
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20433
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/23171
That probably means we should just optimize InSet to have the switch
version though? Rather than do it in In?
On Mon, Dec 03, 2018 at 8:20 PM, Wenchen Fan < notificati...@github.com >
wrote:
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/23171
I thought InSwitch logically is the same as InSet, in which all the child
expressions are literals?
On Mon, Dec 03, 2018 at 8:38 PM, Wenchen Fan < notificati...@github.com >
wrote:
>
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23213
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23213
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23194
**[Test build #99649 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99649/testReport)**
for PR 23194 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/23171
How about, we create an `OptimizedIn`, and convert `In` to `OptimizedIn` if
the list is all literals? `OptimizedIn` will pick `switch` or hash set based on
the length of the list.
---
GitHub user LuciferYang opened a pull request:
https://github.com/apache/spark/pull/23214
[SPARK-26155] Optimizing the performance of LongToUnsafeRowMap
## What changes were proposed in this pull request?
To slove @JkSelf report problem at
Github user LuciferYang commented on the issue:
https://github.com/apache/spark/pull/23214
@adrian-wang ok~ I will add some comments to explain the reason
---
-
To unsubscribe, e-mail:
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22899
@gatorsmile Thanks a lot. I completely agree that we should try and combine
these two. I will continue to think about it :-)
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23088
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23088
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/23214
It's easy to track `numKeyLookups` at `HashedRelation`, but it's hard to
track `numProbes`. One idea is, we pass a `MutableInt` to
`LongToUnsafeRowMap.getValue` as a parameter, and in the method
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/23037
I thought there was already one for that Hive suite failing... SPARK-23622?
---
-
To unsubscribe, e-mail:
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22904#discussion_r238484698
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/SparkKubernetesClientFactory.scala
---
@@ -67,8 +66,16 @@
Github user AzureQ commented on the issue:
https://github.com/apache/spark/pull/23037
> ok, I give up on flaky tests.
>
> Merging to master.
Thanks!
---
-
To unsubscribe, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/23055
Last comment was a minor comment for a doc - actually the whole point was a
minor one. It does related with Windows.
---
-
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23174
Kubernetes integration test starting
URL:
https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/5691/
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23174
Kubernetes integration test status success
URL:
https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/5691/
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23174
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23174
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user pooja-murarka commented on the issue:
https://github.com/apache/spark/pull/23080
I am testing **lineSep** with spark 2.4
data.csv : "a",1 "c",2 "d",3
val schema : StructType =
StructType(
Seq(
StructField(name =
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23155
Oh, I thought it could be handled by another Kubernetes committers. I'll
take a look again.
---
-
To unsubscribe, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20433
**[Test build #99638 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99638/testReport)**
for PR 20433 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23169
**[Test build #99648 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99648/testReport)**
for PR 23169 at commit
Github user HeartSaVioR commented on the issue:
https://github.com/apache/spark/pull/23169
@DaveDeCaprio
You might miss to roll back change in test.
Github user adrian-wang commented on the issue:
https://github.com/apache/spark/pull/23214
maybe add some detailed test result in description and explain the reason
for this in code comment?
---
-
To unsubscribe,
Github user LuciferYang commented on the issue:
https://github.com/apache/spark/pull/23214
ping @viirya
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user dbtsai commented on the issue:
https://github.com/apache/spark/pull/23171
@rxin `switch` in Java is still significantly faster than hash set even
without boxing / unboxing problems when the number of elements are small. We
were thinking about to have two implementations
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23194
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23194
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99644/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23194
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23194
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99649/
Test FAILed.
---
Github user rvesse commented on a diff in the pull request:
https://github.com/apache/spark/pull/22904#discussion_r238484145
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/SparkKubernetesClientFactory.scala
---
@@ -67,8 +66,16 @@
1 - 100 of 626 matches
Mail list logo