[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25472: [SPARK-28756][R] Fix checkJavaVersion to accept JDK8+

2019-08-16 Thread GitBox
dongjoon-hyun commented on a change in pull request #25472: [SPARK-28756][R] Fix checkJavaVersion to accept JDK8+ URL: https://github.com/apache/spark/pull/25472#discussion_r314667733 ## File path: R/pkg/R/client.R ## @@ -91,11 +91,16 @@ checkJavaVersion <- function() {

[GitHub] [spark] SparkQA commented on issue #25469: [SPARK-27637][Shuffle][FOLLOW-UP]For nettyBlockTransferService, if IOException occurred while create client, check whether relative executor is aliv

2019-08-16 Thread GitBox
SparkQA commented on issue #25469: [SPARK-27637][Shuffle][FOLLOW-UP]For nettyBlockTransferService, if IOException occurred while create client, check whether relative executor is alive before retry #24533 URL: https://github.com/apache/spark/pull/25469#issuecomment-521965865 **[Test build

[GitHub] [spark] HyukjinKwon commented on issue #25475: [SPARK-28736][SPARK-28735][PYTHON][ML] Fix PySpark ML tests to pass in JDK 11

2019-08-16 Thread GitBox
HyukjinKwon commented on issue #25475: [SPARK-28736][SPARK-28735][PYTHON][ML] Fix PySpark ML tests to pass in JDK 11 URL: https://github.com/apache/spark/pull/25475#issuecomment-521968822 Merged to master. This is an

[GitHub] [spark] HyukjinKwon commented on issue #25475: [SPARK-28736][SPARK-28735][PYTHON][ML] Fix PySpark ML tests to pass in JDK 11

2019-08-16 Thread GitBox
HyukjinKwon commented on issue #25475: [SPARK-28736][SPARK-28735][PYTHON][ML] Fix PySpark ML tests to pass in JDK 11 URL: https://github.com/apache/spark/pull/25475#issuecomment-521968748 Im going to just merge it. This is test-only PR and should always be fixed later. I roughly checked

[GitHub] [spark] dongjoon-hyun commented on issue #25472: [SPARK-28756][R] Fix checkJavaVersion to accept JDK8+

2019-08-16 Thread GitBox
dongjoon-hyun commented on issue #25472: [SPARK-28756][R] Fix checkJavaVersion to accept JDK8+ URL: https://github.com/apache/spark/pull/25472#issuecomment-521977333 Retest this please. This is an automated message from the

[GitHub] [spark] SparkQA commented on issue #25476: [SPARK-28759][BUILD] Upgrade scala-maven-plugin to 4.1.1

2019-08-16 Thread GitBox
SparkQA commented on issue #25476: [SPARK-28759][BUILD] Upgrade scala-maven-plugin to 4.1.1 URL: https://github.com/apache/spark/pull/25476#issuecomment-521982262 **[Test build #109211 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109211/testReport)**

[GitHub] [spark] HyukjinKwon commented on issue #25472: [SPARK-28756][R] Fix checkJavaVersion to accept JDK8+

2019-08-16 Thread GitBox
HyukjinKwon commented on issue #25472: [SPARK-28756][R] Fix checkJavaVersion to accept JDK8+ URL: https://github.com/apache/spark/pull/25472#issuecomment-521982075 retest this please This is an automated message from the

[GitHub] [spark] gaborgsomogyi commented on a change in pull request #25412: [SPARK-28691][EXAMPLES] Add Java/Scala DirectKerberizedKafkaWordCount examples

2019-08-16 Thread GitBox
gaborgsomogyi commented on a change in pull request #25412: [SPARK-28691][EXAMPLES] Add Java/Scala DirectKerberizedKafkaWordCount examples URL: https://github.com/apache/spark/pull/25412#discussion_r314693286 ## File path:

[GitHub] [spark] wangyum commented on a change in pull request #24829: [SPARK-27988][SQL][TEST] Port AGGREGATES.sql [Part 3]

2019-08-16 Thread GitBox
wangyum commented on a change in pull request #24829: [SPARK-27988][SQL][TEST] Port AGGREGATES.sql [Part 3] URL: https://github.com/apache/spark/pull/24829#discussion_r314692870 ## File path: sql/core/src/test/resources/sql-tests/inputs/pgSQL/aggregates_part3.sql ## @@

[GitHub] [spark] SparkQA commented on issue #25461: [SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow

2019-08-16 Thread GitBox
SparkQA commented on issue #25461: [SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow URL: https://github.com/apache/spark/pull/25461#issuecomment-521987273 **[Test build #109193 has

[GitHub] [spark] wangyum commented on a change in pull request #24829: [SPARK-27988][SQL][TEST] Port AGGREGATES.sql [Part 3]

2019-08-16 Thread GitBox
wangyum commented on a change in pull request #24829: [SPARK-27988][SQL][TEST] Port AGGREGATES.sql [Part 3] URL: https://github.com/apache/spark/pull/24829#discussion_r314692870 ## File path: sql/core/src/test/resources/sql-tests/inputs/pgSQL/aggregates_part3.sql ## @@

[GitHub] [spark] SparkQA removed a comment on issue #25461: [SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow

2019-08-16 Thread GitBox
SparkQA removed a comment on issue #25461: [SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow URL: https://github.com/apache/spark/pull/25461#issuecomment-521912292 **[Test build #109193 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #25477: [SPARK-28760][SS][TESTS] Add Kafka delegation token end-to-end test with mini KDC

2019-08-16 Thread GitBox
AmplabJenkins removed a comment on issue #25477: [SPARK-28760][SS][TESTS] Add Kafka delegation token end-to-end test with mini KDC URL: https://github.com/apache/spark/pull/25477#issuecomment-521992509 Test FAILed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] AmplabJenkins commented on issue #25394: [SPARK-28671][SQL] Throw NoSuchPermanentFunctionException for a non-exsistent permanent function in dropFunction

2019-08-16 Thread GitBox
AmplabJenkins commented on issue #25394: [SPARK-28671][SQL] Throw NoSuchPermanentFunctionException for a non-exsistent permanent function in dropFunction URL: https://github.com/apache/spark/pull/25394#issuecomment-521993204 Test PASSed. Refer to this link for build results (access

[GitHub] [spark] SparkQA removed a comment on issue #25394: [SPARK-28671][SQL] Throw NoSuchPermanentFunctionException for a non-exsistent permanent function in dropFunction

2019-08-16 Thread GitBox
SparkQA removed a comment on issue #25394: [SPARK-28671][SQL] Throw NoSuchPermanentFunctionException for a non-exsistent permanent function in dropFunction URL: https://github.com/apache/spark/pull/25394#issuecomment-521926632 **[Test build #109204 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #25394: [SPARK-28671][SQL] Throw NoSuchPermanentFunctionException for a non-exsistent permanent function in dropFunction

2019-08-16 Thread GitBox
AmplabJenkins removed a comment on issue #25394: [SPARK-28671][SQL] Throw NoSuchPermanentFunctionException for a non-exsistent permanent function in dropFunction URL: https://github.com/apache/spark/pull/25394#issuecomment-521993198 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #25394: [SPARK-28671][SQL] Throw NoSuchPermanentFunctionException for a non-exsistent permanent function in dropFunction

2019-08-16 Thread GitBox
AmplabJenkins removed a comment on issue #25394: [SPARK-28671][SQL] Throw NoSuchPermanentFunctionException for a non-exsistent permanent function in dropFunction URL: https://github.com/apache/spark/pull/25394#issuecomment-521993204 Test PASSed. Refer to this link for build results

[GitHub] [spark] AmplabJenkins commented on issue #25394: [SPARK-28671][SQL] Throw NoSuchPermanentFunctionException for a non-exsistent permanent function in dropFunction

2019-08-16 Thread GitBox
AmplabJenkins commented on issue #25394: [SPARK-28671][SQL] Throw NoSuchPermanentFunctionException for a non-exsistent permanent function in dropFunction URL: https://github.com/apache/spark/pull/25394#issuecomment-521993198 Merged build finished. Test PASSed.

[GitHub] [spark] gaborgsomogyi commented on issue #25477: [WIP][SPARK-28760][SS][TESTS] Add Kafka delegation token end-to-end test with mini KDC

2019-08-16 Thread GitBox
gaborgsomogyi commented on issue #25477: [WIP][SPARK-28760][SS][TESTS] Add Kafka delegation token end-to-end test with mini KDC URL: https://github.com/apache/spark/pull/25477#issuecomment-522001170 Other than that some unexpected dependency problem popped up: ```

[GitHub] [spark] AmplabJenkins removed a comment on issue #24715: [SPARK-25474][SQL] Data source tables support fallback to HDFS for size estimation

2019-08-16 Thread GitBox
AmplabJenkins removed a comment on issue #24715: [SPARK-25474][SQL] Data source tables support fallback to HDFS for size estimation URL: https://github.com/apache/spark/pull/24715#issuecomment-522008163 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #24715: [SPARK-25474][SQL] Data source tables support fallback to HDFS for size estimation

2019-08-16 Thread GitBox
AmplabJenkins removed a comment on issue #24715: [SPARK-25474][SQL] Data source tables support fallback to HDFS for size estimation URL: https://github.com/apache/spark/pull/24715#issuecomment-522008165 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] gaborgsomogyi commented on issue #25477: [WIP][SPARK-28760][SS][TESTS][test-maven] Add Kafka delegation token end-to-end test with mini KDC

2019-08-16 Thread GitBox
gaborgsomogyi commented on issue #25477: [WIP][SPARK-28760][SS][TESTS][test-maven] Add Kafka delegation token end-to-end test with mini KDC URL: https://github.com/apache/spark/pull/25477#issuecomment-522012374 retest this please

[GitHub] [spark] gaborgsomogyi removed a comment on issue #25477: [WIP][SPARK-28760][SS][TESTS][test-maven] Add Kafka delegation token end-to-end test with mini KDC

2019-08-16 Thread GitBox
gaborgsomogyi removed a comment on issue #25477: [WIP][SPARK-28760][SS][TESTS][test-maven] Add Kafka delegation token end-to-end test with mini KDC URL: https://github.com/apache/spark/pull/25477#issuecomment-522005385 retest this please

[GitHub] [spark] cloud-fan commented on issue #25473: [SPARK-28757][SQL] File table location should include both values of option `path` and `paths`

2019-08-16 Thread GitBox
cloud-fan commented on issue #25473: [SPARK-28757][SQL] File table location should include both values of option `path` and `paths` URL: https://github.com/apache/spark/pull/25473#issuecomment-522028666 thanks, merging to master!

[GitHub] [spark] peter-toth commented on issue #25479: [SPARK-28356][FOLLOWUP] fix case with different pre-shuffle partition numbers

2019-08-16 Thread GitBox
peter-toth commented on issue #25479: [SPARK-28356][FOLLOWUP] fix case with different pre-shuffle partition numbers URL: https://github.com/apache/spark/pull/25479#issuecomment-522040585 I opened this PR to fix https://github.com/apache/spark/pull/25121#discussion_r313447177 cc

[GitHub] [spark] wangyum commented on a change in pull request #25458: [SPARK-27931][SQL] Accept 'on' and 'off' as input and trim input for the boolean data type.

2019-08-16 Thread GitBox
wangyum commented on a change in pull request #25458: [SPARK-27931][SQL] Accept 'on' and 'off' as input and trim input for the boolean data type. URL: https://github.com/apache/spark/pull/25458#discussion_r314759147 ## File path:

[GitHub] [spark] cloud-fan commented on a change in pull request #25456: [SPARK-28739][SQL] Add a simple cost check for Adaptive Query Execution

2019-08-16 Thread GitBox
cloud-fan commented on a change in pull request #25456: [SPARK-28739][SQL] Add a simple cost check for Adaptive Query Execution URL: https://github.com/apache/spark/pull/25456#discussion_r314763473 ## File path:

[GitHub] [spark] AmplabJenkins removed a comment on issue #25472: [SPARK-28756][R] Fix checkJavaVersion to accept JDK8+

2019-08-16 Thread GitBox
AmplabJenkins removed a comment on issue #25472: [SPARK-28756][R] Fix checkJavaVersion to accept JDK8+ URL: https://github.com/apache/spark/pull/25472#issuecomment-521967805 Merged build finished. Test PASSed. This is an

[GitHub] [spark] AmplabJenkins removed a comment on issue #25472: [SPARK-28756][R] Fix checkJavaVersion to accept JDK8+

2019-08-16 Thread GitBox
AmplabJenkins removed a comment on issue #25472: [SPARK-28756][R] Fix checkJavaVersion to accept JDK8+ URL: https://github.com/apache/spark/pull/25472#issuecomment-521967807 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #25477: [SPARK-28760][SS][TESTS] Add Kafka delegation token end-to-end test with mini KDC

2019-08-16 Thread GitBox
AmplabJenkins removed a comment on issue #25477: [SPARK-28760][SS][TESTS] Add Kafka delegation token end-to-end test with mini KDC URL: https://github.com/apache/spark/pull/25477#issuecomment-521967554 Can one of the admins verify this patch?

[GitHub] [spark] kamalbanga commented on issue #25449: [PYSPARK] Simpler countByValue using collections' Counter

2019-08-16 Thread GitBox
kamalbanga commented on issue #25449: [PYSPARK] Simpler countByValue using collections' Counter URL: https://github.com/apache/spark/pull/25449#issuecomment-521977070 I benchmarked it and the existing implementation is faster 臘‍♂ ```python from pyspark import SparkContext, SparkConf

[GitHub] [spark] AmplabJenkins removed a comment on issue #25465: [SPARK-28747][SQL] merge the two data source v2 fallback configs

2019-08-16 Thread GitBox
AmplabJenkins removed a comment on issue #25465: [SPARK-28747][SQL] merge the two data source v2 fallback configs URL: https://github.com/apache/spark/pull/25465#issuecomment-521983772 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] gaborgsomogyi commented on a change in pull request #25412: [SPARK-28691][EXAMPLES] Add Java/Scala DirectKerberizedKafkaWordCount examples

2019-08-16 Thread GitBox
gaborgsomogyi commented on a change in pull request #25412: [SPARK-28691][EXAMPLES] Add Java/Scala DirectKerberizedKafkaWordCount examples URL: https://github.com/apache/spark/pull/25412#discussion_r314693286 ## File path:

[GitHub] [spark] wangyum commented on a change in pull request #24829: [SPARK-27988][SQL][TEST] Port AGGREGATES.sql [Part 3]

2019-08-16 Thread GitBox
wangyum commented on a change in pull request #24829: [SPARK-27988][SQL][TEST] Port AGGREGATES.sql [Part 3] URL: https://github.com/apache/spark/pull/24829#discussion_r314695645 ## File path: sql/core/src/test/resources/sql-tests/inputs/pgSQL/aggregates_part3.sql ## @@

[GitHub] [spark] AmplabJenkins commented on issue #25477: [SPARK-28760][SS][TESTS] Add Kafka delegation token end-to-end test with mini KDC

2019-08-16 Thread GitBox
AmplabJenkins commented on issue #25477: [SPARK-28760][SS][TESTS] Add Kafka delegation token end-to-end test with mini KDC URL: https://github.com/apache/spark/pull/25477#issuecomment-521992503 Merged build finished. Test FAILed.

[GitHub] [spark] wangyum commented on a change in pull request #24829: [SPARK-27988][SQL][TEST] Port AGGREGATES.sql [Part 3]

2019-08-16 Thread GitBox
wangyum commented on a change in pull request #24829: [SPARK-27988][SQL][TEST] Port AGGREGATES.sql [Part 3] URL: https://github.com/apache/spark/pull/24829#discussion_r314699552 ## File path: sql/core/src/test/resources/sql-tests/inputs/pgSQL/aggregates_part3.sql ## @@

[GitHub] [spark] SparkQA removed a comment on issue #25477: [SPARK-28760][SS][TESTS] Add Kafka delegation token end-to-end test with mini KDC

2019-08-16 Thread GitBox
SparkQA removed a comment on issue #25477: [SPARK-28760][SS][TESTS] Add Kafka delegation token end-to-end test with mini KDC URL: https://github.com/apache/spark/pull/25477#issuecomment-521966524 **[Test build #109213 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #25477: [SPARK-28760][SS][TESTS] Add Kafka delegation token end-to-end test with mini KDC

2019-08-16 Thread GitBox
AmplabJenkins removed a comment on issue #25477: [SPARK-28760][SS][TESTS] Add Kafka delegation token end-to-end test with mini KDC URL: https://github.com/apache/spark/pull/25477#issuecomment-521992503 Merged build finished. Test FAILed.

[GitHub] [spark] SparkQA commented on issue #25394: [SPARK-28671][SQL] Throw NoSuchPermanentFunctionException for a non-exsistent permanent function in dropFunction

2019-08-16 Thread GitBox
SparkQA commented on issue #25394: [SPARK-28671][SQL] Throw NoSuchPermanentFunctionException for a non-exsistent permanent function in dropFunction URL: https://github.com/apache/spark/pull/25394#issuecomment-521992734 **[Test build #109204 has

[GitHub] [spark] maropu commented on issue #22570: [SPARK-25553][BUILD] Add EmptyInterpolatedStringChecker to scalastyle config

2019-08-16 Thread GitBox
maropu commented on issue #22570: [SPARK-25553][BUILD] Add EmptyInterpolatedStringChecker to scalastyle config URL: https://github.com/apache/spark/pull/22570#issuecomment-521992646 retest this please This is an automated

[GitHub] [spark] AmplabJenkins removed a comment on issue #25477: [SPARK-28760][SS][TESTS] Add Kafka delegation token end-to-end test with mini KDC

2019-08-16 Thread GitBox
AmplabJenkins removed a comment on issue #25477: [SPARK-28760][SS][TESTS] Add Kafka delegation token end-to-end test with mini KDC URL: https://github.com/apache/spark/pull/25477#issuecomment-521967717 Can one of the admins verify this patch?

[GitHub] [spark] AmplabJenkins commented on issue #25477: [SPARK-28760][SS][TESTS] Add Kafka delegation token end-to-end test with mini KDC

2019-08-16 Thread GitBox
AmplabJenkins commented on issue #25477: [SPARK-28760][SS][TESTS] Add Kafka delegation token end-to-end test with mini KDC URL: https://github.com/apache/spark/pull/25477#issuecomment-521992509 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] HyukjinKwon commented on issue #25478: [SPARK-28755][R][TESTS] Increase tolerance in 'spark.mlp' SparkR test for JDK 11

2019-08-16 Thread GitBox
HyukjinKwon commented on issue #25478: [SPARK-28755][R][TESTS] Increase tolerance in 'spark.mlp' SparkR test for JDK 11 URL: https://github.com/apache/spark/pull/25478#issuecomment-521996496 @felixcheung and @shivaram, we're actually a bit rushing to let Hive 2.3.6 (with JDK 11 fix)

[GitHub] [spark] peter-toth commented on a change in pull request #23531: [SPARK-24497][SQL] Support recursive SQL query

2019-08-16 Thread GitBox
peter-toth commented on a change in pull request #23531: [SPARK-24497][SQL] Support recursive SQL query URL: https://github.com/apache/spark/pull/23531#discussion_r314704239 ## File path: sql/core/src/test/resources/sql-tests/results/cte.sql.out ## @@ -328,16 +328,891 @@

[GitHub] [spark] peter-toth commented on a change in pull request #23531: [SPARK-24497][SQL] Support recursive SQL query

2019-08-16 Thread GitBox
peter-toth commented on a change in pull request #23531: [SPARK-24497][SQL] Support recursive SQL query URL: https://github.com/apache/spark/pull/23531#discussion_r314704140 ## File path: sql/core/src/test/resources/sql-tests/results/cte.sql.out ## @@ -328,16 +328,891 @@

[GitHub] [spark] peter-toth commented on a change in pull request #23531: [SPARK-24497][SQL] Support recursive SQL query

2019-08-16 Thread GitBox
peter-toth commented on a change in pull request #23531: [SPARK-24497][SQL] Support recursive SQL query URL: https://github.com/apache/spark/pull/23531#discussion_r314704761 ## File path: sql/core/src/test/resources/sql-tests/results/cte.sql.out ## @@ -328,16 +328,891 @@

[GitHub] [spark] peter-toth commented on a change in pull request #23531: [SPARK-24497][SQL] Support recursive SQL query

2019-08-16 Thread GitBox
peter-toth commented on a change in pull request #23531: [SPARK-24497][SQL] Support recursive SQL query URL: https://github.com/apache/spark/pull/23531#discussion_r314704294 ## File path: sql/core/src/test/resources/sql-tests/results/cte.sql.out ## @@ -328,16 +328,891 @@

[GitHub] [spark] younggyuchun commented on a change in pull request #25458: [SPARK-27931][SQL] Accept 'on' and 'off' as input and trim input for the boolean data type.

2019-08-16 Thread GitBox
younggyuchun commented on a change in pull request #25458: [SPARK-27931][SQL] Accept 'on' and 'off' as input and trim input for the boolean data type. URL: https://github.com/apache/spark/pull/25458#discussion_r314716565 ## File path:

[GitHub] [spark] srowen commented on issue #22570: [SPARK-25553][BUILD] Add EmptyInterpolatedStringChecker to scalastyle config

2019-08-16 Thread GitBox
srowen commented on issue #22570: [SPARK-25553][BUILD] Add EmptyInterpolatedStringChecker to scalastyle config URL: https://github.com/apache/spark/pull/22570#issuecomment-522006541 Whew, that's a lot of files! I'm hesitant to do this. I checked if the standard interpolator special-cases

[GitHub] [spark] maropu commented on issue #25394: [SPARK-28671][SQL] Throw NoSuchPermanentFunctionException for a non-exsistent permanent function in dropFunction/alterFunction

2019-08-16 Thread GitBox
maropu commented on issue #25394: [SPARK-28671][SQL] Throw NoSuchPermanentFunctionException for a non-exsistent permanent function in dropFunction/alterFunction URL: https://github.com/apache/spark/pull/25394#issuecomment-522017433 @PavithraRamachandran Thanks for your contribution! I

[GitHub] [spark] cloud-fan commented on a change in pull request #25461: [SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow

2019-08-16 Thread GitBox
cloud-fan commented on a change in pull request #25461: [SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow URL: https://github.com/apache/spark/pull/25461#discussion_r314743668 ## File path:

[GitHub] [spark] cloud-fan commented on a change in pull request #25456: [SPARK-28739][SQL] Add a simple cost check for Adaptive Query Execution

2019-08-16 Thread GitBox
cloud-fan commented on a change in pull request #25456: [SPARK-28739][SQL] Add a simple cost check for Adaptive Query Execution URL: https://github.com/apache/spark/pull/25456#discussion_r314762909 ## File path:

[GitHub] [spark] cloud-fan commented on a change in pull request #25456: [SPARK-28739][SQL] Add a simple cost check for Adaptive Query Execution

2019-08-16 Thread GitBox
cloud-fan commented on a change in pull request #25456: [SPARK-28739][SQL] Add a simple cost check for Adaptive Query Execution URL: https://github.com/apache/spark/pull/25456#discussion_r314763473 ## File path:

[GitHub] [spark] AmplabJenkins commented on issue #25469: [SPARK-27637][Shuffle][FOLLOW-UP]For nettyBlockTransferService, if IOException occurred while create client, check whether relative executor i

2019-08-16 Thread GitBox
AmplabJenkins commented on issue #25469: [SPARK-27637][Shuffle][FOLLOW-UP]For nettyBlockTransferService, if IOException occurred while create client, check whether relative executor is alive before retry #24533 URL: https://github.com/apache/spark/pull/25469#issuecomment-521966380 Test

[GitHub] [spark] SparkQA removed a comment on issue #25469: [SPARK-27637][Shuffle][FOLLOW-UP]For nettyBlockTransferService, if IOException occurred while create client, check whether relative executor

2019-08-16 Thread GitBox
SparkQA removed a comment on issue #25469: [SPARK-27637][Shuffle][FOLLOW-UP]For nettyBlockTransferService, if IOException occurred while create client, check whether relative executor is alive before retry #24533 URL: https://github.com/apache/spark/pull/25469#issuecomment-521922297

[GitHub] [spark] AmplabJenkins commented on issue #25469: [SPARK-27637][Shuffle][FOLLOW-UP]For nettyBlockTransferService, if IOException occurred while create client, check whether relative executor i

2019-08-16 Thread GitBox
AmplabJenkins commented on issue #25469: [SPARK-27637][Shuffle][FOLLOW-UP]For nettyBlockTransferService, if IOException occurred while create client, check whether relative executor is alive before retry #24533 URL: https://github.com/apache/spark/pull/25469#issuecomment-521966376 Merged

[GitHub] [spark] Fokko commented on issue #25451: [SPARK-28728][BUILD] Bump Jackson Databind to 2.9.9.3

2019-08-16 Thread GitBox
Fokko commented on issue #25451: [SPARK-28728][BUILD] Bump Jackson Databind to 2.9.9.3 URL: https://github.com/apache/spark/pull/25451#issuecomment-521978456 My pleasure This is an automated message from the Apache Git

[GitHub] [spark] SparkQA removed a comment on issue #25476: [SPARK-28759][BUILD] Upgrade scala-maven-plugin to 4.1.1

2019-08-16 Thread GitBox
SparkQA removed a comment on issue #25476: [SPARK-28759][BUILD] Upgrade scala-maven-plugin to 4.1.1 URL: https://github.com/apache/spark/pull/25476#issuecomment-521954688 **[Test build #109211 has

[GitHub] [spark] AmplabJenkins commented on issue #25476: [SPARK-28759][BUILD] Upgrade scala-maven-plugin to 4.1.1

2019-08-16 Thread GitBox
AmplabJenkins commented on issue #25476: [SPARK-28759][BUILD] Upgrade scala-maven-plugin to 4.1.1 URL: https://github.com/apache/spark/pull/25476#issuecomment-521982525 Merged build finished. Test FAILed. This is an

[GitHub] [spark] AmplabJenkins removed a comment on issue #25476: [SPARK-28759][BUILD] Upgrade scala-maven-plugin to 4.1.1

2019-08-16 Thread GitBox
AmplabJenkins removed a comment on issue #25476: [SPARK-28759][BUILD] Upgrade scala-maven-plugin to 4.1.1 URL: https://github.com/apache/spark/pull/25476#issuecomment-521982525 Merged build finished. Test FAILed. This is an

[GitHub] [spark] AmplabJenkins commented on issue #25476: [SPARK-28759][BUILD] Upgrade scala-maven-plugin to 4.1.1

2019-08-16 Thread GitBox
AmplabJenkins commented on issue #25476: [SPARK-28759][BUILD] Upgrade scala-maven-plugin to 4.1.1 URL: https://github.com/apache/spark/pull/25476#issuecomment-521982529 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] gaborgsomogyi commented on a change in pull request #25412: [SPARK-28691][EXAMPLES] Add Java/Scala DirectKerberizedKafkaWordCount examples

2019-08-16 Thread GitBox
gaborgsomogyi commented on a change in pull request #25412: [SPARK-28691][EXAMPLES] Add Java/Scala DirectKerberizedKafkaWordCount examples URL: https://github.com/apache/spark/pull/25412#discussion_r314695471 ## File path:

[GitHub] [spark] gaborgsomogyi commented on a change in pull request #22138: [SPARK-25151][SS] Apply Apache Commons Pool to KafkaDataConsumer

2019-08-16 Thread GitBox
gaborgsomogyi commented on a change in pull request #22138: [SPARK-25151][SS] Apply Apache Commons Pool to KafkaDataConsumer URL: https://github.com/apache/spark/pull/22138#discussion_r314701313 ## File path:

[GitHub] [spark] HyukjinKwon commented on issue #25443: [WIP][SPARK-28723][test-hadoop3.2][test-maven] Test JDK 11 with Hadoop-3.2/Hive 2.3.6 on jenkins

2019-08-16 Thread GitBox
HyukjinKwon commented on issue #25443: [WIP][SPARK-28723][test-hadoop3.2][test-maven] Test JDK 11 with Hadoop-3.2/Hive 2.3.6 on jenkins URL: https://github.com/apache/spark/pull/25443#issuecomment-521996846 After https://github.com/apache/spark/pull/25472,

[GitHub] [spark] peter-toth commented on a change in pull request #23531: [SPARK-24497][SQL] Support recursive SQL query

2019-08-16 Thread GitBox
peter-toth commented on a change in pull request #23531: [SPARK-24497][SQL] Support recursive SQL query URL: https://github.com/apache/spark/pull/23531#discussion_r314704495 ## File path: sql/core/src/test/resources/sql-tests/results/cte.sql.out ## @@ -328,16 +328,891 @@

[GitHub] [spark] peter-toth commented on a change in pull request #23531: [SPARK-24497][SQL] Support recursive SQL query

2019-08-16 Thread GitBox
peter-toth commented on a change in pull request #23531: [SPARK-24497][SQL] Support recursive SQL query URL: https://github.com/apache/spark/pull/23531#discussion_r314704922 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ##

[GitHub] [spark] younggyuchun commented on issue #25458: [SPARK-27931][SQL] Accept 'on' and 'off' as input and trim input for the boolean data type.

2019-08-16 Thread GitBox
younggyuchun commented on issue #25458: [SPARK-27931][SQL] Accept 'on' and 'off' as input and trim input for the boolean data type. URL: https://github.com/apache/spark/pull/25458#issuecomment-522006950 retest this please

[GitHub] [spark] cloud-fan closed pull request #25473: [SPARK-28757][SQL] File table location should include both values of option `path` and `paths`

2019-08-16 Thread GitBox
cloud-fan closed pull request #25473: [SPARK-28757][SQL] File table location should include both values of option `path` and `paths` URL: https://github.com/apache/spark/pull/25473 This is an automated message from the

[GitHub] [spark] peter-toth opened a new pull request #25479: [SPARK-28356][FOLLOWUP] fix case with different pre-shuffle partition numbers

2019-08-16 Thread GitBox
peter-toth opened a new pull request #25479: [SPARK-28356][FOLLOWUP] fix case with different pre-shuffle partition numbers URL: https://github.com/apache/spark/pull/25479 ### What changes were proposed in this pull request? Small fix to `ReduceNumShufflePartitions` when

[GitHub] [spark] cloud-fan commented on a change in pull request #25456: [SPARK-28739][SQL] Add a simple cost check for Adaptive Query Execution

2019-08-16 Thread GitBox
cloud-fan commented on a change in pull request #25456: [SPARK-28739][SQL] Add a simple cost check for Adaptive Query Execution URL: https://github.com/apache/spark/pull/25456#discussion_r314765055 ## File path:

[GitHub] [spark] AmplabJenkins commented on issue #25477: [SPARK-28760][SS][TESTS] Add Kafka delegation token end-to-end test with mini KDC

2019-08-16 Thread GitBox
AmplabJenkins commented on issue #25477: [SPARK-28760][SS][TESTS] Add Kafka delegation token end-to-end test with mini KDC URL: https://github.com/apache/spark/pull/25477#issuecomment-521967554 Can one of the admins verify this patch?

[GitHub] [spark] HyukjinKwon closed pull request #25475: [SPARK-28736][SPARK-28735][PYTHON][ML][TESTS] Fix PySpark ML tests to pass in JDK 11

2019-08-16 Thread GitBox
HyukjinKwon closed pull request #25475: [SPARK-28736][SPARK-28735][PYTHON][ML][TESTS] Fix PySpark ML tests to pass in JDK 11 URL: https://github.com/apache/spark/pull/25475 This is an automated message from the Apache Git

[GitHub] [spark] wangyum closed pull request #22999: [SPARK-20319][SQL] Already quoted identifiers are getting wrapped with additional quotes

2019-08-16 Thread GitBox
wangyum closed pull request #22999: [SPARK-20319][SQL] Already quoted identifiers are getting wrapped with additional quotes URL: https://github.com/apache/spark/pull/22999 This is an automated message from the Apache Git

[GitHub] [spark] SparkQA removed a comment on issue #22570: [SPARK-25553][BUILD] Add EmptyInterpolatedStringChecker to scalastyle config

2019-08-16 Thread GitBox
SparkQA removed a comment on issue #22570: [SPARK-25553][BUILD] Add EmptyInterpolatedStringChecker to scalastyle config URL: https://github.com/apache/spark/pull/22570#issuecomment-521946557 **[Test build #109209 has

[GitHub] [spark] SparkQA commented on issue #22570: [SPARK-25553][BUILD] Add EmptyInterpolatedStringChecker to scalastyle config

2019-08-16 Thread GitBox
SparkQA commented on issue #22570: [SPARK-25553][BUILD] Add EmptyInterpolatedStringChecker to scalastyle config URL: https://github.com/apache/spark/pull/22570#issuecomment-521985130 **[Test build #109209 has

[GitHub] [spark] AmplabJenkins commented on issue #22570: [SPARK-25553][BUILD] Add EmptyInterpolatedStringChecker to scalastyle config

2019-08-16 Thread GitBox
AmplabJenkins commented on issue #22570: [SPARK-25553][BUILD] Add EmptyInterpolatedStringChecker to scalastyle config URL: https://github.com/apache/spark/pull/22570#issuecomment-521985354 Merged build finished. Test FAILed.

[GitHub] [spark] AmplabJenkins commented on issue #22570: [SPARK-25553][BUILD] Add EmptyInterpolatedStringChecker to scalastyle config

2019-08-16 Thread GitBox
AmplabJenkins commented on issue #22570: [SPARK-25553][BUILD] Add EmptyInterpolatedStringChecker to scalastyle config URL: https://github.com/apache/spark/pull/22570#issuecomment-521985362 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #22570: [SPARK-25553][BUILD] Add EmptyInterpolatedStringChecker to scalastyle config

2019-08-16 Thread GitBox
AmplabJenkins removed a comment on issue #22570: [SPARK-25553][BUILD] Add EmptyInterpolatedStringChecker to scalastyle config URL: https://github.com/apache/spark/pull/22570#issuecomment-521985354 Merged build finished. Test FAILed.

[GitHub] [spark] attilapiros commented on issue #25299: [SPARK-27651][Core] Avoid the network when shuffle blocks are fetched from the same host

2019-08-16 Thread GitBox
attilapiros commented on issue #25299: [SPARK-27651][Core] Avoid the network when shuffle blocks are fetched from the same host URL: https://github.com/apache/spark/pull/25299#issuecomment-521998645 retest this please.

[GitHub] [spark] dongjoon-hyun closed pull request #25451: [SPARK-28728][BUILD] Bump Jackson Databind to 2.9.9.3

2019-08-16 Thread GitBox
dongjoon-hyun closed pull request #25451: [SPARK-28728][BUILD] Bump Jackson Databind to 2.9.9.3 URL: https://github.com/apache/spark/pull/25451 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] peter-toth commented on a change in pull request #23531: [SPARK-24497][SQL] Support recursive SQL query

2019-08-16 Thread GitBox
peter-toth commented on a change in pull request #23531: [SPARK-24497][SQL] Support recursive SQL query URL: https://github.com/apache/spark/pull/23531#discussion_r314703486 ## File path: sql/core/src/test/resources/sql-tests/inputs/cte.sql ## @@ -155,6 +155,419 @@ SELECT

[GitHub] [spark] gaborgsomogyi commented on a change in pull request #22138: [SPARK-25151][SS] Apply Apache Commons Pool to KafkaDataConsumer

2019-08-16 Thread GitBox
gaborgsomogyi commented on a change in pull request #22138: [SPARK-25151][SS] Apply Apache Commons Pool to KafkaDataConsumer URL: https://github.com/apache/spark/pull/22138#discussion_r314703946 ## File path:

[GitHub] [spark] peter-toth commented on a change in pull request #23531: [SPARK-24497][SQL] Support recursive SQL query

2019-08-16 Thread GitBox
peter-toth commented on a change in pull request #23531: [SPARK-24497][SQL] Support recursive SQL query URL: https://github.com/apache/spark/pull/23531#discussion_r314703339 ## File path: sql/core/src/test/resources/sql-tests/results/cte.sql.out ## @@ -1,5 +1,5 @@ --

[GitHub] [spark] HyukjinKwon opened a new pull request #25478: [SPARK-28755][R][TESTS] Increase tolerance in 'spark.mlp' SparkR test for JDK 11

2019-08-16 Thread GitBox
HyukjinKwon opened a new pull request #25478: [SPARK-28755][R][TESTS] Increase tolerance in 'spark.mlp' SparkR test for JDK 11 URL: https://github.com/apache/spark/pull/25478 ### What changes were proposed in this pull request? This PR proposes to increase the tolerance

[GitHub] [spark] gaborgsomogyi commented on issue #25477: [WIP][SPARK-28760][SS][TESTS][test-maven] Add Kafka delegation token end-to-end test with mini KDC

2019-08-16 Thread GitBox
gaborgsomogyi commented on issue #25477: [WIP][SPARK-28760][SS][TESTS][test-maven] Add Kafka delegation token end-to-end test with mini KDC URL: https://github.com/apache/spark/pull/25477#issuecomment-522005515 Let's see if the problem appears with maven as well.

[GitHub] [spark] maropu commented on issue #25394: [SPARK-28671][SQL] Throw NoSuchPermanentFunctionException for a non-exsistent permanent function in dropFunction/alterFunction

2019-08-16 Thread GitBox
maropu commented on issue #25394: [SPARK-28671][SQL] Throw NoSuchPermanentFunctionException for a non-exsistent permanent function in dropFunction/alterFunction URL: https://github.com/apache/spark/pull/25394#issuecomment-522014509 Thanks! Merged to master

[GitHub] [spark] maropu closed pull request #25394: [SPARK-28671][SQL] Throw NoSuchPermanentFunctionException for a non-exsistent permanent function in dropFunction/alterFunction

2019-08-16 Thread GitBox
maropu closed pull request #25394: [SPARK-28671][SQL] Throw NoSuchPermanentFunctionException for a non-exsistent permanent function in dropFunction/alterFunction URL: https://github.com/apache/spark/pull/25394 This is an

[GitHub] [spark] cloud-fan commented on a change in pull request #25461: [SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow

2019-08-16 Thread GitBox
cloud-fan commented on a change in pull request #25461: [SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow URL: https://github.com/apache/spark/pull/25461#discussion_r314741545 ## File path:

[GitHub] [spark] AmplabJenkins commented on issue #25472: [SPARK-28756][R] Fix checkJavaVersion to accept JDK8+

2019-08-16 Thread GitBox
AmplabJenkins commented on issue #25472: [SPARK-28756][R] Fix checkJavaVersion to accept JDK8+ URL: https://github.com/apache/spark/pull/25472#issuecomment-521967805 Merged build finished. Test PASSed. This is an automated

[GitHub] [spark] AmplabJenkins commented on issue #25472: [SPARK-28756][R] Fix checkJavaVersion to accept JDK8+

2019-08-16 Thread GitBox
AmplabJenkins commented on issue #25472: [SPARK-28756][R] Fix checkJavaVersion to accept JDK8+ URL: https://github.com/apache/spark/pull/25472#issuecomment-521967807 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25477: [SPARK-28760][SS][TESTS] Add Kafka delegation token end-to-end test with mini KDC

2019-08-16 Thread GitBox
AmplabJenkins commented on issue #25477: [SPARK-28760][SS][TESTS] Add Kafka delegation token end-to-end test with mini KDC URL: https://github.com/apache/spark/pull/25477#issuecomment-521967717 Can one of the admins verify this patch?

[GitHub] [spark] SparkQA removed a comment on issue #25472: [SPARK-28756][R] Fix checkJavaVersion to accept JDK8+

2019-08-16 Thread GitBox
SparkQA removed a comment on issue #25472: [SPARK-28756][R] Fix checkJavaVersion to accept JDK8+ URL: https://github.com/apache/spark/pull/25472#issuecomment-521966597 **[Test build #109214 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #25472: [SPARK-28756][R] Fix checkJavaVersion to accept JDK8+

2019-08-16 Thread GitBox
AmplabJenkins removed a comment on issue #25472: [SPARK-28756][R] Fix checkJavaVersion to accept JDK8+ URL: https://github.com/apache/spark/pull/25472#issuecomment-521971945 Merged build finished. Test FAILed. This is an

[GitHub] [spark] AmplabJenkins removed a comment on issue #25472: [SPARK-28756][R] Fix checkJavaVersion to accept JDK8+

2019-08-16 Thread GitBox
AmplabJenkins removed a comment on issue #25472: [SPARK-28756][R] Fix checkJavaVersion to accept JDK8+ URL: https://github.com/apache/spark/pull/25472#issuecomment-521971951 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25472: [SPARK-28756][R] Fix checkJavaVersion to accept JDK8+

2019-08-16 Thread GitBox
AmplabJenkins commented on issue #25472: [SPARK-28756][R] Fix checkJavaVersion to accept JDK8+ URL: https://github.com/apache/spark/pull/25472#issuecomment-521971951 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25472: [SPARK-28756][R] Fix checkJavaVersion to accept JDK8+

2019-08-16 Thread GitBox
AmplabJenkins commented on issue #25472: [SPARK-28756][R] Fix checkJavaVersion to accept JDK8+ URL: https://github.com/apache/spark/pull/25472#issuecomment-521971945 Merged build finished. Test FAILed. This is an automated

[GitHub] [spark] SparkQA commented on issue #25472: [SPARK-28756][R] Fix checkJavaVersion to accept JDK8+

2019-08-16 Thread GitBox
SparkQA commented on issue #25472: [SPARK-28756][R] Fix checkJavaVersion to accept JDK8+ URL: https://github.com/apache/spark/pull/25472#issuecomment-521971930 **[Test build #109214 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109214/testReport)** for

[GitHub] [spark] AmplabJenkins removed a comment on issue #25476: [SPARK-28759][BUILD] Upgrade scala-maven-plugin to 4.1.1

2019-08-16 Thread GitBox
AmplabJenkins removed a comment on issue #25476: [SPARK-28759][BUILD] Upgrade scala-maven-plugin to 4.1.1 URL: https://github.com/apache/spark/pull/25476#issuecomment-521982529 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #22570: [SPARK-25553][BUILD] Add EmptyInterpolatedStringChecker to scalastyle config

2019-08-16 Thread GitBox
AmplabJenkins removed a comment on issue #22570: [SPARK-25553][BUILD] Add EmptyInterpolatedStringChecker to scalastyle config URL: https://github.com/apache/spark/pull/22570#issuecomment-521985362 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA commented on issue #25473: [SPARK-28757][SQL] File table location should include both values of option `path` and `paths`

2019-08-16 Thread GitBox
SparkQA commented on issue #25473: [SPARK-28757][SQL] File table location should include both values of option `path` and `paths` URL: https://github.com/apache/spark/pull/25473#issuecomment-521991464 **[Test build #109206 has

  1   2   3   4   5   6   7   8   9   10   >