[GitHub] [spark] SparkQA commented on pull request #28439: [SPARK-30119][WEBUI] Add Pagination Support to Streaming Page

2020-05-03 Thread GitBox
SparkQA commented on pull request #28439: URL: https://github.com/apache/spark/pull/28439#issuecomment-623120580 **[Test build #122231 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122231/testReport)** for PR 28439 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28439: [SPARK-30119][WEBUI] Add Pagination Support to Streaming Page

2020-05-03 Thread GitBox
AmplabJenkins commented on pull request #28439: URL: https://github.com/apache/spark/pull/28439#issuecomment-623120594 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28420: [SPARK-31615][SQL] Pretty string output for sql method of RuntimeReplaceable expressions

2020-05-03 Thread GitBox
SparkQA commented on pull request #28420: URL: https://github.com/apache/spark/pull/28420#issuecomment-623125272 **[Test build #18 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18/testReport)** for PR 28420 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #18323: [SPARK-21117][SQL] Built-in SQL Function Support - WIDTH_BUCKET

2020-05-03 Thread GitBox
SparkQA removed a comment on pull request #18323: URL: https://github.com/apache/spark/pull/18323#issuecomment-623099600 **[Test build #19 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19/testReport)** for PR 18323 at commit

[GitHub] [spark] SparkQA commented on pull request #18323: [SPARK-21117][SQL] Built-in SQL Function Support - WIDTH_BUCKET

2020-05-03 Thread GitBox
SparkQA commented on pull request #18323: URL: https://github.com/apache/spark/pull/18323#issuecomment-623136310 **[Test build #19 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19/testReport)** for PR 18323 at commit

[GitHub] [spark] SparkQA commented on pull request #28442: [SPARK-31631][TESTS] Fix test flakiness caused by MiniKdc which throw s 'address in use' BindException

2020-05-03 Thread GitBox
SparkQA commented on pull request #28442: URL: https://github.com/apache/spark/pull/28442#issuecomment-623138171 **[Test build #122234 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122234/testReport)** for PR 28442 at commit

[GitHub] [spark] SparkQA commented on pull request #28442: [SPARK-31631][TESTS] Fix test flakiness caused by MiniKdc which throws 'address in use' BindException with retry

2020-05-03 Thread GitBox
SparkQA commented on pull request #28442: URL: https://github.com/apache/spark/pull/28442#issuecomment-623145240 **[Test build #122234 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122234/testReport)** for PR 28442 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28442: [SPARK-31631][TESTS] Fix test flakiness caused by MiniKdc which throws 'address in use' BindException with retry

2020-05-03 Thread GitBox
AmplabJenkins commented on pull request #28442: URL: https://github.com/apache/spark/pull/28442#issuecomment-623145301 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28442: [SPARK-31631][TESTS] Fix test flakiness caused by MiniKdc which throws 'address in use' BindException with retry

2020-05-03 Thread GitBox
AmplabJenkins removed a comment on pull request #28442: URL: https://github.com/apache/spark/pull/28442#issuecomment-623145301 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #28442: [SPARK-31631][TESTS] Fix test flakiness caused by MiniKdc which throws 'address in use' BindException with retry

2020-05-03 Thread GitBox
SparkQA removed a comment on pull request #28442: URL: https://github.com/apache/spark/pull/28442#issuecomment-623138171 **[Test build #122234 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122234/testReport)** for PR 28442 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

2020-05-03 Thread GitBox
AmplabJenkins removed a comment on pull request #28370: URL: https://github.com/apache/spark/pull/28370#issuecomment-623134824 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] yaooqinn opened a new pull request #28442: [SPARK-31631][TESTS] Fix test flakiness caused by MiniKdc which throw s 'address in use' BindException

2020-05-03 Thread GitBox
yaooqinn opened a new pull request #28442: URL: https://github.com/apache/spark/pull/28442 ### What changes were proposed in this pull request? The `Kafka*Suite`s are flaky because of the issue of Hadoop MiniKdc - https://issues.apache.org/jira/browse/HADOOP-12656 > Looking at

[GitHub] [spark] AmplabJenkins commented on pull request #18323: [SPARK-21117][SQL] Built-in SQL Function Support - WIDTH_BUCKET

2020-05-03 Thread GitBox
AmplabJenkins commented on pull request #18323: URL: https://github.com/apache/spark/pull/18323#issuecomment-623136811 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #18323: [SPARK-21117][SQL] Built-in SQL Function Support - WIDTH_BUCKET

2020-05-03 Thread GitBox
AmplabJenkins removed a comment on pull request #18323: URL: https://github.com/apache/spark/pull/18323#issuecomment-623136811 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28258: [SPARK-31486] [CORE] spark.submit.waitAppCompletion flag to control spark-submit exit in Standalone Cluster Mode

2020-05-03 Thread GitBox
AmplabJenkins commented on pull request #28258: URL: https://github.com/apache/spark/pull/28258#issuecomment-623143264 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28441: [SPARK-31630][SQL] Fix perf regression by skipping timestamps rebasing after some threshold

2020-05-03 Thread GitBox
SparkQA removed a comment on pull request #28441: URL: https://github.com/apache/spark/pull/28441#issuecomment-623103275 **[Test build #122230 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122230/testReport)** for PR 28441 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28441: [SPARK-31630][SQL] Fix perf regression by skipping timestamps rebasing after some threshold

2020-05-03 Thread GitBox
AmplabJenkins commented on pull request #28441: URL: https://github.com/apache/spark/pull/28441#issuecomment-623143274 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28441: [SPARK-31630][SQL] Fix perf regression by skipping timestamps rebasing after some threshold

2020-05-03 Thread GitBox
AmplabJenkins removed a comment on pull request #28441: URL: https://github.com/apache/spark/pull/28441#issuecomment-623143274 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28258: [SPARK-31486] [CORE] spark.submit.waitAppCompletion flag to control spark-submit exit in Standalone Cluster Mode

2020-05-03 Thread GitBox
AmplabJenkins removed a comment on pull request #28258: URL: https://github.com/apache/spark/pull/28258#issuecomment-623143264 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #28441: [SPARK-31630][SQL] Fix perf regression by skipping timestamps rebasing after some threshold

2020-05-03 Thread GitBox
SparkQA commented on pull request #28441: URL: https://github.com/apache/spark/pull/28441#issuecomment-623142922 **[Test build #122230 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122230/testReport)** for PR 28441 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #28258: [SPARK-31486] [CORE] spark.submit.waitAppCompletion flag to control spark-submit exit in Standalone Cluster Mode

2020-05-03 Thread GitBox
SparkQA removed a comment on pull request #28258: URL: https://github.com/apache/spark/pull/28258#issuecomment-623117834 **[Test build #122232 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122232/testReport)** for PR 28258 at commit

[GitHub] [spark] SparkQA commented on pull request #28258: [SPARK-31486] [CORE] spark.submit.waitAppCompletion flag to control spark-submit exit in Standalone Cluster Mode

2020-05-03 Thread GitBox
SparkQA commented on pull request #28258: URL: https://github.com/apache/spark/pull/28258#issuecomment-623142923 **[Test build #122232 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122232/testReport)** for PR 28258 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

2020-05-03 Thread GitBox
AmplabJenkins removed a comment on pull request #28370: URL: https://github.com/apache/spark/pull/28370#issuecomment-623157273 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

2020-05-03 Thread GitBox
AmplabJenkins removed a comment on pull request #28370: URL: https://github.com/apache/spark/pull/28370#issuecomment-623157276 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on pull request #28420: [SPARK-31615][SQL] Pretty string output for sql method of RuntimeReplaceable expressions

2020-05-03 Thread GitBox
AmplabJenkins commented on pull request #28420: URL: https://github.com/apache/spark/pull/28420#issuecomment-623125621 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28420: [SPARK-31615][SQL] Pretty string output for sql method of RuntimeReplaceable expressions

2020-05-03 Thread GitBox
SparkQA removed a comment on pull request #28420: URL: https://github.com/apache/spark/pull/28420#issuecomment-623090044 **[Test build #18 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18/testReport)** for PR 28420 at commit

[GitHub] [spark] prakharjain09 commented on pull request #28331: [WIP][SPARK-20629][CORE] Copy shuffle data when nodes are being shutdown

2020-05-03 Thread GitBox
prakharjain09 commented on pull request #28331: URL: https://github.com/apache/spark/pull/28331#issuecomment-623130952 > **[Test build #122183 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122183/testReport)** for PR 28331 at commit

[GitHub] [spark] iRakson commented on pull request #28439: [SPARK-30119][WEBUI] Add Pagination Support to Streaming Page

2020-05-03 Thread GitBox
iRakson commented on pull request #28439: URL: https://github.com/apache/spark/pull/28439#issuecomment-623131857 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] AmplabJenkins commented on pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

2020-05-03 Thread GitBox
AmplabJenkins commented on pull request #28370: URL: https://github.com/apache/spark/pull/28370#issuecomment-623134824 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28442: [SPARK-31631][TESTS] Fix test flakiness caused by MiniKdc which throw s 'address in use' BindException

2020-05-03 Thread GitBox
AmplabJenkins removed a comment on pull request #28442: URL: https://github.com/apache/spark/pull/28442#issuecomment-623138464 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28442: [SPARK-31631][TESTS] Fix test flakiness caused by MiniKdc which throw s 'address in use' BindException

2020-05-03 Thread GitBox
AmplabJenkins commented on pull request #28442: URL: https://github.com/apache/spark/pull/28442#issuecomment-623138464 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] yaooqinn commented on pull request #28442: [SPARK-31631][TESTS] Fix test flakiness caused by MiniKdc which throw s 'address in use' BindException

2020-05-03 Thread GitBox
yaooqinn commented on pull request #28442: URL: https://github.com/apache/spark/pull/28442#issuecomment-623138426 cc @dongjoon-hyun @cloud-fan @maropu @HyukjinKwon, many thanks. This is an automated message from the Apache

[GitHub] [spark] akshatb1 commented on pull request #28258: [SPARK-31486] [CORE] spark.submit.waitAppCompletion flag to control spark-submit exit in Standalone Cluster Mode

2020-05-03 Thread GitBox
akshatb1 commented on pull request #28258: URL: https://github.com/apache/spark/pull/28258#issuecomment-623144460 > Oh, is there any simple test that can be added to verify it waits? I couldn't add any tests since the pollAndReportStatus method has System.exit() calls. Please let me

[GitHub] [spark] AmplabJenkins commented on pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

2020-05-03 Thread GitBox
AmplabJenkins commented on pull request #28370: URL: https://github.com/apache/spark/pull/28370#issuecomment-623157273 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

2020-05-03 Thread GitBox
SparkQA removed a comment on pull request #28370: URL: https://github.com/apache/spark/pull/28370#issuecomment-623134683 **[Test build #122233 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122233/testReport)** for PR 28370 at commit

[GitHub] [spark] MaxGekk commented on a change in pull request #28310: [SPARK-31527][SQL] date add/subtract interval only allow those day precision in ansi mode

2020-05-03 Thread GitBox
MaxGekk commented on a change in pull request #28310: URL: https://github.com/apache/spark/pull/28310#discussion_r419142759 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala ## @@ -618,6 +618,22 @@ object DateTimeUtils {

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28439: [SPARK-30119][WEBUI] Add Pagination Support to Streaming Page

2020-05-03 Thread GitBox
AmplabJenkins removed a comment on pull request #28439: URL: https://github.com/apache/spark/pull/28439#issuecomment-623120594 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28439: [SPARK-30119][WEBUI] Add Pagination Support to Streaming Page

2020-05-03 Thread GitBox
AmplabJenkins removed a comment on pull request #28439: URL: https://github.com/apache/spark/pull/28439#issuecomment-623120597 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA removed a comment on pull request #28439: [SPARK-30119][WEBUI] Add Pagination Support to Streaming Page

2020-05-03 Thread GitBox
SparkQA removed a comment on pull request #28439: URL: https://github.com/apache/spark/pull/28439#issuecomment-623117831 **[Test build #122231 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122231/testReport)** for PR 28439 at commit

[GitHub] [spark] MaxGekk commented on pull request #28440: [SPARK-31527][SQL][TESTS][FOLLOWUP] Fix the number of rows in `DateTimeBenchmark`

2020-05-03 Thread GitBox
MaxGekk commented on pull request #28440: URL: https://github.com/apache/spark/pull/28440#issuecomment-623121723 @cloud-fan @maropu @yaooqinn Please, review this PR. This is an automated message from the Apache Git Service.

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28420: [SPARK-31615][SQL] Pretty string output for sql method of RuntimeReplaceable expressions

2020-05-03 Thread GitBox
AmplabJenkins removed a comment on pull request #28420: URL: https://github.com/apache/spark/pull/28420#issuecomment-623125621 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

2020-05-03 Thread GitBox
SparkQA commented on pull request #28370: URL: https://github.com/apache/spark/pull/28370#issuecomment-623134683 **[Test build #122233 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122233/testReport)** for PR 28370 at commit

[GitHub] [spark] SparkQA commented on pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

2020-05-03 Thread GitBox
SparkQA commented on pull request #28370: URL: https://github.com/apache/spark/pull/28370#issuecomment-623157076 **[Test build #122233 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122233/testReport)** for PR 28370 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28435: [SPARK-31625][YARN] Unregister application from YARN RM outside the shutdown hook if it succeeds

2020-05-03 Thread GitBox
AmplabJenkins removed a comment on pull request #28435: URL: https://github.com/apache/spark/pull/28435#issuecomment-623170877 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28435: [SPARK-31625][YARN] Unregister application from YARN RM outside the shutdown hook if it succeeds

2020-05-03 Thread GitBox
AmplabJenkins removed a comment on pull request #28435: URL: https://github.com/apache/spark/pull/28435#issuecomment-623173494 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #28435: [SPARK-31625][YARN] Unregister application from YARN RM outside the shutdown hook if it succeeds

2020-05-03 Thread GitBox
SparkQA removed a comment on pull request #28435: URL: https://github.com/apache/spark/pull/28435#issuecomment-623170659 **[Test build #122235 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122235/testReport)** for PR 28435 at commit

[GitHub] [spark] SparkQA commented on pull request #28435: [SPARK-31625][YARN] Unregister application from YARN RM outside the shutdown hook if it succeeds

2020-05-03 Thread GitBox
SparkQA commented on pull request #28435: URL: https://github.com/apache/spark/pull/28435#issuecomment-623173446 **[Test build #122235 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122235/testReport)** for PR 28435 at commit

[GitHub] [spark] SparkQA commented on pull request #28434: [SPARK-31624] Fix SHOW TBLPROPERTIES for V2 tables that leverage the session catalog

2020-05-03 Thread GitBox
SparkQA commented on pull request #28434: URL: https://github.com/apache/spark/pull/28434#issuecomment-623182874 **[Test build #122236 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122236/testReport)** for PR 28434 at commit

[GitHub] [spark] xccui opened a new pull request #28444: [SPARK-31632][CORE][WEBUI] Make the ApplicationInfo always available when accessed

2020-05-03 Thread GitBox
xccui opened a new pull request #28444: URL: https://github.com/apache/spark/pull/28444 ### What changes were proposed in this pull request? This PR adds a while loop check for the `ApplicationInfo` returned in `AppStatusStore.applicationInfo()`. It eliminates the

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28443: [SPARK-31212][SQL][WIP] Fix Failure of casting the '1000-02-29' string to the date type

2020-05-03 Thread GitBox
AmplabJenkins removed a comment on pull request #28443: URL: https://github.com/apache/spark/pull/28443#issuecomment-623168421 Can one of the admins verify this patch? This is an automated message from the Apache Git

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28434: [SPARK-31624] Fix SHOW TBLPROPERTIES for V2 tables that leverage the session catalog

2020-05-03 Thread GitBox
AmplabJenkins removed a comment on pull request #28434: URL: https://github.com/apache/spark/pull/28434#issuecomment-623182098 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28434: [SPARK-31624] Fix SHOW TBLPROPERTIES for V2 tables that leverage the session catalog

2020-05-03 Thread GitBox
AmplabJenkins commented on pull request #28434: URL: https://github.com/apache/spark/pull/28434#issuecomment-623182098 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] maropu commented on a change in pull request #28442: [SPARK-31631][TESTS] Fix test flakiness caused by MiniKdc which throws 'address in use' BindException with retry

2020-05-03 Thread GitBox
maropu commented on a change in pull request #28442: URL: https://github.com/apache/spark/pull/28442#discussion_r419180458 ## File path: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaTestUtils.scala ## @@ -131,11 +132,33 @@ class KafkaTestUtils(

[GitHub] [spark] tianshizz opened a new pull request #28443: [SPARK-31212][SQL] Fix Failure of casting the '1000-02-29' string to the date type

2020-05-03 Thread GitBox
tianshizz opened a new pull request #28443: URL: https://github.com/apache/spark/pull/28443 ### What changes were proposed in this pull request? Use GregogianCalendar to replace LocalDate when computing days from epoch. This solves a problem where some date before the

[GitHub] [spark] SparkQA commented on pull request #28435: [SPARK-31625][YARN] Unregister application from YARN RM outside the shutdown hook if it succeeds

2020-05-03 Thread GitBox
SparkQA commented on pull request #28435: URL: https://github.com/apache/spark/pull/28435#issuecomment-623170659 **[Test build #122235 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122235/testReport)** for PR 28435 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28435: [SPARK-31625][YARN] Unregister application from YARN RM outside the shutdown hook if it succeeds

2020-05-03 Thread GitBox
AmplabJenkins commented on pull request #28435: URL: https://github.com/apache/spark/pull/28435#issuecomment-623170877 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] MaxGekk commented on a change in pull request #28310: [SPARK-31527][SQL] date add/subtract interval only allow those day precision in ansi mode

2020-05-03 Thread GitBox
MaxGekk commented on a change in pull request #28310: URL: https://github.com/apache/spark/pull/28310#discussion_r419154657 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala ## @@ -618,6 +618,22 @@ object DateTimeUtils {

[GitHub] [spark] MaxGekk commented on a change in pull request #28443: [SPARK-31212][SQL][WIP] Fix Failure of casting the '1000-02-29' string to the date type

2020-05-03 Thread GitBox
MaxGekk commented on a change in pull request #28443: URL: https://github.com/apache/spark/pull/28443#discussion_r419162505 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala ## @@ -205,6 +205,29 @@ object DateTimeUtils {

[GitHub] [spark] AmplabJenkins commented on pull request #28444: [SPARK-31632][CORE][WEBUI] Make the ApplicationInfo always available when accessed

2020-05-03 Thread GitBox
AmplabJenkins commented on pull request #28444: URL: https://github.com/apache/spark/pull/28444#issuecomment-623194303 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #28444: [SPARK-31632][CORE][WEBUI] Make the ApplicationInfo always available when accessed

2020-05-03 Thread GitBox
AmplabJenkins commented on pull request #28444: URL: https://github.com/apache/spark/pull/28444#issuecomment-623194443 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To

[GitHub] [spark] dongjoon-hyun commented on pull request #28390: [SPARK-27340][SS][TESTS][FOLLOW-UP] Rephrase API comments and simplify tests

2020-05-03 Thread GitBox
dongjoon-hyun commented on pull request #28390: URL: https://github.com/apache/spark/pull/28390#issuecomment-623202015 Thank you all. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] maropu commented on a change in pull request #28442: [SPARK-31631][TESTS] Fix test flakiness caused by MiniKdc which throws 'address in use' BindException with retry

2020-05-03 Thread GitBox
maropu commented on a change in pull request #28442: URL: https://github.com/apache/spark/pull/28442#discussion_r419180108 ## File path: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaTestUtils.scala ## @@ -131,11 +132,33 @@ class KafkaTestUtils(

[GitHub] [spark] yaooqinn commented on a change in pull request #28310: [SPARK-31527][SQL] date add/subtract interval only allow those day precision in ansi mode

2020-05-03 Thread GitBox
yaooqinn commented on a change in pull request #28310: URL: https://github.com/apache/spark/pull/28310#discussion_r419149213 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala ## @@ -618,6 +618,22 @@ object DateTimeUtils {

[GitHub] [spark] AmplabJenkins commented on pull request #28443: [SPARK-31212][SQL][WIP] Fix Failure of casting the '1000-02-29' string to the date type

2020-05-03 Thread GitBox
AmplabJenkins commented on pull request #28443: URL: https://github.com/apache/spark/pull/28443#issuecomment-623168421 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #28443: [SPARK-31212][SQL][WIP] Fix Failure of casting the '1000-02-29' string to the date type

2020-05-03 Thread GitBox
AmplabJenkins commented on pull request #28443: URL: https://github.com/apache/spark/pull/28443#issuecomment-623168603 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #28435: [SPARK-31625][YARN] Unregister application from YARN RM outside the shutdown hook if it succeeds

2020-05-03 Thread GitBox
AmplabJenkins commented on pull request #28435: URL: https://github.com/apache/spark/pull/28435#issuecomment-623173494 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] tianshizz commented on a change in pull request #28443: [SPARK-31212][SQL][WIP] Fix Failure of casting the '1000-02-29' string to the date type

2020-05-03 Thread GitBox
tianshizz commented on a change in pull request #28443: URL: https://github.com/apache/spark/pull/28443#discussion_r419164577 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala ## @@ -205,6 +205,29 @@ object DateTimeUtils {

[GitHub] [spark] MaxGekk commented on a change in pull request #28443: [SPARK-31212][SQL][WIP] Fix Failure of casting the '1000-02-29' string to the date type

2020-05-03 Thread GitBox
MaxGekk commented on a change in pull request #28443: URL: https://github.com/apache/spark/pull/28443#discussion_r419168264 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala ## @@ -205,6 +205,29 @@ object DateTimeUtils {

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28444: [SPARK-31632][CORE][WEBUI] Make the ApplicationInfo always available when accessed

2020-05-03 Thread GitBox
AmplabJenkins removed a comment on pull request #28444: URL: https://github.com/apache/spark/pull/28444#issuecomment-623194303 Can one of the admins verify this patch? This is an automated message from the Apache Git

[GitHub] [spark] tianshizz commented on a change in pull request #28443: [SPARK-31212][SQL][WIP] Fix Failure of casting the '1000-02-29' string to the date type

2020-05-03 Thread GitBox
tianshizz commented on a change in pull request #28443: URL: https://github.com/apache/spark/pull/28443#discussion_r419172503 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala ## @@ -205,6 +205,29 @@ object DateTimeUtils {

[GitHub] [spark] dilipbiswal commented on pull request #27803: [SPARK-31049][SQL] Support nested adjacent generators, e.g., explode(explode(v))

2020-05-03 Thread GitBox
dilipbiswal commented on pull request #27803: URL: https://github.com/apache/spark/pull/27803#issuecomment-623211354 Hi @maropu , currently we will be able use flatten and explode to achieve the same result ? Perhaps supporting nested generators will support more use cases. But a simple

[GitHub] [spark] felixcheung commented on pull request #28379: [SPARK-28040][SPARK-28070][R] Write type object s3

2020-05-03 Thread GitBox
felixcheung commented on pull request #28379: URL: https://github.com/apache/spark/pull/28379#issuecomment-623219437 I didn’t review but I recall something similar this to support glue like 2 or 3 years ago? This serde is very sensitive - we probably need (to add) a lot more tests on this

[GitHub] [spark] AmplabJenkins commented on pull request #28386: [SPARK-26199][SPARK-31517][R] fix strategy for handling ... names in mutate

2020-05-03 Thread GitBox
AmplabJenkins commented on pull request #28386: URL: https://github.com/apache/spark/pull/28386#issuecomment-623224566 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28386: [SPARK-26199][SPARK-31517][R] fix strategy for handling ... names in mutate

2020-05-03 Thread GitBox
AmplabJenkins removed a comment on pull request #28386: URL: https://github.com/apache/spark/pull/28386#issuecomment-623224566 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] MichaelChirico commented on pull request #28386: [SPARK-26199][SPARK-31517][R] fix strategy for handling ... names in mutate

2020-05-03 Thread GitBox
MichaelChirico commented on pull request #28386: URL: https://github.com/apache/spark/pull/28386#issuecomment-623224648 Thanks @felixcheung. both backports are directly from `base` R:

[GitHub] [spark] SparkQA commented on pull request #26624: [SPARK-8981][core][test-hadoop3.2][test-java11] Add MDC support in Executor

2020-05-03 Thread GitBox
SparkQA commented on pull request #26624: URL: https://github.com/apache/spark/pull/26624#issuecomment-623248724 **[Test build #122239 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122239/testReport)** for PR 26624 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #26624: [SPARK-8981][core][test-hadoop3.2][test-java11] Add MDC support in Executor

2020-05-03 Thread GitBox
AmplabJenkins removed a comment on pull request #26624: URL: https://github.com/apache/spark/pull/26624#issuecomment-621026766 Can one of the admins verify this patch? This is an automated message from the Apache Git

[GitHub] [spark] maropu edited a comment on pull request #27803: [SPARK-31049][SQL] Support nested adjacent generators, e.g., explode(explode(v))

2020-05-03 Thread GitBox
maropu edited a comment on pull request #27803: URL: https://github.com/apache/spark/pull/27803#issuecomment-623237474 Thanks for the sharing, @dilipbiswal. Yea, as you suggested above, I think now that `explode+flatten` looks fine for the most use cases and this PR makes the rule a bit

[GitHub] [spark] dongjoon-hyun commented on pull request #26624: [SPARK-8981][core][test-hadoop3.2][test-java11] Add MDC support in Executor

2020-05-03 Thread GitBox
dongjoon-hyun commented on pull request #26624: URL: https://github.com/apache/spark/pull/26624#issuecomment-623248068 Retest this please. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] dongjoon-hyun commented on pull request #26624: [SPARK-8981][core][test-hadoop3.2][test-java11] Add MDC support in Executor

2020-05-03 Thread GitBox
dongjoon-hyun commented on pull request #26624: URL: https://github.com/apache/spark/pull/26624#issuecomment-623248314 Hi, All. It would be great if we can verify this in JDK11 together. This is an automated message from

[GitHub] [spark] SparkQA removed a comment on pull request #28438: [SPARK-31267][SQL] Flaky test: WholeStageCodegenSparkSubmitSuite.Generated code on driver should not embed platform-specific constant

2020-05-03 Thread GitBox
SparkQA removed a comment on pull request #28438: URL: https://github.com/apache/spark/pull/28438#issuecomment-623225479 **[Test build #122238 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122238/testReport)** for PR 28438 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28438: [SPARK-31267][SQL] Flaky test: WholeStageCodegenSparkSubmitSuite.Generated code on driver should not embed platform-specific co

2020-05-03 Thread GitBox
AmplabJenkins removed a comment on pull request #28438: URL: https://github.com/apache/spark/pull/28438#issuecomment-623250310 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28438: [SPARK-31267][SQL] Flaky test: WholeStageCodegenSparkSubmitSuite.Generated code on driver should not embed platform-specific constant

2020-05-03 Thread GitBox
AmplabJenkins commented on pull request #28438: URL: https://github.com/apache/spark/pull/28438#issuecomment-623250310 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #28446: [SPARK-31633][BUILD] Upgrade SLF4J from 1.7.16 to 1.7.30

2020-05-03 Thread GitBox
AmplabJenkins commented on pull request #28446: URL: https://github.com/apache/spark/pull/28446#issuecomment-623254789 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28446: [SPARK-31633][BUILD] Upgrade SLF4J from 1.7.16 to 1.7.30

2020-05-03 Thread GitBox
SparkQA commented on pull request #28446: URL: https://github.com/apache/spark/pull/28446#issuecomment-623255917 **[Test build #122241 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122241/testReport)** for PR 28446 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28446: [SPARK-31633][BUILD] Upgrade SLF4J from 1.7.16 to 1.7.30

2020-05-03 Thread GitBox
AmplabJenkins removed a comment on pull request #28446: URL: https://github.com/apache/spark/pull/28446#issuecomment-623254789 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] kiszk opened a new pull request #28447: [MINOR][Doc] Fix typo in document and comments

2020-05-03 Thread GitBox
kiszk opened a new pull request #28447: URL: https://github.com/apache/spark/pull/28447 ### What changes were proposed in this pull request? Fixed typo in `docs` directory and in `project/MimaExcludes.scala` ### Why are the changes needed? Better readability of

[GitHub] [spark] dongjoon-hyun edited a comment on pull request #26624: [SPARK-8981][core][test-hadoop3.2][test-java11] Add MDC support in Executor

2020-05-03 Thread GitBox
dongjoon-hyun edited a comment on pull request #26624: URL: https://github.com/apache/spark/pull/26624#issuecomment-623258947 Although I didn't test this PR yet, MDC feature has been known to be broken on JDK9+. I made a PR to upgrade SLF4J first. Let's see. I hope we can update the

[GitHub] [spark] jalpan-randeri commented on a change in pull request #26585: [WIP][SPARK-25351][SQL][Python] Handle Pandas category type when converting from Python with Arrow

2020-05-03 Thread GitBox
jalpan-randeri commented on a change in pull request #26585: URL: https://github.com/apache/spark/pull/26585#discussion_r419219239 ## File path: python/pyspark/sql/tests/test_arrow.py ## @@ -415,6 +415,20 @@ def run_test(num_records, num_parts, max_records, use_delay=False):

[GitHub] [spark] jalpan-randeri commented on a change in pull request #26585: [WIP][SPARK-25351][SQL][Python] Handle Pandas category type when converting from Python with Arrow

2020-05-03 Thread GitBox
jalpan-randeri commented on a change in pull request #26585: URL: https://github.com/apache/spark/pull/26585#discussion_r419219194 ## File path: python/pyspark/sql/pandas/serializers.py ## @@ -155,7 +156,11 @@ def create_array(s, t): if t is not None and

[GitHub] [spark] jalpan-randeri commented on a change in pull request #26585: [WIP][SPARK-25351][SQL][Python] Handle Pandas category type when converting from Python with Arrow

2020-05-03 Thread GitBox
jalpan-randeri commented on a change in pull request #26585: URL: https://github.com/apache/spark/pull/26585#discussion_r419219147 ## File path: python/pyspark/sql/pandas/serializers.py ## @@ -155,7 +156,11 @@ def create_array(s, t): if t is not None and

[GitHub] [spark] maropu commented on pull request #28440: [SPARK-31527][SQL][TESTS][FOLLOWUP] Fix the number of rows in `DateTimeBenchmark`

2020-05-03 Thread GitBox
maropu commented on pull request #28440: URL: https://github.com/apache/spark/pull/28440#issuecomment-623212105 Thanks! Merged to master/3.0. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28443: [SPARK-31212][SQL][WIP] Fix Failure of casting the '1000-02-29' string to the date type

2020-05-03 Thread GitBox
HyukjinKwon commented on a change in pull request #28443: URL: https://github.com/apache/spark/pull/28443#discussion_r419182567 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala ## @@ -205,6 +205,29 @@ object DateTimeUtils {

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28430: [SPARK-31372][SQL][TEST][FOLLOW-UP] Improve ExpressionsSchemaSuite so that easy to track the diff.

2020-05-03 Thread GitBox
HyukjinKwon commented on a change in pull request #28430: URL: https://github.com/apache/spark/pull/28430#discussion_r419183476 ## File path: sql/core/src/test/scala/org/apache/spark/sql/ExpressionsSchemaSuite.scala ## @@ -156,14 +156,16 @@ class ExpressionsSchemaSuite

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28430: [SPARK-31372][SQL][TEST][FOLLOW-UP] Improve ExpressionsSchemaSuite so that easy to track the diff.

2020-05-03 Thread GitBox
HyukjinKwon commented on a change in pull request #28430: URL: https://github.com/apache/spark/pull/28430#discussion_r419183476 ## File path: sql/core/src/test/scala/org/apache/spark/sql/ExpressionsSchemaSuite.scala ## @@ -156,14 +156,16 @@ class ExpressionsSchemaSuite

[GitHub] [spark] maropu edited a comment on pull request #28438: [SPARK-31267][SQL] Flaky test: WholeStageCodegenSparkSubmitSuite.Generated code on driver should not embed platform-specific constant

2020-05-03 Thread GitBox
maropu edited a comment on pull request #28438: URL: https://github.com/apache/spark/pull/28438#issuecomment-623215783 Thanks for the work, @tianshizz . btw, have you checked a root cause of the flaky failure is just a timeout, e.g., from jenkins logs? If that's true, the fix looks fine.

[GitHub] [spark] maropu commented on pull request #28438: [SPARK-31267][SQL] Flaky test: WholeStageCodegenSparkSubmitSuite.Generated code on driver should not embed platform-specific constant

2020-05-03 Thread GitBox
maropu commented on pull request #28438: URL: https://github.com/apache/spark/pull/28438#issuecomment-623215783 Thanks for the work, @tianshizz . btw, have you checked a root cause of the flaky failure is just a timeout, e.g., from jenkins logs?

[GitHub] [spark] SparkQA removed a comment on pull request #28434: [SPARK-31624] Fix SHOW TBLPROPERTIES for V2 tables that leverage the session catalog

2020-05-03 Thread GitBox
SparkQA removed a comment on pull request #28434: URL: https://github.com/apache/spark/pull/28434#issuecomment-623182874 **[Test build #122236 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122236/testReport)** for PR 28434 at commit

[GitHub] [spark] SparkQA commented on pull request #28434: [SPARK-31624] Fix SHOW TBLPROPERTIES for V2 tables that leverage the session catalog

2020-05-03 Thread GitBox
SparkQA commented on pull request #28434: URL: https://github.com/apache/spark/pull/28434#issuecomment-623220371 **[Test build #122236 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122236/testReport)** for PR 28434 at commit

[GitHub] [spark] felixcheung commented on pull request #28386: [SPARK-26199][SPARK-31517][R] fix strategy for handling ... names in mutate

2020-05-03 Thread GitBox
felixcheung commented on pull request #28386: URL: https://github.com/apache/spark/pull/28386#issuecomment-623220355 Where is the code on deparse1 etc from? It might have license implication. I think backport.R is implicitly dependent on the alphabetical order of .R files, I’d

  1   2   3   >