gengliangwang commented on a change in pull request #28690:
URL: https://github.com/apache/spark/pull/28690#discussion_r433641562
##
File path: core/src/main/scala/org/apache/spark/ui/UIUtils.scala
##
@@ -292,6 +292,7 @@ private[spark] object UIUtils extends Logging {
AmplabJenkins commented on pull request #27366:
URL: https://github.com/apache/spark/pull/27366#issuecomment-637303297
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #27366:
URL: https://github.com/apache/spark/pull/27366#issuecomment-637303297
This is an automated message from the Apache Git Service.
To respond to the message, please log on
gatorsmile commented on pull request #27246:
URL: https://github.com/apache/spark/pull/27246#issuecomment-637319803
This PR has some legit test failures. Could you fix them?
This is an automated message from the Apache
gatorsmile commented on pull request #27246:
URL: https://github.com/apache/spark/pull/27246#issuecomment-637320181
cc @Ngone51 @jiangxb1987 can take a look at this?
This is an automated message from the Apache Git Service.
igreenfield commented on pull request #28629:
URL: https://github.com/apache/spark/pull/28629#issuecomment-637299078
@cloud-fan I think you are right, it can't be. so maybe we don't need to add
this as default.
This is an
gengliangwang commented on pull request #28690:
URL: https://github.com/apache/spark/pull/28690#issuecomment-637301679
@sarutak Does the bug exist in branch 3.0?
This is an automated message from the Apache Git Service.
To
sarutak commented on pull request #28690:
URL: https://github.com/apache/spark/pull/28690#issuecomment-637311750
@gengliangwang I've confirmed this bug exists in branch 3.0 too.
This is an automated message from the Apache
gengliangwang commented on pull request #28690:
URL: https://github.com/apache/spark/pull/28690#issuecomment-637312344
Then, let's merge to both master and 3.0 :)
This is an automated message from the Apache Git Service.
To
gatorsmile commented on pull request #27843:
URL: https://github.com/apache/spark/pull/27843#issuecomment-637323399
cc @Ngone51 @tgravescs
This is an automated message from the Apache Git Service.
To respond to the message,
SparkQA removed a comment on pull request #28697:
URL: https://github.com/apache/spark/pull/28697#issuecomment-637253029
**[Test build #123416 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123416/testReport)**
for PR 28697 at commit
SparkQA commented on pull request #28697:
URL: https://github.com/apache/spark/pull/28697#issuecomment-637334376
**[Test build #123416 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123416/testReport)**
for PR 28697 at commit
sarutak commented on a change in pull request #28690:
URL: https://github.com/apache/spark/pull/28690#discussion_r433638598
##
File path: core/src/main/scala/org/apache/spark/ui/UIUtils.scala
##
@@ -292,6 +292,7 @@ private[spark] object UIUtils extends Logging {
SparkQA removed a comment on pull request #27366:
URL: https://github.com/apache/spark/pull/27366#issuecomment-637199584
**[Test build #123408 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123408/testReport)**
for PR 27366 at commit
SparkQA commented on pull request #27366:
URL: https://github.com/apache/spark/pull/27366#issuecomment-637302319
**[Test build #123408 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123408/testReport)**
for PR 27366 at commit
xuanyuanking edited a comment on pull request #27627:
URL: https://github.com/apache/spark/pull/27627#issuecomment-637271156
> How about we merge it to master only first, and wait for the schema
incompatibility check to be done?
Agree.
> Just to avoid redundant efforts, have
sarutak commented on pull request #28690:
URL: https://github.com/apache/spark/pull/28690#issuecomment-637315623
Yeah, but #28627 isn't merged to `branch-3.0` so we need to back port it
first or open another PR for `branch-3.0` to back port this change without the
testcase.
gatorsmile commented on pull request #27598:
URL: https://github.com/apache/spark/pull/27598#issuecomment-637326327
cc @HyukjinKwon @vanzin @tgravescs
This is an automated message from the Apache Git Service.
To respond to
AngersZh commented on pull request #28490:
URL: https://github.com/apache/spark/pull/28490#issuecomment-637325327
cc @maropu Can you have a review ?
This is an automated message from the Apache Git Service.
To
sarutak commented on pull request #28690:
URL: https://github.com/apache/spark/pull/28690#issuecomment-637326056
Anyway, I'll open a PR for backporting #28627.
This is an automated message from the Apache Git Service.
To
AngersZh removed a comment on pull request #28490:
URL: https://github.com/apache/spark/pull/28490#issuecomment-626340051
gentle ping @cloud-fan
Another analyze bug, a little band-fix now, hope some good suggestion and
better place to fix this.
gengliangwang commented on pull request #28690:
URL: https://github.com/apache/spark/pull/28690#issuecomment-637330492
Awesome, let's merge this one after #28627 is backported
This is an automated message from the
AmplabJenkins removed a comment on pull request #28654:
URL: https://github.com/apache/spark/pull/28654#issuecomment-637335562
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
AmplabJenkins removed a comment on pull request #28697:
URL: https://github.com/apache/spark/pull/28697#issuecomment-637335627
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #28699:
URL: https://github.com/apache/spark/pull/28699#issuecomment-637335673
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #28696:
URL: https://github.com/apache/spark/pull/28696#issuecomment-637335317
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
AmplabJenkins commented on pull request #28692:
URL: https://github.com/apache/spark/pull/28692#issuecomment-637335864
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA removed a comment on pull request #28692:
URL: https://github.com/apache/spark/pull/28692#issuecomment-637227803
**[Test build #123413 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123413/testReport)**
for PR 28692 at commit
AmplabJenkins commented on pull request #27627:
URL: https://github.com/apache/spark/pull/27627#issuecomment-637335670
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins commented on pull request #28696:
URL: https://github.com/apache/spark/pull/28696#issuecomment-637335317
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #28692:
URL: https://github.com/apache/spark/pull/28692#issuecomment-637335200
**[Test build #123413 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123413/testReport)**
for PR 28692 at commit
AmplabJenkins commented on pull request #28686:
URL: https://github.com/apache/spark/pull/28686#issuecomment-637335430
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #28686:
URL: https://github.com/apache/spark/pull/28686#issuecomment-637335204
**[Test build #123418 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123418/testReport)**
for PR 28686 at commit
AmplabJenkins commented on pull request #28697:
URL: https://github.com/apache/spark/pull/28697#issuecomment-637335627
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA removed a comment on pull request #28686:
URL: https://github.com/apache/spark/pull/28686#issuecomment-637289802
**[Test build #123418 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123418/testReport)**
for PR 28686 at commit
AmplabJenkins removed a comment on pull request #28699:
URL: https://github.com/apache/spark/pull/28699#issuecomment-637335673
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
SparkQA removed a comment on pull request #28696:
URL: https://github.com/apache/spark/pull/28696#issuecomment-637295139
**[Test build #123420 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123420/testReport)**
for PR 28696 at commit
AmplabJenkins removed a comment on pull request #28686:
URL: https://github.com/apache/spark/pull/28686#issuecomment-637335430
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
SparkQA commented on pull request #27908:
URL: https://github.com/apache/spark/pull/27908#issuecomment-637335203
**[Test build #123412 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123412/testReport)**
for PR 27908 at commit
SparkQA commented on pull request #27627:
URL: https://github.com/apache/spark/pull/27627#issuecomment-637335199
**[Test build #123414 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123414/testReport)**
for PR 27627 at commit
SparkQA commented on pull request #28654:
URL: https://github.com/apache/spark/pull/28654#issuecomment-637335195
**[Test build #123415 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123415/testReport)**
for PR 28654 at commit
AmplabJenkins commented on pull request #28654:
URL: https://github.com/apache/spark/pull/28654#issuecomment-637335562
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #28699:
URL: https://github.com/apache/spark/pull/28699#issuecomment-637335206
**[Test build #123411 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123411/testReport)**
for PR 28699 at commit
AmplabJenkins removed a comment on pull request #27908:
URL: https://github.com/apache/spark/pull/27908#issuecomment-637336199
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
AmplabJenkins removed a comment on pull request #28692:
URL: https://github.com/apache/spark/pull/28692#issuecomment-637335881
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
yaooqinn commented on pull request #28692:
URL: https://github.com/apache/spark/pull/28692#issuecomment-637337298
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
yaooqinn commented on pull request #28692:
URL: https://github.com/apache/spark/pull/28692#issuecomment-637336891
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
viirya commented on pull request #28556:
URL: https://github.com/apache/spark/pull/28556#issuecomment-637336896
ping @cloud-fan @dongjoon-hyun
This is an automated message from the Apache Git Service.
To respond to the
AmplabJenkins commented on pull request #28692:
URL: https://github.com/apache/spark/pull/28692#issuecomment-637339913
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
MaxGekk commented on pull request #28696:
URL: https://github.com/apache/spark/pull/28696#issuecomment-637339865
jenkins, retest this, please
This is an automated message from the Apache Git Service.
To respond to the
cloud-fan commented on a change in pull request #28647:
URL: https://github.com/apache/spark/pull/28647#discussion_r433668494
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala
##
@@ -839,6 +839,19 @@ case class
SparkQA commented on pull request #28654:
URL: https://github.com/apache/spark/pull/28654#issuecomment-637342881
**[Test build #123423 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123423/testReport)**
for PR 28654 at commit
SparkQA commented on pull request #25840:
URL: https://github.com/apache/spark/pull/25840#issuecomment-637342888
**[Test build #123424 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123424/testReport)**
for PR 25840 at commit
SparkQA commented on pull request #28696:
URL: https://github.com/apache/spark/pull/28696#issuecomment-637342883
**[Test build #123422 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123422/testReport)**
for PR 28696 at commit
AmplabJenkins commented on pull request #28654:
URL: https://github.com/apache/spark/pull/28654#issuecomment-637343496
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins commented on pull request #25840:
URL: https://github.com/apache/spark/pull/25840#issuecomment-637343501
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins commented on pull request #28696:
URL: https://github.com/apache/spark/pull/28696#issuecomment-637343433
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
sarutak edited a comment on pull request #28702:
URL: https://github.com/apache/spark/pull/28702#issuecomment-637359385
CC: @gengliangwang @dongjoon-hyun
I've opened this PR in response to [the
discussion](https://github.com/apache/spark/pull/28690#issuecomment-637315623).
sarutak commented on pull request #28702:
URL: https://github.com/apache/spark/pull/28702#issuecomment-637359385
CC: @gengliangwang @dongjoon-hyun
I've open this PR in response to [the
discussion](https://github.com/apache/spark/pull/28690#issuecomment-637315623).
cloud-fan commented on a change in pull request #28645:
URL: https://github.com/apache/spark/pull/28645#discussion_r433673986
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##
@@ -2847,6 +2848,39 @@ class Analyzer(
}
}
AmplabJenkins commented on pull request #28702:
URL: https://github.com/apache/spark/pull/28702#issuecomment-637362304
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #28702:
URL: https://github.com/apache/spark/pull/28702#issuecomment-637361640
**[Test build #123425 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123425/testReport)**
for PR 28702 at commit
AmplabJenkins commented on pull request #28703:
URL: https://github.com/apache/spark/pull/28703#issuecomment-637376943
Can one of the admins verify this patch?
This is an automated message from the Apache Git Service.
To
AmplabJenkins removed a comment on pull request #28696:
URL: https://github.com/apache/spark/pull/28696#issuecomment-637335324
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
AmplabJenkins removed a comment on pull request #28686:
URL: https://github.com/apache/spark/pull/28686#issuecomment-637335438
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
AmplabJenkins commented on pull request #27908:
URL: https://github.com/apache/spark/pull/27908#issuecomment-637336186
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #27627:
URL: https://github.com/apache/spark/pull/27627#issuecomment-637335683
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
AmplabJenkins removed a comment on pull request #28654:
URL: https://github.com/apache/spark/pull/28654#issuecomment-637335571
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
AmplabJenkins removed a comment on pull request #28692:
URL: https://github.com/apache/spark/pull/28692#issuecomment-637335864
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
AmplabJenkins removed a comment on pull request #27908:
URL: https://github.com/apache/spark/pull/27908#issuecomment-637336186
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
SparkQA removed a comment on pull request #28699:
URL: https://github.com/apache/spark/pull/28699#issuecomment-637221536
**[Test build #123411 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123411/testReport)**
for PR 28699 at commit
SparkQA removed a comment on pull request #27908:
URL: https://github.com/apache/spark/pull/27908#issuecomment-637221473
**[Test build #123412 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123412/testReport)**
for PR 27908 at commit
SparkQA removed a comment on pull request #28654:
URL: https://github.com/apache/spark/pull/28654#issuecomment-637245241
**[Test build #123415 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123415/testReport)**
for PR 28654 at commit
SparkQA removed a comment on pull request #27627:
URL: https://github.com/apache/spark/pull/27627#issuecomment-637229956
**[Test build #123414 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123414/testReport)**
for PR 27627 at commit
AmplabJenkins removed a comment on pull request #27627:
URL: https://github.com/apache/spark/pull/27627#issuecomment-637335670
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
SparkQA commented on pull request #28696:
URL: https://github.com/apache/spark/pull/28696#issuecomment-637335205
**[Test build #123420 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123420/testReport)**
for PR 28696 at commit
viirya commented on pull request #28560:
URL: https://github.com/apache/spark/pull/28560#issuecomment-637336844
ping @cloud-fan @dongjoon-hyun
This is an automated message from the Apache Git Service.
To respond to the
SparkQA commented on pull request #28692:
URL: https://github.com/apache/spark/pull/28692#issuecomment-637339211
**[Test build #123421 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123421/testReport)**
for PR 28692 at commit
viirya commented on a change in pull request #28700:
URL: https://github.com/apache/spark/pull/28700#discussion_r433665567
##
File path: dev/create-release/release-tag.sh
##
@@ -24,7 +24,7 @@ function exit_with_usage {
local NAME=$(basename $0)
cat << EOF
usage: $NAME
maropu commented on pull request #28654:
URL: https://github.com/apache/spark/pull/28654#issuecomment-637340650
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
AmplabJenkins removed a comment on pull request #28699:
URL: https://github.com/apache/spark/pull/28699#issuecomment-637335687
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
AmplabJenkins removed a comment on pull request #28692:
URL: https://github.com/apache/spark/pull/28692#issuecomment-637339913
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins removed a comment on pull request #28696:
URL: https://github.com/apache/spark/pull/28696#issuecomment-637343444
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins removed a comment on pull request #28654:
URL: https://github.com/apache/spark/pull/28654#issuecomment-637343496
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins removed a comment on pull request #25840:
URL: https://github.com/apache/spark/pull/25840#issuecomment-637343501
This is an automated message from the Apache Git Service.
To respond to the message, please log on
cloud-fan commented on a change in pull request #28645:
URL: https://github.com/apache/spark/pull/28645#discussion_r433673640
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala
##
@@ -49,11 +52,19 @@ case class ScalaUDF(
cloud-fan commented on a change in pull request #28645:
URL: https://github.com/apache/spark/pull/28645#discussion_r433673986
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##
@@ -2847,6 +2848,39 @@ class Analyzer(
}
}
sarutak opened a new pull request #28702:
URL: https://github.com/apache/spark/pull/28702
### What changes were proposed in this pull request?
This PR backports the change of #28627 .
Some fixes for UI like #28690 should be merged to `branch-3.0` including
testcases so #28627 is
AmplabJenkins removed a comment on pull request #28702:
URL: https://github.com/apache/spark/pull/28702#issuecomment-637362304
This is an automated message from the Apache Git Service.
To respond to the message, please log on
advancedxy commented on a change in pull request #28308:
URL: https://github.com/apache/spark/pull/28308#discussion_r433696896
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/expressions/ExpressionInfoSuite.scala
##
@@ -0,0 +1,156 @@
+/*
+ * Licensed to the Apache
sathyaprakashg opened a new pull request #28703:
URL: https://github.com/apache/spark/pull/28703
### What changes were proposed in this pull request?
Add implicit cast option for SubtractTimestamps expression
### Why are the changes needed?
Currently, this statement is
AmplabJenkins removed a comment on pull request #28703:
URL: https://github.com/apache/spark/pull/28703#issuecomment-637376943
Can one of the admins verify this patch?
This is an automated message from the Apache Git
AmplabJenkins commented on pull request #28703:
URL: https://github.com/apache/spark/pull/28703#issuecomment-637377768
Can one of the admins verify this patch?
This is an automated message from the Apache Git Service.
To
HyukjinKwon commented on a change in pull request #28308:
URL: https://github.com/apache/spark/pull/28308#discussion_r433711518
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/expressions/ExpressionInfoSuite.scala
##
@@ -0,0 +1,156 @@
+/*
+ * Licensed to the Apache
akshatb1 commented on pull request #28258:
URL: https://github.com/apache/spark/pull/28258#issuecomment-637383391
Thanks, @Ngone51 for reviewing.
CC: @srowen @jiangxb1987 @prakharjain09
Could you kindly help in reviewing this PR?
akshatb1 edited a comment on pull request #28258:
URL: https://github.com/apache/spark/pull/28258#issuecomment-637383391
Thanks, @Ngone51 for reviewing. I have taken care of the last comment
(indentation) as well.
CC: @srowen @jiangxb1987 @prakharjain09
Could you kindly help in
maropu commented on a change in pull request #28308:
URL: https://github.com/apache/spark/pull/28308#discussion_r433711978
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/expressions/ExpressionInfoSuite.scala
##
@@ -0,0 +1,156 @@
+/*
+ * Licensed to the Apache
viirya opened a new pull request #28704:
URL: https://github.com/apache/spark/pull/28704
### What changes were proposed in this pull request?
This patch adds user-specified fold column support to `CrossValidator`. User
can assign fold numbers to dataset instead of
advancedxy commented on a change in pull request #28308:
URL: https://github.com/apache/spark/pull/28308#discussion_r433715996
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/expressions/ExpressionInfoSuite.scala
##
@@ -0,0 +1,156 @@
+/*
+ * Licensed to the Apache
SparkQA commented on pull request #28704:
URL: https://github.com/apache/spark/pull/28704#issuecomment-637390451
**[Test build #123426 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123426/testReport)**
for PR 28704 at commit
1 - 100 of 539 matches
Mail list logo