[GitHub] [spark] gengliangwang commented on a change in pull request #28690: [SPARK-31882][WEBUI] DAG-viz is not rendered correctly with pagination

2020-06-02 Thread GitBox
gengliangwang commented on a change in pull request #28690: URL: https://github.com/apache/spark/pull/28690#discussion_r433641562 ## File path: core/src/main/scala/org/apache/spark/ui/UIUtils.scala ## @@ -292,6 +292,7 @@ private[spark] object UIUtils extends Logging {

[GitHub] [spark] AmplabJenkins commented on pull request #27366: [SPARK-30648][SQL] Support filters pushdown in JSON datasource

2020-06-02 Thread GitBox
AmplabJenkins commented on pull request #27366: URL: https://github.com/apache/spark/pull/27366#issuecomment-637303297 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27366: [SPARK-30648][SQL] Support filters pushdown in JSON datasource

2020-06-02 Thread GitBox
AmplabJenkins removed a comment on pull request #27366: URL: https://github.com/apache/spark/pull/27366#issuecomment-637303297 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] gatorsmile commented on pull request #27246: [SPARK-30536][CORE][SQL] Sort-merge join operator spilling performance improvements

2020-06-02 Thread GitBox
gatorsmile commented on pull request #27246: URL: https://github.com/apache/spark/pull/27246#issuecomment-637319803 This PR has some legit test failures. Could you fix them?  This is an automated message from the Apache

[GitHub] [spark] gatorsmile commented on pull request #27246: [SPARK-30536][CORE][SQL] Sort-merge join operator spilling performance improvements

2020-06-02 Thread GitBox
gatorsmile commented on pull request #27246: URL: https://github.com/apache/spark/pull/27246#issuecomment-637320181 cc @Ngone51 @jiangxb1987 can take a look at this? This is an automated message from the Apache Git Service.

[GitHub] [spark] igreenfield commented on pull request #28629: [SPARK-31769] Add MDC support for driver threads

2020-06-02 Thread GitBox
igreenfield commented on pull request #28629: URL: https://github.com/apache/spark/pull/28629#issuecomment-637299078 @cloud-fan I think you are right, it can't be. so maybe we don't need to add this as default. This is an

[GitHub] [spark] gengliangwang commented on pull request #28690: [SPARK-31882][WEBUI] DAG-viz is not rendered correctly with pagination

2020-06-02 Thread GitBox
gengliangwang commented on pull request #28690: URL: https://github.com/apache/spark/pull/28690#issuecomment-637301679 @sarutak Does the bug exist in branch 3.0? This is an automated message from the Apache Git Service. To

[GitHub] [spark] sarutak commented on pull request #28690: [SPARK-31882][WEBUI] DAG-viz is not rendered correctly with pagination

2020-06-02 Thread GitBox
sarutak commented on pull request #28690: URL: https://github.com/apache/spark/pull/28690#issuecomment-637311750 @gengliangwang I've confirmed this bug exists in branch 3.0 too. This is an automated message from the Apache

[GitHub] [spark] gengliangwang commented on pull request #28690: [SPARK-31882][WEBUI] DAG-viz is not rendered correctly with pagination

2020-06-02 Thread GitBox
gengliangwang commented on pull request #28690: URL: https://github.com/apache/spark/pull/28690#issuecomment-637312344 Then, let's merge to both master and 3.0 :) This is an automated message from the Apache Git Service. To

[GitHub] [spark] gatorsmile commented on pull request #27843: [SPARK-31029] Avoid using global execution context in driver main thread for YarnSchedulerBackend

2020-06-02 Thread GitBox
gatorsmile commented on pull request #27843: URL: https://github.com/apache/spark/pull/27843#issuecomment-637323399 cc @Ngone51 @tgravescs This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] SparkQA removed a comment on pull request #28697: [SPARK-29150][CORE] Update RDD API for Stage level scheduling to be public

2020-06-02 Thread GitBox
SparkQA removed a comment on pull request #28697: URL: https://github.com/apache/spark/pull/28697#issuecomment-637253029 **[Test build #123416 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123416/testReport)** for PR 28697 at commit

[GitHub] [spark] SparkQA commented on pull request #28697: [SPARK-29150][CORE] Update RDD API for Stage level scheduling to be public

2020-06-02 Thread GitBox
SparkQA commented on pull request #28697: URL: https://github.com/apache/spark/pull/28697#issuecomment-637334376 **[Test build #123416 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123416/testReport)** for PR 28697 at commit

[GitHub] [spark] sarutak commented on a change in pull request #28690: [SPARK-31882][WEBUI] DAG-viz is not rendered correctly with pagination

2020-06-02 Thread GitBox
sarutak commented on a change in pull request #28690: URL: https://github.com/apache/spark/pull/28690#discussion_r433638598 ## File path: core/src/main/scala/org/apache/spark/ui/UIUtils.scala ## @@ -292,6 +292,7 @@ private[spark] object UIUtils extends Logging {

[GitHub] [spark] SparkQA removed a comment on pull request #27366: [SPARK-30648][SQL] Support filters pushdown in JSON datasource

2020-06-02 Thread GitBox
SparkQA removed a comment on pull request #27366: URL: https://github.com/apache/spark/pull/27366#issuecomment-637199584 **[Test build #123408 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123408/testReport)** for PR 27366 at commit

[GitHub] [spark] SparkQA commented on pull request #27366: [SPARK-30648][SQL] Support filters pushdown in JSON datasource

2020-06-02 Thread GitBox
SparkQA commented on pull request #27366: URL: https://github.com/apache/spark/pull/27366#issuecomment-637302319 **[Test build #123408 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123408/testReport)** for PR 27366 at commit

[GitHub] [spark] xuanyuanking edited a comment on pull request #27627: [SPARK-28067][SQL] Fix incorrect results for decimal aggregate sum by returning null on decimal overflow

2020-06-02 Thread GitBox
xuanyuanking edited a comment on pull request #27627: URL: https://github.com/apache/spark/pull/27627#issuecomment-637271156 > How about we merge it to master only first, and wait for the schema incompatibility check to be done? Agree. > Just to avoid redundant efforts, have

[GitHub] [spark] sarutak commented on pull request #28690: [SPARK-31882][WEBUI] DAG-viz is not rendered correctly with pagination

2020-06-02 Thread GitBox
sarutak commented on pull request #28690: URL: https://github.com/apache/spark/pull/28690#issuecomment-637315623 Yeah, but #28627 isn't merged to `branch-3.0` so we need to back port it first or open another PR for `branch-3.0` to back port this change without the testcase.

[GitHub] [spark] gatorsmile commented on pull request #27598: [SPARK-30845] Do not upload local pyspark archives for spark-submit on Yarn

2020-06-02 Thread GitBox
gatorsmile commented on pull request #27598: URL: https://github.com/apache/spark/pull/27598#issuecomment-637326327 cc @HyukjinKwon @vanzin @tgravescs This is an automated message from the Apache Git Service. To respond to

[GitHub] [spark] AngersZhuuuu commented on pull request #28490: [SPARK-31670][SQL]Struct Field in groupByExpr with CUBE

2020-06-02 Thread GitBox
AngersZh commented on pull request #28490: URL: https://github.com/apache/spark/pull/28490#issuecomment-637325327 cc @maropu Can you have a review ? This is an automated message from the Apache Git Service. To

[GitHub] [spark] sarutak commented on pull request #28690: [SPARK-31882][WEBUI] DAG-viz is not rendered correctly with pagination

2020-06-02 Thread GitBox
sarutak commented on pull request #28690: URL: https://github.com/apache/spark/pull/28690#issuecomment-637326056 Anyway, I'll open a PR for backporting #28627. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AngersZhuuuu removed a comment on pull request #28490: [SPARK-31670][SQL]Struct Field in groupByExpr with CUBE

2020-06-02 Thread GitBox
AngersZh removed a comment on pull request #28490: URL: https://github.com/apache/spark/pull/28490#issuecomment-626340051 gentle ping @cloud-fan Another analyze bug, a little band-fix now, hope some good suggestion and better place to fix this.

[GitHub] [spark] gengliangwang commented on pull request #28690: [SPARK-31882][WEBUI] DAG-viz is not rendered correctly with pagination

2020-06-02 Thread GitBox
gengliangwang commented on pull request #28690: URL: https://github.com/apache/spark/pull/28690#issuecomment-637330492 Awesome, let's merge this one after #28627 is backported  This is an automated message from the

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28654: [SPARK-31834][SQL]Improve error message for incompatible data types

2020-06-02 Thread GitBox
AmplabJenkins removed a comment on pull request #28654: URL: https://github.com/apache/spark/pull/28654#issuecomment-637335562 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28697: [SPARK-29150][CORE] Update RDD API for Stage level scheduling to be public

2020-06-02 Thread GitBox
AmplabJenkins removed a comment on pull request #28697: URL: https://github.com/apache/spark/pull/28697#issuecomment-637335627 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28699: [SPARK-31885][SQL][3.0] Fix filter push down for old millis timestamps to Parquet

2020-06-02 Thread GitBox
AmplabJenkins commented on pull request #28699: URL: https://github.com/apache/spark/pull/28699#issuecomment-637335673 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28696: [SPARK-31888][SQL] Support `java.time.Instant` in Parquet filter pushdown

2020-06-02 Thread GitBox
AmplabJenkins removed a comment on pull request #28696: URL: https://github.com/apache/spark/pull/28696#issuecomment-637335317 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #28692: [SPARK-31879][SQL] Using GB as default Locale for datetime formatters

2020-06-02 Thread GitBox
AmplabJenkins commented on pull request #28692: URL: https://github.com/apache/spark/pull/28692#issuecomment-637335864 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28692: [SPARK-31879][SQL] Using GB as default Locale for datetime formatters

2020-06-02 Thread GitBox
SparkQA removed a comment on pull request #28692: URL: https://github.com/apache/spark/pull/28692#issuecomment-637227803 **[Test build #123413 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123413/testReport)** for PR 28692 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #27627: [SPARK-28067][SQL] Fix incorrect results for decimal aggregate sum by returning null on decimal overflow

2020-06-02 Thread GitBox
AmplabJenkins commented on pull request #27627: URL: https://github.com/apache/spark/pull/27627#issuecomment-637335670 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #28696: [SPARK-31888][SQL] Support `java.time.Instant` in Parquet filter pushdown

2020-06-02 Thread GitBox
AmplabJenkins commented on pull request #28696: URL: https://github.com/apache/spark/pull/28696#issuecomment-637335317 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28692: [SPARK-31879][SQL] Using GB as default Locale for datetime formatters

2020-06-02 Thread GitBox
SparkQA commented on pull request #28692: URL: https://github.com/apache/spark/pull/28692#issuecomment-637335200 **[Test build #123413 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123413/testReport)** for PR 28692 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28686: [SPARK-31877][SQL]Avoid stats computation for Hive table

2020-06-02 Thread GitBox
AmplabJenkins commented on pull request #28686: URL: https://github.com/apache/spark/pull/28686#issuecomment-637335430 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28686: [SPARK-31877][SQL]Avoid stats computation for Hive table

2020-06-02 Thread GitBox
SparkQA commented on pull request #28686: URL: https://github.com/apache/spark/pull/28686#issuecomment-637335204 **[Test build #123418 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123418/testReport)** for PR 28686 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28697: [SPARK-29150][CORE] Update RDD API for Stage level scheduling to be public

2020-06-02 Thread GitBox
AmplabJenkins commented on pull request #28697: URL: https://github.com/apache/spark/pull/28697#issuecomment-637335627 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28686: [SPARK-31877][SQL]Avoid stats computation for Hive table

2020-06-02 Thread GitBox
SparkQA removed a comment on pull request #28686: URL: https://github.com/apache/spark/pull/28686#issuecomment-637289802 **[Test build #123418 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123418/testReport)** for PR 28686 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28699: [SPARK-31885][SQL][3.0] Fix filter push down for old millis timestamps to Parquet

2020-06-02 Thread GitBox
AmplabJenkins removed a comment on pull request #28699: URL: https://github.com/apache/spark/pull/28699#issuecomment-637335673 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA removed a comment on pull request #28696: [SPARK-31888][SQL] Support `java.time.Instant` in Parquet filter pushdown

2020-06-02 Thread GitBox
SparkQA removed a comment on pull request #28696: URL: https://github.com/apache/spark/pull/28696#issuecomment-637295139 **[Test build #123420 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123420/testReport)** for PR 28696 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28686: [SPARK-31877][SQL]Avoid stats computation for Hive table

2020-06-02 Thread GitBox
AmplabJenkins removed a comment on pull request #28686: URL: https://github.com/apache/spark/pull/28686#issuecomment-637335430 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA commented on pull request #27908: [SPARK-31000] Add ability to set table description via Catalog.createTable()

2020-06-02 Thread GitBox
SparkQA commented on pull request #27908: URL: https://github.com/apache/spark/pull/27908#issuecomment-637335203 **[Test build #123412 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123412/testReport)** for PR 27908 at commit

[GitHub] [spark] SparkQA commented on pull request #27627: [SPARK-28067][SQL] Fix incorrect results for decimal aggregate sum by returning null on decimal overflow

2020-06-02 Thread GitBox
SparkQA commented on pull request #27627: URL: https://github.com/apache/spark/pull/27627#issuecomment-637335199 **[Test build #123414 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123414/testReport)** for PR 27627 at commit

[GitHub] [spark] SparkQA commented on pull request #28654: [SPARK-31834][SQL]Improve error message for incompatible data types

2020-06-02 Thread GitBox
SparkQA commented on pull request #28654: URL: https://github.com/apache/spark/pull/28654#issuecomment-637335195 **[Test build #123415 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123415/testReport)** for PR 28654 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28654: [SPARK-31834][SQL]Improve error message for incompatible data types

2020-06-02 Thread GitBox
AmplabJenkins commented on pull request #28654: URL: https://github.com/apache/spark/pull/28654#issuecomment-637335562 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28699: [SPARK-31885][SQL][3.0] Fix filter push down for old millis timestamps to Parquet

2020-06-02 Thread GitBox
SparkQA commented on pull request #28699: URL: https://github.com/apache/spark/pull/28699#issuecomment-637335206 **[Test build #123411 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123411/testReport)** for PR 28699 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27908: [SPARK-31000] Add ability to set table description via Catalog.createTable()

2020-06-02 Thread GitBox
AmplabJenkins removed a comment on pull request #27908: URL: https://github.com/apache/spark/pull/27908#issuecomment-637336199 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28692: [SPARK-31879][SQL] Using GB as default Locale for datetime formatters

2020-06-02 Thread GitBox
AmplabJenkins removed a comment on pull request #28692: URL: https://github.com/apache/spark/pull/28692#issuecomment-637335881 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] yaooqinn commented on pull request #28692: [SPARK-31879][SQL] Using GB as default Locale for datetime formatters

2020-06-02 Thread GitBox
yaooqinn commented on pull request #28692: URL: https://github.com/apache/spark/pull/28692#issuecomment-637337298 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] yaooqinn commented on pull request #28692: [SPARK-31879][SQL] Using GB as default Locale for datetime formatters

2020-06-02 Thread GitBox
yaooqinn commented on pull request #28692: URL: https://github.com/apache/spark/pull/28692#issuecomment-637336891 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] viirya commented on pull request #28556: [SPARK-31736][SQL] Nested column aliasing for RepartitionByExpression/Join

2020-06-02 Thread GitBox
viirya commented on pull request #28556: URL: https://github.com/apache/spark/pull/28556#issuecomment-637336896 ping @cloud-fan @dongjoon-hyun This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] AmplabJenkins commented on pull request #28692: [SPARK-31879][SQL] Using GB as default Locale for datetime formatters

2020-06-02 Thread GitBox
AmplabJenkins commented on pull request #28692: URL: https://github.com/apache/spark/pull/28692#issuecomment-637339913 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] MaxGekk commented on pull request #28696: [SPARK-31888][SQL] Support `java.time.Instant` in Parquet filter pushdown

2020-06-02 Thread GitBox
MaxGekk commented on pull request #28696: URL: https://github.com/apache/spark/pull/28696#issuecomment-637339865 jenkins, retest this, please This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] cloud-fan commented on a change in pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

2020-06-02 Thread GitBox
cloud-fan commented on a change in pull request #28647: URL: https://github.com/apache/spark/pull/28647#discussion_r433668494 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ## @@ -839,6 +839,19 @@ case class

[GitHub] [spark] SparkQA commented on pull request #28654: [SPARK-31834][SQL]Improve error message for incompatible data types

2020-06-02 Thread GitBox
SparkQA commented on pull request #28654: URL: https://github.com/apache/spark/pull/28654#issuecomment-637342881 **[Test build #123423 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123423/testReport)** for PR 28654 at commit

[GitHub] [spark] SparkQA commented on pull request #25840: [SPARK-29166][SQL] Add parameters to limit the number of dynamic partitions for data source table

2020-06-02 Thread GitBox
SparkQA commented on pull request #25840: URL: https://github.com/apache/spark/pull/25840#issuecomment-637342888 **[Test build #123424 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123424/testReport)** for PR 25840 at commit

[GitHub] [spark] SparkQA commented on pull request #28696: [SPARK-31888][SQL] Support `java.time.Instant` in Parquet filter pushdown

2020-06-02 Thread GitBox
SparkQA commented on pull request #28696: URL: https://github.com/apache/spark/pull/28696#issuecomment-637342883 **[Test build #123422 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123422/testReport)** for PR 28696 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28654: [SPARK-31834][SQL]Improve error message for incompatible data types

2020-06-02 Thread GitBox
AmplabJenkins commented on pull request #28654: URL: https://github.com/apache/spark/pull/28654#issuecomment-637343496 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #25840: [SPARK-29166][SQL] Add parameters to limit the number of dynamic partitions for data source table

2020-06-02 Thread GitBox
AmplabJenkins commented on pull request #25840: URL: https://github.com/apache/spark/pull/25840#issuecomment-637343501 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #28696: [SPARK-31888][SQL] Support `java.time.Instant` in Parquet filter pushdown

2020-06-02 Thread GitBox
AmplabJenkins commented on pull request #28696: URL: https://github.com/apache/spark/pull/28696#issuecomment-637343433 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] sarutak edited a comment on pull request #28702: [SPARK-31756][WEBUI][3.0] Add real headless browser support for UI test

2020-06-02 Thread GitBox
sarutak edited a comment on pull request #28702: URL: https://github.com/apache/spark/pull/28702#issuecomment-637359385 CC: @gengliangwang @dongjoon-hyun I've opened this PR in response to [the discussion](https://github.com/apache/spark/pull/28690#issuecomment-637315623).

[GitHub] [spark] sarutak commented on pull request #28702: [SPARK-31756][WEBUI][3.0] Add real headless browser support for UI test

2020-06-02 Thread GitBox
sarutak commented on pull request #28702: URL: https://github.com/apache/spark/pull/28702#issuecomment-637359385 CC: @gengliangwang @dongjoon-hyun I've open this PR in response to [the discussion](https://github.com/apache/spark/pull/28690#issuecomment-637315623).

[GitHub] [spark] cloud-fan commented on a change in pull request #28645: [SPARK-31826][SQL] Support composed type of case class for typed Scala UDF

2020-06-02 Thread GitBox
cloud-fan commented on a change in pull request #28645: URL: https://github.com/apache/spark/pull/28645#discussion_r433673986 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -2847,6 +2848,39 @@ class Analyzer( } }

[GitHub] [spark] AmplabJenkins commented on pull request #28702: [SPARK-31756][WEBUI][3.0] Add real headless browser support for UI test

2020-06-02 Thread GitBox
AmplabJenkins commented on pull request #28702: URL: https://github.com/apache/spark/pull/28702#issuecomment-637362304 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28702: [SPARK-31756][WEBUI][3.0] Add real headless browser support for UI test

2020-06-02 Thread GitBox
SparkQA commented on pull request #28702: URL: https://github.com/apache/spark/pull/28702#issuecomment-637361640 **[Test build #123425 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123425/testReport)** for PR 28702 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28703: SPARK-29897 Add implicit cast for SubtractTimestamps

2020-06-02 Thread GitBox
AmplabJenkins commented on pull request #28703: URL: https://github.com/apache/spark/pull/28703#issuecomment-637376943 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28696: [SPARK-31888][SQL] Support `java.time.Instant` in Parquet filter pushdown

2020-06-02 Thread GitBox
AmplabJenkins removed a comment on pull request #28696: URL: https://github.com/apache/spark/pull/28696#issuecomment-637335324 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28686: [SPARK-31877][SQL]Avoid stats computation for Hive table

2020-06-02 Thread GitBox
AmplabJenkins removed a comment on pull request #28686: URL: https://github.com/apache/spark/pull/28686#issuecomment-637335438 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on pull request #27908: [SPARK-31000] Add ability to set table description via Catalog.createTable()

2020-06-02 Thread GitBox
AmplabJenkins commented on pull request #27908: URL: https://github.com/apache/spark/pull/27908#issuecomment-637336186 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27627: [SPARK-28067][SQL] Fix incorrect results for decimal aggregate sum by returning null on decimal overflow

2020-06-02 Thread GitBox
AmplabJenkins removed a comment on pull request #27627: URL: https://github.com/apache/spark/pull/27627#issuecomment-637335683 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28654: [SPARK-31834][SQL]Improve error message for incompatible data types

2020-06-02 Thread GitBox
AmplabJenkins removed a comment on pull request #28654: URL: https://github.com/apache/spark/pull/28654#issuecomment-637335571 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28692: [SPARK-31879][SQL] Using GB as default Locale for datetime formatters

2020-06-02 Thread GitBox
AmplabJenkins removed a comment on pull request #28692: URL: https://github.com/apache/spark/pull/28692#issuecomment-637335864 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27908: [SPARK-31000] Add ability to set table description via Catalog.createTable()

2020-06-02 Thread GitBox
AmplabJenkins removed a comment on pull request #27908: URL: https://github.com/apache/spark/pull/27908#issuecomment-637336186 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA removed a comment on pull request #28699: [SPARK-31885][SQL][3.0] Fix filter push down for old millis timestamps to Parquet

2020-06-02 Thread GitBox
SparkQA removed a comment on pull request #28699: URL: https://github.com/apache/spark/pull/28699#issuecomment-637221536 **[Test build #123411 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123411/testReport)** for PR 28699 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #27908: [SPARK-31000] Add ability to set table description via Catalog.createTable()

2020-06-02 Thread GitBox
SparkQA removed a comment on pull request #27908: URL: https://github.com/apache/spark/pull/27908#issuecomment-637221473 **[Test build #123412 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123412/testReport)** for PR 27908 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #28654: [SPARK-31834][SQL]Improve error message for incompatible data types

2020-06-02 Thread GitBox
SparkQA removed a comment on pull request #28654: URL: https://github.com/apache/spark/pull/28654#issuecomment-637245241 **[Test build #123415 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123415/testReport)** for PR 28654 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #27627: [SPARK-28067][SQL] Fix incorrect results for decimal aggregate sum by returning null on decimal overflow

2020-06-02 Thread GitBox
SparkQA removed a comment on pull request #27627: URL: https://github.com/apache/spark/pull/27627#issuecomment-637229956 **[Test build #123414 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123414/testReport)** for PR 27627 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27627: [SPARK-28067][SQL] Fix incorrect results for decimal aggregate sum by returning null on decimal overflow

2020-06-02 Thread GitBox
AmplabJenkins removed a comment on pull request #27627: URL: https://github.com/apache/spark/pull/27627#issuecomment-637335670 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA commented on pull request #28696: [SPARK-31888][SQL] Support `java.time.Instant` in Parquet filter pushdown

2020-06-02 Thread GitBox
SparkQA commented on pull request #28696: URL: https://github.com/apache/spark/pull/28696#issuecomment-637335205 **[Test build #123420 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123420/testReport)** for PR 28696 at commit

[GitHub] [spark] viirya commented on pull request #28560: [SPARK-27217][SQL] Nested column aliasing for more operators which can prune nested column

2020-06-02 Thread GitBox
viirya commented on pull request #28560: URL: https://github.com/apache/spark/pull/28560#issuecomment-637336844 ping @cloud-fan @dongjoon-hyun This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] SparkQA commented on pull request #28692: [SPARK-31879][SQL] Using GB as default Locale for datetime formatters

2020-06-02 Thread GitBox
SparkQA commented on pull request #28692: URL: https://github.com/apache/spark/pull/28692#issuecomment-637339211 **[Test build #123421 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123421/testReport)** for PR 28692 at commit

[GitHub] [spark] viirya commented on a change in pull request #28700: [SPARK-31860][BUILD] only push release tags on succes

2020-06-02 Thread GitBox
viirya commented on a change in pull request #28700: URL: https://github.com/apache/spark/pull/28700#discussion_r433665567 ## File path: dev/create-release/release-tag.sh ## @@ -24,7 +24,7 @@ function exit_with_usage { local NAME=$(basename $0) cat << EOF usage: $NAME

[GitHub] [spark] maropu commented on pull request #28654: [SPARK-31834][SQL]Improve error message for incompatible data types

2020-06-02 Thread GitBox
maropu commented on pull request #28654: URL: https://github.com/apache/spark/pull/28654#issuecomment-637340650 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28699: [SPARK-31885][SQL][3.0] Fix filter push down for old millis timestamps to Parquet

2020-06-02 Thread GitBox
AmplabJenkins removed a comment on pull request #28699: URL: https://github.com/apache/spark/pull/28699#issuecomment-637335687 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28692: [SPARK-31879][SQL] Using GB as default Locale for datetime formatters

2020-06-02 Thread GitBox
AmplabJenkins removed a comment on pull request #28692: URL: https://github.com/apache/spark/pull/28692#issuecomment-637339913 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28696: [SPARK-31888][SQL] Support `java.time.Instant` in Parquet filter pushdown

2020-06-02 Thread GitBox
AmplabJenkins removed a comment on pull request #28696: URL: https://github.com/apache/spark/pull/28696#issuecomment-637343444 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28654: [SPARK-31834][SQL]Improve error message for incompatible data types

2020-06-02 Thread GitBox
AmplabJenkins removed a comment on pull request #28654: URL: https://github.com/apache/spark/pull/28654#issuecomment-637343496 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #25840: [SPARK-29166][SQL] Add parameters to limit the number of dynamic partitions for data source table

2020-06-02 Thread GitBox
AmplabJenkins removed a comment on pull request #25840: URL: https://github.com/apache/spark/pull/25840#issuecomment-637343501 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] cloud-fan commented on a change in pull request #28645: [SPARK-31826][SQL] Support composed type of case class for typed Scala UDF

2020-06-02 Thread GitBox
cloud-fan commented on a change in pull request #28645: URL: https://github.com/apache/spark/pull/28645#discussion_r433673640 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala ## @@ -49,11 +52,19 @@ case class ScalaUDF(

[GitHub] [spark] cloud-fan commented on a change in pull request #28645: [SPARK-31826][SQL] Support composed type of case class for typed Scala UDF

2020-06-02 Thread GitBox
cloud-fan commented on a change in pull request #28645: URL: https://github.com/apache/spark/pull/28645#discussion_r433673986 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -2847,6 +2848,39 @@ class Analyzer( } }

[GitHub] [spark] sarutak opened a new pull request #28702: [SPARK-31756][WEBUI][3.0] Add real headless browser support for UI test

2020-06-02 Thread GitBox
sarutak opened a new pull request #28702: URL: https://github.com/apache/spark/pull/28702 ### What changes were proposed in this pull request? This PR backports the change of #28627 . Some fixes for UI like #28690 should be merged to `branch-3.0` including testcases so #28627 is

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28702: [SPARK-31756][WEBUI][3.0] Add real headless browser support for UI test

2020-06-02 Thread GitBox
AmplabJenkins removed a comment on pull request #28702: URL: https://github.com/apache/spark/pull/28702#issuecomment-637362304 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] advancedxy commented on a change in pull request #28308: [SPARK-31526][SQL][TESTS] Add a new test suite for ExpressionInfo

2020-06-02 Thread GitBox
advancedxy commented on a change in pull request #28308: URL: https://github.com/apache/spark/pull/28308#discussion_r433696896 ## File path: sql/core/src/test/scala/org/apache/spark/sql/expressions/ExpressionInfoSuite.scala ## @@ -0,0 +1,156 @@ +/* + * Licensed to the Apache

[GitHub] [spark] sathyaprakashg opened a new pull request #28703: SPARK-29897 Add implicit cast for SubtractTimestamps

2020-06-02 Thread GitBox
sathyaprakashg opened a new pull request #28703: URL: https://github.com/apache/spark/pull/28703 ### What changes were proposed in this pull request? Add implicit cast option for SubtractTimestamps expression ### Why are the changes needed? Currently, this statement is

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28703: SPARK-29897 Add implicit cast for SubtractTimestamps

2020-06-02 Thread GitBox
AmplabJenkins removed a comment on pull request #28703: URL: https://github.com/apache/spark/pull/28703#issuecomment-637376943 Can one of the admins verify this patch? This is an automated message from the Apache Git

[GitHub] [spark] AmplabJenkins commented on pull request #28703: SPARK-29897 Add implicit cast for SubtractTimestamps

2020-06-02 Thread GitBox
AmplabJenkins commented on pull request #28703: URL: https://github.com/apache/spark/pull/28703#issuecomment-637377768 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28308: [SPARK-31526][SQL][TESTS] Add a new test suite for ExpressionInfo

2020-06-02 Thread GitBox
HyukjinKwon commented on a change in pull request #28308: URL: https://github.com/apache/spark/pull/28308#discussion_r433711518 ## File path: sql/core/src/test/scala/org/apache/spark/sql/expressions/ExpressionInfoSuite.scala ## @@ -0,0 +1,156 @@ +/* + * Licensed to the Apache

[GitHub] [spark] akshatb1 commented on pull request #28258: [SPARK-31486] [CORE] spark.submit.waitAppCompletion flag to control spark-submit exit in Standalone Cluster Mode

2020-06-02 Thread GitBox
akshatb1 commented on pull request #28258: URL: https://github.com/apache/spark/pull/28258#issuecomment-637383391 Thanks, @Ngone51 for reviewing. CC: @srowen @jiangxb1987 @prakharjain09 Could you kindly help in reviewing this PR?

[GitHub] [spark] akshatb1 edited a comment on pull request #28258: [SPARK-31486] [CORE] spark.submit.waitAppCompletion flag to control spark-submit exit in Standalone Cluster Mode

2020-06-02 Thread GitBox
akshatb1 edited a comment on pull request #28258: URL: https://github.com/apache/spark/pull/28258#issuecomment-637383391 Thanks, @Ngone51 for reviewing. I have taken care of the last comment (indentation) as well. CC: @srowen @jiangxb1987 @prakharjain09 Could you kindly help in

[GitHub] [spark] maropu commented on a change in pull request #28308: [SPARK-31526][SQL][TESTS] Add a new test suite for ExpressionInfo

2020-06-02 Thread GitBox
maropu commented on a change in pull request #28308: URL: https://github.com/apache/spark/pull/28308#discussion_r433711978 ## File path: sql/core/src/test/scala/org/apache/spark/sql/expressions/ExpressionInfoSuite.scala ## @@ -0,0 +1,156 @@ +/* + * Licensed to the Apache

[GitHub] [spark] viirya opened a new pull request #28704: [SPARK-31777][ML] Add user-specified fold column to CrossValidator

2020-06-02 Thread GitBox
viirya opened a new pull request #28704: URL: https://github.com/apache/spark/pull/28704 ### What changes were proposed in this pull request? This patch adds user-specified fold column support to `CrossValidator`. User can assign fold numbers to dataset instead of

[GitHub] [spark] advancedxy commented on a change in pull request #28308: [SPARK-31526][SQL][TESTS] Add a new test suite for ExpressionInfo

2020-06-02 Thread GitBox
advancedxy commented on a change in pull request #28308: URL: https://github.com/apache/spark/pull/28308#discussion_r433715996 ## File path: sql/core/src/test/scala/org/apache/spark/sql/expressions/ExpressionInfoSuite.scala ## @@ -0,0 +1,156 @@ +/* + * Licensed to the Apache

[GitHub] [spark] SparkQA commented on pull request #28704: [SPARK-31777][ML] Add user-specified fold column to CrossValidator

2020-06-02 Thread GitBox
SparkQA commented on pull request #28704: URL: https://github.com/apache/spark/pull/28704#issuecomment-637390451 **[Test build #123426 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123426/testReport)** for PR 28704 at commit

  1   2   3   4   5   6   >