[GitHub] [spark] SparkQA removed a comment on pull request #28876: [SPARK-32038][SQL] NormalizeFloatingNumbers should also work on distinct aggregate

2020-06-20 Thread GitBox
SparkQA removed a comment on pull request #28876: URL: https://github.com/apache/spark/pull/28876#issuecomment-647053489 **[Test build #124328 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124328/testReport)** for PR 28876 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28876: [SPARK-32038][SQL] NormalizeFloatingNumbers should also work on distinct aggregate

2020-06-20 Thread GitBox
AmplabJenkins removed a comment on pull request #28876: URL: https://github.com/apache/spark/pull/28876#issuecomment-647072406 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28876: [SPARK-32038][SQL] NormalizeFloatingNumbers should also work on distinct aggregate

2020-06-20 Thread GitBox
AmplabJenkins commented on pull request #28876: URL: https://github.com/apache/spark/pull/28876#issuecomment-647072406 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28876: [SPARK-32038][SQL] NormalizeFloatingNumbers should also work on distinct aggregate

2020-06-20 Thread GitBox
SparkQA commented on pull request #28876: URL: https://github.com/apache/spark/pull/28876#issuecomment-647072192 **[Test build #124328 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124328/testReport)** for PR 28876 at commit

[GitHub] [spark] SparkQA commented on pull request #27246: [SPARK-30536][CORE][SQL] Sort-merge join operator spilling performance improvements

2020-06-20 Thread GitBox
SparkQA commented on pull request #27246: URL: https://github.com/apache/spark/pull/27246#issuecomment-647074298 **[Test build #124329 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124329/testReport)** for PR 27246 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #27246: [SPARK-30536][CORE][SQL] Sort-merge join operator spilling performance improvements

2020-06-20 Thread GitBox
SparkQA removed a comment on pull request #27246: URL: https://github.com/apache/spark/pull/27246#issuecomment-647066335 **[Test build #124329 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124329/testReport)** for PR 27246 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #27246: [SPARK-30536][CORE][SQL] Sort-merge join operator spilling performance improvements

2020-06-20 Thread GitBox
AmplabJenkins commented on pull request #27246: URL: https://github.com/apache/spark/pull/27246#issuecomment-647074366 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27246: [SPARK-30536][CORE][SQL] Sort-merge join operator spilling performance improvements

2020-06-20 Thread GitBox
AmplabJenkins removed a comment on pull request #27246: URL: https://github.com/apache/spark/pull/27246#issuecomment-647074367 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27246: [SPARK-30536][CORE][SQL] Sort-merge join operator spilling performance improvements

2020-06-20 Thread GitBox
AmplabJenkins removed a comment on pull request #27246: URL: https://github.com/apache/spark/pull/27246#issuecomment-647074366 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] rajatahujaatinmobi opened a new pull request #28880: [SPARK-32039][YARN][WEBUI][master] Adding Check to not to set UI port (spark.ui.port) property if mentioned explicitly

2020-06-20 Thread GitBox
rajatahujaatinmobi opened a new pull request #28880: URL: https://github.com/apache/spark/pull/28880 What changes were proposed in this pull request? When a Spark Job launched in Cluster mode with Yarn, Application Master sets spark.ui.port port to 0 which means Driver's web UI gets any

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28880: [SPARK-32039][YARN][WEBUI][master] Adding Check to not to set UI port (spark.ui.port) property if mentioned explicitly

2020-06-20 Thread GitBox
AmplabJenkins removed a comment on pull request #28880: URL: https://github.com/apache/spark/pull/28880#issuecomment-647077486 Can one of the admins verify this patch? This is an automated message from the Apache Git

[GitHub] [spark] AmplabJenkins commented on pull request #28880: [SPARK-32039][YARN][WEBUI][master] Adding Check to not to set UI port (spark.ui.port) property if mentioned explicitly

2020-06-20 Thread GitBox
AmplabJenkins commented on pull request #28880: URL: https://github.com/apache/spark/pull/28880#issuecomment-647077548 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #28880: [SPARK-32039][YARN][WEBUI][master] Adding Check to not to set UI port (spark.ui.port) property if mentioned explicitly

2020-06-20 Thread GitBox
AmplabJenkins commented on pull request #28880: URL: https://github.com/apache/spark/pull/28880#issuecomment-647077486 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To

[GitHub] [spark] yaooqinn commented on pull request #28870: [SPARK-32034][SQL][test-hive1.2] Port HIVE-14817: Shutdown the SessionManager timeoutChecker thread properly upon shutdown

2020-06-20 Thread GitBox
yaooqinn commented on pull request #28870: URL: https://github.com/apache/spark/pull/28870#issuecomment-647078801 @dongjoon-hyun thanks for the check! This is an automated message from the Apache Git Service. To respond to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28870: [SPARK-32034][SQL][test-hive1.2] Port HIVE-14817: Shutdown the SessionManager timeoutChecker thread properly upon shutdown

2020-06-20 Thread GitBox
AmplabJenkins removed a comment on pull request #28870: URL: https://github.com/apache/spark/pull/28870#issuecomment-647078787 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28870: [SPARK-32034][SQL][test-hive1.2] Port HIVE-14817: Shutdown the SessionManager timeoutChecker thread properly upon shutdown

2020-06-20 Thread GitBox
AmplabJenkins commented on pull request #28870: URL: https://github.com/apache/spark/pull/28870#issuecomment-647078787 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28870: [SPARK-32034][SQL][test-hive1.2] Port HIVE-14817: Shutdown the SessionManager timeoutChecker thread properly upon shutdown

2020-06-20 Thread GitBox
SparkQA commented on pull request #28870: URL: https://github.com/apache/spark/pull/28870#issuecomment-647079198 **[Test build #124331 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124331/testReport)** for PR 28870 at commit

[GitHub] [spark] maropu commented on pull request #27366: [SPARK-30648][SQL] Support filters pushdown in JSON datasource

2020-06-20 Thread GitBox
maropu commented on pull request #27366: URL: https://github.com/apache/spark/pull/27366#issuecomment-647079738 Looks nice work and I left some comments. This is an automated message from the Apache Git Service. To respond

[GitHub] [spark] maropu commented on a change in pull request #27366: [SPARK-30648][SQL] Support filters pushdown in JSON datasource

2020-06-20 Thread GitBox
maropu commented on a change in pull request #27366: URL: https://github.com/apache/spark/pull/27366#discussion_r443181394 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JsonFilters.scala ## @@ -0,0 +1,131 @@ +/* + * Licensed to the Apache

[GitHub] [spark] abellina commented on a change in pull request #28876: [SPARK-32038][SQL] NormalizeFloatingNumbers should also work on distinct aggregate

2020-06-20 Thread GitBox
abellina commented on a change in pull request #28876: URL: https://github.com/apache/spark/pull/28876#discussion_r443183186 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/AggUtils.scala ## @@ -148,7 +149,15 @@ object AggUtils { case ne:

[GitHub] [spark] SparkQA commented on pull request #28870: [SPARK-32034][SQL][test-hive1.2] Port HIVE-14817: Shutdown the SessionManager timeoutChecker thread properly upon shutdown

2020-06-20 Thread GitBox
SparkQA commented on pull request #28870: URL: https://github.com/apache/spark/pull/28870#issuecomment-647081271 **[Test build #124331 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124331/testReport)** for PR 28870 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #28870: [SPARK-32034][SQL][test-hive1.2] Port HIVE-14817: Shutdown the SessionManager timeoutChecker thread properly upon shutdown

2020-06-20 Thread GitBox
SparkQA removed a comment on pull request #28870: URL: https://github.com/apache/spark/pull/28870#issuecomment-647079198 **[Test build #124331 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124331/testReport)** for PR 28870 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28870: [SPARK-32034][SQL][test-hive1.2] Port HIVE-14817: Shutdown the SessionManager timeoutChecker thread properly upon shutdown

2020-06-20 Thread GitBox
AmplabJenkins removed a comment on pull request #28870: URL: https://github.com/apache/spark/pull/28870#issuecomment-647081318 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28870: [SPARK-32034][SQL][test-hive1.2] Port HIVE-14817: Shutdown the SessionManager timeoutChecker thread properly upon shutdown

2020-06-20 Thread GitBox
AmplabJenkins commented on pull request #28870: URL: https://github.com/apache/spark/pull/28870#issuecomment-647081318 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] prakharjain09 opened a new pull request #28881: [SPARK-32041][SQL] Fix Exchange reuse issues when subqueries are involved

2020-06-20 Thread GitBox
prakharjain09 opened a new pull request #28881: URL: https://github.com/apache/spark/pull/28881 ### What changes were proposed in this pull request? Create a single post-order rule for ReuseExchange and ReuseSubquery which traverses the plan in 1 single post order and replaces

[GitHub] [spark] AmplabJenkins commented on pull request #28881: [SPARK-32041][SQL] Fix Exchange reuse issues when subqueries are involved

2020-06-20 Thread GitBox
AmplabJenkins commented on pull request #28881: URL: https://github.com/apache/spark/pull/28881#issuecomment-647082454 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #28881: [SPARK-32041][SQL] Fix Exchange reuse issues when subqueries are involved

2020-06-20 Thread GitBox
AmplabJenkins commented on pull request #28881: URL: https://github.com/apache/spark/pull/28881#issuecomment-647082517 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28881: [SPARK-32041][SQL] Fix Exchange reuse issues when subqueries are involved

2020-06-20 Thread GitBox
AmplabJenkins removed a comment on pull request #28881: URL: https://github.com/apache/spark/pull/28881#issuecomment-647082454 Can one of the admins verify this patch? This is an automated message from the Apache Git

[GitHub] [spark] igreenfield edited a comment on pull request #28629: [SPARK-31769][CORE] Add MDC support for driver threads

2020-06-20 Thread GitBox
igreenfield edited a comment on pull request #28629: URL: https://github.com/apache/spark/pull/28629#issuecomment-647082690 @cloud-fan 1. Do you want an automatic test for that? that will run on each build? 1. that feature does not work with `setLocalProperty` it just takes the

[GitHub] [spark] igreenfield commented on pull request #28629: [SPARK-31769][CORE] Add MDC support for driver threads

2020-06-20 Thread GitBox
igreenfield commented on pull request #28629: URL: https://github.com/apache/spark/pull/28629#issuecomment-647082690 @cloud-fan do you want an automatic test for that? that will run on each build? This is an automated

[GitHub] [spark] maropu commented on a change in pull request #28863: [SPARK-31336][SQL] Support Oracle Kerberos login in JDBC connector

2020-06-20 Thread GitBox
maropu commented on a change in pull request #28863: URL: https://github.com/apache/spark/pull/28863#discussion_r443106215 ## File path: external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/OracleIntegrationSuite.scala ## @@ -32,35 +32,29 @@ import

[GitHub] [spark] SparkQA commented on pull request #28860: [SPARK-32002][SQL]Support ExtractValue from nested ArrayStruct

2020-06-20 Thread GitBox
SparkQA commented on pull request #28860: URL: https://github.com/apache/spark/pull/28860#issuecomment-646952841 **[Test build #124314 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124314/testReport)** for PR 28860 at commit

[GitHub] [spark] viirya opened a new pull request #28876: [SPARK-32038][SQL] NormalizeFloatingNumbers should also work on distinct aggregate

2020-06-20 Thread GitBox
viirya opened a new pull request #28876: URL: https://github.com/apache/spark/pull/28876 ### What changes were proposed in this pull request? This patch applies `NormalizeFloatingNumbers` to distinct aggregate to fix a regression of distinct aggregate on NaNs. ###

[GitHub] [spark] MaxGekk opened a new pull request #28878: [SPARK-32021][SQL][3.0] Increase precision of seconds and fractions of `make_interval`

2020-06-20 Thread GitBox
MaxGekk opened a new pull request #28878: URL: https://github.com/apache/spark/pull/28878 ### What changes were proposed in this pull request? Change precision of seconds and its fraction from 8 to 18 to be able to construct intervals of max allowed microseconds value (long). ###

[GitHub] [spark] MaxGekk commented on pull request #28873: [SPARK-32021][SQL] Increase precision of seconds and fractions of `make_interval`

2020-06-20 Thread GitBox
MaxGekk commented on pull request #28873: URL: https://github.com/apache/spark/pull/28873#issuecomment-646963674 @dongjoon-hyun This is the backport https://github.com/apache/spark/pull/28878 This is an automated message

[GitHub] [spark] AmplabJenkins commented on pull request #28856: [SPARK-31982][SQL]Function sequence doesn't handle date increments that cross DST

2020-06-20 Thread GitBox
AmplabJenkins commented on pull request #28856: URL: https://github.com/apache/spark/pull/28856#issuecomment-646965243 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28856: [SPARK-31982][SQL]Function sequence doesn't handle date increments that cross DST

2020-06-20 Thread GitBox
AmplabJenkins removed a comment on pull request #28856: URL: https://github.com/apache/spark/pull/28856#issuecomment-646965243 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28423: [SPARK-24266][k8s] Restart the watcher when we receive a version changed from k8s

2020-06-20 Thread GitBox
AmplabJenkins commented on pull request #28423: URL: https://github.com/apache/spark/pull/28423#issuecomment-646976784 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28423: [SPARK-24266][k8s] Restart the watcher when we receive a version changed from k8s

2020-06-20 Thread GitBox
AmplabJenkins removed a comment on pull request #28423: URL: https://github.com/apache/spark/pull/28423#issuecomment-646976784 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA commented on pull request #28423: [SPARK-24266][k8s] Restart the watcher when we receive a version changed from k8s

2020-06-20 Thread GitBox
SparkQA commented on pull request #28423: URL: https://github.com/apache/spark/pull/28423#issuecomment-646976759 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/28942/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28868: [SPARK-32029][SQL] Make active session null when application end

2020-06-20 Thread GitBox
AmplabJenkins removed a comment on pull request #28868: URL: https://github.com/apache/spark/pull/28868#issuecomment-646947829 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA removed a comment on pull request #28868: [SPARK-32029][SQL] Make active session null when application end

2020-06-20 Thread GitBox
SparkQA removed a comment on pull request #28868: URL: https://github.com/apache/spark/pull/28868#issuecomment-646937285 **[Test build #124312 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124312/testReport)** for PR 28868 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28868: [SPARK-32029][SQL] Make active session null when application end

2020-06-20 Thread GitBox
AmplabJenkins commented on pull request #28868: URL: https://github.com/apache/spark/pull/28868#issuecomment-646947826 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28868: [SPARK-32029][SQL] Make active session null when application end

2020-06-20 Thread GitBox
AmplabJenkins removed a comment on pull request #28868: URL: https://github.com/apache/spark/pull/28868#issuecomment-646947826 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA commented on pull request #28875: [SPARK-32030][SQL] Support unlimited MATCHED and NOT MATCHED clauses in MERGE INTO

2020-06-20 Thread GitBox
SparkQA commented on pull request #28875: URL: https://github.com/apache/spark/pull/28875#issuecomment-646951464 **[Test build #124306 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124306/testReport)** for PR 28875 at commit

[GitHub] [spark] maropu commented on a change in pull request #28863: [SPARK-31336][SQL] Support Oracle Kerberos login in JDBC connector

2020-06-20 Thread GitBox
maropu commented on a change in pull request #28863: URL: https://github.com/apache/spark/pull/28863#discussion_r443106703 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/jdbc/connection/OracleConnectionProviderSuite.scala ## @@ -0,0 +1,28 @@

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28840: [SPARK-31999][SQL] Add REFRESH FUNCTION command

2020-06-20 Thread GitBox
AmplabJenkins removed a comment on pull request #28840: URL: https://github.com/apache/spark/pull/28840#issuecomment-646955285 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28683: [SPARK-31875][SQL] Provide a option to disable user supplied Hints

2020-06-20 Thread GitBox
AmplabJenkins removed a comment on pull request #28683: URL: https://github.com/apache/spark/pull/28683#issuecomment-646955319 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28860: [SPARK-32002][SQL]Support ExtractValue from nested ArrayStruct

2020-06-20 Thread GitBox
AmplabJenkins removed a comment on pull request #28860: URL: https://github.com/apache/spark/pull/28860#issuecomment-646955216 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] dilipbiswal commented on pull request #28683: [SPARK-31875][SQL] Provide a option to disable user supplied Hints

2020-06-20 Thread GitBox
dilipbiswal commented on pull request #28683: URL: https://github.com/apache/spark/pull/28683#issuecomment-646955288 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] AmplabJenkins commented on pull request #28840: [SPARK-31999][SQL] Add REFRESH FUNCTION command

2020-06-20 Thread GitBox
AmplabJenkins commented on pull request #28840: URL: https://github.com/apache/spark/pull/28840#issuecomment-646955281 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #28853: [SPARK-32019][SQL] Add spark.sql.files.minPartitionNum config

2020-06-20 Thread GitBox
AmplabJenkins commented on pull request #28853: URL: https://github.com/apache/spark/pull/28853#issuecomment-646955301 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28840: [SPARK-31999][SQL] Add REFRESH FUNCTION command

2020-06-20 Thread GitBox
SparkQA removed a comment on pull request #28840: URL: https://github.com/apache/spark/pull/28840#issuecomment-646937314 **[Test build #124313 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124313/testReport)** for PR 28840 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28840: [SPARK-31999][SQL] Add REFRESH FUNCTION command

2020-06-20 Thread GitBox
AmplabJenkins removed a comment on pull request #28840: URL: https://github.com/apache/spark/pull/28840#issuecomment-646955281 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA commented on pull request #28683: [SPARK-31875][SQL] Provide a option to disable user supplied Hints

2020-06-20 Thread GitBox
SparkQA commented on pull request #28683: URL: https://github.com/apache/spark/pull/28683#issuecomment-646955345 **[Test build #124315 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124315/testReport)** for PR 28683 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #28853: [SPARK-32019][SQL] Add spark.sql.files.minPartitionNum config

2020-06-20 Thread GitBox
SparkQA removed a comment on pull request #28853: URL: https://github.com/apache/spark/pull/28853#issuecomment-646936144 **[Test build #124311 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124311/testReport)** for PR 28853 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #28683: [SPARK-31875][SQL] Provide a option to disable user supplied Hints

2020-06-20 Thread GitBox
SparkQA removed a comment on pull request #28683: URL: https://github.com/apache/spark/pull/28683#issuecomment-646930991 **[Test build #124310 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124310/testReport)** for PR 28683 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28853: [SPARK-32019][SQL] Add spark.sql.files.minPartitionNum config

2020-06-20 Thread GitBox
AmplabJenkins removed a comment on pull request #28853: URL: https://github.com/apache/spark/pull/28853#issuecomment-646955301 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #28860: [SPARK-32002][SQL]Support ExtractValue from nested ArrayStruct

2020-06-20 Thread GitBox
AmplabJenkins commented on pull request #28860: URL: https://github.com/apache/spark/pull/28860#issuecomment-646955214 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28840: [SPARK-31999][SQL] Add REFRESH FUNCTION command

2020-06-20 Thread GitBox
SparkQA commented on pull request #28840: URL: https://github.com/apache/spark/pull/28840#issuecomment-646955185 **[Test build #124313 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124313/testReport)** for PR 28840 at commit

[GitHub] [spark] SparkQA commented on pull request #28853: [SPARK-32019][SQL] Add spark.sql.files.minPartitionNum config

2020-06-20 Thread GitBox
SparkQA commented on pull request #28853: URL: https://github.com/apache/spark/pull/28853#issuecomment-646955189 **[Test build #124311 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124311/testReport)** for PR 28853 at commit

[GitHub] [spark] SparkQA commented on pull request #28860: [SPARK-32002][SQL]Support ExtractValue from nested ArrayStruct

2020-06-20 Thread GitBox
SparkQA commented on pull request #28860: URL: https://github.com/apache/spark/pull/28860#issuecomment-646955186 **[Test build #124314 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124314/testReport)** for PR 28860 at commit

[GitHub] [spark] SparkQA commented on pull request #28683: [SPARK-31875][SQL] Provide a option to disable user supplied Hints

2020-06-20 Thread GitBox
SparkQA commented on pull request #28683: URL: https://github.com/apache/spark/pull/28683#issuecomment-646955187 **[Test build #124310 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124310/testReport)** for PR 28683 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #28860: [SPARK-32002][SQL]Support ExtractValue from nested ArrayStruct

2020-06-20 Thread GitBox
SparkQA removed a comment on pull request #28860: URL: https://github.com/apache/spark/pull/28860#issuecomment-646952841 **[Test build #124314 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124314/testReport)** for PR 28860 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28683: [SPARK-31875][SQL] Provide a option to disable user supplied Hints

2020-06-20 Thread GitBox
AmplabJenkins commented on pull request #28683: URL: https://github.com/apache/spark/pull/28683#issuecomment-646955319 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28860: [SPARK-32002][SQL]Support ExtractValue from nested ArrayStruct

2020-06-20 Thread GitBox
AmplabJenkins removed a comment on pull request #28860: URL: https://github.com/apache/spark/pull/28860#issuecomment-646955214 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] maropu commented on a change in pull request #28863: [SPARK-31336][SQL] Support Oracle Kerberos login in JDBC connector

2020-06-20 Thread GitBox
maropu commented on a change in pull request #28863: URL: https://github.com/apache/spark/pull/28863#discussion_r443110503 ## File path: external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/OracleIntegrationSuite.scala ## @@ -32,35 +32,29 @@ import

[GitHub] [spark] AmplabJenkins commented on pull request #28877: [SPARK-31980][SQL][FOLLOW-UP]Function sequence() fails if start and end of range are equal dates

2020-06-20 Thread GitBox
AmplabJenkins commented on pull request #28877: URL: https://github.com/apache/spark/pull/28877#issuecomment-646958689 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To

[GitHub] [spark] maropu commented on a change in pull request #28863: [SPARK-31336][SQL] Support Oracle Kerberos login in JDBC connector

2020-06-20 Thread GitBox
maropu commented on a change in pull request #28863: URL: https://github.com/apache/spark/pull/28863#discussion_r443110374 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/connection/OracleConnectionProvider.scala ## @@ -0,0 +1,60 @@ +/* +

[GitHub] [spark] maropu commented on pull request #28863: [SPARK-31336][SQL] Support Oracle Kerberos login in JDBC connector

2020-06-20 Thread GitBox
maropu commented on pull request #28863: URL: https://github.com/apache/spark/pull/28863#issuecomment-646958790 Note: I've checked that `OracleIntegrationSuite` passed in my local Mac env. This is an automated message from

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28877: [SPARK-31980][SQL][FOLLOW-UP]Function sequence() fails if start and end of range are equal dates

2020-06-20 Thread GitBox
AmplabJenkins removed a comment on pull request #28877: URL: https://github.com/apache/spark/pull/28877#issuecomment-646958634 Can one of the admins verify this patch? This is an automated message from the Apache Git

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28877: [SPARK-31980][SQL][2.4] Function sequence() fails if start and end of range are equal dates

2020-06-20 Thread GitBox
AmplabJenkins removed a comment on pull request #28877: URL: https://github.com/apache/spark/pull/28877#issuecomment-646962662 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28877: [SPARK-31980][SQL][2.4] Function sequence() fails if start and end of range are equal dates

2020-06-20 Thread GitBox
AmplabJenkins commented on pull request #28877: URL: https://github.com/apache/spark/pull/28877#issuecomment-646962662 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #28878: [SPARK-32021][SQL][3.0] Increase precision of seconds and fractions of `make_interval`

2020-06-20 Thread GitBox
AmplabJenkins commented on pull request #28878: URL: https://github.com/apache/spark/pull/28878#issuecomment-646963932 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28878: [SPARK-32021][SQL][3.0] Increase precision of seconds and fractions of `make_interval`

2020-06-20 Thread GitBox
AmplabJenkins removed a comment on pull request #28878: URL: https://github.com/apache/spark/pull/28878#issuecomment-646963932 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #28856: [SPARK-31982][SQL]Function sequence doesn't handle date increments that cross DST

2020-06-20 Thread GitBox
SparkQA commented on pull request #28856: URL: https://github.com/apache/spark/pull/28856#issuecomment-646965123 **[Test build #124321 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124321/testReport)** for PR 28856 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28856: [SPARK-31982][SQL]Function sequence doesn't handle date increments that cross DST

2020-06-20 Thread GitBox
AmplabJenkins commented on pull request #28856: URL: https://github.com/apache/spark/pull/28856#issuecomment-646966671 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28856: [SPARK-31982][SQL]Function sequence doesn't handle date increments that cross DST

2020-06-20 Thread GitBox
SparkQA commented on pull request #28856: URL: https://github.com/apache/spark/pull/28856#issuecomment-646966550 **[Test build #124322 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124322/testReport)** for PR 28856 at commit

[GitHub] [spark] TJX2014 edited a comment on pull request #28877: [SPARK-31980][SQL][2.4] Function sequence() fails if start and end of range are equal dates

2020-06-20 Thread GitBox
TJX2014 edited a comment on pull request #28877: URL: https://github.com/apache/spark/pull/28877#issuecomment-646963359 > Is this not follow-up but backport, right? Yes, it is a backport. This is an automated message

[GitHub] [spark] SparkQA commented on pull request #28423: [SPARK-24266][k8s] Restart the watcher when we receive a version changed from k8s

2020-06-20 Thread GitBox
SparkQA commented on pull request #28423: URL: https://github.com/apache/spark/pull/28423#issuecomment-646969444 **[Test build #124323 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124323/testReport)** for PR 28423 at commit

[GitHub] [spark] SparkQA commented on pull request #28423: [SPARK-24266][k8s] Restart the watcher when we receive a version changed from k8s

2020-06-20 Thread GitBox
SparkQA commented on pull request #28423: URL: https://github.com/apache/spark/pull/28423#issuecomment-646970682 **[Test build #124323 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124323/testReport)** for PR 28423 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28423: [SPARK-24266][k8s] Restart the watcher when we receive a version changed from k8s

2020-06-20 Thread GitBox
AmplabJenkins removed a comment on pull request #28423: URL: https://github.com/apache/spark/pull/28423#issuecomment-646970708 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28423: [SPARK-24266][k8s] Restart the watcher when we receive a version changed from k8s

2020-06-20 Thread GitBox
AmplabJenkins commented on pull request #28423: URL: https://github.com/apache/spark/pull/28423#issuecomment-646970708 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28423: [SPARK-24266][k8s] Restart the watcher when we receive a version changed from k8s

2020-06-20 Thread GitBox
SparkQA removed a comment on pull request #28423: URL: https://github.com/apache/spark/pull/28423#issuecomment-646969444 **[Test build #124323 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124323/testReport)** for PR 28423 at commit

[GitHub] [spark] maropu commented on pull request #28804: [SPARK-31973][SQL] Add ability to disable Sort,Spill in Partial aggregation

2020-06-20 Thread GitBox
maropu commented on pull request #28804: URL: https://github.com/apache/spark/pull/28804#issuecomment-646973316 > When the cardinality of grouping column is close to the total number of records being processed, the sorting of data spilling to disk is not required, since it is kind of

[GitHub] [spark] SparkQA removed a comment on pull request #28683: [SPARK-31875][SQL] Provide a option to disable user supplied Hints

2020-06-20 Thread GitBox
SparkQA removed a comment on pull request #28683: URL: https://github.com/apache/spark/pull/28683#issuecomment-646955345 **[Test build #124315 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124315/testReport)** for PR 28683 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28683: [SPARK-31875][SQL] Provide a option to disable user supplied Hints

2020-06-20 Thread GitBox
AmplabJenkins commented on pull request #28683: URL: https://github.com/apache/spark/pull/28683#issuecomment-646984162 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28683: [SPARK-31875][SQL] Provide a option to disable user supplied Hints

2020-06-20 Thread GitBox
AmplabJenkins removed a comment on pull request #28683: URL: https://github.com/apache/spark/pull/28683#issuecomment-646984162 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] maropu commented on a change in pull request #28863: [SPARK-31336][SQL] Support Oracle Kerberos login in JDBC connector

2020-06-20 Thread GitBox
maropu commented on a change in pull request #28863: URL: https://github.com/apache/spark/pull/28863#discussion_r443105054 ## File path: external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/OracleIntegrationSuite.scala ## @@ -32,35 +32,29 @@ import

[GitHub] [spark] SparkQA commented on pull request #28868: [SPARK-32029][SQL] Make active session null when application end

2020-06-20 Thread GitBox
SparkQA commented on pull request #28868: URL: https://github.com/apache/spark/pull/28868#issuecomment-646947759 **[Test build #124312 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124312/testReport)** for PR 28868 at commit

[GitHub] [spark] maropu commented on a change in pull request #28863: [SPARK-31336][SQL] Support Oracle Kerberos login in JDBC connector

2020-06-20 Thread GitBox
maropu commented on a change in pull request #28863: URL: https://github.com/apache/spark/pull/28863#discussion_r443105104 ## File path: external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/OracleIntegrationSuite.scala ## @@ -69,6 +63,7 @@ class

[GitHub] [spark] AngersZhuuuu commented on pull request #28860: [SPARK-32002][SQL]Support ExtractValue from nested ArrayStruct

2020-06-20 Thread GitBox
AngersZh commented on pull request #28860: URL: https://github.com/apache/spark/pull/28860#issuecomment-646952561 Seems this way will change the schema, maybe we should add a new class to get multidimensional array form GetArrayStruct

[GitHub] [spark] SparkQA commented on pull request #28876: [SPARK-32038][SQL] NormalizeFloatingNumbers should also work on distinct aggregate

2020-06-20 Thread GitBox
SparkQA commented on pull request #28876: URL: https://github.com/apache/spark/pull/28876#issuecomment-646956695 **[Test build #124316 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124316/testReport)** for PR 28876 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28876: [SPARK-32038][SQL] NormalizeFloatingNumbers should also work on distinct aggregate

2020-06-20 Thread GitBox
AmplabJenkins removed a comment on pull request #28876: URL: https://github.com/apache/spark/pull/28876#issuecomment-646956822 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28876: [SPARK-32038][SQL] NormalizeFloatingNumbers should also work on distinct aggregate

2020-06-20 Thread GitBox
AmplabJenkins commented on pull request #28876: URL: https://github.com/apache/spark/pull/28876#issuecomment-646956822 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] maropu commented on a change in pull request #28863: [SPARK-31336][SQL] Support Oracle Kerberos login in JDBC connector

2020-06-20 Thread GitBox
maropu commented on a change in pull request #28863: URL: https://github.com/apache/spark/pull/28863#discussion_r443109663 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/connection/OracleConnectionProvider.scala ## @@ -0,0 +1,60 @@ +/* +

[GitHub] [spark] SparkQA commented on pull request #28853: [SPARK-32019][SQL] Add spark.sql.files.minPartitionNum config

2020-06-20 Thread GitBox
SparkQA commented on pull request #28853: URL: https://github.com/apache/spark/pull/28853#issuecomment-646959284 **[Test build #124317 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124317/testReport)** for PR 28853 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28853: [SPARK-32019][SQL] Add spark.sql.files.minPartitionNum config

2020-06-20 Thread GitBox
AmplabJenkins commented on pull request #28853: URL: https://github.com/apache/spark/pull/28853#issuecomment-646959404 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28853: [SPARK-32019][SQL] Add spark.sql.files.minPartitionNum config

2020-06-20 Thread GitBox
AmplabJenkins removed a comment on pull request #28853: URL: https://github.com/apache/spark/pull/28853#issuecomment-646959404 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] maropu commented on pull request #28877: [SPARK-31980][SQL][FOLLOW-UP]Function sequence() fails if start and end of range are equal dates

2020-06-20 Thread GitBox
maropu commented on pull request #28877: URL: https://github.com/apache/spark/pull/28877#issuecomment-646962158 Is this not follow-up but backport, right? This is an automated message from the Apache Git Service. To respond

  1   2   3   >