dongjoon-hyun opened a new pull request #29293:
URL: https://github.com/apache/spark/pull/29293
…
### What changes were proposed in this pull request?
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
ueshin opened a new pull request #29294:
URL: https://github.com/apache/spark/pull/29294
### What changes were proposed in this pull request?
This is a backport of #29278, but with allowing to create `SparkContext` in
executors by default.
This PR adds configs to switch
AmplabJenkins commented on pull request #29211:
URL: https://github.com/apache/spark/pull/29211#issuecomment-665973679
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
dongjoon-hyun opened a new pull request #29295:
URL: https://github.com/apache/spark/pull/29295
### What changes were proposed in this pull request?
This PR aims to recover Java 11 build in `GitHub Action`.
### Why are the changes needed?
This test coverage is removed
AmplabJenkins removed a comment on pull request #29278:
URL: https://github.com/apache/spark/pull/29278#issuecomment-665971227
This is an automated message from the Apache Git Service.
To respond to the message, please log on
SparkQA commented on pull request #29067:
URL: https://github.com/apache/spark/pull/29067#issuecomment-665827301
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
WinkerDu commented on pull request #29000:
URL: https://github.com/apache/spark/pull/29000#issuecomment-666098220
Gentle ping @Ngone51 for further review, thanks :)
This is an automated message from the Apache Git Service.
c21 commented on a change in pull request #29277:
URL: https://github.com/apache/spark/pull/29277#discussion_r462677816
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashJoin.scala
##
@@ -316,6 +318,387 @@ trait HashJoin extends BaseJoinExec {
SparkQA commented on pull request #29283:
URL: https://github.com/apache/spark/pull/29283#issuecomment-666047693
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
AmplabJenkins removed a comment on pull request #29276:
URL: https://github.com/apache/spark/pull/29276#issuecomment-665903672
This is an automated message from the Apache Git Service.
To respond to the message, please log on
dongjoon-hyun closed pull request #29295:
URL: https://github.com/apache/spark/pull/29295
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
yaooqinn commented on pull request #29297:
URL: https://github.com/apache/spark/pull/29297#issuecomment-666151668
cc @gatorsmile @cloud-fan @dongjoon-hyun @maropu thanks very much.
This is an automated message from the
maropu commented on a change in pull request #29146:
URL: https://github.com/apache/spark/pull/29146#discussion_r462610033
##
File path:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##
@@ -244,11 +258,31 @@ statement
| SET TIME ZONE
SparkQA commented on pull request #29291:
URL: https://github.com/apache/spark/pull/29291#issuecomment-666042867
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
dot-vlad commented on pull request #25575:
URL: https://github.com/apache/spark/pull/25575#issuecomment-665931156
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
zhengruifeng commented on pull request #29255:
URL: https://github.com/apache/spark/pull/29255#issuecomment-666060052
Thanks for reviewing! @huaxingao @srowen
This is an automated message from the Apache Git Service.
To
AmplabJenkins removed a comment on pull request #29283:
URL: https://github.com/apache/spark/pull/29283#issuecomment-666050070
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins removed a comment on pull request #29294:
URL: https://github.com/apache/spark/pull/29294#issuecomment-665989640
This is an automated message from the Apache Git Service.
To respond to the message, please log on
yaooqinn opened a new pull request #29297:
URL: https://github.com/apache/spark/pull/29297
### What changes were proposed in this pull request?
This followup addresses comments from
https://github.com/apache/spark/pull/29202#discussion_r462054784
1. make RESET static
HyukjinKwon commented on a change in pull request #29283:
URL: https://github.com/apache/spark/pull/29283#discussion_r462692911
##
File path: docs/sparkr.md
##
@@ -681,12 +681,12 @@ The current supported minimum version is 1.0.0; however,
this might change betwe
Arrow
holdenk commented on a change in pull request #29211:
URL: https://github.com/apache/spark/pull/29211#discussion_r462638989
##
File path:
core/src/main/scala/org/apache/spark/executor/CoarseGrainedExecutorBackend.scala
##
@@ -277,12 +282,52 @@ private[spark] class
AmplabJenkins removed a comment on pull request #29295:
URL: https://github.com/apache/spark/pull/29295#issuecomment-665995022
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins removed a comment on pull request #29277:
URL: https://github.com/apache/spark/pull/29277#issuecomment-666020525
This is an automated message from the Apache Git Service.
To respond to the message, please log on
maryannxue commented on a change in pull request #29276:
URL: https://github.com/apache/spark/pull/29276#discussion_r462650727
##
File path: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala
##
@@ -695,7 +696,7 @@ private[spark] class TaskSetManager(
def
SparkQA removed a comment on pull request #29262:
URL: https://github.com/apache/spark/pull/29262#issuecomment-665703985
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #29277:
URL: https://github.com/apache/spark/pull/29277#issuecomment-666019778
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
LuciferYang opened a new pull request #29299:
URL: https://github.com/apache/spark/pull/29299
### What changes were proposed in this pull request?
This PR aims to bring the bug fixes from the latest netty version.
### Why are the changes needed?
- 4.1.48.Final:
SparkQA removed a comment on pull request #29293:
URL: https://github.com/apache/spark/pull/29293#issuecomment-665941955
**[Test build #126787 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126787/testReport)**
for PR 29293 at commit
viirya commented on a change in pull request #29276:
URL: https://github.com/apache/spark/pull/29276#discussion_r462618883
##
File path: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala
##
@@ -695,7 +696,7 @@ private[spark] class TaskSetManager(
def
cloud-fan commented on a change in pull request #29297:
URL: https://github.com/apache/spark/pull/29297#discussion_r462773434
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala
##
@@ -142,9 +142,12 @@ class SQLConfSuite extends QueryTest
AmplabJenkins removed a comment on pull request #29262:
URL: https://github.com/apache/spark/pull/29262#issuecomment-665850566
This is an automated message from the Apache Git Service.
To respond to the message, please log on
cloud-fan commented on a change in pull request #29146:
URL: https://github.com/apache/spark/pull/29146#discussion_r462761942
##
File path:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##
@@ -244,11 +258,31 @@ statement
| SET TIME ZONE
gatorsmile commented on a change in pull request #29146:
URL: https://github.com/apache/spark/pull/29146#discussion_r462777127
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/SparkSqlParserSuite.scala
##
@@ -61,6 +63,64 @@ class SparkSqlParserSuite
SparkQA commented on pull request #29278:
URL: https://github.com/apache/spark/pull/29278#issuecomment-665970816
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
cloud-fan commented on pull request #29296:
URL: https://github.com/apache/spark/pull/29296#issuecomment-666201062
thanks, merging to master!
This is an automated message from the Apache Git Service.
To respond to the
cloud-fan closed pull request #29296:
URL: https://github.com/apache/spark/pull/29296
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
SparkQA removed a comment on pull request #29234:
URL: https://github.com/apache/spark/pull/29234#issuecomment-665941972
**[Test build #126788 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126788/testReport)**
for PR 29234 at commit
cloud-fan closed pull request #29234:
URL: https://github.com/apache/spark/pull/29234
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
viirya commented on pull request #29283:
URL: https://github.com/apache/spark/pull/29283#issuecomment-666050771
LGTM
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
HyukjinKwon commented on a change in pull request #29298:
URL: https://github.com/apache/spark/pull/29298#discussion_r462787946
##
File path:
core/src/test/scala/org/apache/spark/deploy/rest/SubmitRestProtocolSuite.scala
##
@@ -258,6 +260,33 @@ class SubmitRestProtocolSuite
AmplabJenkins removed a comment on pull request #29291:
URL: https://github.com/apache/spark/pull/29291#issuecomment-666043783
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #29277:
URL: https://github.com/apache/spark/pull/29277#issuecomment-666020525
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
c21 commented on pull request #29277:
URL: https://github.com/apache/spark/pull/29277#issuecomment-666027985
@cloud-fan - updated the PR with addressing comments, and it is ready for
review. Also updated the PR description for latest codegen code of example
query. Thanks.
Ngone51 commented on a change in pull request #29270:
URL: https://github.com/apache/spark/pull/29270#discussion_r462769211
##
File path: sql/core/src/test/scala/org/apache/spark/sql/PlanStabilitySuite.scala
##
@@ -0,0 +1,306 @@
+/*
+ * Licensed to the Apache Software
HyukjinKwon commented on pull request #29300:
URL: https://github.com/apache/spark/pull/29300#issuecomment-666201596
The fix here should partially fix the build when R is not needed. Looks it
fails when R is needed too, for example, at
maropu commented on pull request #29296:
URL: https://github.com/apache/spark/pull/29296#issuecomment-666201603
Thanks!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
leanken opened a new pull request #29301:
URL: https://github.com/apache/spark/pull/29301
### What changes were proposed in this pull request?
This is a follow up issue of
[SPARK-32290](https://issues.apache.org/jira/browse/SPARK-32290).
In SPARK-32290, We only support Single
AmplabJenkins commented on pull request #29291:
URL: https://github.com/apache/spark/pull/29291#issuecomment-666043783
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #29294:
URL: https://github.com/apache/spark/pull/29294#issuecomment-665989295
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
tgravescs commented on pull request #29262:
URL: https://github.com/apache/spark/pull/29262#issuecomment-665855971
I merged this to master, unfortunately wouldn't pick clean to branch-3.0.
@cloud-fan would you want to put up PR for branch-3.0? Otherwise Andy or
myself can.
cloud-fan closed pull request #29204:
URL: https://github.com/apache/spark/pull/29204
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
maropu edited a comment on pull request #29270:
URL: https://github.com/apache/spark/pull/29270#issuecomment-666012926
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins commented on pull request #29283:
URL: https://github.com/apache/spark/pull/29283#issuecomment-666050070
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #29234:
URL: https://github.com/apache/spark/pull/29234#issuecomment-665942755
This is an automated message from the Apache Git Service.
To respond to the message, please log on
maropu opened a new pull request #29296:
URL: https://github.com/apache/spark/pull/29296
### What changes were proposed in this pull request?
This PR aims to update `SqlBse.g4` for avoiding generating unused code.
Currently, ANTLR generates unused methods and variables;
zsxwing commented on a change in pull request #28986:
URL: https://github.com/apache/spark/pull/28986#discussion_r462679180
##
File path: core/src/main/scala/org/apache/spark/SparkContext.scala
##
@@ -2554,6 +2557,19 @@ object SparkContext extends Logging {
}
}
+
AmplabJenkins commented on pull request #29276:
URL: https://github.com/apache/spark/pull/29276#issuecomment-665903672
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins commented on pull request #28781:
URL: https://github.com/apache/spark/pull/28781#issuecomment-666049254
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
HyukjinKwon commented on pull request #29286:
URL: https://github.com/apache/spark/pull/29286#issuecomment-666020324
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
AmplabJenkins commented on pull request #29294:
URL: https://github.com/apache/spark/pull/29294#issuecomment-665989640
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins commented on pull request #29262:
URL: https://github.com/apache/spark/pull/29262#issuecomment-665850566
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #29211:
URL: https://github.com/apache/spark/pull/29211#issuecomment-665973326
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
SparkQA commented on pull request #28781:
URL: https://github.com/apache/spark/pull/28781#issuecomment-666048818
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
AmplabJenkins commented on pull request #29278:
URL: https://github.com/apache/spark/pull/29278#issuecomment-665971227
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
dongjoon-hyun closed pull request #29293:
URL: https://github.com/apache/spark/pull/29293
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
cloud-fan commented on a change in pull request #20176:
URL: https://github.com/apache/spark/pull/20176#discussion_r462767193
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
##
@@ -259,6 +259,29 @@ case class Cast(child:
cloud-fan commented on pull request #29262:
URL: https://github.com/apache/spark/pull/29262#issuecomment-666158610
Does it qualify a backport? It's kind of a new feature.
This is an automated message from the Apache Git
HyukjinKwon commented on pull request #29298:
URL: https://github.com/apache/spark/pull/29298#issuecomment-666170687
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
SparkQA removed a comment on pull request #29067:
URL: https://github.com/apache/spark/pull/29067#issuecomment-665690606
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
cchighman commented on pull request #28841:
URL: https://github.com/apache/spark/pull/28841#issuecomment-666133472
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
AmplabJenkins removed a comment on pull request #28781:
URL: https://github.com/apache/spark/pull/28781#issuecomment-666049254
This is an automated message from the Apache Git Service.
To respond to the message, please log on
attilapiros commented on pull request #29090:
URL: https://github.com/apache/spark/pull/29090#issuecomment-665952684
Thanks @holdenk for looking into this.
And what about logging out a warning when no unit is given?
Like:
"Memory setting without explicit unit (${value})
HyukjinKwon commented on pull request #29295:
URL: https://github.com/apache/spark/pull/29295#issuecomment-666014185
Thank you @dongjoon-hyun.
This is an automated message from the Apache Git Service.
To respond to the
huaxingao closed pull request #29255:
URL: https://github.com/apache/spark/pull/29255
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
SparkQA commented on pull request #29295:
URL: https://github.com/apache/spark/pull/29295#issuecomment-665994152
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
SparkQA removed a comment on pull request #29295:
URL: https://github.com/apache/spark/pull/29295#issuecomment-665994152
**[Test build #126795 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126795/testReport)**
for PR 29295 at commit
SparkQA removed a comment on pull request #28781:
URL: https://github.com/apache/spark/pull/28781#issuecomment-666048818
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
uncleGen commented on a change in pull request #28781:
URL: https://github.com/apache/spark/pull/28781#discussion_r462696730
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/StreamingQueryStatusStore.scala
##
@@ -0,0 +1,60 @@
+/*
+ * Licensed to the
HyukjinKwon closed pull request #28968:
URL: https://github.com/apache/spark/pull/28968
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
huaxingao commented on pull request #29255:
URL: https://github.com/apache/spark/pull/29255#issuecomment-666058041
Merged to master. Thanks @zhengruifeng @srowen
This is an automated message from the Apache Git Service.
To
dongjoon-hyun commented on a change in pull request #29298:
URL: https://github.com/apache/spark/pull/29298#discussion_r462780182
##
File path:
core/src/test/resources/HistoryServerExpectations/app_environment_expectation.json
##
@@ -5,283 +5,283 @@
"scalaVersion" :
dongjoon-hyun commented on pull request #29298:
URL: https://github.com/apache/spark/pull/29298#issuecomment-666169269
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA removed a comment on pull request #29276:
URL: https://github.com/apache/spark/pull/29276#issuecomment-665792999
**[Test build #126786 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126786/testReport)**
for PR 29276 at commit
SparkQA removed a comment on pull request #29283:
URL: https://github.com/apache/spark/pull/29283#issuecomment-666047693
**[Test build #126798 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126798/testReport)**
for PR 29283 at commit
holdenk commented on pull request #29274:
URL: https://github.com/apache/spark/pull/29274#issuecomment-665819306
Thanks @HyukjinKwon I've added that it impacts `maven deploy` to the
description.
This is an automated message
jiangxb1987 commented on pull request #29228:
URL: https://github.com/apache/spark/pull/29228#issuecomment-666137629
It would be really great if you can list the test cases/suites that could
get simplified by this change, thanks!
cloud-fan commented on pull request #29234:
URL: https://github.com/apache/spark/pull/29234#issuecomment-666142201
thanks, merging to master!
This is an automated message from the Apache Git Service.
To respond to the
maropu commented on a change in pull request #20176:
URL: https://github.com/apache/spark/pull/20176#discussion_r462636447
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
##
@@ -259,6 +259,29 @@ case class Cast(child: Expression,
HeartSaVioR removed a comment on pull request #29272:
URL: https://github.com/apache/spark/pull/29272#issuecomment-666160436
retest this, please
This is an automated message from the Apache Git Service.
To respond to the
viirya commented on a change in pull request #29234:
URL: https://github.com/apache/spark/pull/29234#discussion_r462557526
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/util/SchemaUtils.scala
##
@@ -42,7 +42,27 @@ private[spark] object SchemaUtils {
*/
SparkQA removed a comment on pull request #29277:
URL: https://github.com/apache/spark/pull/29277#issuecomment-666019778
**[Test build #126796 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126796/testReport)**
for PR 29277 at commit
cloud-fan commented on pull request #29270:
URL: https://github.com/apache/spark/pull/29270#issuecomment-666098964
One of my worries is that: this test generates plans with empty tables, and
we lost test coverage for things like SMJ. Can the `variant` feature help to
improve the test
dongjoon-hyun commented on pull request #29295:
URL: https://github.com/apache/spark/pull/29295#issuecomment-665994816
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
HyukjinKwon commented on a change in pull request #28986:
URL: https://github.com/apache/spark/pull/28986#discussion_r462673731
##
File path: core/src/main/scala/org/apache/spark/SparkContext.scala
##
@@ -2554,6 +2557,19 @@ object SparkContext extends Logging {
}
}
+
HeartSaVioR commented on pull request #29272:
URL: https://github.com/apache/spark/pull/29272#issuecomment-666158718
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
AmplabJenkins removed a comment on pull request #29296:
URL: https://github.com/apache/spark/pull/29296#issuecomment-666050019
This is an automated message from the Apache Git Service.
To respond to the message, please log on
SparkQA commented on pull request #29146:
URL: https://github.com/apache/spark/pull/29146#issuecomment-665949787
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
AmplabJenkins commented on pull request #29234:
URL: https://github.com/apache/spark/pull/29234#issuecomment-665942755
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
holdenk commented on pull request #29090:
URL: https://github.com/apache/spark/pull/29090#issuecomment-665972368
That sounds good to me.
This is an automated message from the Apache Git Service.
To respond to the message,
viirya commented on a change in pull request #29283:
URL: https://github.com/apache/spark/pull/29283#discussion_r462682167
##
File path: docs/sparkr.md
##
@@ -681,12 +681,12 @@ The current supported minimum version is 1.0.0; however,
this might change betwe
Arrow
1 - 100 of 776 matches
Mail list logo