[GitHub] [spark] viirya commented on a change in pull request #25965: [SPARK-26425][SS] Add more constraint checks to avoid checkpoint corruption

2020-09-16 Thread GitBox
viirya commented on a change in pull request #25965: URL: https://github.com/apache/spark/pull/25965#discussion_r489180882 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/MicroBatchExecution.scala ## @@ -585,7 +585,8 @@ class

[GitHub] [spark] SparkQA commented on pull request #29762: [SPARK-32892][CORE][SQL] Fix hash functions on big-endian platforms.

2020-09-16 Thread GitBox
SparkQA commented on pull request #29762: URL: https://github.com/apache/spark/pull/29762#issuecomment-693193153 **[Test build #128738 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128738/testReport)** for PR 29762 at commit

[GitHub] [spark] cloud-fan commented on pull request #29734: [SPARK-32861][SQL] GenerateExec should require column ordering

2020-09-16 Thread GitBox
cloud-fan commented on pull request #29734: URL: https://github.com/apache/spark/pull/29734#issuecomment-693193357 thanks, merging to master! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] SparkQA removed a comment on pull request #29762: [SPARK-32892][CORE][SQL] Fix hash functions on big-endian platforms.

2020-09-16 Thread GitBox
SparkQA removed a comment on pull request #29762: URL: https://github.com/apache/spark/pull/29762#issuecomment-693146552 **[Test build #128738 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128738/testReport)** for PR 29762 at commit

[GitHub] [spark] cloud-fan commented on a change in pull request #29722: [SPARK-32850][CORE] Simplify the RPC message flow of decommission

2020-09-16 Thread GitBox
cloud-fan commented on a change in pull request #29722: URL: https://github.com/apache/spark/pull/29722#discussion_r489185564 ## File path: core/src/main/scala/org/apache/spark/deploy/master/Master.scala ## @@ -245,15 +245,24 @@ private[deploy] class Master(

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29766: [SPARK-32704][SQL][TESTS][FOLLOW-UP] Check any physical rule instead of a specific rule in the test

2020-09-16 Thread GitBox
AmplabJenkins removed a comment on pull request #29766: URL: https://github.com/apache/spark/pull/29766#issuecomment-693194803 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] cloud-fan commented on a change in pull request #29722: [SPARK-32850][CORE] Simplify the RPC message flow of decommission

2020-09-16 Thread GitBox
cloud-fan commented on a change in pull request #29722: URL: https://github.com/apache/spark/pull/29722#discussion_r489185786 ## File path: core/src/main/scala/org/apache/spark/deploy/master/Master.scala ## @@ -245,15 +245,24 @@ private[deploy] class Master(

[GitHub] [spark] SparkQA commented on pull request #29765: [SPARK-32888][DOCS] Add user document about header flag and RDD as path for reading CSV

2020-09-16 Thread GitBox
SparkQA commented on pull request #29765: URL: https://github.com/apache/spark/pull/29765#issuecomment-693195603 **[Test build #128729 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128729/testReport)** for PR 29765 at commit

[GitHub] [spark] SparkQA commented on pull request #25965: [SPARK-26425][SS] Add more constraint checks to avoid checkpoint corruption

2020-09-16 Thread GitBox
SparkQA commented on pull request #25965: URL: https://github.com/apache/spark/pull/25965#issuecomment-693197739 **[Test build #128745 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128745/testReport)** for PR 25965 at commit

[GitHub] [spark] viirya commented on a change in pull request #29756: [SPARK-32885][SS] Add DataStreamReader.table API

2020-09-16 Thread GitBox
viirya commented on a change in pull request #29756: URL: https://github.com/apache/spark/pull/29756#discussion_r489192414 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -846,9 +848,9 @@ class Analyzer( */ object

[GitHub] [spark] AmplabJenkins commented on pull request #28841: [SPARK-31962][SQL] Provide modifiedAfter and modifiedBefore options when filtering from a batch-based file data source

2020-09-16 Thread GitBox
AmplabJenkins commented on pull request #28841: URL: https://github.com/apache/spark/pull/28841#issuecomment-693200669 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28841: [SPARK-31962][SQL] Provide modifiedAfter and modifiedBefore options when filtering from a batch-based file data source

2020-09-16 Thread GitBox
AmplabJenkins removed a comment on pull request #28841: URL: https://github.com/apache/spark/pull/28841#issuecomment-693200669 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] cloud-fan commented on a change in pull request #29739: [SPARK-32867][SQL] When explain, HiveTableRelation show limited message

2020-09-16 Thread GitBox
cloud-fan commented on a change in pull request #29739: URL: https://github.com/apache/spark/pull/29739#discussion_r489199893 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala ## @@ -693,4 +694,29 @@ case class HiveTableRelation(

[GitHub] [spark] gaborgsomogyi commented on a change in pull request #29729: [SPARK-32032][SS] Avoid infinite wait in driver because of KafkaConsumer.poll(long) API

2020-09-16 Thread GitBox
gaborgsomogyi commented on a change in pull request #29729: URL: https://github.com/apache/spark/pull/29729#discussion_r489212011 ## File path: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaOffsetReader.scala ## @@ -105,34 +109,16 @@

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29316: [SPARK-32508][SQL] Disallow empty part col values in partition spec before static partition writing

2020-09-16 Thread GitBox
AmplabJenkins removed a comment on pull request #29316: URL: https://github.com/apache/spark/pull/29316#issuecomment-693218342 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29591: [SPARK-32714][PYTHON] Initial pyspark-stubs port.

2020-09-16 Thread GitBox
AmplabJenkins removed a comment on pull request #29591: URL: https://github.com/apache/spark/pull/29591#issuecomment-693218513 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] HeartSaVioR commented on a change in pull request #29729: [SPARK-32032][SS] Avoid infinite wait in driver because of KafkaConsumer.poll(long) API

2020-09-16 Thread GitBox
HeartSaVioR commented on a change in pull request #29729: URL: https://github.com/apache/spark/pull/29729#discussion_r489217921 ## File path: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaOffsetReader.scala ## @@ -105,34 +109,16 @@

[GitHub] [spark] HeartSaVioR commented on pull request #28841: [SPARK-31962][SQL] Provide modifiedAfter and modifiedBefore options when filtering from a batch-based file data source

2020-09-16 Thread GitBox
HeartSaVioR commented on pull request #28841: URL: https://github.com/apache/spark/pull/28841#issuecomment-693225135 retest this, please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] HeartSaVioR commented on pull request #29767: [SPARK-32896][SS] Add DataStreamWriter.table API

2020-09-16 Thread GitBox
HeartSaVioR commented on pull request #29767: URL: https://github.com/apache/spark/pull/29767#issuecomment-693225169 retest this, please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28841: [SPARK-31962][SQL] Provide modifiedAfter and modifiedBefore options when filtering from a batch-based file data source

2020-09-16 Thread GitBox
AmplabJenkins removed a comment on pull request #28841: URL: https://github.com/apache/spark/pull/28841#issuecomment-693227460 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #25965: [SPARK-26425][SS] Add more constraint checks to avoid checkpoint corruption

2020-09-16 Thread GitBox
AmplabJenkins commented on pull request #25965: URL: https://github.com/apache/spark/pull/25965#issuecomment-693227427 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #28841: [SPARK-31962][SQL] Provide modifiedAfter and modifiedBefore options when filtering from a batch-based file data source

2020-09-16 Thread GitBox
AmplabJenkins commented on pull request #28841: URL: https://github.com/apache/spark/pull/28841#issuecomment-693227460 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #29767: [SPARK-32896][SS] Add DataStreamWriter.table API

2020-09-16 Thread GitBox
AmplabJenkins commented on pull request #29767: URL: https://github.com/apache/spark/pull/29767#issuecomment-693227405 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #25965: [SPARK-26425][SS] Add more constraint checks to avoid checkpoint corruption

2020-09-16 Thread GitBox
AmplabJenkins removed a comment on pull request #25965: URL: https://github.com/apache/spark/pull/25965#issuecomment-693227427 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] gaborgsomogyi commented on a change in pull request #29729: [SPARK-32032][SS] Avoid infinite wait in driver because of KafkaConsumer.poll(long) API

2020-09-16 Thread GitBox
gaborgsomogyi commented on a change in pull request #29729: URL: https://github.com/apache/spark/pull/29729#discussion_r489221735 ## File path: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaOffsetReader.scala ## @@ -213,64 +187,68 @@

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29767: [SPARK-32896][SS] Add DataStreamWriter.table API

2020-09-16 Thread GitBox
AmplabJenkins removed a comment on pull request #29767: URL: https://github.com/apache/spark/pull/29767#issuecomment-693227405 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] cloud-fan commented on a change in pull request #29604: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function

2020-09-16 Thread GitBox
cloud-fan commented on a change in pull request #29604: URL: https://github.com/apache/spark/pull/29604#discussion_r489227880 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala ## @@ -476,7 +476,7 @@ case class

[GitHub] [spark] SparkQA commented on pull request #29585: [SPARK-32741][SQL] Check if the same ExprId refers to the unique attribute in logical plans

2020-09-16 Thread GitBox
SparkQA commented on pull request #29585: URL: https://github.com/apache/spark/pull/29585#issuecomment-693233512 **[Test build #128754 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128754/testReport)** for PR 29585 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #29585: [SPARK-32741][SQL] Check if the same ExprId refers to the unique attribute in logical plans

2020-09-16 Thread GitBox
AmplabJenkins commented on pull request #29585: URL: https://github.com/apache/spark/pull/29585#issuecomment-693234148 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] cloud-fan commented on a change in pull request #29604: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function

2020-09-16 Thread GitBox
cloud-fan commented on a change in pull request #29604: URL: https://github.com/apache/spark/pull/29604#discussion_r489231123 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala ## @@ -549,6 +549,85 @@ case class

[GitHub] [spark] cloud-fan commented on a change in pull request #29604: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function

2020-09-16 Thread GitBox
cloud-fan commented on a change in pull request #29604: URL: https://github.com/apache/spark/pull/29604#discussion_r489234526 ## File path: sql/core/src/test/resources/sql-tests/results/postgreSQL/window_part3.sql.out ## @@ -385,6 +385,15 @@

[GitHub] [spark] cloud-fan commented on a change in pull request #29604: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function

2020-09-16 Thread GitBox
cloud-fan commented on a change in pull request #29604: URL: https://github.com/apache/spark/pull/29604#discussion_r48927 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisErrorSuite.scala ## @@ -233,6 +233,17 @@ class

[GitHub] [spark] AmplabJenkins commented on pull request #29770: [SPARK-32899][CORE] Support submit application with user-defined cluster manager

2020-09-16 Thread GitBox
AmplabJenkins commented on pull request #29770: URL: https://github.com/apache/spark/pull/29770#issuecomment-693240551 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29770: [SPARK-32899][CORE] Support submit application with user-defined cluster manager

2020-09-16 Thread GitBox
AmplabJenkins removed a comment on pull request #29770: URL: https://github.com/apache/spark/pull/29770#issuecomment-693239885 Can one of the admins verify this patch? This is an automated message from the Apache Git

[GitHub] [spark] beliefer commented on a change in pull request #29604: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function

2020-09-16 Thread GitBox
beliefer commented on a change in pull request #29604: URL: https://github.com/apache/spark/pull/29604#discussion_r489243512 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala ## @@ -476,7 +476,7 @@ case class

[GitHub] [spark] beliefer commented on a change in pull request #29604: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function

2020-09-16 Thread GitBox
beliefer commented on a change in pull request #29604: URL: https://github.com/apache/spark/pull/29604#discussion_r489245255 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala ## @@ -549,6 +549,85 @@ case class

[GitHub] [spark] SparkQA commented on pull request #29316: [SPARK-32508][SQL] Disallow empty part col values in partition spec before static partition writing

2020-09-16 Thread GitBox
SparkQA commented on pull request #29316: URL: https://github.com/apache/spark/pull/29316#issuecomment-693247282 **[Test build #128755 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128755/testReport)** for PR 29316 at commit

[GitHub] [spark] beliefer commented on a change in pull request #29604: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function

2020-09-16 Thread GitBox
beliefer commented on a change in pull request #29604: URL: https://github.com/apache/spark/pull/29604#discussion_r489252543 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisErrorSuite.scala ## @@ -233,6 +233,17 @@ class

[GitHub] [spark] beliefer commented on a change in pull request #29604: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function

2020-09-16 Thread GitBox
beliefer commented on a change in pull request #29604: URL: https://github.com/apache/spark/pull/29604#discussion_r489256112 ## File path: sql/core/src/test/resources/sql-tests/results/postgreSQL/window_part3.sql.out ## @@ -385,6 +385,15 @@

[GitHub] [spark] AmplabJenkins commented on pull request #29604: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function

2020-09-16 Thread GitBox
AmplabJenkins commented on pull request #29604: URL: https://github.com/apache/spark/pull/29604#issuecomment-693258818 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #29604: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function

2020-09-16 Thread GitBox
SparkQA commented on pull request #29604: URL: https://github.com/apache/spark/pull/29604#issuecomment-693258202 **[Test build #128756 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128756/testReport)** for PR 29604 at commit

[GitHub] [spark] mundaym commented on pull request #29762: [SPARK-32892][CORE][SQL] Fix hash functions on big-endian platforms.

2020-09-16 Thread GitBox
mundaym commented on pull request #29762: URL: https://github.com/apache/spark/pull/29762#issuecomment-693262630 In an ideal world we'd probably consolidate platform endianness handling into the Platform class by adding methods that perform the necessary conversions. I'm not sure if that

[GitHub] [spark] maropu commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-09-16 Thread GitBox
maropu commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r489265261 ## File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSetOperationsSuite.scala ## @@ -507,33 +507,156 @@ class DataFrameSetOperationsSuite

[GitHub] [spark] maropu commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-09-16 Thread GitBox
maropu commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r489259568 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveUnion.scala ## @@ -17,29 +17,168 @@ package

[GitHub] [spark] HeartSaVioR commented on a change in pull request #29729: [SPARK-32032][SS] Avoid infinite wait in driver because of KafkaConsumer.poll(long) API

2020-09-16 Thread GitBox
HeartSaVioR commented on a change in pull request #29729: URL: https://github.com/apache/spark/pull/29729#discussion_r489215803 ## File path: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaOffsetReader.scala ## @@ -105,34 +109,16 @@

[GitHub] [spark] gaborgsomogyi commented on a change in pull request #29729: [SPARK-32032][SS] Avoid infinite wait in driver because of KafkaConsumer.poll(long) API

2020-09-16 Thread GitBox
gaborgsomogyi commented on a change in pull request #29729: URL: https://github.com/apache/spark/pull/29729#discussion_r489218487 ## File path: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaOffsetReader.scala ## @@ -105,34 +109,16 @@

[GitHub] [spark] HeartSaVioR commented on pull request #25965: [SPARK-26425][SS] Add more constraint checks to avoid checkpoint corruption

2020-09-16 Thread GitBox
HeartSaVioR commented on pull request #25965: URL: https://github.com/apache/spark/pull/25965#issuecomment-693225068 retest this, please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] SparkQA commented on pull request #28841: [SPARK-31962][SQL] Provide modifiedAfter and modifiedBefore options when filtering from a batch-based file data source

2020-09-16 Thread GitBox
SparkQA commented on pull request #28841: URL: https://github.com/apache/spark/pull/28841#issuecomment-693226793 **[Test build #128752 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128752/testReport)** for PR 28841 at commit

[GitHub] [spark] SparkQA commented on pull request #29767: [SPARK-32896][SS] Add DataStreamWriter.table API

2020-09-16 Thread GitBox
SparkQA commented on pull request #29767: URL: https://github.com/apache/spark/pull/29767#issuecomment-693226706 **[Test build #128751 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128751/testReport)** for PR 29767 at commit

[GitHub] [spark] SparkQA commented on pull request #25965: [SPARK-26425][SS] Add more constraint checks to avoid checkpoint corruption

2020-09-16 Thread GitBox
SparkQA commented on pull request #25965: URL: https://github.com/apache/spark/pull/25965#issuecomment-693226799 **[Test build #128753 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128753/testReport)** for PR 25965 at commit

[GitHub] [spark] gaborgsomogyi commented on a change in pull request #29729: [SPARK-32032][SS] Avoid infinite wait in driver because of KafkaConsumer.poll(long) API

2020-09-16 Thread GitBox
gaborgsomogyi commented on a change in pull request #29729: URL: https://github.com/apache/spark/pull/29729#discussion_r489222628 ## File path: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaOffsetReader.scala ## @@ -182,28 +170,14 @@

[GitHub] [spark] maropu commented on pull request #29585: [SPARK-32741][SQL] Check if the same ExprId refers to the unique attribute in logical plans

2020-09-16 Thread GitBox
maropu commented on pull request #29585: URL: https://github.com/apache/spark/pull/29585#issuecomment-693232942 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] cloud-fan commented on a change in pull request #29604: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function

2020-09-16 Thread GitBox
cloud-fan commented on a change in pull request #29604: URL: https://github.com/apache/spark/pull/29604#discussion_r489229928 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala ## @@ -549,6 +549,85 @@ case class

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29585: [SPARK-32741][SQL] Check if the same ExprId refers to the unique attribute in logical plans

2020-09-16 Thread GitBox
AmplabJenkins removed a comment on pull request #29585: URL: https://github.com/apache/spark/pull/29585#issuecomment-693234148 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] ConeyLiu opened a new pull request #29770: [SPARK-32899][CORE] Support submit application with user-defined cluster manager

2020-09-16 Thread GitBox
ConeyLiu opened a new pull request #29770: URL: https://github.com/apache/spark/pull/29770 ### What changes were proposed in this pull request? Add the support to submit applications with user-defined cluster manager. ### Why are the changes needed? We

[GitHub] [spark] AmplabJenkins commented on pull request #29770: [SPARK-32899][CORE] Support submit application with user-defined cluster manager

2020-09-16 Thread GitBox
AmplabJenkins commented on pull request #29770: URL: https://github.com/apache/spark/pull/29770#issuecomment-693239885 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To

[GitHub] [spark] beliefer commented on a change in pull request #29604: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function

2020-09-16 Thread GitBox
beliefer commented on a change in pull request #29604: URL: https://github.com/apache/spark/pull/29604#discussion_r489247134 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala ## @@ -549,6 +549,85 @@ case class

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29316: [SPARK-32508][SQL] Disallow empty part col values in partition spec before static partition writing

2020-09-16 Thread GitBox
AmplabJenkins removed a comment on pull request #29316: URL: https://github.com/apache/spark/pull/29316#issuecomment-693247910 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29316: [SPARK-32508][SQL] Disallow empty part col values in partition spec before static partition writing

2020-09-16 Thread GitBox
AmplabJenkins commented on pull request #29316: URL: https://github.com/apache/spark/pull/29316#issuecomment-693247910 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29604: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function

2020-09-16 Thread GitBox
AmplabJenkins removed a comment on pull request #29604: URL: https://github.com/apache/spark/pull/29604#issuecomment-693258818 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] maropu commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-09-16 Thread GitBox
maropu commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r489257352 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveUnion.scala ## @@ -17,29 +17,168 @@ package

[GitHub] [spark] AngersZhuuuu commented on pull request #29739: [SPARK-32867][SQL] When explain, HiveTableRelation show limited message

2020-09-16 Thread GitBox
AngersZh commented on pull request #29739: URL: https://github.com/apache/spark/pull/29739#issuecomment-693264163 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] AmplabJenkins commented on pull request #29766: [SPARK-32704][SQL][TESTS][FOLLOW-UP] Check any physical rule instead of a specific rule in the test

2020-09-16 Thread GitBox
AmplabJenkins commented on pull request #29766: URL: https://github.com/apache/spark/pull/29766#issuecomment-693194803 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29762: [SPARK-32892][CORE][SQL] Fix hash functions on big-endian platforms.

2020-09-16 Thread GitBox
AmplabJenkins removed a comment on pull request #29762: URL: https://github.com/apache/spark/pull/29762#issuecomment-693193773 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] viirya commented on pull request #29765: [SPARK-32888][DOCS] Add user document about header flag and RDD as path for reading CSV

2020-09-16 Thread GitBox
viirya commented on pull request #29765: URL: https://github.com/apache/spark/pull/29765#issuecomment-693199014 Not sure why GitHub Actions failed at Python linter? This is an automated message from the Apache Git Service.

[GitHub] [spark] HeartSaVioR commented on pull request #29729: [SPARK-32032][SS] Avoid infinite wait in driver because of KafkaConsumer.poll(long) API

2020-09-16 Thread GitBox
HeartSaVioR commented on pull request #29729: URL: https://github.com/apache/spark/pull/29729#issuecomment-693198878 Looks OK except the cleanup of unnecessary workarounds for `consumer.poll` as a new commit. cc. @zsxwing

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29604: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function

2020-09-16 Thread GitBox
AmplabJenkins removed a comment on pull request #29604: URL: https://github.com/apache/spark/pull/29604#issuecomment-693214552 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #29731: [SPARK-32706][SQL] Improve cast string to decimal type

2020-09-16 Thread GitBox
SparkQA commented on pull request #29731: URL: https://github.com/apache/spark/pull/29731#issuecomment-693220302 **[Test build #128750 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128750/testReport)** for PR 29731 at commit

[GitHub] [spark] cloud-fan commented on a change in pull request #29756: [SPARK-32885][SS] Add DataStreamReader.table API

2020-09-16 Thread GitBox
cloud-fan commented on a change in pull request #29756: URL: https://github.com/apache/spark/pull/29756#discussion_r489182003 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -923,6 +925,19 @@ class Analyzer( case

[GitHub] [spark] cloud-fan closed pull request #29734: [SPARK-32861][SQL] GenerateExec should require column ordering

2020-09-16 Thread GitBox
cloud-fan closed pull request #29734: URL: https://github.com/apache/spark/pull/29734 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] AmplabJenkins commented on pull request #29762: [SPARK-32892][CORE][SQL] Fix hash functions on big-endian platforms.

2020-09-16 Thread GitBox
AmplabJenkins commented on pull request #29762: URL: https://github.com/apache/spark/pull/29762#issuecomment-693193767 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #29766: [SPARK-32704][SQL][TESTS][FOLLOW-UP] Check any physical rule instead of a specific rule in the test

2020-09-16 Thread GitBox
SparkQA removed a comment on pull request #29766: URL: https://github.com/apache/spark/pull/29766#issuecomment-693112608 **[Test build #128730 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128730/testReport)** for PR 29766 at commit

[GitHub] [spark] cloud-fan commented on a change in pull request #29761: [SPARK-32889][SQL] orc table column name supports special characters.

2020-09-16 Thread GitBox
cloud-fan commented on a change in pull request #29761: URL: https://github.com/apache/spark/pull/29761#discussion_r489184669 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFileFormat.scala ## @@ -38,14 +38,19 @@ import

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29762: [SPARK-32892][CORE][SQL] Fix hash functions on big-endian platforms.

2020-09-16 Thread GitBox
AmplabJenkins removed a comment on pull request #29762: URL: https://github.com/apache/spark/pull/29762#issuecomment-693193767 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA commented on pull request #29766: [SPARK-32704][SQL][TESTS][FOLLOW-UP] Check any physical rule instead of a specific rule in the test

2020-09-16 Thread GitBox
SparkQA commented on pull request #29766: URL: https://github.com/apache/spark/pull/29766#issuecomment-693193823 **[Test build #128730 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128730/testReport)** for PR 29766 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #29765: [SPARK-32888][DOCS] Add user document about header flag and RDD as path for reading CSV

2020-09-16 Thread GitBox
SparkQA removed a comment on pull request #29765: URL: https://github.com/apache/spark/pull/29765#issuecomment-693110435 **[Test build #128729 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128729/testReport)** for PR 29765 at commit

[GitHub] [spark] Ngone51 commented on a change in pull request #29722: [SPARK-32850][CORE] Simplify the RPC message flow of decommission

2020-09-16 Thread GitBox
Ngone51 commented on a change in pull request #29722: URL: https://github.com/apache/spark/pull/29722#discussion_r489186319 ## File path: core/src/main/scala/org/apache/spark/deploy/master/Master.scala ## @@ -245,15 +245,24 @@ private[deploy] class Master(

[GitHub] [spark] beliefer commented on a change in pull request #29604: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function

2020-09-16 Thread GitBox
beliefer commented on a change in pull request #29604: URL: https://github.com/apache/spark/pull/29604#discussion_r489187346 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala ## @@ -549,6 +549,96 @@ case class

[GitHub] [spark] cloud-fan commented on a change in pull request #29722: [SPARK-32850][CORE] Simplify the RPC message flow of decommission

2020-09-16 Thread GitBox
cloud-fan commented on a change in pull request #29722: URL: https://github.com/apache/spark/pull/29722#discussion_r489187271 ## File path: core/src/main/scala/org/apache/spark/deploy/master/Master.scala ## @@ -245,15 +245,24 @@ private[deploy] class Master(

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29765: [SPARK-32888][DOCS] Add user document about header flag and RDD as path for reading CSV

2020-09-16 Thread GitBox
AmplabJenkins removed a comment on pull request #29765: URL: https://github.com/apache/spark/pull/29765#issuecomment-693196447 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] beliefer commented on a change in pull request #29604: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function

2020-09-16 Thread GitBox
beliefer commented on a change in pull request #29604: URL: https://github.com/apache/spark/pull/29604#discussion_r489187186 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala ## @@ -549,6 +549,96 @@ case class

[GitHub] [spark] cloud-fan commented on a change in pull request #29722: [SPARK-32850][CORE] Simplify the RPC message flow of decommission

2020-09-16 Thread GitBox
cloud-fan commented on a change in pull request #29722: URL: https://github.com/apache/spark/pull/29722#discussion_r489186794 ## File path: core/src/main/scala/org/apache/spark/deploy/master/Master.scala ## @@ -245,15 +245,24 @@ private[deploy] class Master(

[GitHub] [spark] HeartSaVioR commented on a change in pull request #25965: [SPARK-26425][SS] Add more constraint checks to avoid checkpoint corruption

2020-09-16 Thread GitBox
HeartSaVioR commented on a change in pull request #25965: URL: https://github.com/apache/spark/pull/25965#discussion_r489186932 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/MicroBatchExecution.scala ## @@ -585,7 +585,8 @@ class

[GitHub] [spark] AmplabJenkins commented on pull request #29765: [SPARK-32888][DOCS] Add user document about header flag and RDD as path for reading CSV

2020-09-16 Thread GitBox
AmplabJenkins commented on pull request #29765: URL: https://github.com/apache/spark/pull/29765#issuecomment-693196447 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] HyukjinKwon commented on pull request #29765: [SPARK-32888][DOCS] Add user document about header flag and RDD as path for reading CSV

2020-09-16 Thread GitBox
HyukjinKwon commented on pull request #29765: URL: https://github.com/apache/spark/pull/29765#issuecomment-693204275 I think .. Jenkins currently doesn't run PySpark documentation due to missing dependencies. I opened some JIRAs but looks like Shane is busy at this moment. GitHub Actions

[GitHub] [spark] viirya commented on a change in pull request #29756: [SPARK-32885][SS] Add DataStreamReader.table API

2020-09-16 Thread GitBox
viirya commented on a change in pull request #29756: URL: https://github.com/apache/spark/pull/29756#discussion_r489195938 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -942,6 +957,47 @@ class Analyzer( } } +

[GitHub] [spark] viirya commented on pull request #29765: [SPARK-32888][DOCS] Add user document about header flag and RDD as path for reading CSV

2020-09-16 Thread GitBox
viirya commented on pull request #29765: URL: https://github.com/apache/spark/pull/29765#issuecomment-693209330 Oh, got it. I'm fixing it. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] SparkQA removed a comment on pull request #29765: [SPARK-32888][DOCS] Add user document about header flag and RDD as path for reading CSV

2020-09-16 Thread GitBox
SparkQA removed a comment on pull request #29765: URL: https://github.com/apache/spark/pull/29765#issuecomment-693213988 **[Test build #128747 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128747/testReport)** for PR 29765 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28841: [SPARK-31962][SQL] Provide modifiedAfter and modifiedBefore options when filtering from a batch-based file data source

2020-09-16 Thread GitBox
AmplabJenkins removed a comment on pull request #28841: URL: https://github.com/apache/spark/pull/28841#issuecomment-693216812 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA removed a comment on pull request #29591: [SPARK-32714][PYTHON] Initial pyspark-stubs port.

2020-09-16 Thread GitBox
SparkQA removed a comment on pull request #29591: URL: https://github.com/apache/spark/pull/29591#issuecomment-693148274 **[Test build #128740 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128740/testReport)** for PR 29591 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #29767: [SPARK-32896][SS] Add DataStreamWriter.table API

2020-09-16 Thread GitBox
SparkQA removed a comment on pull request #29767: URL: https://github.com/apache/spark/pull/29767#issuecomment-693148256 **[Test build #128739 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128739/testReport)** for PR 29767 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #29739: [SPARK-32867][SQL] When explain, HiveTableRelation show limited message

2020-09-16 Thread GitBox
SparkQA removed a comment on pull request #29739: URL: https://github.com/apache/spark/pull/29739#issuecomment-693179376 **[Test build #128743 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128743/testReport)** for PR 29739 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #29316: [SPARK-32508][SQL] Disallow empty part col values in partition spec before static partition writing

2020-09-16 Thread GitBox
SparkQA removed a comment on pull request #29316: URL: https://github.com/apache/spark/pull/29316#issuecomment-693135193 **[Test build #128735 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128735/testReport)** for PR 29316 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #25965: [SPARK-26425][SS] Add more constraint checks to avoid checkpoint corruption

2020-09-16 Thread GitBox
AmplabJenkins removed a comment on pull request #25965: URL: https://github.com/apache/spark/pull/25965#issuecomment-693216851 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA removed a comment on pull request #29586: [SPARK-32743][SQL] Add distinct info at UnresolvedFunction toString

2020-09-16 Thread GitBox
SparkQA removed a comment on pull request #29586: URL: https://github.com/apache/spark/pull/29586#issuecomment-693176982 **[Test build #128741 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128741/testReport)** for PR 29586 at commit

[GitHub] [spark] SparkQA commented on pull request #25965: [SPARK-26425][SS] Add more constraint checks to avoid checkpoint corruption

2020-09-16 Thread GitBox
SparkQA commented on pull request #25965: URL: https://github.com/apache/spark/pull/25965#issuecomment-693216733 **[Test build #128745 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128745/testReport)** for PR 25965 at commit

[GitHub] [spark] SparkQA commented on pull request #29316: [SPARK-32508][SQL] Disallow empty part col values in partition spec before static partition writing

2020-09-16 Thread GitBox
SparkQA commented on pull request #29316: URL: https://github.com/apache/spark/pull/29316#issuecomment-693216736 **[Test build #128735 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128735/testReport)** for PR 29316 at commit

[GitHub] [spark] SparkQA commented on pull request #29739: [SPARK-32867][SQL] When explain, HiveTableRelation show limited message

2020-09-16 Thread GitBox
SparkQA commented on pull request #29739: URL: https://github.com/apache/spark/pull/29739#issuecomment-693216722 **[Test build #128743 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128743/testReport)** for PR 29739 at commit

[GitHub] [spark] SparkQA commented on pull request #29585: [SPARK-32741][SQL] Check if the same ExprId refers to the unique attribute in logical plans

2020-09-16 Thread GitBox
SparkQA commented on pull request #29585: URL: https://github.com/apache/spark/pull/29585#issuecomment-693216740 **[Test build #128734 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128734/testReport)** for PR 29585 at commit

[GitHub] [spark] SparkQA commented on pull request #29591: [SPARK-32714][PYTHON] Initial pyspark-stubs port.

2020-09-16 Thread GitBox
SparkQA commented on pull request #29591: URL: https://github.com/apache/spark/pull/29591#issuecomment-693216732 **[Test build #128740 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128740/testReport)** for PR 29591 at commit

  1   2   3   4   5   6   7   8   >