[GitHub] [spark] viirya commented on a change in pull request #32503: [SPARK-35400][SQL] Improve error message for correlated subquery

2021-05-15 Thread GitBox
viirya commented on a change in pull request #32503: URL: https://github.com/apache/spark/pull/32503#discussion_r632906552 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala ## @@ -836,15 +836,7 @@ trait CheckAnalysis extends

[GitHub] [spark] viirya commented on a change in pull request #32503: [SPARK-35400][SQL] Improve error message for correlated subquery

2021-05-15 Thread GitBox
viirya commented on a change in pull request #32503: URL: https://github.com/apache/spark/pull/32503#discussion_r632906552 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala ## @@ -836,15 +836,7 @@ trait CheckAnalysis extends

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32556: [Minor][SPARK-35409][SQL]Add flag for escaping meta characters in show command

2021-05-15 Thread GitBox
AmplabJenkins removed a comment on pull request #32556: URL: https://github.com/apache/spark/pull/32556#issuecomment-841629935 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32552: [WIP][SPARK-34819][SPARK-18134][SQL] MapType supports comparable semantics

2021-05-15 Thread GitBox
AmplabJenkins removed a comment on pull request #32552: URL: https://github.com/apache/spark/pull/32552#issuecomment-841629934 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138570/

[GitHub] [spark] AmplabJenkins commented on pull request #32556: [Minor][SPARK-35409][SQL]Add flag for escaping meta characters in show command

2021-05-15 Thread GitBox
AmplabJenkins commented on pull request #32556: URL: https://github.com/apache/spark/pull/32556#issuecomment-841629935 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [spark] AmplabJenkins commented on pull request #32552: [WIP][SPARK-34819][SPARK-18134][SQL] MapType supports comparable semantics

2021-05-15 Thread GitBox
AmplabJenkins commented on pull request #32552: URL: https://github.com/apache/spark/pull/32552#issuecomment-841629934 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138570/ -- This

[GitHub] [spark] SparkQA commented on pull request #32556: [Minor][SPARK-35409][SQL]Add flag for escaping meta characters in show command

2021-05-15 Thread GitBox
SparkQA commented on pull request #32556: URL: https://github.com/apache/spark/pull/32556#issuecomment-841623502 **[Test build #138572 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138572/testReport)** for PR 32556 at commit

[GitHub] [spark] SparkQA commented on pull request #32552: [WIP][SPARK-34819][SPARK-18134][SQL] MapType supports comparable semantics

2021-05-15 Thread GitBox
SparkQA commented on pull request #32552: URL: https://github.com/apache/spark/pull/32552#issuecomment-841626474 **[Test build #138570 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138570/testReport)** for PR 32552 at commit

[GitHub] [spark] SparkQA commented on pull request #32556: [Minor][SPARK-35409][SQL]Add flag for escaping meta characters in show command

2021-05-15 Thread GitBox
SparkQA commented on pull request #32556: URL: https://github.com/apache/spark/pull/32556#issuecomment-841628416 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [spark] SparkQA removed a comment on pull request #32552: [WIP][SPARK-34819][SPARK-18134][SQL] MapType supports comparable semantics

2021-05-15 Thread GitBox
SparkQA removed a comment on pull request #32552: URL: https://github.com/apache/spark/pull/32552#issuecomment-841598821 **[Test build #138570 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138570/testReport)** for PR 32552 at commit

[GitHub] [spark] gerashegalov opened a new pull request #32555: [SPARK-35408][PYSPARK] Improve parameter validation in DataFrame.show

2021-05-15 Thread GitBox
gerashegalov opened a new pull request #32555: URL: https://github.com/apache/spark/pull/32555 ### What changes were proposed in this pull request? Provide clearer error message tied to the user's Python code if incorrect parameters are passed to `DataFrame.show` rather than the message

[GitHub] [spark] viirya commented on a change in pull request #32272: [SPARK-35172][SS] The implementation of RocksDBCheckpointMetadata

2021-05-15 Thread GitBox
viirya commented on a change in pull request #32272: URL: https://github.com/apache/spark/pull/32272#discussion_r632907718 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBFileManager.scala ## @@ -0,0 +1,165 @@ +/* + * Licensed to

[GitHub] [spark] SparkQA commented on pull request #32556: [Minor][SPARK-35409][SQL]Add flag for escaping meta characters in show command

2021-05-15 Thread GitBox
SparkQA commented on pull request #32556: URL: https://github.com/apache/spark/pull/32556#issuecomment-841623047 **[Test build #138571 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138571/testReport)** for PR 32556 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #32555: [SPARK-35408][PYSPARK] Improve parameter validation in DataFrame.show

2021-05-15 Thread GitBox
AmplabJenkins commented on pull request #32555: URL: https://github.com/apache/spark/pull/32555#issuecomment-841609630 Can one of the admins verify this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [spark] viirya commented on a change in pull request #32272: [SPARK-35172][SS] The implementation of RocksDBCheckpointMetadata

2021-05-15 Thread GitBox
viirya commented on a change in pull request #32272: URL: https://github.com/apache/spark/pull/32272#discussion_r632907718 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBFileManager.scala ## @@ -0,0 +1,165 @@ +/* + * Licensed to

[GitHub] [spark] viirya commented on a change in pull request #32272: [SPARK-35172][SS] The implementation of RocksDBCheckpointMetadata

2021-05-15 Thread GitBox
viirya commented on a change in pull request #32272: URL: https://github.com/apache/spark/pull/32272#discussion_r632908535 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBFileManager.scala ## @@ -0,0 +1,165 @@ +/* + * Licensed to

[GitHub] [spark] shahidki31 opened a new pull request #32556: [Minor][SPARK-35409][SQL]Add flag for escaping meta characters in show command

2021-05-15 Thread GitBox
shahidki31 opened a new pull request #32556: URL: https://github.com/apache/spark/pull/32556 ### What changes were proposed in this pull request? `scala>sql("EXPLAIN cost SELECT item.i_brand, count(1), date_dim.d_year, item.i_brand_id, sum(store_sales.ss_ext_sales_price) AS

[GitHub] [spark] SparkQA commented on pull request #32552: [WIP][SPARK-34819][SPARK-18134][SQL] MapType supports comparable semantics

2021-05-15 Thread GitBox
SparkQA commented on pull request #32552: URL: https://github.com/apache/spark/pull/32552#issuecomment-841704975 **[Test build #138573 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138573/testReport)** for PR 32552 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #32552: [WIP][SPARK-34819][SPARK-18134][SQL] MapType supports comparable semantics

2021-05-15 Thread GitBox
AmplabJenkins commented on pull request #32552: URL: https://github.com/apache/spark/pull/32552#issuecomment-841705873 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138573/ -- This

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32552: [WIP][SPARK-34819][SPARK-18134][SQL] MapType supports comparable semantics

2021-05-15 Thread GitBox
AmplabJenkins removed a comment on pull request #32552: URL: https://github.com/apache/spark/pull/32552#issuecomment-841705873 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138573/

[GitHub] [spark] shahidki31 edited a comment on pull request #32556: [SPARK-35409][SQL]Skip escaping meta-characters for EXPLAIN command using show()

2021-05-15 Thread GitBox
shahidki31 edited a comment on pull request #32556: URL: https://github.com/apache/spark/pull/32556#issuecomment-841707067 > Also, why not doing `spark.sql("...").explain` rather than `spark.sql("EXPLAIN ...").show`? Yes right. There are many ways to see the plan of a query. Ideally

[GitHub] [spark] shahidki31 commented on pull request #32556: [SPARK-35409][SQL]Skip escaping meta-characters for EXPLAIN command using show()

2021-05-15 Thread GitBox
shahidki31 commented on pull request #32556: URL: https://github.com/apache/spark/pull/32556#issuecomment-841707067 > Also, why not doing `spark.sql("...").explain` rather than `spark.sql("EXPLAIN ...").show`? Yes right. There are many ways to see the plan of a query. Ideally

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32552: [WIP][SPARK-34819][SPARK-18134][SQL] MapType supports comparable semantics

2021-05-15 Thread GitBox
AmplabJenkins removed a comment on pull request #32552: URL: https://github.com/apache/spark/pull/32552#issuecomment-841713327 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138575/

[GitHub] [spark] AmplabJenkins commented on pull request #32552: [WIP][SPARK-34819][SPARK-18134][SQL] MapType supports comparable semantics

2021-05-15 Thread GitBox
AmplabJenkins commented on pull request #32552: URL: https://github.com/apache/spark/pull/32552#issuecomment-841713327 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138575/ -- This

[GitHub] [spark] SparkQA commented on pull request #32049: [SPARK-34952][SQL] Aggregate (Min/Max/Count) push down for Parquet

2021-05-15 Thread GitBox
SparkQA commented on pull request #32049: URL: https://github.com/apache/spark/pull/32049#issuecomment-841722424 **[Test build #138576 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138576/testReport)** for PR 32049 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #32049: [SPARK-34952][SQL] Aggregate (Min/Max/Count) push down for Parquet

2021-05-15 Thread GitBox
SparkQA removed a comment on pull request #32049: URL: https://github.com/apache/spark/pull/32049#issuecomment-841722424 **[Test build #138576 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138576/testReport)** for PR 32049 at commit

[GitHub] [spark] SparkQA commented on pull request #32049: [SPARK-34952][SQL] Aggregate (Min/Max/Count) push down for Parquet

2021-05-15 Thread GitBox
SparkQA commented on pull request #32049: URL: https://github.com/apache/spark/pull/32049#issuecomment-841734753 **[Test build #138578 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138578/testReport)** for PR 32049 at commit

[GitHub] [spark] sarutak commented on pull request #32556: [SPARK-35409][SQL]Skip escaping meta-characters for EXPLAIN command using show()

2021-05-15 Thread GitBox
sarutak commented on pull request #32556: URL: https://github.com/apache/spark/pull/32556#issuecomment-841703929 How about overload `show` which takes a parameter controlling which special character is not escaped. I don't think it's a good idea to treat only `explain` as a special

[GitHub] [spark] sarutak edited a comment on pull request #32556: [SPARK-35409][SQL]Skip escaping meta-characters for EXPLAIN command using show()

2021-05-15 Thread GitBox
sarutak edited a comment on pull request #32556: URL: https://github.com/apache/spark/pull/32556#issuecomment-841703929 How about overloading `show` which takes a parameter controlling which special character is not escaped. I don't think it's a good idea to treat only `explain` as a

[GitHub] [spark] Yiszart commented on pull request #32544: [SPARK-32484][SQL] Fix log info BroadcastExchangeExec.scala

2021-05-15 Thread GitBox
Yiszart commented on pull request #32544: URL: https://github.com/apache/spark/pull/32544#issuecomment-841705279 > ### What changes were proposed in this pull request? > Fix log info in BroadcastExchangeExec.scala > > ### Why are the changes needed? > Log info s"Cannot

[GitHub] [spark] SparkQA commented on pull request #32556: [SPARK-35409][SQL]Skip escaping meta-characters for EXPLAIN command using show()

2021-05-15 Thread GitBox
SparkQA commented on pull request #32556: URL: https://github.com/apache/spark/pull/32556#issuecomment-841722922 **[Test build #138574 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138574/testReport)** for PR 32556 at commit

[GitHub] [spark] SparkQA commented on pull request #32049: [SPARK-34952][SQL] Aggregate (Min/Max/Count) push down for Parquet

2021-05-15 Thread GitBox
SparkQA commented on pull request #32049: URL: https://github.com/apache/spark/pull/32049#issuecomment-841733145 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [spark] sarutak commented on pull request #32556: [SPARK-35409][SQL]Skip escaping meta-characters for EXPLAIN command using show()

2021-05-15 Thread GitBox
sarutak commented on pull request #32556: URL: https://github.com/apache/spark/pull/32556#issuecomment-841705425 Also, why not doing `spark.sql("...").explain` rather than `spark.sql("EXPLAIN ...").show`? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] SparkQA commented on pull request #32552: [WIP][SPARK-34819][SPARK-18134][SQL] MapType supports comparable semantics

2021-05-15 Thread GitBox
SparkQA commented on pull request #32552: URL: https://github.com/apache/spark/pull/32552#issuecomment-841711387 **[Test build #138575 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138575/testReport)** for PR 32552 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #32552: [WIP][SPARK-34819][SPARK-18134][SQL] MapType supports comparable semantics

2021-05-15 Thread GitBox
SparkQA removed a comment on pull request #32552: URL: https://github.com/apache/spark/pull/32552#issuecomment-841689731 **[Test build #138575 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138575/testReport)** for PR 32552 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #32556: [SPARK-35409][SQL]Skip escaping meta-characters for EXPLAIN command using show()

2021-05-15 Thread GitBox
SparkQA removed a comment on pull request #32556: URL: https://github.com/apache/spark/pull/32556#issuecomment-841689694 **[Test build #138574 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138574/testReport)** for PR 32556 at commit

[GitHub] [spark] SparkQA commented on pull request #32049: [SPARK-34952][SQL] Aggregate (Min/Max/Count) push down for Parquet

2021-05-15 Thread GitBox
SparkQA commented on pull request #32049: URL: https://github.com/apache/spark/pull/32049#issuecomment-841723995 **[Test build #138576 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138576/testReport)** for PR 32049 at commit

[GitHub] [spark] SparkQA commented on pull request #32049: [SPARK-34952][SQL] Aggregate (Min/Max/Count) push down for Parquet

2021-05-15 Thread GitBox
SparkQA commented on pull request #32049: URL: https://github.com/apache/spark/pull/32049#issuecomment-841727823 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [spark] AmplabJenkins commented on pull request #32556: [SPARK-35409][SQL]Skip escaping meta-characters for EXPLAIN command using show()

2021-05-15 Thread GitBox
AmplabJenkins commented on pull request #32556: URL: https://github.com/apache/spark/pull/32556#issuecomment-841728876 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138574/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #32049: [SPARK-34952][SQL] Aggregate (Min/Max/Count) push down for Parquet

2021-05-15 Thread GitBox
AmplabJenkins commented on pull request #32049: URL: https://github.com/apache/spark/pull/32049#issuecomment-841728875 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32049: [SPARK-34952][SQL] Aggregate (Min/Max/Count) push down for Parquet

2021-05-15 Thread GitBox
AmplabJenkins removed a comment on pull request #32049: URL: https://github.com/apache/spark/pull/32049#issuecomment-841728874 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32556: [SPARK-35409][SQL]Skip escaping meta-characters for EXPLAIN command using show()

2021-05-15 Thread GitBox
AmplabJenkins removed a comment on pull request #32556: URL: https://github.com/apache/spark/pull/32556#issuecomment-841728876 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138574/

[GitHub] [spark] SparkQA commented on pull request #32049: [SPARK-34952][SQL] Aggregate (Min/Max/Count) push down for Parquet

2021-05-15 Thread GitBox
SparkQA commented on pull request #32049: URL: https://github.com/apache/spark/pull/32049#issuecomment-841729332 **[Test build #138577 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138577/testReport)** for PR 32049 at commit

[GitHub] [spark] SparkQA commented on pull request #32049: [SPARK-34952][SQL] Aggregate (Min/Max/Count) push down for Parquet

2021-05-15 Thread GitBox
SparkQA commented on pull request #32049: URL: https://github.com/apache/spark/pull/32049#issuecomment-841730923 **[Test build #138577 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138577/testReport)** for PR 32049 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #32049: [SPARK-34952][SQL] Aggregate (Min/Max/Count) push down for Parquet

2021-05-15 Thread GitBox
SparkQA removed a comment on pull request #32049: URL: https://github.com/apache/spark/pull/32049#issuecomment-841729332 **[Test build #138577 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138577/testReport)** for PR 32049 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #32049: [SPARK-34952][SQL] Aggregate (Min/Max/Count) push down for Parquet

2021-05-15 Thread GitBox
AmplabJenkins commented on pull request #32049: URL: https://github.com/apache/spark/pull/32049#issuecomment-841734527 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32049: [SPARK-34952][SQL] Aggregate (Min/Max/Count) push down for Parquet

2021-05-15 Thread GitBox
AmplabJenkins removed a comment on pull request #32049: URL: https://github.com/apache/spark/pull/32049#issuecomment-841734527 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [spark] srowen commented on pull request #32544: [SPARK-32484][SQL] Fix log info BroadcastExchangeExec.scala

2021-05-15 Thread GitBox
srowen commented on pull request #32544: URL: https://github.com/apache/spark/pull/32544#issuecomment-841702828 Merged to master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [spark] srowen closed pull request #32544: [SPARK-32484][SQL] Fix log info BroadcastExchangeExec.scala

2021-05-15 Thread GitBox
srowen closed pull request #32544: URL: https://github.com/apache/spark/pull/32544 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [spark] SparkQA removed a comment on pull request #32552: [WIP][SPARK-34819][SPARK-18134][SQL] MapType supports comparable semantics

2021-05-15 Thread GitBox
SparkQA removed a comment on pull request #32552: URL: https://github.com/apache/spark/pull/32552#issuecomment-841681383 **[Test build #138573 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138573/testReport)** for PR 32552 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #32556: [Minor][SPARK-35409][SQL]Add flag for escaping meta characters in show command

2021-05-15 Thread GitBox
SparkQA removed a comment on pull request #32556: URL: https://github.com/apache/spark/pull/32556#issuecomment-841623502 **[Test build #138572 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138572/testReport)** for PR 32556 at commit

[GitHub] [spark] SparkQA commented on pull request #32556: [Minor][SPARK-35409][SQL]Add flag for escaping meta characters in show command

2021-05-15 Thread GitBox
SparkQA commented on pull request #32556: URL: https://github.com/apache/spark/pull/32556#issuecomment-841656248 **[Test build #138572 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138572/testReport)** for PR 32556 at commit

[GitHub] [spark] srowen commented on pull request #32554: [MINOR][DOCS] Add required imports to CV, train validation split Pyspark ML examples

2021-05-15 Thread GitBox
srowen commented on pull request #32554: URL: https://github.com/apache/spark/pull/32554#issuecomment-841657507 Merged to master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [spark] srowen closed pull request #32554: [MINOR][DOCS] Add required imports to CV, train validation split Pyspark ML examples

2021-05-15 Thread GitBox
srowen closed pull request #32554: URL: https://github.com/apache/spark/pull/32554 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [spark] shahidki31 commented on pull request #32556: [Minor][SPARK-35409][SQL]Add flag for escaping meta characters in show command

2021-05-15 Thread GitBox
shahidki31 commented on pull request #32556: URL: https://github.com/apache/spark/pull/32556#issuecomment-841686141 > Can we somehow special case EXPLAIN output? I don't think it makes sense to make users figure this out.. Sure. I will try. -- This is an automated message from

[GitHub] [spark] AmplabJenkins commented on pull request #32552: [WIP][SPARK-34819][SPARK-18134][SQL] MapType supports comparable semantics

2021-05-15 Thread GitBox
AmplabJenkins commented on pull request #32552: URL: https://github.com/apache/spark/pull/32552#issuecomment-841689180 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43094/ --

[GitHub] [spark] AmplabJenkins commented on pull request #32552: [WIP][SPARK-34819][SPARK-18134][SQL] MapType supports comparable semantics

2021-05-15 Thread GitBox
AmplabJenkins commented on pull request #32552: URL: https://github.com/apache/spark/pull/32552#issuecomment-841698164 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43096/ --

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32556: [SPARK-35409][SQL]Skip escaping meta-characters for EXPLAIN command using show()

2021-05-15 Thread GitBox
AmplabJenkins removed a comment on pull request #32556: URL: https://github.com/apache/spark/pull/32556#issuecomment-841698166 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43095/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32552: [WIP][SPARK-34819][SPARK-18134][SQL] MapType supports comparable semantics

2021-05-15 Thread GitBox
AmplabJenkins removed a comment on pull request #32552: URL: https://github.com/apache/spark/pull/32552#issuecomment-841698164 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43096/

[GitHub] [spark] AmplabJenkins commented on pull request #32556: [Minor][SPARK-35409][SQL]Add flag for escaping meta characters in show command

2021-05-15 Thread GitBox
AmplabJenkins commented on pull request #32556: URL: https://github.com/apache/spark/pull/32556#issuecomment-841659813 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [spark] SparkQA commented on pull request #32552: [WIP][SPARK-34819][SPARK-18134][SQL] MapType supports comparable semantics

2021-05-15 Thread GitBox
SparkQA commented on pull request #32552: URL: https://github.com/apache/spark/pull/32552#issuecomment-841681383 **[Test build #138573 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138573/testReport)** for PR 32552 at commit

[GitHub] [spark] SparkQA commented on pull request #32552: [WIP][SPARK-34819][SPARK-18134][SQL] MapType supports comparable semantics

2021-05-15 Thread GitBox
SparkQA commented on pull request #32552: URL: https://github.com/apache/spark/pull/32552#issuecomment-841687753 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [spark] shahidki31 commented on pull request #32556: [Minor][SPARK-35409][SQL]Add flag for escaping meta characters in show command

2021-05-15 Thread GitBox
shahidki31 commented on pull request #32556: URL: https://github.com/apache/spark/pull/32556#issuecomment-841689408 @srowen I have updated the PR. Please check -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [spark] SparkQA commented on pull request #32556: [SPARK-35409][SQL]Skip escaping meta-characters for EXPLAIN command using show()

2021-05-15 Thread GitBox
SparkQA commented on pull request #32556: URL: https://github.com/apache/spark/pull/32556#issuecomment-841695824 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [spark] SparkQA commented on pull request #32552: [WIP][SPARK-34819][SPARK-18134][SQL] MapType supports comparable semantics

2021-05-15 Thread GitBox
SparkQA commented on pull request #32552: URL: https://github.com/apache/spark/pull/32552#issuecomment-841695856 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43096/ -- This is an automated message from the Apache

[GitHub] [spark] AmplabJenkins commented on pull request #32558: [SPARK-35279][CORE][SQL] Add the code change for adding the DateType in the infer schema while reading

2021-05-15 Thread GitBox
AmplabJenkins commented on pull request #32558: URL: https://github.com/apache/spark/pull/32558#issuecomment-841699366 Can one of the admins verify this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32556: [Minor][SPARK-35409][SQL]Add flag for escaping meta characters in show command

2021-05-15 Thread GitBox
AmplabJenkins removed a comment on pull request #32556: URL: https://github.com/apache/spark/pull/32556#issuecomment-841659813 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [spark] srowen commented on pull request #32556: [Minor][SPARK-35409][SQL]Add flag for escaping meta characters in show command

2021-05-15 Thread GitBox
srowen commented on pull request #32556: URL: https://github.com/apache/spark/pull/32556#issuecomment-841685767 Can we somehow special case EXPLAIN output? I don't think it makes sense to make users figure this out.. -- This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA commented on pull request #32556: [Minor][SPARK-35409][SQL]Add flag for escaping meta characters in show command

2021-05-15 Thread GitBox
SparkQA commented on pull request #32556: URL: https://github.com/apache/spark/pull/32556#issuecomment-841689694 **[Test build #138574 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138574/testReport)** for PR 32556 at commit

[GitHub] [spark] SparkQA commented on pull request #32552: [WIP][SPARK-34819][SPARK-18134][SQL] MapType supports comparable semantics

2021-05-15 Thread GitBox
SparkQA commented on pull request #32552: URL: https://github.com/apache/spark/pull/32552#issuecomment-841689731 **[Test build #138575 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138575/testReport)** for PR 32552 at commit

[GitHub] [spark] SparkQA commented on pull request #32552: [WIP][SPARK-34819][SPARK-18134][SQL] MapType supports comparable semantics

2021-05-15 Thread GitBox
SparkQA commented on pull request #32552: URL: https://github.com/apache/spark/pull/32552#issuecomment-841696558 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43096/ -- This is an automated message from the

[GitHub] [spark] AmplabJenkins commented on pull request #32556: [SPARK-35409][SQL]Skip escaping meta-characters for EXPLAIN command using show()

2021-05-15 Thread GitBox
AmplabJenkins commented on pull request #32556: URL: https://github.com/apache/spark/pull/32556#issuecomment-841698166 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43095/ --

[GitHub] [spark] SaurabhChawla100 opened a new pull request #32558: [SPARK-35279][CORE][SQL] Add the code change for adding the DateType in the infer schema while reading

2021-05-15 Thread GitBox
SaurabhChawla100 opened a new pull request #32558: URL: https://github.com/apache/spark/pull/32558 ### What changes were proposed in this pull request? Till now there is no support in infer schema for the DateType format while reading the CSV/json. In this PR, code change is done to

[GitHub] [spark] SparkQA removed a comment on pull request #32556: [Minor][SPARK-35409][SQL]Add flag for escaping meta characters in show command

2021-05-15 Thread GitBox
SparkQA removed a comment on pull request #32556: URL: https://github.com/apache/spark/pull/32556#issuecomment-841623047 **[Test build #138571 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138571/testReport)** for PR 32556 at commit

[GitHub] [spark] SparkQA commented on pull request #32556: [Minor][SPARK-35409][SQL]Add flag for escaping meta characters in show command

2021-05-15 Thread GitBox
SparkQA commented on pull request #32556: URL: https://github.com/apache/spark/pull/32556#issuecomment-841655969 **[Test build #138571 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138571/testReport)** for PR 32556 at commit

[GitHub] [spark] ivoson opened a new pull request #32557: [SPARK-35411][SQL] Add essential information while serializing TreeNode to json

2021-05-15 Thread GitBox
ivoson opened a new pull request #32557: URL: https://github.com/apache/spark/pull/32557 ### What changes were proposed in this pull request? Write out Seq of product objects which contain TreeNode, to avoid the cases as described in https://issues.apache.org/jira/browse/SPARK-35411

[GitHub] [spark] AmplabJenkins commented on pull request #32557: [SPARK-35411][SQL] Add essential information while serializing TreeNode to json

2021-05-15 Thread GitBox
AmplabJenkins commented on pull request #32557: URL: https://github.com/apache/spark/pull/32557#issuecomment-841680826 Can one of the admins verify this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [spark] shahidki31 commented on pull request #32556: [Minor][SPARK-35409][SQL]Add flag for escaping meta characters in show command

2021-05-15 Thread GitBox
shahidki31 commented on pull request #32556: URL: https://github.com/apache/spark/pull/32556#issuecomment-841683880 Hi @srowen , This was added to fix an issue in the JIRA: https://issues.apache.org/jira/browse/SPARK-33690. But after that it would be difficult to see spark plans using

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32552: [WIP][SPARK-34819][SPARK-18134][SQL] MapType supports comparable semantics

2021-05-15 Thread GitBox
AmplabJenkins removed a comment on pull request #32552: URL: https://github.com/apache/spark/pull/32552#issuecomment-841689180 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43094/

[GitHub] [spark] srowen commented on a change in pull request #32526: [SPARK-35391] Fix memory leak in ExecutorAllocationListener

2021-05-15 Thread GitBox
srowen commented on a change in pull request #32526: URL: https://github.com/apache/spark/pull/32526#discussion_r632986727 ## File path: core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ## @@ -859,6 +847,29 @@ private[spark] class ExecutorAllocationManager(

[GitHub] [spark] dongjoon-hyun commented on pull request #29642: [SPARK-32792][SQL] Improve Parquet In filter pushdown

2021-05-15 Thread GitBox
dongjoon-hyun commented on pull request #29642: URL: https://github.com/apache/spark/pull/29642#issuecomment-841741287 Thank you for updating, @wangyum . At the last commit, yes, I agree that it looks like there is no regression by this PR. One last question: could you spot what is

[GitHub] [spark] HyukjinKwon commented on a change in pull request #32204: [SPARK-34494][SQL][DOCS] Move JSON data source options from Python and Scala into a single page

2021-05-15 Thread GitBox
HyukjinKwon commented on a change in pull request #32204: URL: https://github.com/apache/spark/pull/32204#discussion_r633025358 ## File path: docs/sql-data-sources-json.md ## @@ -94,3 +94,146 @@ SELECT * FROM jsonTable + +## Data Source Option + +Data source options of

[GitHub] [spark] HyukjinKwon commented on a change in pull request #32204: [SPARK-34494][SQL][DOCS] Move JSON data source options from Python and Scala into a single page

2021-05-15 Thread GitBox
HyukjinKwon commented on a change in pull request #32204: URL: https://github.com/apache/spark/pull/32204#discussion_r633025358 ## File path: docs/sql-data-sources-json.md ## @@ -94,3 +94,146 @@ SELECT * FROM jsonTable + +## Data Source Option + +Data source options of

[GitHub] [spark] HyukjinKwon commented on a change in pull request #32204: [SPARK-34494][SQL][DOCS] Move JSON data source options from Python and Scala into a single page

2021-05-15 Thread GitBox
HyukjinKwon commented on a change in pull request #32204: URL: https://github.com/apache/spark/pull/32204#discussion_r633025442 ## File path: docs/sql-data-sources-json.md ## @@ -94,3 +94,146 @@ SELECT * FROM jsonTable + +## Data Source Option + +Data source options of

[GitHub] [spark] HyukjinKwon commented on a change in pull request #32204: [SPARK-34494][SQL][DOCS] Move JSON data source options from Python and Scala into a single page

2021-05-15 Thread GitBox
HyukjinKwon commented on a change in pull request #32204: URL: https://github.com/apache/spark/pull/32204#discussion_r633025337 ## File path: docs/sql-data-sources-json.md ## @@ -94,3 +94,146 @@ SELECT * FROM jsonTable + +## Data Source Option + +Data source options of

[GitHub] [spark] HyukjinKwon commented on a change in pull request #32161: [SPARK-35025][SQL][PYTHON][DOCS] Move Parquet data source options from Python and Scala into a single page.

2021-05-15 Thread GitBox
HyukjinKwon commented on a change in pull request #32161: URL: https://github.com/apache/spark/pull/32161#discussion_r633025728 ## File path: python/pyspark/sql/readwriter.py ## @@ -416,53 +416,12 @@ def parquet(self, *paths, **options): Other Parameters

[GitHub] [spark] dongjoon-hyun edited a comment on pull request #29642: [SPARK-32792][SQL] Improve Parquet In filter pushdown

2021-05-15 Thread GitBox
dongjoon-hyun edited a comment on pull request #29642: URL: https://github.com/apache/spark/pull/29642#issuecomment-841741287 Thank you for updating, @wangyum . At the last commit, yes, I agree that it looks like there is no regression by this PR. One last question: could you spot

[GitHub] [spark] HyukjinKwon commented on pull request #32558: [SPARK-34953][CORE][SQL] Add the code change for adding the DateType in the infer schema while reading

2021-05-15 Thread GitBox
HyukjinKwon commented on pull request #32558: URL: https://github.com/apache/spark/pull/32558#issuecomment-841743327 See also https://github.com/apache/spark/pull/23202. I think this JIRA is a duplicate of SPARK-26248 -- This is an automated message from the Apache Git Service. To

[GitHub] [spark] HyukjinKwon commented on a change in pull request #32558: [SPARK-34953][CORE][SQL] Add the code change for adding the DateType in the infer schema while reading

2021-05-15 Thread GitBox
HyukjinKwon commented on a change in pull request #32558: URL: https://github.com/apache/spark/pull/32558#discussion_r633020874 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/csv/CSVInferSchema.scala ## @@ -168,6 +169,15 @@ class CSVInferSchema(val

[GitHub] [spark] HyukjinKwon removed a comment on pull request #32556: [SPARK-35409][SQL] Skip escaping meta-characters for EXPLAIN command using show()

2021-05-15 Thread GitBox
HyukjinKwon removed a comment on pull request #32556: URL: https://github.com/apache/spark/pull/32556#issuecomment-841745461 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [spark] HyukjinKwon commented on a change in pull request #32555: [SPARK-35408][PYTHON] Improve parameter validation in DataFrame.show

2021-05-15 Thread GitBox
HyukjinKwon commented on a change in pull request #32555: URL: https://github.com/apache/spark/pull/32555#discussion_r633024476 ## File path: python/pyspark/sql/dataframe.py ## @@ -482,10 +482,22 @@ def show(self, n=20, truncate=True, vertical=False): age | 5

[GitHub] [spark] HyukjinKwon commented on a change in pull request #32555: [SPARK-35408][PYTHON] Improve parameter validation in DataFrame.show

2021-05-15 Thread GitBox
HyukjinKwon commented on a change in pull request #32555: URL: https://github.com/apache/spark/pull/32555#discussion_r633024555 ## File path: python/pyspark/sql/dataframe.py ## @@ -482,10 +482,22 @@ def show(self, n=20, truncate=True, vertical=False): age | 5

[GitHub] [spark] HyukjinKwon commented on a change in pull request #32204: [SPARK-34494][SQL][DOCS] Move JSON data source options from Python and Scala into a single page

2021-05-15 Thread GitBox
HyukjinKwon commented on a change in pull request #32204: URL: https://github.com/apache/spark/pull/32204#discussion_r633025267 ## File path: docs/sql-data-sources-json.md ## @@ -94,3 +94,146 @@ SELECT * FROM jsonTable + +## Data Source Option + +Data source options of

[GitHub] [spark] HyukjinKwon commented on pull request #32550: [SPARK-35282][SQL] Support AQE side shuffled hash join formula using rule

2021-05-15 Thread GitBox
HyukjinKwon commented on pull request #32550: URL: https://github.com/apache/spark/pull/32550#issuecomment-841749521 cc @maryannxue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [spark] SparkQA commented on pull request #32049: [SPARK-34952][SQL] Aggregate (Min/Max/Count) push down for Parquet

2021-05-15 Thread GitBox
SparkQA commented on pull request #32049: URL: https://github.com/apache/spark/pull/32049#issuecomment-841738479 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32049: [SPARK-34952][SQL] Aggregate (Min/Max/Count) push down for Parquet

2021-05-15 Thread GitBox
AmplabJenkins removed a comment on pull request #32049: URL: https://github.com/apache/spark/pull/32049#issuecomment-841739542 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43099/

[GitHub] [spark] AmplabJenkins commented on pull request #32049: [SPARK-34952][SQL] Aggregate (Min/Max/Count) push down for Parquet

2021-05-15 Thread GitBox
AmplabJenkins commented on pull request #32049: URL: https://github.com/apache/spark/pull/32049#issuecomment-841739542 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43099/ --

[GitHub] [spark] HyukjinKwon commented on a change in pull request #32558: [SPARK-34953][CORE][SQL] Add the code change for adding the DateType in the infer schema while reading

2021-05-15 Thread GitBox
HyukjinKwon commented on a change in pull request #32558: URL: https://github.com/apache/spark/pull/32558#discussion_r633020775 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/csv/CSVInferSchemaSuite.scala ## @@ -192,4 +192,13 @@ class

[GitHub] [spark] HyukjinKwon commented on a change in pull request #32558: [SPARK-34953][CORE][SQL] Add the code change for adding the DateType in the infer schema while reading

2021-05-15 Thread GitBox
HyukjinKwon commented on a change in pull request #32558: URL: https://github.com/apache/spark/pull/32558#discussion_r633020781 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/csv/CSVInferSchema.scala ## @@ -168,6 +169,15 @@ class CSVInferSchema(val

[GitHub] [spark] github-actions[bot] commented on pull request #31431: [WIP][SPARK-34322][SQL] When refreshing a view, also refresh its underlying tables

2021-05-15 Thread GitBox
github-actions[bot] commented on pull request #31431: URL: https://github.com/apache/spark/pull/31431#issuecomment-841742970 We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue

  1   2   >