Github user maryannxue commented on the issue:
https://github.com/apache/spark/pull/20816
Thank you, @cloud-fan and @gatorsmile !
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
GitHub user maryannxue opened a pull request:
https://github.com/apache/spark/pull/21187
[SPARK-24035][SQL] SQL syntax for Pivot
## What changes were proposed in this pull request?
Add SQL support for Pivot according to Pivot grammar defined by Oracle
(https
Github user maryannxue closed the pull request at:
https://github.com/apache/spark/pull/20613
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maryannxue commented on the issue:
https://github.com/apache/spark/pull/21187
Thank you, @aray!
Thank you, @rxin, for the nice suggestion! Changes made accordingly in my
latest commit.
---
-
To
Github user maryannxue commented on the issue:
https://github.com/apache/spark/pull/21187
Thank you, @Tagar, for you comment! I think by saying "making FOR section
optional", you actually mean to support "IN ANY".
As you said and as I have pointed in my PR d
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/21187#discussion_r185273161
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -805,6 +810,7 @@ RIGHT: 'RIGHT';
F
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/21187#discussion_r185278179
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -691,7 +691,9 @@ case class Pivot
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/21187#discussion_r185278754
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -691,7 +691,9 @@ case class Pivot
Github user maryannxue commented on the issue:
https://github.com/apache/spark/pull/21187
@gatorsmile "In-any-subquery in Pivot can be implemented like what we did
in the other parts", can you make this clearer? The Pivot's "IN" values are
special coz t
Github user maryannxue commented on the issue:
https://github.com/apache/spark/pull/21187
Thank you, @gatorsmile, for the review and comments! I have opened
SPARK-24162, SPARK-24163 and SPARK-24164 as follow-up improvements for this
issue. Please feel free to assign them to me
GitHub user maryannxue opened a pull request:
https://github.com/apache/spark/pull/21324
[SPARK-24035][SQL] SQL syntax for Pivot - fix antlr warning
## What changes were proposed in this pull request?
1. Change antlr rule to fix the warning.
2. Add PIVOT/LATERAL check
Github user maryannxue commented on the issue:
https://github.com/apache/spark/pull/21324
@gatorsmile @rxin Could you please review this fix?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/21324#discussion_r188079751
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -398,7 +398,7 @@ hintStatement
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/21324#discussion_r188080851
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -398,7 +398,7 @@ hintStatement
GitHub user maryannxue opened a pull request:
https://github.com/apache/spark/pull/21360
[SPARK-24288] Enable preventing predicate pushdown
## What changes were proposed in this pull request?
1. Add DataSet interface "withOptimizerBarrier()"
2. Modify Analysis
Github user maryannxue commented on the issue:
https://github.com/apache/spark/pull/21360
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/20816#discussion_r175330576
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -669,11 +672,42 @@ object
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/20816#discussion_r175550955
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -669,11 +672,42 @@ object
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/20816#discussion_r175864663
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -669,11 +672,42 @@ object
Github user maryannxue commented on the issue:
https://github.com/apache/spark/pull/20816
Ping @gatorsmile
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews
Github user maryannxue commented on the issue:
https://github.com/apache/spark/pull/20613
Did you get a chance to look at it, @dongjoon-hyun?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/20816#discussion_r178187202
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -669,11 +672,42 @@ object
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/20816#discussion_r178328204
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -669,11 +672,42 @@ object
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/20816#discussion_r178328704
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -669,11 +672,42 @@ object
Github user maryannxue commented on the issue:
https://github.com/apache/spark/pull/20816
@gatorsmile Do I need to sync this branch and let the tests run again?
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user maryannxue commented on the issue:
https://github.com/apache/spark/pull/21083
cc @mgaido91 @maryannxue @KaiXinXiaoLei @gatorsmile @jiangxb1987
@gengliangwang: I do not think this is the right way to do things, @cloud-fan.
Looks like you have been aware of my and others
Github user maryannxue commented on the issue:
https://github.com/apache/spark/pull/21083
Thank you for you reply, @cloud-fan! I was not clear when you had become
aware of the effort on SPARK-21479 so it might be a misunderstanding on my side
and I apologize. Anyway, if you had had a
GitHub user maryannxue opened a pull request:
https://github.com/apache/spark/pull/20613
SPARK-23368 Avoid unnecessary Exchange or Sort after projection
## What changes were proposed in this pull request?
1. Add "project" methods for both Partitioning and Orde
Github user maryannxue commented on the issue:
https://github.com/apache/spark/pull/20613
@gatorsmile, @kiszk, any update on this one?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
GitHub user maryannxue opened a pull request:
https://github.com/apache/spark/pull/20805
SPARK-21479 Outer join filter pushdown in null supplying table when
condition is on one of the joined columns
## What changes were proposed in this pull request?
In left/right outer
Github user maryannxue closed the pull request at:
https://github.com/apache/spark/pull/20805
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
GitHub user maryannxue opened a pull request:
https://github.com/apache/spark/pull/20816
SPARK-21479 Outer join filter pushdown in null supplying table when
condition is on one of the joined columns
## What changes were proposed in this pull request?
Added
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/20816#discussion_r174300996
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/InferFiltersFromConstraintsSuite.scala
---
@@ -204,4 +205,40 @@ class
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/20816#discussion_r174302419
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1071,6 +1072,66 @@ object
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/20816#discussion_r174303151
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1071,6 +1072,66 @@ object
Github user maryannxue commented on the issue:
https://github.com/apache/spark/pull/20816
How does it look now, @gatorsmile? Please let me know if there's anything I
can improve.
---
-
To unsubscribe, e
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/20816#discussion_r175184304
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -669,11 +672,42 @@ object
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/22030#discussion_r208410422
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/RelationalGroupedDataset.scala ---
@@ -384,6 +392,10 @@ class RelationalGroupedDataset protected
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/22030#discussion_r208411022
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/RelationalGroupedDataset.scala ---
@@ -384,6 +392,10 @@ class RelationalGroupedDataset protected
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/22030#discussion_r208423936
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/RelationalGroupedDataset.scala ---
@@ -403,20 +415,29 @@ class RelationalGroupedDataset protected
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/22030#discussion_r208451663
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/RelationalGroupedDataset.scala ---
@@ -335,7 +337,7 @@ class RelationalGroupedDataset protected
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/22030#discussion_r208453178
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/RelationalGroupedDataset.scala ---
@@ -403,20 +415,29 @@ class RelationalGroupedDataset protected
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/22030#discussion_r208458789
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/RelationalGroupedDataset.scala ---
@@ -403,20 +415,29 @@ class RelationalGroupedDataset protected
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/22030#discussion_r208458861
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/RelationalGroupedDataset.scala ---
@@ -335,7 +337,7 @@ class RelationalGroupedDataset protected
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/22030#discussion_r208459011
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/RelationalGroupedDataset.scala ---
@@ -403,20 +415,29 @@ class RelationalGroupedDataset protected
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/22030#discussion_r208460101
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/RelationalGroupedDataset.scala ---
@@ -403,20 +415,29 @@ class RelationalGroupedDataset protected
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/22030#discussion_r208466779
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/RelationalGroupedDataset.scala ---
@@ -335,7 +337,7 @@ class RelationalGroupedDataset protected
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/22030#discussion_r208468677
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/RelationalGroupedDataset.scala ---
@@ -403,20 +415,29 @@ class RelationalGroupedDataset protected
GitHub user maryannxue opened a pull request:
https://github.com/apache/spark/pull/22049
[SPARK-25063][SQL] Rename class KnowNotNull to KnownNotNull
## What changes were proposed in this pull request?
Correct the class name typo checked in through SPARK-24891
Github user maryannxue commented on the issue:
https://github.com/apache/spark/pull/22049
@gatorsmile
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
GitHub user maryannxue opened a pull request:
https://github.com/apache/spark/pull/22060
[DO NOT MERGE][TEST ONLY] Add once-policy rule check
## What changes were proposed in this pull request?
Rules like `HandleNullInputsForUDF`
(https://issues.apache.org/jira/browse
Github user maryannxue commented on the issue:
https://github.com/apache/spark/pull/22060
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
GitHub user maryannxue opened a pull request:
https://github.com/apache/spark/pull/21753
[SPARK-24790][SQL] Allow complex aggregate expressions in Pivot
## What changes were proposed in this pull request?
Relax the check to allow complex aggregate expressions, like
`ceil
Github user maryannxue commented on the issue:
https://github.com/apache/spark/pull/21753
@maropu It's not a bug. It works as I specified in my original PR, and you
can also refer to
https://docs.oracle.com/database/121/SQLRF/img_text/pivot_clause.htm, which
only allows a fo
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/21753#discussion_r201922330
--- Diff: sql/core/src/test/resources/sql-tests/results/pivot.sql.out ---
@@ -192,3 +192,33 @@ struct<>
-- !query 12
GitHub user maryannxue opened a pull request:
https://github.com/apache/spark/pull/21764
[SPARK-24802] Optimization Rule Exclusion
## What changes were proposed in this pull request?
Since Spark has provided fairly clear interfaces for adding user-defined
optimization
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/21764#discussion_r202759884
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -46,7 +47,23 @@ abstract class Optimizer
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/21764#discussion_r202760924
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -175,6 +179,35 @@ abstract class Optimizer
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/21764#discussion_r202762054
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -127,6 +127,14 @@ object SQLConf
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/21764#discussion_r202786530
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -127,6 +127,14 @@ object SQLConf
Github user maryannxue commented on the issue:
https://github.com/apache/spark/pull/21720
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user maryannxue commented on the issue:
https://github.com/apache/spark/pull/21720
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/21764#discussion_r203730125
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -175,6 +182,44 @@ abstract class Optimizer
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/21764#discussion_r203730652
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -160,6 +160,13 @@ abstract class Optimizer
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/21764#discussion_r203730778
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/OptimizerRuleExclusionSuite.scala
---
@@ -0,0 +1,84
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/21764#discussion_r203731087
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -127,6 +127,14 @@ object SQLConf
Github user maryannxue commented on the issue:
https://github.com/apache/spark/pull/21821
Yes, @gatorsmile. Code is ready. Will post a PR shortly.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/21764#discussion_r204279843
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -175,6 +191,41 @@ abstract class Optimizer
Github user maryannxue commented on the issue:
https://github.com/apache/spark/pull/21821
I just ran a test with once-strategy check and found out that a few
batches/rules do not stop, e.g. AggregatePushDown, "Convert to Spark client
exec", PartitionPruning. I believe mo
GitHub user maryannxue opened a pull request:
https://github.com/apache/spark/pull/21851
[SPARK-24891][SQL] Fix HandleNullInputsForUDF rule
## What changes were proposed in this pull request?
The HandleNullInputsForUDF would always add a new `If` node every time it
is
Github user maryannxue commented on the issue:
https://github.com/apache/spark/pull/21403
I think the behavior definition is good and clear. But just a question on
the implementation: is it necessary to introduce a new class `InValues`? or we
could simply make `In` has it's
Github user maryannxue commented on the issue:
https://github.com/apache/spark/pull/21821
LGTM.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maryannxue closed the pull request at:
https://github.com/apache/spark/pull/21360
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
GitHub user maryannxue opened a pull request:
https://github.com/apache/spark/pull/21875
[SPARK-24288][SQL] Enable preventing predicate pushdown
## What changes were proposed in this pull request?
Add a JDBC Option "pushDownPredicate" (default `true`) to allo
Github user maryannxue commented on the issue:
https://github.com/apache/spark/pull/21875
@gatorsmile @TomaszGaweda
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user maryannxue commented on the issue:
https://github.com/apache/spark/pull/21403
@mgaido91 I see. But by using Seq[Expression] in `In`, can we hopefully
remove `ResolveInValues`. I wouldn't mind changing the parser if it's necessary
and if it saves work elsewhe
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/21875#discussion_r205266067
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala
---
@@ -172,7 +172,11 @@ private[sql] case class
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/21875#discussion_r205267327
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCOptions.scala
---
@@ -183,6 +183,9 @@ class JDBCOptions
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/21875#discussion_r205268701
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala
---
@@ -172,7 +172,11 @@ private[sql] case class
GitHub user maryannxue opened a pull request:
https://github.com/apache/spark/pull/21876
[SPARK-24802][SQL][FOLLOW-UP] Add a new config for Optimization Rule
Exclusion
## What changes were proposed in this pull request?
This is an extension to the original PR, in which
Github user maryannxue commented on the issue:
https://github.com/apache/spark/pull/21875
Programming guide updated. Thank you, @dilipbiswal and @HyukjinKwon!
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user maryannxue commented on the issue:
https://github.com/apache/spark/pull/21699
@MaxGekk Yes, it was caused by my previous PR. The change in my PR was a
walk-around for an existing problem in either Aggregate or PivotFirst (I
suspect it's Aggregate) with struct-type co
GitHub user maryannxue opened a pull request:
https://github.com/apache/spark/pull/21926
[SPARK-24972][SQL] PivotFirst could not handle pivot columns of complex
types
## What changes were proposed in this pull request?
When the pivot column is of a complex type, the eval
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/21926#discussion_r206354004
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -574,10 +578,14 @@ class Analyzer
Github user maryannxue commented on the issue:
https://github.com/apache/spark/pull/21699
@MaxGekk Please take a look at https://github.com/apache/spark/pull/21926.
There was a bug in PivotFirst and this PR should fix your test here
Github user maryannxue commented on the issue:
https://github.com/apache/spark/pull/21926
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user maryannxue commented on the issue:
https://github.com/apache/spark/pull/21699
@MaxGekk LGTM, but one more thing to consider:
Since we support column list in SQL, it would be nice to support it and
test it in DataFrame pivot too. The only thing that we need to enable is
Github user maryannxue commented on the issue:
https://github.com/apache/spark/pull/21699
Thank you for the change, @MaxGekk!
@HyukjinKwon my idea was actually that the overloaded versions of pivot
would be `pivot(column: Column, values, Seq[Column])`, so that we can construct
Github user maryannxue commented on the issue:
https://github.com/apache/spark/pull/21699
> Actually I am mostly worry of the pivotColumn. Specifying multiple
columns via struct is not intuitive I believe.
It depends on whether we'd like to add extra interfaces for
GitHub user maryannxue opened a pull request:
https://github.com/apache/spark/pull/21585
[SPARK-24583][SQL] Wrong schema type in InsertIntoDataSourceCommand
## What changes were proposed in this pull request?
Change insert input schema type: "insertRelatio
Github user maryannxue commented on the issue:
https://github.com/apache/spark/pull/21585
@gatorsmile @cloud-fan Could you please review this PR?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user maryannxue commented on the issue:
https://github.com/apache/spark/pull/21585
Done with the changes. Thanks a lot, @cloud-fan !
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
GitHub user maryannxue opened a pull request:
https://github.com/apache/spark/pull/21594
[SPARK-24596][SQL] Non-cascading Cache Invalidation
## What changes were proposed in this pull request?
1. Add parameter 'cascade' in CacheManager.uncacheQuery(). Under
Github user maryannxue commented on the issue:
https://github.com/apache/spark/pull/21594
cc @gatorsmile @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/21594#discussion_r196899266
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/CacheManager.scala ---
@@ -107,22 +107,35 @@ class CacheManager extends Logging
Github user maryannxue commented on the issue:
https://github.com/apache/spark/pull/21594
@TomaszGaweda @viirya Nice suggestion about the doc. I'll update it.
---
-
To unsubscribe, e-mail: reviews-uns
GitHub user maryannxue opened a pull request:
https://github.com/apache/spark/pull/21602
[SPARK-24613][SQL] Cache with UDF could not be matched with subsequent
dependent caches
## What changes were proposed in this pull request?
Wrap the logical plan with a
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/21602#discussion_r197017717
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DatasetCacheSuite.scala ---
@@ -132,4 +132,19 @@ class DatasetCacheSuite extends QueryTest with
Github user maryannxue commented on the issue:
https://github.com/apache/spark/pull/21594
retest please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/21594#discussion_r197314556
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DatasetCacheSuite.scala ---
@@ -143,9 +153,57 @@ class DatasetCacheSuite extends QueryTest with
1 - 100 of 194 matches
Mail list logo
