Github user yangw1234 commented on a diff in the pull request:
https://github.com/apache/spark/pull/13585#discussion_r66743506
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveStrategies.scala ---
@@ -65,15 +65,20 @@ private[hive] trait HiveStrategies
Github user yangw1234 commented on the issue:
https://github.com/apache/spark/pull/13585
Hi @liancheng , CNF is truly a more systematic way to deal with this
problem.
Not really sure I am right or not, but I think as long as we push the `not`
operator down to the lowest
Github user yangw1234 commented on a diff in the pull request:
https://github.com/apache/spark/pull/13585#discussion_r66742485
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala
---
@@ -92,6 +92,36 @@ object PhysicalOperation extends
GitHub user yangw1234 opened a pull request:
https://github.com/apache/spark/pull/13601
[SPARK-15875] Try to use Seq.isEmpty and Seq.nonEmpty instead of Seq.length
== 0 and Seq.length > 0
## What changes were proposed in this pull request?
In scala, immutable.List.len
Github user yangw1234 commented on a diff in the pull request:
https://github.com/apache/spark/pull/13601#discussion_r66630258
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1656,7 +1656,7 @@ class Analyzer
Github user yangw1234 commented on a diff in the pull request:
https://github.com/apache/spark/pull/13585#discussion_r66714468
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala
---
@@ -92,6 +92,36 @@ object PhysicalOperation extends
Github user yangw1234 commented on the issue:
https://github.com/apache/spark/pull/11929
Hi @hvanhovell , just checked. In branch-1.6 latest code, yes this problem
still exists. Branch master and branch-2.0 don't have this problem.
---
If your project is set up for it, you can reply
Github user yangw1234 commented on the issue:
https://github.com/apache/spark/pull/16820
@mengxr @rxin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user yangw1234 opened a pull request:
https://github.com/apache/spark/pull/16820
[SPARK-19471] AggregationIterator does not initialize the generated result
projection before using it
## What changes were proposed in this pull request?
When AggregationIterator
Github user yangw1234 commented on the issue:
https://github.com/apache/spark/pull/16820
@hvanhovell thanks for your review. Whole stage code generation seems fine
and unit test is added.
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user yangw1234 opened a pull request:
https://github.com/apache/spark/pull/15096
[SPARK-17537] [SQL] Reading parquet schema from driver directly when there
is only one file to touch
## What changes were proposed in this pull request?
`spark.read.parquet("parque
Github user yangw1234 closed the pull request at:
https://github.com/apache/spark/pull/15096
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user yangw1234 commented on the issue:
https://github.com/apache/spark/pull/15096
Yes, this is a duplicate, closing it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user yangw1234 commented on a diff in the pull request:
https://github.com/apache/spark/pull/15416#discussion_r82715416
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -298,10 +298,11 @@ class Analyzer(
case
Github user yangw1234 commented on a diff in the pull request:
https://github.com/apache/spark/pull/15416#discussion_r82715694
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -298,10 +298,11 @@ class Analyzer(
case
Github user yangw1234 commented on the issue:
https://github.com/apache/spark/pull/15416
@rxin @davies Will this patch be merged in 2.0.2? Kind of need this to
upgrade our production environment. Thanks.
---
If your project is set up for it, you can reply to this email and have
Github user yangw1234 commented on the issue:
https://github.com/apache/spark/pull/15416
scala style fixed.
I didn't notice. Sorry for the delay. @rxin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user yangw1234 opened a pull request:
https://github.com/apache/spark/pull/15416
[SPARK-17849] Fix NPE problem when using grouping sets
## What changes were proposed in this pull request?
Prior this pr, the following code would cause an NPE:
`case class point(a:String
Github user yangw1234 commented on a diff in the pull request:
https://github.com/apache/spark/pull/15416#discussion_r82562070
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -2189,6 +2189,24 @@ class SQLQuerySuite extends QueryTest
Github user yangw1234 commented on the issue:
https://github.com/apache/spark/pull/15416
cc @davies Would you help reviewing this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user yangw1234 commented on the issue:
https://github.com/apache/spark/pull/15416
also cc @hvanhovell
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user yangw1234 commented on a diff in the pull request:
https://github.com/apache/spark/pull/15416#discussion_r82721927
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -298,10 +298,14 @@ class Analyzer(
case
Github user yangw1234 commented on a diff in the pull request:
https://github.com/apache/spark/pull/15416#discussion_r82726593
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -298,10 +298,14 @@ class Analyzer(
case
Github user yangw1234 commented on the issue:
https://github.com/apache/spark/pull/15416
@davies Other places all seem to be correct.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user yangw1234 commented on the issue:
https://github.com/apache/spark/pull/16820
@gatorsmile Sorry, I totally forget this pr. I will try to address the
comment this week (need a little time to re-familiarize the context).
---
If your project is set up for it, you can reply
Github user yangw1234 closed the pull request at:
https://github.com/apache/spark/pull/11929
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user yangw1234 commented on the issue:
https://github.com/apache/spark/pull/11929
sure
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user yangw1234 commented on the issue:
https://github.com/apache/spark/pull/16820
Sorry I could not find time to finish this pr recently. Close it for now.
If you need this fix, please feel free to base on it and finish it.
---
If your project is set up for it, you can reply
Github user yangw1234 closed the pull request at:
https://github.com/apache/spark/pull/16820
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user yangw1234 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19717#discussion_r157666054
--- Diff:
resource-managers/kubernetes/docker/src/main/dockerfiles/spark-base/Dockerfile
---
@@ -0,0 +1,47 @@
+#
+# Licensed to the Apache
Github user yangw1234 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19717#discussion_r155707713
--- Diff:
resource-managers/kubernetes/docker/src/main/dockerfiles/spark-base/Dockerfile
---
@@ -0,0 +1,47 @@
+#
+# Licensed to the Apache
31 matches
Mail list logo
