[GitHub] [spark] William1104 commented on issue #24221: [SPARK-27248][SQL] refresh table should recreate cache with same cache name
William1104 commented on issue #24221: [SPARK-27248][SQL] refresh table should recreate cache with same cache name URL: https://github.com/apache/spark/pull/24221#issuecomment-487450791 Hi @cloud-fan , @gatorsmile and @srowen , Appreciate if you can take a look the PR again. I enhanced the test case to cover storage level. If we should remove the note in migration guide, I could update it accordingly as well. Many thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] William1104 commented on issue #24221: [SPARK-27248][SQL] refresh table should recreate cache with same cache name
William1104 commented on issue #24221: [SPARK-27248][SQL] refresh table should recreate cache with same cache name URL: https://github.com/apache/spark/pull/24221#issuecomment-483065759 Hi @gatorsmile, Would you mind to review it again? I moved tests from sql/hive to sql/core as those tests do not depend on anything on hive. I hope it also makes sense to you. Thanks, William This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] William1104 commented on issue #24221: [SPARK-27248][SQL] refresh table should recreate cache with same cache name
William1104 commented on issue #24221: [SPARK-27248][SQL] refresh table should recreate cache with same cache name URL: https://github.com/apache/spark/pull/24221#issuecomment-479560769 Hi @gatorsmile, thanks for the review. * May I know where the migration guide? I am happy to update related session. * A newly added test ‘Refresh Qualified Table’ would fail with the old behavior. The old behavior would recreate cache with unqualified name upon table refresh. This test was added to verify the new behavior. * Yes. You are right that we should add a test to sql/core. I will checkout related test cases in sql/core to learn a bit more on that. * it seems that we missed a test utility to create a cache with non temp table and clean them up afterward. I will creat such utility to enrich the test utilities. * I will do my best to check those cache/uncache calls. Hope I did not miss anyone. Again. Thanks for your help. Best regards, William This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] William1104 commented on issue #24221: [SPARK-27248][SQL] refresh table should recreate cache with same cache name
William1104 commented on issue #24221: [SPARK-27248][SQL] refresh table should recreate cache with same cache name URL: https://github.com/apache/spark/pull/24221#issuecomment-478570405 Hi @cloud-fan, appreciate if you could take a look this PR. I hope it makes sense. Best regards, William This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] William1104 commented on issue #24221: [SPARK-27248][SQL] refresh table should recreate cache with same cache name
William1104 commented on issue #24221: [SPARK-27248][SQL] refresh table should recreate cache with same cache name URL: https://github.com/apache/spark/pull/24221#issuecomment-478308499 Hi @srowen, this PR is to preserve cache name and storage level when refresh a table. May I know if you can help to review it as well? Appreciate your help. Thanks and regards, William This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] William1104 commented on issue #24221: [SPARK-27248][SQL] refresh table should recreate cache with same cache name
William1104 commented on issue #24221: [SPARK-27248][SQL] refresh table should recreate cache with same cache name URL: https://github.com/apache/spark/pull/24221#issuecomment-478202736 Hi @dongjoon-hyun, would you mind to also take a look the PR? If it is good, pls kindly help to merge. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] William1104 commented on issue #24221: [SPARK-27248][SQL] refresh table should recreate cache with same cache name
William1104 commented on issue #24221: [SPARK-27248][SQL] refresh table should recreate cache with same cache name URL: https://github.com/apache/spark/pull/24221#issuecomment-477636923 Hi @attilapiros , thanks for those review. just patched the PR accordingly. please review again. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] William1104 commented on issue #24221: [SPARK-27248][SQL] refresh table should recreate cache with same cache name
William1104 commented on issue #24221: [SPARK-27248][SQL] refresh table should recreate cache with same cache name URL: https://github.com/apache/spark/pull/24221#issuecomment-477267036 > Nit: avoid punctuation-free syntax for methods where the name is not an operator Thanks. Will update it. BTW, Scala is relative new to me. May I know where I can find good style guide? Any good book / reference ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] William1104 commented on issue #24221: [SPARK-27248][SQL] refresh table should recreate cache with same cache name
William1104 commented on issue #24221: [SPARK-27248][SQL] refresh table should recreate cache with same cache name URL: https://github.com/apache/spark/pull/24221#issuecomment-477237397 Hi @attilapiros, I did not realize pushing my changes to the branch would trigger a build automatically. I will test it before push next time. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] William1104 commented on issue #24221: [SPARK-27248][SQL] refresh table should recreate cache with same cache name
William1104 commented on issue #24221: [SPARK-27248][SQL] refresh table should recreate cache with same cache name URL: https://github.com/apache/spark/pull/24221#issuecomment-477218636 Hi @attilapiros , Thanks for the review and hints. I will fix them soon. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] William1104 commented on issue #24221: [SPARK-27248][SQL] refresh table should recreate cache with same cache name
William1104 commented on issue #24221: [SPARK-27248][SQL] refresh table should recreate cache with same cache name URL: https://github.com/apache/spark/pull/24221#issuecomment-477216623 Hi @dongjoon-hyun, Many thanks. :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
