[GitHub] [spark] baganokodo2022 commented on a diff in pull request #38922: [SPARK-41396][SQL][PROTOBUF] OneOf field support and recursion checks

2022-12-08 Thread GitBox
baganokodo2022 commented on code in PR #38922: URL: https://github.com/apache/spark/pull/38922#discussion_r1043925095 ## connector/protobuf/src/main/scala/org/apache/spark/sql/protobuf/utils/ProtobufOptions.scala: ## @@ -38,6 +38,12 @@ private[sql] class ProtobufOptions( va

[GitHub] [spark] baganokodo2022 commented on a diff in pull request #38922: [SPARK-41396][SQL][PROTOBUF] OneOf field support and recursion checks

2022-12-08 Thread GitBox
baganokodo2022 commented on code in PR #38922: URL: https://github.com/apache/spark/pull/38922#discussion_r1043904214 ## connector/protobuf/src/main/scala/org/apache/spark/sql/protobuf/utils/SchemaConverters.scala: ## @@ -92,14 +109,38 @@ object SchemaConverters { M

[GitHub] [spark] baganokodo2022 commented on a diff in pull request #38922: [SPARK-41396][SQL][PROTOBUF] OneOf field support and recursion checks

2022-12-08 Thread GitBox
baganokodo2022 commented on code in PR #38922: URL: https://github.com/apache/spark/pull/38922#discussion_r1043901516 ## connector/protobuf/src/main/scala/org/apache/spark/sql/protobuf/utils/SchemaConverters.scala: ## @@ -40,19 +40,26 @@ object SchemaConverters { * * @si