[GitHub] [spark] cloud-fan commented on a change in pull request #26881: [SPARK-30252][SQL] Disallow negative scale of Decimal

2020-01-14 Thread GitBox
cloud-fan commented on a change in pull request #26881: [SPARK-30252][SQL] Disallow negative scale of Decimal URL: https://github.com/apache/spark/pull/26881#discussion_r366725522 ## File path: sql/core/src/test/resources/sql-tests/results/ansi/literals.sql.out ## @@

[GitHub] [spark] cloud-fan commented on a change in pull request #26881: [SPARK-30252][SQL] Disallow negative scale of Decimal

2020-01-14 Thread GitBox
cloud-fan commented on a change in pull request #26881: [SPARK-30252][SQL] Disallow negative scale of Decimal URL: https://github.com/apache/spark/pull/26881#discussion_r366725133 ## File path:

[GitHub] [spark] cloud-fan commented on a change in pull request #26881: [SPARK-30252][SQL] Disallow negative scale of Decimal

2020-01-14 Thread GitBox
cloud-fan commented on a change in pull request #26881: [SPARK-30252][SQL] Disallow negative scale of Decimal URL: https://github.com/apache/spark/pull/26881#discussion_r366725192 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/types/DecimalSuite.scala ##

[GitHub] [spark] cloud-fan commented on a change in pull request #26881: [SPARK-30252][SQL] Disallow negative scale of Decimal

2020-01-14 Thread GitBox
cloud-fan commented on a change in pull request #26881: [SPARK-30252][SQL] Disallow negative scale of Decimal URL: https://github.com/apache/spark/pull/26881#discussion_r366724047 ## File path: python/pyspark/sql/tests/test_types.py ## @@ -204,12 +204,16 @@ def

[GitHub] [spark] cloud-fan commented on a change in pull request #26881: [SPARK-30252][SQL] Disallow negative scale of Decimal

2020-01-14 Thread GitBox
cloud-fan commented on a change in pull request #26881: [SPARK-30252][SQL] Disallow negative scale of Decimal URL: https://github.com/apache/spark/pull/26881#discussion_r366724203 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ## @@

[GitHub] [spark] cloud-fan commented on a change in pull request #26881: [SPARK-30252][SQL] Disallow negative scale of Decimal

2020-01-14 Thread GitBox
cloud-fan commented on a change in pull request #26881: [SPARK-30252][SQL] Disallow negative scale of Decimal URL: https://github.com/apache/spark/pull/26881#discussion_r366237772 ## File path: sql/core/src/test/resources/sql-tests/results/literals.sql.out ## @@ -211,7

[GitHub] [spark] cloud-fan commented on a change in pull request #26881: [SPARK-30252][SQL] Disallow negative scale of Decimal

2020-01-14 Thread GitBox
cloud-fan commented on a change in pull request #26881: [SPARK-30252][SQL] Disallow negative scale of Decimal URL: https://github.com/apache/spark/pull/26881#discussion_r366233799 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala ## @@

[GitHub] [spark] cloud-fan commented on a change in pull request #26881: [SPARK-30252][SQL] Disallow negative scale of Decimal under ansi mode

2020-01-08 Thread GitBox
cloud-fan commented on a change in pull request #26881: [SPARK-30252][SQL] Disallow negative scale of Decimal under ansi mode URL: https://github.com/apache/spark/pull/26881#discussion_r364192439 ## File path:

[GitHub] [spark] cloud-fan commented on a change in pull request #26881: [SPARK-30252][SQL] Disallow negative scale of Decimal under ansi mode

2020-01-08 Thread GitBox
cloud-fan commented on a change in pull request #26881: [SPARK-30252][SQL] Disallow negative scale of Decimal under ansi mode URL: https://github.com/apache/spark/pull/26881#discussion_r364192940 ## File path:

[GitHub] [spark] cloud-fan commented on a change in pull request #26881: [SPARK-30252][SQL] Disallow negative scale of Decimal under ansi mode

2020-01-08 Thread GitBox
cloud-fan commented on a change in pull request #26881: [SPARK-30252][SQL] Disallow negative scale of Decimal under ansi mode URL: https://github.com/apache/spark/pull/26881#discussion_r364192439 ## File path: