[GitHub] [spark] cloud-fan commented on a change in pull request #29792: [SPARK-32858][SQL] UnwrapCastInBinaryComparison: support other numeric types

2020-10-12 Thread GitBox
cloud-fan commented on a change in pull request #29792: URL: https://github.com/apache/spark/pull/29792#discussion_r503135640 ## File path: sql/core/src/test/scala/org/apache/spark/sql/UnwrapCastInComparisonEndToEndSuite.scala ## @@ -0,0 +1,165 @@ +/* + * Licensed to the

[GitHub] [spark] cloud-fan commented on a change in pull request #29792: [SPARK-32858][SQL] UnwrapCastInBinaryComparison: support other numeric types

2020-10-12 Thread GitBox
cloud-fan commented on a change in pull request #29792: URL: https://github.com/apache/spark/pull/29792#discussion_r503134929 ## File path: sql/core/src/test/scala/org/apache/spark/sql/UnwrapCastInComparisonEndToEndSuite.scala ## @@ -0,0 +1,165 @@ +/* + * Licensed to the

[GitHub] [spark] cloud-fan commented on a change in pull request #29792: [SPARK-32858][SQL] UnwrapCastInBinaryComparison: support other numeric types

2020-10-12 Thread GitBox
cloud-fan commented on a change in pull request #29792: URL: https://github.com/apache/spark/pull/29792#discussion_r503133967 ## File path: sql/core/src/test/scala/org/apache/spark/sql/UnwrapCastInComparisonEndToEndSuite.scala ## @@ -0,0 +1,165 @@ +/* + * Licensed to the

[GitHub] [spark] cloud-fan commented on a change in pull request #29792: [SPARK-32858][SQL] UnwrapCastInBinaryComparison: support other numeric types

2020-10-12 Thread GitBox
cloud-fan commented on a change in pull request #29792: URL: https://github.com/apache/spark/pull/29792#discussion_r503132659 ## File path: sql/core/src/test/scala/org/apache/spark/sql/UnwrapCastInComparisonEndToEndSuite.scala ## @@ -0,0 +1,165 @@ +/* + * Licensed to the

[GitHub] [spark] cloud-fan commented on a change in pull request #29792: [SPARK-32858][SQL] UnwrapCastInBinaryComparison: support other numeric types

2020-10-12 Thread GitBox
cloud-fan commented on a change in pull request #29792: URL: https://github.com/apache/spark/pull/29792#discussion_r503130781 ## File path: sql/core/src/test/scala/org/apache/spark/sql/UnwrapCastInComparisonEndToEndSuite.scala ## @@ -0,0 +1,165 @@ +/* + * Licensed to the

[GitHub] [spark] cloud-fan commented on a change in pull request #29792: [SPARK-32858][SQL] UnwrapCastInBinaryComparison: support other numeric types

2020-10-06 Thread GitBox
cloud-fan commented on a change in pull request #29792: URL: https://github.com/apache/spark/pull/29792#discussion_r500247652 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/UnwrapCastInBinaryComparison.scala ## @@ -116,82 +128,118 @@ object

[GitHub] [spark] cloud-fan commented on a change in pull request #29792: [SPARK-32858][SQL] UnwrapCastInBinaryComparison: support other numeric types

2020-10-06 Thread GitBox
cloud-fan commented on a change in pull request #29792: URL: https://github.com/apache/spark/pull/29792#discussion_r500137824 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/UnwrapCastInBinaryComparison.scala ## @@ -116,82 +132,118 @@ object

[GitHub] [spark] cloud-fan commented on a change in pull request #29792: [SPARK-32858][SQL] UnwrapCastInBinaryComparison: support other numeric types

2020-10-06 Thread GitBox
cloud-fan commented on a change in pull request #29792: URL: https://github.com/apache/spark/pull/29792#discussion_r500243158 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/UnwrapCastInBinaryComparison.scala ## @@ -116,82 +132,118 @@ object

[GitHub] [spark] cloud-fan commented on a change in pull request #29792: [SPARK-32858][SQL] UnwrapCastInBinaryComparison: support other numeric types

2020-10-06 Thread GitBox
cloud-fan commented on a change in pull request #29792: URL: https://github.com/apache/spark/pull/29792#discussion_r500138374 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/UnwrapCastInBinaryComparison.scala ## @@ -116,82 +128,118 @@ object

[GitHub] [spark] cloud-fan commented on a change in pull request #29792: [SPARK-32858][SQL] UnwrapCastInBinaryComparison: support other numeric types

2020-10-06 Thread GitBox
cloud-fan commented on a change in pull request #29792: URL: https://github.com/apache/spark/pull/29792#discussion_r500137824 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/UnwrapCastInBinaryComparison.scala ## @@ -116,82 +132,118 @@ object

[GitHub] [spark] cloud-fan commented on a change in pull request #29792: [SPARK-32858][SQL] UnwrapCastInBinaryComparison: support other numeric types

2020-09-29 Thread GitBox
cloud-fan commented on a change in pull request #29792: URL: https://github.com/apache/spark/pull/29792#discussion_r496547966 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/UnwrapCastInBinaryComparison.scala ## @@ -116,82 +132,118 @@ object

[GitHub] [spark] cloud-fan commented on a change in pull request #29792: [SPARK-32858][SQL] UnwrapCastInBinaryComparison: support other numeric types

2020-09-29 Thread GitBox
cloud-fan commented on a change in pull request #29792: URL: https://github.com/apache/spark/pull/29792#discussion_r496536630 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/UnwrapCastInBinaryComparison.scala ## @@ -116,82 +132,118 @@ object

[GitHub] [spark] cloud-fan commented on a change in pull request #29792: [SPARK-32858][SQL] UnwrapCastInBinaryComparison: support other numeric types

2020-09-29 Thread GitBox
cloud-fan commented on a change in pull request #29792: URL: https://github.com/apache/spark/pull/29792#discussion_r496529759 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/UnwrapCastInBinaryComparison.scala ## @@ -200,25 +252,27 @@ object

[GitHub] [spark] cloud-fan commented on a change in pull request #29792: [SPARK-32858][SQL] UnwrapCastInBinaryComparison: support other numeric types

2020-09-29 Thread GitBox
cloud-fan commented on a change in pull request #29792: URL: https://github.com/apache/spark/pull/29792#discussion_r496523301 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/UnwrapCastInBinaryComparison.scala ## @@ -35,18 +35,34 @@ import

[GitHub] [spark] cloud-fan commented on a change in pull request #29792: [SPARK-32858][SQL] UnwrapCastInBinaryComparison: support other numeric types

2020-09-25 Thread GitBox
cloud-fan commented on a change in pull request #29792: URL: https://github.com/apache/spark/pull/29792#discussion_r495008728 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/UnwrapCastInBinaryComparisonSuite.scala ## @@ -79,13 +106,65 @@

[GitHub] [spark] cloud-fan commented on a change in pull request #29792: [SPARK-32858][SQL] UnwrapCastInBinaryComparison: support other numeric types

2020-09-23 Thread GitBox
cloud-fan commented on a change in pull request #29792: URL: https://github.com/apache/spark/pull/29792#discussion_r493731636 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/UnwrapCastInBinaryComparisonSuite.scala ## @@ -79,13 +106,65 @@

[GitHub] [spark] cloud-fan commented on a change in pull request #29792: [SPARK-32858][SQL] UnwrapCastInBinaryComparison: support other numeric types

2020-09-23 Thread GitBox
cloud-fan commented on a change in pull request #29792: URL: https://github.com/apache/spark/pull/29792#discussion_r493216123 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/UnwrapCastInBinaryComparisonSuite.scala ## @@ -67,6 +77,23 @@ class