[GitHub] [spark] dtenedor commented on pull request #40496: [SPARK-42874][SQL] Enable new golden file test framework for analysis for all input files

2023-03-24 Thread via GitHub
dtenedor commented on PR #40496: URL: https://github.com/apache/spark/pull/40496#issuecomment-1483703189 Looks like @LuciferYang fixed it with https://github.com/apache/spark/pull/40552. Thanks so much for the fix! -- This is an automated message from the Apache Git Service. To respond

[GitHub] [spark] dtenedor commented on pull request #40496: [SPARK-42874][SQL] Enable new golden file test framework for analysis for all input files

2023-03-24 Thread via GitHub
dtenedor commented on PR #40496: URL: https://github.com/apache/spark/pull/40496#issuecomment-1483263177 @HyukjinKwon I ran the test locally and it passes. Maybe it is fixed at head now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] dtenedor commented on pull request #40496: [SPARK-42874][SQL] Enable new golden file test framework for analysis for all input files

2023-03-24 Thread via GitHub
dtenedor commented on PR #40496: URL: https://github.com/apache/spark/pull/40496#issuecomment-1483097427 Sure, I can take a look. On Fri, Mar 24, 2023 at 3:12 AM Hyukjin Kwon ***@***.***> wrote: > I think ANSI test fails after this PR: > > [info] -

[GitHub] [spark] dtenedor commented on pull request #40496: [SPARK-42874][SQL] Enable new golden file test framework for analysis for all input files

2023-03-21 Thread via GitHub
dtenedor commented on PR #40496: URL: https://github.com/apache/spark/pull/40496#issuecomment-1478835534 @HyukjinKwon the tests are passing now, this is ready to merge if you are ready :) -- This is an automated message from the Apache Git Service. To respond to the message, please log