[GitHub] [spark] sathiyapk commented on pull request #34593: [SPARK-37324][SQL] Adds support for decimal rounding mode up, down, half_down
sathiyapk commented on pull request #34593: URL: https://github.com/apache/spark/pull/34593#issuecomment-979436276 @gengliangwang @HyukjinKwon what do you think ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] sathiyapk commented on pull request #34593: [SPARK-37324][SQL] Adds support for decimal rounding mode up, down, half_down
sathiyapk commented on pull request #34593: URL: https://github.com/apache/spark/pull/34593#issuecomment-979429513 @cloud-fan In our case, the first function we looked into was `floor`/`ceil` but since it didn't take the scale parameter we had to look for other ways. So i believe adding a `scale` parameter to floor/ceil is a good idea and also I believe the rounding of negative numbers are not so common. If everyone agree I will open a new PR for the scale parameter to `floor`/`ceil` function. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] sathiyapk commented on pull request #34593: [SPARK-37324][SQL] Adds support for decimal rounding mode up, down, half_down
sathiyapk commented on pull request #34593: URL: https://github.com/apache/spark/pull/34593#issuecomment-979224815 @cloud-fan I like the idea of adding `scale` parameter to `floor` and `ceil`. This would simulate the rounding mode `UP` and `down` for positive integers, but for negative integers it will work differently i believe ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] sathiyapk commented on pull request #34593: [SPARK-37324][SQL] Adds support for decimal rounding mode up, down, half_down
sathiyapk commented on pull request #34593: URL: https://github.com/apache/spark/pull/34593#issuecomment-979089012 @cloud-fan @gengliangwang I confirm `floor` and `ceil` don't match our use case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] sathiyapk commented on pull request #34593: [SPARK-37324][SQL] Adds support for decimal rounding mode up, down, half_down
sathiyapk commented on pull request #34593: URL: https://github.com/apache/spark/pull/34593#issuecomment-979087156 Currently, we are relying on UDF for rounding, when i googled to do it via spark native methods, i found a lot of people have the same issue and it's not complex to support it via spark native methods, so i opened this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] sathiyapk commented on pull request #34593: [SPARK-37324][SQL] Adds support for decimal rounding mode up, down, half_down
sathiyapk commented on pull request #34593: URL: https://github.com/apache/spark/pull/34593#issuecomment-974659848 @HyukjinKwon May I know the status of this PR please ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] sathiyapk commented on pull request #34593: [SPARK-37324][SQL] Adds support for decimal rounding mode up, down, half_down
sathiyapk commented on pull request #34593: URL: https://github.com/apache/spark/pull/34593#issuecomment-974659848 @HyukjinKwon May I know the status of this PR please ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] sathiyapk commented on pull request #34593: [SPARK-37324][SQL] Adds support for decimal rounding mode up, down, half_down
sathiyapk commented on pull request #34593: URL: https://github.com/apache/spark/pull/34593#issuecomment-973394467 @HyukjinKwon All tests are passing. I'm not sure why the Kubernetes integration test is failing, could you please kindly take a loot at it ? thanks ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] sathiyapk commented on pull request #34593: [SPARK-37324][SQL] Adds support for decimal rounding mode up, down, half_down
sathiyapk commented on pull request #34593: URL: https://github.com/apache/spark/pull/34593#issuecomment-969299145 @gengliangwang Could you please kindly take a look at this ? thank you very much. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] sathiyapk commented on pull request #34593: [SPARK-37324][SQL] Adds support for decimal rounding mode up, down, half_down
sathiyapk commented on pull request #34593:
URL: https://github.com/apache/spark/pull/34593#issuecomment-969293378
**Test Fails on compatibility check against spark-sql_2.12:3.2.0!** but it
is normal, no ? any idea how can we fix it ?
error] spark-sql: Failed binary compatibility check against
org.apache.spark:spark-sql_2.12:3.2.0! Found 2 potential problems (filtered 203)
[error] * static method
round(org.apache.spark.sql.Column,Int)org.apache.spark.sql.Column in class
org.apache.spark.sql.functions does not have a correspondent in current version
[error]filter with:
ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.sql.functions.round")
[error] * method
round(org.apache.spark.sql.Column,Int)org.apache.spark.sql.Column in object
org.apache.spark.sql.functions does not have a correspondent in current version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
