[GitHub] [spark] wangyum commented on a diff in pull request #40268: [SPARK-42500][SQL] ConstantPropagation support more cases

2023-03-29 Thread via GitHub
wangyum commented on code in PR #40268: URL: https://github.com/apache/spark/pull/40268#discussion_r1151346831 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala: ## @@ -113,15 +114,13 @@ object ConstantPropagation extends Rule[LogicalPlan]

[GitHub] [spark] wangyum commented on a diff in pull request #40268: [SPARK-42500][SQL] ConstantPropagation support more cases

2023-03-28 Thread via GitHub
wangyum commented on code in PR #40268: URL: https://github.com/apache/spark/pull/40268#discussion_r1151346831 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala: ## @@ -113,15 +114,13 @@ object ConstantPropagation extends Rule[LogicalPlan]

[GitHub] [spark] wangyum commented on a diff in pull request #40268: [SPARK-42500][SQL] ConstantPropagation support more cases

2023-03-06 Thread via GitHub
wangyum commented on code in PR #40268: URL: https://github.com/apache/spark/pull/40268#discussion_r1127193046 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala: ## @@ -138,56 +136,53 @@ object ConstantPropagation extends Rule[LogicalPlan]

[GitHub] [spark] wangyum commented on a diff in pull request #40268: [SPARK-42500][SQL] ConstantPropagation support more cases

2023-03-06 Thread via GitHub
wangyum commented on code in PR #40268: URL: https://github.com/apache/spark/pull/40268#discussion_r1126255588 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala: ## @@ -198,16 +192,15 @@ object ConstantPropagation extends Rule[LogicalPlan]

[GitHub] [spark] wangyum commented on a diff in pull request #40268: [SPARK-42500][SQL] ConstantPropagation support more cases

2023-03-06 Thread via GitHub
wangyum commented on code in PR #40268: URL: https://github.com/apache/spark/pull/40268#discussion_r1126254824 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala: ## @@ -198,16 +192,15 @@ object ConstantPropagation extends Rule[LogicalPlan]

[GitHub] [spark] wangyum commented on a diff in pull request #40268: [SPARK-42500][SQL] ConstantPropagation support more cases

2023-03-06 Thread via GitHub
wangyum commented on code in PR #40268: URL: https://github.com/apache/spark/pull/40268#discussion_r1126250472 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala: ## @@ -138,56 +136,52 @@ object ConstantPropagation extends Rule[LogicalPlan]

[GitHub] [spark] wangyum commented on a diff in pull request #40268: [SPARK-42500][SQL] ConstantPropagation support more cases

2023-03-06 Thread via GitHub
wangyum commented on code in PR #40268: URL: https://github.com/apache/spark/pull/40268#discussion_r1126249818 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala: ## @@ -138,56 +136,52 @@ object ConstantPropagation extends Rule[LogicalPlan]

[GitHub] [spark] wangyum commented on a diff in pull request #40268: [SPARK-42500][SQL] ConstantPropagation support more cases

2023-03-06 Thread via GitHub
wangyum commented on code in PR #40268: URL: https://github.com/apache/spark/pull/40268#discussion_r1126248967 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala: ## @@ -112,16 +113,13 @@ object ConstantFolding extends Rule[LogicalPlan] {