[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2017-07-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14963 Build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2017-07-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14963 **[Test build #79181 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79181/testReport)** for PR 14963 at commit

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2017-07-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14963 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79181/ Test FAILed. ---

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2017-07-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14963 **[Test build #79181 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79181/testReport)** for PR 14963 at commit

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2017-06-26 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/14963 Hi, are you still working on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2017-05-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14963 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2017-05-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14963 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76550/ Test PASSed. ---

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2017-05-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14963 **[Test build #76550 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76550/testReport)** for PR 14963 at commit

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2017-05-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14963 **[Test build #76550 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76550/testReport)** for PR 14963 at commit

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2017-02-28 Thread holdenk
Github user holdenk commented on the issue: https://github.com/apache/spark/pull/14963 So under the current jenkins set up this isn't running the Python style checks in Jenkins so it would be good to make sure these work in jenkins (can you update a python file)? --- If your

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2017-02-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14963 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73451/ Test PASSed. ---

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2017-02-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14963 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2017-02-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14963 **[Test build #73451 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73451/testReport)** for PR 14963 at commit

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2017-02-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14963 **[Test build #73451 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73451/testReport)** for PR 14963 at commit

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2017-02-24 Thread holdenk
Github user holdenk commented on the issue: https://github.com/apache/spark/pull/14963 That's a reasonable question, I'll try and look at this some next week but if you've got a chance to look at/address the current comments on it that would be great. --- If your project is set up

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2017-01-09 Thread Stibbons
Github user Stibbons commented on the issue: https://github.com/apache/spark/pull/14963 Any hope this patch might be integrated ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-12-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14963 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70518/ Test PASSed. ---

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-12-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14963 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-12-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14963 **[Test build #70518 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70518/testReport)** for PR 14963 at commit

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-12-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14963 **[Test build #70518 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70518/testReport)** for PR 14963 at commit

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-10-20 Thread Stibbons
Github user Stibbons commented on the issue: https://github.com/apache/spark/pull/14963 I agree, just email me :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-10-16 Thread holdenk
Github user holdenk commented on the issue: https://github.com/apache/spark/pull/14963 Also if it would be useful to have a quick chat off-line and then circle back to the PR with the result of our chat let me know - I'd really like to see us get something like this in so we can have

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-10-13 Thread holdenk
Github user holdenk commented on the issue: https://github.com/apache/spark/pull/14963 @Stibbons however the problem is the virtualenv that gets created when a user is in a conda enviroment is partially broken. --- If your project is set up for it, you can reply to this email and

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-10-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14963 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66846/ Test PASSed. ---

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-10-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14963 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-10-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14963 **[Test build #66846 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66846/consoleFull)** for PR 14963 at commit

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-10-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14963 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-10-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14963 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66848/ Test FAILed. ---

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-10-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14963 **[Test build #66848 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66848/consoleFull)** for PR 14963 at commit

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-10-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14963 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-10-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14963 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66837/ Test PASSed. ---

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-10-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14963 **[Test build #66837 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66837/consoleFull)** for PR 14963 at commit

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-10-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14963 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-10-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14963 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66836/ Test PASSed. ---

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-10-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14963 **[Test build #66836 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66836/consoleFull)** for PR 14963 at commit

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-10-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14963 **[Test build #66848 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66848/consoleFull)** for PR 14963 at commit

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-10-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14963 **[Test build #66846 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66846/consoleFull)** for PR 14963 at commit

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-10-12 Thread Stibbons
Github user Stibbons commented on the issue: https://github.com/apache/spark/pull/14963 Ho, I have these pylint errors on my ubuntu! Probably I did not rebased correctly. Fixed with new check ignore: - deprecated-method - unsubscriptable-object, -

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-10-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14963 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66838/ Test FAILed. ---

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-10-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14963 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-10-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14963 **[Test build #66838 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66838/consoleFull)** for PR 14963 at commit

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-10-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14963 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-10-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14963 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66835/ Test PASSed. ---

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-10-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14963 **[Test build #66835 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66835/consoleFull)** for PR 14963 at commit

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-10-12 Thread Stibbons
Github user Stibbons commented on the issue: https://github.com/apache/spark/pull/14963 I really think using Spark with Anaconda is a **must have**. Deploying jobs that runs inside a Conda environment is so fast and efficient. I really want to push for this pull request #14180 that

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-10-12 Thread Stibbons
Github user Stibbons commented on the issue: https://github.com/apache/spark/pull/14963 You and I agree, actually: - PySpark can run inside Anaconda, and indeed this is greatly valuable. This will make available to the "driver" all the package provided by Anaconda (in client

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-10-12 Thread holdenk
Github user holdenk commented on the issue: https://github.com/apache/spark/pull/14963 @Stibbons the jenkins environment for Spark is not OS X, but since a lot of the developers work in OS X I figured it would be good to test there too. I think we should probably figure out why

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-10-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14963 **[Test build #66838 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66838/consoleFull)** for PR 14963 at commit

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-10-12 Thread Stibbons
Github user Stibbons commented on the issue: https://github.com/apache/spark/pull/14963 Here is my proposal: I leave the environment and let the script create the virtual env, plus minor improvement on the linter script. --- If your project is set up for it, you can reply to this

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-10-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14963 **[Test build #66837 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66837/consoleFull)** for PR 14963 at commit

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-10-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14963 **[Test build #66836 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66836/consoleFull)** for PR 14963 at commit

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-10-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14963 **[Test build #66835 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66835/consoleFull)** for PR 14963 at commit

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-10-12 Thread Stibbons
Github user Stibbons commented on the issue: https://github.com/apache/spark/pull/14963 I have just tested this pull request on MacOS X with latest version of Spark, no error: ``` ... Checking Pep8... PEP8 checks passed. Checking Pylint... Pylint checks

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-10-12 Thread Stibbons
Github user Stibbons commented on the issue: https://github.com/apache/spark/pull/14963 Indeed, I have not taken into account Anaconda environment, first because this tool provide quick and efficient way of having an almost good working environment to run jobs with numpy, pandas, and

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-10-12 Thread sethah
Github user sethah commented on the issue: https://github.com/apache/spark/pull/14963 I tested this on macosx, and got some pylint errors: + echo 'Checking Pylint...' Checking Pylint... + for to_be_checked in '"$PATHS_TO_CHECK"' + '[' false == true ']'

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-10-12 Thread holdenk
Github user holdenk commented on the issue: https://github.com/apache/spark/pull/14963 Another minor question is running the lint script now produces a lot of output about the package versions - it might make sense to silence this output except on failures (as we do with the actually

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-10-12 Thread holdenk
Github user holdenk commented on the issue: https://github.com/apache/spark/pull/14963 So looking at https://github.com/ContinuumIO/anaconda-issues/issues/305 it seems like we might cause problems for Conda users (and I've setup Conda locally to verify that this is indeed the case

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-10-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14963 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66819/ Test PASSed. ---

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-10-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14963 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-10-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14963 **[Test build #66819 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66819/consoleFull)** for PR 14963 at commit

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-10-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14963 **[Test build #66819 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66819/consoleFull)** for PR 14963 at commit

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-10-10 Thread Stibbons
Github user Stibbons commented on the issue: https://github.com/apache/spark/pull/14963 Thanks both of you for your reviews. It also fix the version of sphinx for documentation build during the `lint-python` My point of view is that for **application**, all versions of tools

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-10-10 Thread holdenk
Github user holdenk commented on the issue: https://github.com/apache/spark/pull/14963 This PR does somehting useful by its self namely it uses virtual env / `requirements.txt` to fix the versions of `pylint` and `pep8` and reenables `pylint` checking of the code. There is a setup

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-10-10 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14963 Just so I'm doubly clear, this PR is ready to go, does something useful by itself? that is it's not just like a change that only makes sense with others? I'm OK to merge it if the Python folks think

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-10-08 Thread holdenk
Github user holdenk commented on the issue: https://github.com/apache/spark/pull/14963 Also @Stibbons I'm sorry the process has been so challenging and thanks for hanging in with it :) --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-10-08 Thread holdenk
Github user holdenk commented on the issue: https://github.com/apache/spark/pull/14963 Right I think the virtualenv support for PySpark in general is interesting - but its a large enough change we would need to get some substantail reviewer time dedicated to it (and I don't see that

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-10-08 Thread Stibbons
Github user Stibbons commented on the issue: https://github.com/apache/spark/pull/14963 sorry I wrote on the wrong pull request, I was talking about the virtualenv support for executor (#14180) :( This one is indeed only to reenable pylint. Merging this would allow me to submit

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-10-08 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14963 Python really isn't my area, so I don't feel qualified to evaluate this. It sounds reasonable and has only build-time consequences, so I imagine it's low-risk. Improve style checking is good. I can

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-10-08 Thread Stibbons
Github user Stibbons commented on the issue: https://github.com/apache/spark/pull/14963 I would love to have a bit more feedback on this matter but it does not seem to interest core developers, sadly :( It's a bit disappointing, seeing how Python support on Spark is great, being

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-10-07 Thread holdenk
Github user holdenk commented on the issue: https://github.com/apache/spark/pull/14963 I think this could be a good change for allowing more developers to onboard with PySpark - is there any interest in the current PySpark/Build focused committers [ @davies @srowen @rxin ] in seeing

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-10-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14963 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66387/ Test PASSed. ---

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-10-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14963 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-10-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14963 **[Test build #66387 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66387/consoleFull)** for PR 14963 at commit

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-10-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14963 **[Test build #66387 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66387/consoleFull)** for PR 14963 at commit

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-09-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14963 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-09-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14963 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66044/ Test PASSed. ---

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-09-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14963 **[Test build #66044 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66044/consoleFull)** for PR 14963 at commit

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-09-28 Thread holdenk
Github user holdenk commented on the issue: https://github.com/apache/spark/pull/14963 Maybe @davies, @srowen, or @yhuai will have some thoughts as people who have worked on python linting. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-09-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14963 **[Test build #66044 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66044/consoleFull)** for PR 14963 at commit

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-09-28 Thread holdenk
Github user holdenk commented on the issue: https://github.com/apache/spark/pull/14963 Jenkins retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-09-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14963 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66041/ Test FAILed. ---

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-09-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14963 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-09-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14963 **[Test build #66041 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66041/consoleFull)** for PR 14963 at commit

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-09-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14963 **[Test build #66041 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66041/consoleFull)** for PR 14963 at commit

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-09-26 Thread Stibbons
Github user Stibbons commented on the issue: https://github.com/apache/spark/pull/14963 Hello. Does anyone had time to review this patch? Is there anything I should do to help it being merged? This reenables Pylint checks using `lint-python` script and there are some errors that

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-09-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14963 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-09-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14963 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65760/ Test PASSed. ---

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-09-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14963 **[Test build #65760 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65760/consoleFull)** for PR 14963 at commit

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-09-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14963 **[Test build #65760 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65760/consoleFull)** for PR 14963 at commit

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-09-22 Thread Stibbons
Github user Stibbons commented on the issue: https://github.com/apache/spark/pull/14963 Pull Request rebased --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-09-21 Thread holdenk
Github user holdenk commented on the issue: https://github.com/apache/spark/pull/14963 oh actually it seems like the PR dashboard updated its self (it lives at https://spark-prs.appspot.com/ and is sometimes used by reviewers to decide which PRs to look at). --- If your project is

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-09-21 Thread Stibbons
Github user Stibbons commented on the issue: https://github.com/apache/spark/pull/14963 What is the PR dashboard ? I usually rebase this patch one or twice a week, I'll do it tomorrow --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-09-21 Thread holdenk
Github user holdenk commented on the issue: https://github.com/apache/spark/pull/14963 So even though this passes tests - its showing up in the PR dashboard as not for me. It might be easier to get reviewers to take a look if it was listed correctly, if you merge in the latest master

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-09-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14963 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65481/ Test PASSed. ---

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-09-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14963 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-09-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14963 **[Test build #65481 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65481/consoleFull)** for PR 14963 at commit

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-09-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14963 **[Test build #65481 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65481/consoleFull)** for PR 14963 at commit

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-09-16 Thread Stibbons
Github user Stibbons commented on the issue: https://github.com/apache/spark/pull/14963 Hello, sorry to bother you, but if this patch gets merged, I can work on the pylint errors and submit new PR I had to add in the ignore list of pylint. If I reenable most of them, here is

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-09-14 Thread holdenk
Github user holdenk commented on the issue: https://github.com/apache/spark/pull/14963 cc @davies ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8

2016-09-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14963 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

  1   2   >