Github user zhengruifeng commented on the issue:
https://github.com/apache/spark/pull/15324
@jkbradley What's your opinion about whether GNB should be a separated
Classifier or a modeltype in existing NB?
---
If your project is set up for it, you can reply to this email and have
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15324
**[Test build #70811 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70811/testReport)**
for PR 15324 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15324
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15324
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70811/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15324
**[Test build #70811 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70811/testReport)**
for PR 15324 at commit
Github user zhengruifeng commented on the issue:
https://github.com/apache/spark/pull/15324
Jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15324
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15324
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70803/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15324
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70802/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15324
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15324
**[Test build #70803 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70803/testReport)**
for PR 15324 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15324
**[Test build #70799 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70799/testReport)**
for PR 15324 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15324
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70799/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15324
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15324
**[Test build #70802 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70802/testReport)**
for PR 15324 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15324
**[Test build #70799 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70799/testReport)**
for PR 15324 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15324
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15324
**[Test build #70794 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70794/testReport)**
for PR 15324 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15324
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70794/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15324
**[Test build #70794 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70794/testReport)**
for PR 15324 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15324
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70791/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15324
**[Test build #70791 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70791/testReport)**
for PR 15324 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15324
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15324
**[Test build #70791 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70791/testReport)**
for PR 15324 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15324
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70747/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15324
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15324
**[Test build #70747 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70747/testReport)**
for PR 15324 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15324
**[Test build #70747 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70747/testReport)**
for PR 15324 at commit
Github user zhengruifeng commented on the issue:
https://github.com/apache/spark/pull/15324
@sethah @MLnick @yanboliang Thanks for your comments, and I will work to
make GNB a separated classifier.
---
If your project is set up for it, you can reply to this email and have your
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15324
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15324
**[Test build #66727 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66727/consoleFull)**
for PR 15324 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15324
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66727/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15324
**[Test build #66727 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66727/consoleFull)**
for PR 15324 at commit
Github user zhengruifeng commented on the issue:
https://github.com/apache/spark/pull/15324
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15324
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66604/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15324
**[Test build #66604 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66604/consoleFull)**
for PR 15324 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15324
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15324
**[Test build #66604 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66604/consoleFull)**
for PR 15324 at commit
Github user zhengruifeng commented on the issue:
https://github.com/apache/spark/pull/15324
I tend to make GaussianNB as a special `modelType` option in current NB.
However, there are significant differences:
1, 'theta' matrix is used to store means
2, extra `sigma` matrix
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/15324
I'm against to merge ```theta``` and ```sigma``` together, it should be two
individual variables of model. To the question that whether GaussianNB should
be part of the ```NaiveBayes```
Github user zhengruifeng commented on the issue:
https://github.com/apache/spark/pull/15324
@MLnick @sethah Thanks for your review. This PR now is just like what I am
using in work. I agree that it will bring some inconvenience to merge `theta`
and `sigma` together. I will change it
Github user zhengruifeng commented on the issue:
https://github.com/apache/spark/pull/15324
@yanboliang what is your opioion?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user MLnick commented on the issue:
https://github.com/apache/spark/pull/15324
I tend to agree with Seth on this - the gaussian case is different enough
that it could be separate.
Though in terms of the estimator, from a public-facing API perspective it
is one param
Github user sethah commented on the issue:
https://github.com/apache/spark/pull/15324
Was there some discussion as to whether GaussianNB should be part of the
NaiveBayes estimator or its own estimator? It seems the semantics are different
enough between multinomial NB and Gaussian NB
Github user zhengruifeng commented on the issue:
https://github.com/apache/spark/pull/15324
cc @yanboliang @MLnick Can you please review this in spare time?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15324
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66237/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15324
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15324
**[Test build #66237 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66237/consoleFull)**
for PR 15324 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15324
**[Test build #66237 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66237/consoleFull)**
for PR 15324 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15324
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66236/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15324
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15324
**[Test build #66236 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66236/consoleFull)**
for PR 15324 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15324
**[Test build #66236 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66236/consoleFull)**
for PR 15324 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15324
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15324
**[Test build #66235 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66235/consoleFull)**
for PR 15324 at commit
55 matches
Mail list logo
