Github user uncleGen commented on the issue:
https://github.com/apache/spark/pull/16000
@saturday-shi Yes, I will reopen it, and welcome to improve it and work
together :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user saturday-shi commented on the issue:
https://github.com/apache/spark/pull/16000
@vanzin
Hello, I'm a collaborator of this PR. Actually I am interested in your
plan, but we don't want to make the changes here because that is not the
purpose of this PR. I think I can op
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/16000
If you're not willing to make the changes, we should close this one, if you
don't mind, and reopen @uncleGen's PR instead.
---
If your project is set up for it, you can reply to this email and have
Github user ChorPangChan commented on the issue:
https://github.com/apache/spark/pull/16000
@uncleGen
apologize for interrupted your work,
I dont know the story at that time.
@vanzin
its true that i havent consider that.
but anyway, I have no plan to implement a
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/16000
> in order to make use of the history server you need to stop your
application
That's just not true. You're also ignoring people who have clients running
streaming applications, and would be
Github user uncleGen commented on the issue:
https://github.com/apache/spark/pull/16000
> It's completely possible to mount the streaming API on top of the
existing spark-core API.
A similar pr https://github.com/apache/spark/pull/15904 for you. Is it what
you want?
---
I
Github user ChorPangChan commented on the issue:
https://github.com/apache/spark/pull/16000
> What is the real problem with it?
actually I dont have any problem with it
I just think its is already a new version and that's not this PR nor I
means to do
another poin
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/16000
> what is the benefit of force they as one API beside "it sounds correct"?
Because it pretty much ensures that when (not if) we add streaming to the
history server, it will cause breakage in
Github user ChorPangChan commented on the issue:
https://github.com/apache/spark/pull/16000
I could not agree with "The API should be one" yet
what is the benefit of force they as one API beside "it sounds correct"?
as i mention before, i can not think of any usage of histo
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/16000
The API should be one; it doesn't belong to core or streaming, it belongs
to Spark. Parts of it would be coming from core, parts of it would be coming
from streaming. Just like the UI.
And y
Github user ChorPangChan commented on the issue:
https://github.com/apache/spark/pull/16000
I understand its possible,
and actually I agree having a hooking mechanism is a better approach as
well in turns of programing and if we really need streaming to support history
server.
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/16000
I disagree. It's completely possible to mount the streaming API on top of
the existing spark-core API. You just need to add the necessary hooks so that
the API code can ask the streaming module for i
Github user ChorPangChan commented on the issue:
https://github.com/apache/spark/pull/16000
@vanzin
I undertstand the story now, but im afraid i cant help to accomplish that
story.
as my first comment state,
this implementation is base on the current REST implementati
Github user ajbozarth commented on the issue:
https://github.com/apache/spark/pull/16000
@ChorPangChan the updates look good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabl
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16000
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16000
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69458/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16000
**[Test build #69458 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69458/consoleFull)**
for PR 16000 at commit
[`651dc67`](https://github.com/apache/spark/commit/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16000
**[Test build #69458 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69458/consoleFull)**
for PR 16000 at commit
[`651dc67`](https://github.com/apache/spark/commit/6
Github user ChorPangChan commented on the issue:
https://github.com/apache/spark/pull/16000
`[error] * method
onStreamingStarted(org.apache.spark.streaming.scheduler.StreamingListenerStreamingStarted)Unit
in trait org.apache.spark.streaming.scheduler.StreamingListener is present
onl
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16000
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16000
**[Test build #69441 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69441/consoleFull)**
for PR 16000 at commit
[`de50bf2`](https://github.com/apache/spark/commit/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16000
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69441/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16000
**[Test build #69441 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69441/consoleFull)**
for PR 16000 at commit
[`de50bf2`](https://github.com/apache/spark/commit/d
Github user ChorPangChan commented on the issue:
https://github.com/apache/spark/pull/16000
@vanzin
sorry, I think I remove some empty line accidently
the Scala style problem should be fixed now.
---
If your project is set up for it, you can reply to this email and have your
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16000
**[Test build #69440 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69440/consoleFull)**
for PR 16000 at commit
[`6855cb9`](https://github.com/apache/spark/commit/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16000
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69440/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16000
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16000
**[Test build #69440 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69440/consoleFull)**
for PR 16000 at commit
[`6855cb9`](https://github.com/apache/spark/commit/6
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/16000
Sean can definitely take a look, but others like @tdas have more background
in streaming.
I want to take a look at the API hook up since it relates to other things
I'm working on, but I'm cu
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/16000
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user ChorPangChan commented on the issue:
https://github.com/apache/spark/pull/16000
@ajbozarth
sorry, just in case you didn't noticed
I had make the change to handle the startTime
how do you think?
@srowen
hello,
I also think we need someone with s
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16000
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user ChorPangChan commented on the issue:
https://github.com/apache/spark/pull/16000
startTime will record in StreamingContext and pass to listener through
StreamingStarted event.
---
If your project is set up for it, you can reply to this email and have your
reply appear on G
Github user ajbozarth commented on the issue:
https://github.com/apache/spark/pull/16000
I'll taken a general look through your code and from an api perspective I
believe it looks good, but I don't have any experience with the streaming code
that it surfaces. A streaming person should
Github user ajbozarth commented on the issue:
https://github.com/apache/spark/pull/16000
@ChorPangChan thanks for asking, I'll take a look through the code by
EOD(PST)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If y
Github user ChorPangChan commented on the issue:
https://github.com/apache/spark/pull/16000
if there is no other comment,
i believe this PR is ready to go.
@ajbozarth
please forgive me if its not appropriate to ask
but will you please take a look on the code?
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16000
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user ChorPangChan commented on the issue:
https://github.com/apache/spark/pull/16000
hi @vanzin
new PR against master is ready.
please have a look
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
38 matches
Mail list logo
