Github user srowen commented on the issue:
https://github.com/apache/spark/pull/19890
We'll need to back port to 2.2/2.1 to match the previous janino update.
I'll do that. A different PR will be required for 2.1
---
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19890
Thanks! Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user rednaxelafx commented on the issue:
https://github.com/apache/spark/pull/19890
I'd LGTM on both upgrading to Janino 3.0.8 and also changing the exception
type captured from `JaninoRuntimeException` to the new
`InternalCompilerException`. It's never a good idea to have
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19890
cc @hvanhovell @cloud-fan @rednaxelafx
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/19890
It would only cause a problem if somehow and older Janino was on the
classpath, which does not have the new exception type. I don't think there's a
reason to believe that happens in practice (i.e.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19890
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84545/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19890
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19890
**[Test build #84545 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84545/testReport)**
for PR 19890 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19890
**[Test build #84545 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84545/testReport)**
for PR 19890 at commit
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/19890
Sure
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19890
Yea, let's avoid using deprecated ones, of course.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/19890
@gatorsmile The current code works functionally correct since
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/19890
@gatorsmile great catch, I will double check it.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19890
Wait...
> Renamed the "JaninoRuntimeException" to "InternalCompilerException" (and
left the old class for backwards compatibility), because the old name was
confusing.
We captured
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/19890
@srowen thank you for pointing it out.
[Here](https://github.com/apache/spark/pull/19866) is an example at 3.0.7.
---
-
To
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19890
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84465/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19890
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19890
**[Test build #84465 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84465/testReport)**
for PR 19890 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19890
**[Test build #84465 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84465/testReport)**
for PR 19890 at commit
19 matches
Mail list logo
